Re: Background image shows up in hosted mode but not in web mode

2009-06-12 Thread alex.d
Wrong path? Some CSS/browser issues? Who knows. Take firebug and check your page's styling. On 11 Jun., 17:15, Manolis Platakis m.plata...@gmail.com wrote: Hello, I have created the following css style to add a background image to the html page of my application. .bg {   background:

Re: Browser memory usage grows

2009-06-12 Thread David
Hi, In the general case GWT's design guards against common JS pitfalls that cause memory leaks. There are a few known issues though: When you use IFrames that memory is never decently released after removing the IFrame. The FormPanel can also leak. IE6/IE7 are also consuming a huge amount of

Re: Browser memory usage grows

2009-06-12 Thread Craig Spry
Hi, I would just like to clarify your last point. I thought that GWT took java code and turned it into javascript, this is what http://code.google.com/webtoolkit/overview.html seems to indicate, so when I have deployed my application there is no java running just javascript, have I missed

Re: Browser memory usage grows

2009-06-12 Thread David
Hi, The last type of memory leaks is independent of the language you use. so yes, these leaks will translate from Java to Javascript. The reason is because your code is faulty since it keeps hard references to objects that are no longer necessary. For example you might have a list of listeners

Re: Name a function that will not get changed when compliling?

2009-06-12 Thread Shedokan
Thanks, I now realize what was that strange comments in GQuery and that's what JSNI means. I will check later the GWT exporter. thanks. On 11 יוני, 23:41, Alex Rudnick a...@google.com wrote: Hey Shedokan, The approach I've used for that is to attach a GWT function to the window object

Re: Event handler for model ?

2009-06-12 Thread mnenchev
Well what exactly you want to do? Dalla wrote: Could you please post some examples will? Or maybe send me some code? mnenchevs example was good, but more examples never hurt :-) On 11 Juni, 14:08, Will wil...@gmail.com wrote: That's what I use as well. I created an Abstract Class

Re: Preventing JavaScript Injection cient/server side solutions

2009-06-12 Thread tamsler
Evaluating user input on the client side and checking for script, etc. tags is a good practice, however, there are ways to bypass such input validation. So the next best line of defense is to validate/re- validate on the server side where the GWT RPC call terminates. I am wondering what

Re: LoginSecurityFAQ and sessionID/tokens

2009-06-12 Thread mars1412
as I interpret this article: http://groups.google.com/group/Google-Web-Toolkit/web/security-for-gwt-applications then you should do 2 things: store the session-id in a cookie on the client side + include the session-id in every RPC call (to prevent XSFR) and if you call a custom servlet from

Re: Preventing JavaScript Injection cient/server side solutions

2009-06-12 Thread mars1412
on the client side, we simply use a html-editor and only enable simple functions like bold, italics, list... however, as already pointed out the user may easily work around this - and if he does, all tags/attributes that we do not allow will silently be filtered out on the serverside: we use

Re: Eclipse Classic 3.5

2009-06-12 Thread Joakim
Good to hear! Thanks very much. Looking forward to the release! On Jun 11, 10:24 pm, Rajeev Dayal rda...@google.com wrote: Hi, We're currently working on this. I don't have a set date for you, but we will get it out there as soon as we can. Thanks, Rajeev On Thu, Jun 11, 2009 at 4:15

Re: GAE + GWT + password transfer

2009-06-12 Thread Shane
I really wish I had an answer to this. On Jun 10, 5:04 pm, Shane shanelstev...@gmail.com wrote: Sorry to keep talking to myself here, but I find what other sites are doing really interesting, and pertinent to GAE because there doesn't seem to be an agreed upon solution. Facebook uses a form

Re: Mouse Wheel Handler on a TextBox

2009-06-12 Thread D L H
Ah I wish I had known this before I created a native method to handle it. haha Thanks for the info. I was just wondering, are there any major disadvantages with using the latest svn revisions as opposed to the latest stable release? -DLH On Jun 11, 2:54 pm, Sumit Chandel

Running GWT with IBM JDK

2009-06-12 Thread ping2ravi
Hi All, I got into this funny situation that i can not run my GWT application in IBM JDK(1.5). It seems GWT is using some sun related classes which are not available in IBM Java version. Can you please advise how can i deploy such application with IBM java. 10:20:39,309 ERROR [[/SwSupWebTool]]

async code and the callback-chain

2009-06-12 Thread daniel
hi all, I hope someone can help to find a solution to the following problem: I have some complex code that may need data from the server. When I make a request I get the data asynchronous, so I have to provide a callback to handle the response. Now all the code that use this function need a

Re: Running GWT with IBM JDK

2009-06-12 Thread Thomas Broyer
On 12 juin, 14:49, ping2ravi ping2r...@gmail.com wrote:         at sun.net.www.protocol.http.HttpURLConnection.getInputStream (HttpURLConnection.java:943)         at com.sun.net.ssl.internal.www.protocol.https.HttpsURLConnectionOldImpl.getInputStream (HttpsURLConnectionOldImpl.java:204)  

Re: GWT architecture MVP/EventBus (mentioned at Google I/O)

2009-06-12 Thread Thomas Broyer
On 11 juin, 21:34, Benju b...@fastcastmedia.com wrote: I did not attend Google I/O but as soon as the video Google I/O 2009 - Best Practices for Architecting GWT App (http://www.youtube.com/ watch?v=PDuhR18-EdM) was posted I reviewed it and was a bit confused by the idea of an EventBus. For

Community announcements on GWT blog

2009-06-12 Thread Miles T.
Hi, I've read community updates here : http://googlewebtoolkit.blogspot.com/2009/06/gwt-community-updates.html. I just wonder why it is talking about SmartGWT but not ExtGWT ? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the

Re: Background image shows up in hosted mode but not in web mode

2009-06-12 Thread Manolis Platakis
It was, indeed, a css non-standard that was ignored by Firefox. Thanks for your answer. Manolis On Jun 12, 9:21 am, alex.d alex.dukhov...@googlemail.com wrote: Wrong path? Some CSS/browser issues? Who knows. Take firebug and check your page's styling. On 11 Jun., 17:15, Manolis Platakis

Re: Spring Security login forwarding to blank page issue

2009-06-12 Thread El Mentecato Mayor
I'm experiencing the same. So far I'm blaming the problem on the application not being production ready yet, so it is buggy and sometimes I see some javascript errors. As these errors go away and the application stabilizes, I'll take a look at the problem more closely. But of course, if

Re: Large Data Set problems

2009-06-12 Thread Tercio
Hi! The problem is that in your function public void showUsers() { you create a entry into FlexTable for each user, including the non-visible ones. Some browsers have problems displaying a huge data. To solve this you have 2 options: Create some kind of pagination into your flextable,

gwt-maven and web service

2009-06-12 Thread net
Hi all, I'm trying to call and get response from a wsdl service. When I compile the UI layer with maven, it throws this error: com.google.gwt.user.client.rpc.SerializationException: Type 'javax.xml.ws.WebServiceException' was not included in the set of types which can be serialized by this

Re: GAE + GWT + password transfer

2009-06-12 Thread Isaac Truett
I'm not sure what your question is. Do you have a specific question? You mentioned problems with HTTPS on GAE, which is probably a topic more appropriate for the GAE group. As far as GWT is concerned, I think you've already got the gist: HTTPS is a must-have for sending passwords over a public

New Event Handling and Composites

2009-06-12 Thread Buzzterrier
I am just not getting the new Event handling. I have went over every example I can find, but it is not clicking. How do you let composite widgets subscribe to events from other composite widgets? From reading it sounds like there is a HandlerManager that you register with by implementing the

Flex Table or DIV's for layout

2009-06-12 Thread retro
Which will be lighter size wise if there are too many of them for laying out components? Suggestions? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

Dynamic ImageBundle selection ?

2009-06-12 Thread ciukes
Hi, My application will by displaying a country flag depending on a locale selected form list. All the flags are gathered within LocaleFlag (extends ImageBundle). I want to be able to get flag image out of LocaleFlag having only a locale name string in hand. List selection - Locale name string

GWT in Eclipse spontaneously stopped working

2009-06-12 Thread skeemer
I'm running Leopard with Eclipse 3.4.2 and GWT 1.6.4. I was able create the first Getting Started app and everything worked fine. I then started creating the StockMarket app from the tutorial and now hosted mode won't do anything on either project or a brand new empty one. There is a crashlog

Can't debug in Eclipse

2009-06-12 Thread Max
Hi! I just started using the gwt. I followed the instructions in the getting started tutorial but i cant debug my application in eclipse. If i click on Debug - Stockwatcher Eclipse doesnt stop at any Breakpoint. It doesnt even switch into the debug view. The Hosted Mode Windows and the client

file importing in gwt

2009-06-12 Thread shalini
I'm new of GWT.I am doing a project using GWT. The project have two module namely student and Recruiter. I want to import the file from recruiter module into file of student module.how to do this. --~--~-~--~~~---~--~~ You received this message because you are

ClassNotFoundException when have reference to another project

2009-06-12 Thread ailinykh
Hello everybody! I have simple GWT project. In servlet implementation I use class from another Java project (it is regular class library). Both of them are eclipse projects. Main project has reference to library project, I can compile. But when I run it I get ClassNotFoundException. If I export

Re: Can't debug in Eclipse

2009-06-12 Thread Rajeev Dayal
See http://code.google.com/p/google-web-toolkit/issues/detail?id=3724 Let me know if you have other questions. On Fri, Jun 12, 2009 at 10:54 AM, Max max.blumena...@googlemail.com wrote: Hi! I just started using the gwt. I followed the instructions in the getting started tutorial but i cant

Re: GAE + GWT + password transfer

2009-06-12 Thread Shane
Maybe the question got lost in my research. I'm not from a Web background (C++ + video games), so this may be painfully obvious, but I want to know how people authenticate over non- HTTPS connections, specifically using GAE (Java). My point is that any app that stores any sort of user specific

Getting auto scroll

2009-06-12 Thread RKK
Hi, I am new to GWT GWT-EXT I am using GWT and GWT-EXT. I use absolutepanel inside a GWT-EXT panel. I use drag and drop. My requirement is to get automatic scroll when I drop the widgets at the edges of absolutepanel. If I do not set sizes for GWT-EXT panel (rather mention % size) and no size

Re: async code and the callback-chain

2009-06-12 Thread Ravi
Daniel, First thing, With Asynchronous call you should never get the Stack over flow as Asynchronous calls are running in different thread and your function retursn back before calls finish. But i think you have genuine problem of asynchronous call chains...where writing code become too

Re: Request after request.

2009-06-12 Thread Rvanlaak
Did you've found a sollution for your case? And, did you already take a look to GWTEventService? :) On 27 apr, 06:53, davidst...@gmail.com davidst...@gmail.com wrote: I mean this : getThreadLocalRequest().getSession().getId() gives me the same id for two different clients that are opened.

Re: Can't debug in Eclipse

2009-06-12 Thread Max
Wow! Thx for the fast reply! Now debbuging works perfectly! On 12 Jun., 17:40, Rajeev Dayal rda...@google.com wrote: Seehttp://code.google.com/p/google-web-toolkit/issues/detail?id=3724 Let me know if you have other questions. On Fri, Jun 12, 2009 at 10:54 AM, Max

GWT in Custome browswer.

2009-06-12 Thread sajil
Hi readers, I want to know how can I run a GWT application in Custom browser in Hosted mode. Here is what exactly I am looking for: I have an application which interacts with the client machine through window.external calls. We are using a IE 6 in a custom container for getting this done. I am

Re: GWT architecture MVP/EventBus (mentioned at Google I/O)

2009-06-12 Thread Benju
Thanks for the reply I have some further thoughts... Looking at the source code for the event handling in GWT 1.6 it seems the fundamental difference is as follows... Old way with listeners I am adding this event listener to this component, when the listener is triggered I know the source must

Incorporating existing jars without modularizing them?

2009-06-12 Thread watsonta
I'm building a proof-of-concept GWT Google Map application that would utilize an existing Hibernate business model for data retrieval. As soon as I reference and use a class from the business model into the application, the AppEngine server complains about not being able to find the source code

Gwt Component Works in Hosted, but not in Tomcat.

2009-06-12 Thread Patrick
I am new to GWT as of 3 weeks. I have a component running in hosted mode. It is a table. It works in hosted mode, but not when I deploy it to tomcat. My other components work, but it is not visible. I tried it in all browsers. I am deploying the compiled javascript. I see the javascript in

Re: 404 error: gwt server can not be found

2009-06-12 Thread Braheem Sikiru
Hi How about removing the foward slash before searchService i.e. something like this instead: String moduleRelativeURL = GWT.getModuleBaseURL() + searchService; Had similar problems sometimes, and that worked for me. According to the docs, GWT.getModuleBaseURL() if

Re: async code and the callback-chain

2009-06-12 Thread daniel
Hi Ravi, thanks for your reply. You`re right. ts not the async call itself that leads to the stackoverflow. its because of the callback chain that comes when a large amount of code depends directly or indirectly on the callback. supposed i have some simple code like this: public Value

Re: GWT in Custome browswer.

2009-06-12 Thread Paul Robinson
http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM sajil wrote: Hi readers, I want to know how can I run a GWT application in Custom browser in Hosted mode. Here is what exactly I am looking for: I have an application which interacts with the client machine through

Re: Dynamic ImageBundle selection ?

2009-06-12 Thread Thomas Broyer
On 12 juin, 12:36, ciukes ciu...@gmail.com wrote: My application will by displaying a country flag depending on a locale selected form list. All the flags are gathered within LocaleFlag (extends ImageBundle). I want to be able to get flag image out of LocaleFlag having only a locale name

Re: New Event Handling and Composites

2009-06-12 Thread Thomas Broyer
On 12 juin, 17:24, Buzzterrier terry.je...@gmail.com wrote: I am just not getting the new Event handling.  I have went over every example I can find, but it is not clicking. How do you let composite widgets subscribe to events from other composite widgets? From reading it sounds like there

Re: GWT best Practices - JS Library Wrappers Overlay Types

2009-06-12 Thread Bobby
Ok, so time to look at class structure. In the JS API we have for example: com.google.gwt.gdata.client.calendar.CalendarFeed com.google.gwt.gdata.client.Feed com.google.gwt.gdata.client.atom.Feed We won't be able to implement this structure with overlay types because all methods are

Re: Passing bag of Serializable objects to RPC

2009-06-12 Thread Daniel Jue
Ah, I figured out what I was doing wrong. I am using GXT, and my pojo/bean was being used as a runtime generated class that implemented gxt's BeanModel. My ignorance on exactly how this worked prevented me from refactoring correctly. I had been trying to make a genericized form component,

How can I add a MouseOutHandler to a FlexTable cell?

2009-06-12 Thread Eduardo Nunes
Well, the subject says everything, I would like to know how can I add a MouseOutHandler to a FlexTable cell. I tried a lot of things but none of them with success. I tried a wrap class: private class FlexTableTd extends Widget implements HasMouseOutHandlers, HasMouseOverHandlers

no source available

2009-06-12 Thread Peter Kirklewski
Hi Guys I created an application, it starts and shows the two standard windows but there are some errors: No source is available for type org.timepedia.client.browser.Chronoscope; did you forget to inherit required module ? The answer is no - I didn't as my HelloChart.gwt.xml file contains:

Re: Guice 2.0 servlet example

2009-06-12 Thread Arthur Kalmenson
I'd try asking your question on the Google Guice group: http://groups.google.com/group/google-guice?pli=1 -- Arthur Kalmenson On Wed, Jun 10, 2009 at 2:40 AM, Dariuszdarius...@gmail.com wrote: I'm trying to get the example of guice 2.0 running, but I can't figure out why it's not working.

Re: can't run javax adn org/w3c library and bigDecimal in gwt - 1.6 project

2009-06-12 Thread Sumit Chandel
Hi Linda, The reason why you get the import javax.xml cannot be resolved and other problematic import resolutions is because these are not supported in the GWT emulated JRE (see doc link below). As the GWT code you right gets cross-compiled into JavaScript that will run in the browser, there is no

Re: gwt-maven and web service

2009-06-12 Thread Arthur Kalmenson
Hello Netty, In order for classes to be serializable, their source code needs to be available and should be compiled by the GWT compiler. Since the Service class is not a white listed class, you'll have to add it to your source and use the super-source tag in your GWT module to get it compiled.

Re: no source available

2009-06-12 Thread Arthur Kalmenson
The inherits tag needs to point to the .gwt.xml module file, not a class file. Looking at the Chronoscope library, it looks like Chronoscope.gwt.xml is actually in org.timepedia.chronoscope.Chronoscope so your inherits tag should look as follows: inherits

Re: Key events for scrolltable

2009-06-12 Thread Sumit Chandel
Hi vduong, The plan for the most used and matured widgets in the incubator is to eventually have them graduate to GWT proper. In the case of the ScrollTable, part of that transition should involve bringing it into the new GWT 1.6 event architecture and having it implement some of the handlers that

Re: New Event Handling and Composites

2009-06-12 Thread Buzzterrier
Thx Thomas I really appreciate this. That worked, but when I handle the event in DoSomething, I need to know what button was clicked. e.g. public class DoSomething extends Composite implements ClickHandler{ private SimpleWidget simpleWidget; public

redirect without loosing state

2009-06-12 Thread michaael_l
Hi guys. I'm not quite new to GWT, but I've recently faced quite frustrating problem, that I'm unable to solve alone. I have requirement to integrate my webapp with single sign on system which is HTTP based. So whilst starting GWT app I have redirect user to different URL, check retrieved URL and

Re: How can I add a MouseOutHandler to a FlexTable cell?

2009-06-12 Thread matthew jones
Try this instead. addMouseOverHandler(MouseOverHandler handler) { return addDomHandler(handler, MouseOverEvent.getType()); } On Jun 12, 12:52 pm, Eduardo Nunes esnu...@gmail.com wrote: Well, the subject says everything, I would like to know how can I add a MouseOutHandler

Re: GWT in Eclipse spontaneously stopped working

2009-06-12 Thread Rajeev Dayal
What JVM is your project using? Can you look at your project properties and take a look? On Fri, Jun 12, 2009 at 2:33 AM, skeemer skee...@gmail.com wrote: I'm running Leopard with Eclipse 3.4.2 and GWT 1.6.4. I was able create the first Getting Started app and everything worked fine. I then

Re: How can I add a MouseOutHandler to a FlexTable cell?

2009-06-12 Thread Eduardo Nunes
I already tried it, but it didn't work. I found a solution, but a very ugly one: private class FlexTableTd extends UIObject implements HasMouseOutHandlers, HasMouseOverHandlers, EventListener { public FlexTableTd(Element element) { this.setElement(element);

Re: ClassNotFoundException when have reference to another project

2009-06-12 Thread Rajeev Dayal
Hi, Good question! This is a known issue right now. Check this thread out for a discussion: http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/951499c5773693c9 Post back here if you have any other questions. Rajeev On Fri, Jun 12, 2009 at 9:47 AM, ailinykh

Re: Gwt Component Works in Hosted, but not in Tomcat.

2009-06-12 Thread Rajeev Dayal
What version of GWT are you using? What type of error are you seeing? On Fri, Jun 12, 2009 at 12:20 PM, Patrick www...@gmail.com wrote: I am new to GWT as of 3 weeks. I have a component running in hosted mode. It is a table. It works in hosted mode, but not when I deploy it to tomcat. My

Re: New Event Handling and Composites

2009-06-12 Thread Buzzterrier
So tracing the fireEvent method, I found that the source does indeed reference the button, but in HandlerManager, the source gets changed to SimpleWidget. Object oldSource = event.getSource(); //event.getSouce is button event.setSource(source); //here source is SimpleWidget Not sure why. the

Re: Preventing JavaScript Injection cient/server side solutions

2009-06-12 Thread Jeff Chimene
On 06/11/2009 09:03 PM, Shawn Brown wrote: It's a good question, but it's not really GWT related. Sure it is. The OP asked: 'I am wondering if anybody has attempted to intercept JS injection on the server side by scanning RPC calls' My interpretation of the phrase on the server

Re: Preventing JavaScript Injection cient/server side solutions

2009-06-12 Thread Jeff Chimene
On 06/12/2009 12:45 AM, tamsler wrote: Evaluating user input on the client side and checking for script, etc. tags is a good practice, however, there are ways to bypass such input validation. So the next best line of defense is to validate/re- validate on the server side where the GWT RPC

Re: New Event Handling and Composites

2009-06-12 Thread Thomas Broyer
On 12 juin, 21:15, Buzzterrier terry.je...@gmail.com wrote: Thx Thomas I really appreciate this. That worked, but when I handle the event in DoSomething, I need to know what button was clicked. So you actually need to access an HasClickHandlers from the SimpleWidget, not make SimpleWidget

Re: How can I add a MouseOutHandler to a FlexTable cell?

2009-06-12 Thread Kelo
Hi Eduardo, Here's your solution: public class BocaJrsTable extends FlexTable implements HasMouseOutHandlers { private HandlerManager manager = new HandlerManager(this); public BocaJrsTable(){ super(); addDomHandler(new MouseOutHandler() {

3rd parties and GWT-RPC?

2009-06-12 Thread markww
Hi, I'm wondering what options we have when we want a 3rd party to talk to our server. For example, I'm using GWT RPC as-is. So my clients (browsers) talk to the server perfectly, works great. Now I'd like to make an iPhone app (an actual objective-c compiled app) that also uses my web service.

[gwt-contrib] Comment on OverlayTypes in google-web-toolkit

2009-06-12 Thread codesite-noreply
Comment by bobbysoares: Scottb, I was suggesting for example having new MyObject(...) be replaced with MyObject.newInstance(...) automatically (where newInstance would be a method supplied by the developer which returns an instance of the class, possibly natively, after calling the JS

[gwt-contrib] [google-web-toolkit commit] r5549 - Remove stale branches.

2009-06-12 Thread codesite-noreply
Author: b...@google.com Date: Fri Jun 12 12:16:17 2009 New Revision: 5549 Removed: changes/bobv/clientbundle/ changes/bobv/derpc/ Log: Remove stale branches. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit commit] r5550 - Create a branch to publish derpc test code.

2009-06-12 Thread codesite-noreply
Author: b...@google.com Date: Fri Jun 12 12:26:45 2009 New Revision: 5550 Added: changes/bobv/derpc/ (props changed) - copied from r5549, /trunk/ Log: Create a branch to publish derpc test code. --~--~-~--~~~---~--~~

[gwt-contrib] Allow generators fast access to source path resources

2009-06-12 Thread scottb
Reviewers: bobv, jat, Description: This patch adds a new method to GeneratorContext that makes a new ResourceOracle available specifically to generators. This ResourceOracle contains all of the resources on the classpath that are associated with source files on the sourcepath. Certain

[gwt-contrib] Re: Allow generators fast access to source path resources

2009-06-12 Thread bobv
LGTM. http://gwt-code-reviews.appspot.com/40801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right): http://gwt-code-reviews.appspot.com/40801/diff/1/2#newcode76 Line 76: * being compiled. containing all resources in the module's source paths That it's from the

[gwt-contrib] Re: Allow generators fast access to source path resources

2009-06-12 Thread scottb
http://gwt-code-reviews.appspot.com/40801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right): http://gwt-code-reviews.appspot.com/40801/diff/1/2#newcode76 Line 76: * being compiled. Will clarify doc. http://gwt-code-reviews.appspot.com/40801

[gwt-contrib] [google-web-toolkit commit] r5552 - Adds a new method to GeneratorContext that makes a new ResourceOracle available specifica...

2009-06-12 Thread codesite-noreply
Author: sco...@google.com Date: Fri Jun 12 13:56:52 2009 New Revision: 5552 Modified: trunk/dev/core/src/com/google/gwt/core/ext/GeneratorContext.java trunk/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java trunk/dev/core/src/com/google/gwt/dev/cfg/PublicOracle.java

[gwt-contrib] Re: Custom tag constructor for HTMLPanel

2009-06-12 Thread rjrjr
[+ contrib] http://gwt-code-reviews.appspot.com/39802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Custom tag constructor for HTMLPanel

2009-06-12 Thread jgw
http://gwt-code-reviews.appspot.com/39802/diff/1/3 File user/src/com/google/gwt/user/client/ui/HTMLPanel.java (right): http://gwt-code-reviews.appspot.com/39802/diff/1/3#newcode61 Line 61: public HTMLPanel(String tag, String html) { Could we not force 'tag' to simply be an element, so that we

[gwt-contrib] Re: Custom tag constructor for HTMLPanel

2009-06-12 Thread Ray Ryan
That won't really protect anyone from anything, as they could just call DOM.createElement(bugger) and hand that in. Also, accepting an existing element is another way to say HTMLPanel.wrap(), which we haven't provided so far--you really want to go there? Anyhow, does any browser not accept bugger

[gwt-contrib] Re: Custom tag constructor for HTMLPanel

2009-06-12 Thread jgw
Ray: That won't really protect anyone from anything, as they could just call DOM.createElement(bugger) and hand that in. Also, accepting an existing element is another way to say HTMLPanel.wrap(), which we haven't provided so far--you really want to go there? Anyhow, does any browser not accept

[gwt-contrib] Re: Custom tag constructor for HTMLPanel

2009-06-12 Thread jgw
On 2009/06/12 21:20:50, jgw wrote: Ray: That won't really protect anyone from anything, as they could just call DOM.createElement(bugger) and hand that in. Also, accepting an existing element is another way to say HTMLPanel.wrap(), which we haven't provided so far--you really want to go

[gwt-contrib] [google-web-toolkit commit] r5553 - Don't be so silly about the event sink constants in RadioButton

2009-06-12 Thread codesite-noreply
Author: rj...@google.com Date: Fri Jun 12 15:33:13 2009 New Revision: 5553 Modified: trunk/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/DefaultMuseum.java trunk/user/src/com/google/gwt/user/client/ui/RadioButton.java Log: Don't be so silly about the event sink

[gwt-contrib] Specify the path for translatable code explicitly in new apps created by webAppCreator

2009-06-12 Thread amitmanjhi
Reviewers: Ray Ryan, scottb, Description: It will be less confusing for new users. Anyone see any downsides? Please review this at http://gwt-code-reviews.appspot.com/39803 Affected files: user/src/com/google/gwt/user/tools/Module.gwt.xmlsrc Index:

[gwt-contrib] [google-web-toolkit commit] r5554 - Allow CompilationResult.getStatementRanges() to return null,

2009-06-12 Thread codesite-noreply
Author: sp...@google.com Date: Fri Jun 12 15:49:54 2009 New Revision: 5554 Modified: trunk/dev/core/src/com/google/gwt/core/ext/linker/CompilationResult.java trunk/dev/core/src/com/google/gwt/core/linker/IFrameLinker.java

[gwt-contrib] Re: Specify the path for translatable code explicitly in new apps created by webAppCreator

2009-06-12 Thread Scott Blum
LGTM On Fri, Jun 12, 2009 at 6:49 PM, amitman...@google.com wrote: Reviewers: Ray Ryan, scottb, Description: It will be less confusing for new users. Anyone see any downsides? Please review this at http://gwt-code-reviews.appspot.com/39803 Affected files:

[gwt-contrib] Re: Specify the path for translatable code explicitly in new apps created by webAppCreator

2009-06-12 Thread Ray Ryan
LGTM++ On Fri, Jun 12, 2009 at 4:08 PM, Scott Blum sco...@google.com wrote: LGTM On Fri, Jun 12, 2009 at 6:49 PM, amitman...@google.com wrote: Reviewers: Ray Ryan, scottb, Description: It will be less confusing for new users. Anyone see any downsides? Please review this at

[gwt-contrib] Re: Specify the path for translatable code explicitly in new apps created by webAppCreator

2009-06-12 Thread Amit Manjhi
Thanks Scott and Ray. Commited at r. On Fri, Jun 12, 2009 at 4:11 PM, Ray Ryan rj...@google.com wrote: LGTM++ On Fri, Jun 12, 2009 at 4:08 PM, Scott Blum sco...@google.com wrote: LGTM On Fri, Jun 12, 2009 at 6:49 PM, amitman...@google.com wrote: Reviewers: Ray Ryan, scottb,

[gwt-contrib] [google-web-toolkit commit] r5555 - Specify the path for translatable code explicitly in new apps created by webAppCreator.

2009-06-12 Thread codesite-noreply
Author: amitman...@google.com Date: Fri Jun 12 16:20:01 2009 New Revision: Modified: trunk/user/src/com/google/gwt/user/tools/Module.gwt.xmlsrc Log: Specify the path for translatable code explicitly in new apps created by webAppCreator. Patch by: amitmanjhi Review by: scottb, rjrjr

[gwt-contrib] [google-web-toolkit commit] r5556 - Merge trunk r5554 into 6/2 snapshot branch. This fixes a breaking API change

2009-06-12 Thread codesite-noreply
Author: j...@google.com Date: Fri Jun 12 16:53:06 2009 New Revision: 5556 Modified: branches/snapshot-2009.06.02-r5498/branch-info.txt branches/snapshot-2009.06.02-r5498/dev/core/src/com/google/gwt/core/ext/linker/CompilationResult.java

[gwt-contrib] Comment on OverlayTypes in google-web-toolkit

2009-06-12 Thread codesite-noreply
Comment by cromwellian: It would be interesting to consider Constructor() as being rewritten to a static method with an implicit call to createObject() and all references to this rewritten to this$static. e.g. public Foo(int x, String y) { this.x = x; this.y = y; } rewritten to

[gwt-contrib] Re: Changing JsArrayT extends JavaScriptObject to JsArrayT

2009-06-12 Thread Ray Cromwell
I'm in the process of some final tweaks on GQuery, so I'll look at how much of my private JSArray class I can move over as a patch. One possibility for avoiding Iterator object creation without using flyweights is to introduce a new Iterator type which contains methods which are parameterized by

[gwt-contrib] [google-web-toolkit commit] r5557 - Ant top-level target rework to allow single-platform use. Not that whereas ant build u...

2009-06-12 Thread codesite-noreply
Author: fabb...@google.com Date: Fri Jun 12 19:28:21 2009 New Revision: 5557 Modified: trunk/build.xml trunk/common.ant.xml trunk/tools/benchmark-viewer/build.xml trunk/user/build.xml Log: Ant top-level target rework to allow single-platform use. Not that whereas ant build

[gwt-contrib] Re: Changing JsArrayT extends JavaScriptObject to JsArrayT

2009-06-12 Thread Ray Cromwell
BTW, the last proposal is very unsafe with some form of escape analysis since it is unsafe to pass references to classes which reference local scope to other scopes. Another possibility is a form of 'destructuring' of Iterator classes by inlining them completely into local scope vs escape