Re: showing all the elements from SuggestOracle in suggestionBox

2010-09-10 Thread ciosbel
I don't suggest you to do that. I think it's quite misleading for the user. A better solution should be to show a popup with a message like no suggestions found or something like that. It's quite simple using 2.1 milestones: extend either SuggestBox.DefaultSuggestionDisplay or

Re: New Website with a huge database using GWT

2010-09-10 Thread Rokesh
I searched for it also, but so far the option were iffy... Try Java AppEngine :) or something like http://www.slicehost.com/ or http://www.linode.com/ And yes, GWT will do your job (large apps...) On Sep 10, 6:12 am, Rahul Vijay rahul.vija...@gmail.com wrote: Hi gal,   Thanks for that.

Release 0.4 of gwt-platform

2010-09-10 Thread PhilBeaudoin
We just released version 0.4 of the gwt-platform MVP framework, you can get it from http://gwtplatform.com New features include automatic event and action generation via annotation processors, a new mechanism for delayed reveal of presenters, simplified unit testing, and many other improvements

Re: UiBinder: ClientBundle with ImageResource ui:style. How?

2010-09-10 Thread daniel brelovsky
i think the 'resource' attribute is ignored u can use the 'src'-attribute and use the relative path to the image! but there seems to be a problem when the image is in a parent path is in a parent directory (relative to the ui.xml). in this case u can write src='../image.png' but this fails when a

java.lang.NullPointerException at com.google.gwt.requestfactory.server.RequestFactoryServlet.doPost(RequestFactoryServlet.java:94)

2010-09-10 Thread Rene Vielma
Hello. I had created a new project using roo from eclipse, with GWT capability. The project only contains one entity with two string attributes. And the scaffold worked fine. then I added a birthDate attribute. And the scaffold work fine too.. but the eclipse console throws: GRAVE: null

FTP download link for GWT

2010-09-10 Thread Mayuresh
Hello, Our organization has blocked downloads over http(s). However the same works with FTP client. Since I am not able to open GWT download page, is there any FTP download link for GWT where I can get the latest version? Thanks and regards, Mayuresh. -- You received this message because you

GWT Checkbox label positioning

2010-09-10 Thread gshep7
I have a need to position the checkbox label to the left of the checkbox. By default it is positioned on the right. Is there anyway to do this? I tried using css to do this without any luck. I googled it and couldn't find anything that works for me. Any example would be greatly appreciated.

Re: GWT Checkbox label positioning

2010-09-10 Thread Thomas Broyer
On Sep 9, 9:27 pm, gshep7 guys...@gmail.com wrote: I have a need to position the checkbox label to the left of the checkbox.  By default it is positioned on the right.  Is there anyway to do this?  I tried using css to do this without any luck.  I googled it and couldn't find anything that

Re: How to use an obfuscated css selector in a css file in a depending project

2010-09-10 Thread Thomas Broyer
On Sep 9, 11:44 pm, Steve Armstrong steve.armstr...@gmail.com wrote: I've asked this on Stack Overflow, but noone seems to know:http://stackoverflow.com/questions/3612146/use-obfusticated-css-name-... I've got a library with some CSS, and a depending project that expands on the CSS. I'm

Getting ACSID cookie in web mode

2010-09-10 Thread mma
Hi there, I'm implementing an auto-login method for google users, where if a user is already logged in the GWT App won't show the welcome page and will go directly to the page that is relevant for that particular user. If the user is not logged in, the App will show the welcome page and ask to

Re: java.lang.NullPointerException at com.google.gwt.requestfactory.server.RequestFactoryServlet.doPost(RequestFactoryServlet.java:94)

2010-09-10 Thread Chris Conroy
Can you try to reproduce this from trunk? This code has gone through several revisions since 2.1.0 M3 On Thu, Sep 9, 2010 at 6:46 PM, Rene Vielma renevie...@gmail.com wrote: Hello. I had created a new project using roo from eclipse, with GWT capability. The project only contains one entity

Re: The Compiler is Compiling Only One Permutation

2010-09-10 Thread bindu priya
hi Daniel, Use define-property name=user.agent value=''ie6,gecko,gecko1_8,safari,opera / and try.. let me know if it works. On Fri, Sep 10, 2010 at 11:11 AM, Daniel Simons daniel.simo...@gmail.comwrote: I am trying to compile all 5 permutation for my GWT App. For some reason it is only

Re: Getting ACSID cookie in web mode

2010-09-10 Thread Thomas Broyer
On Sep 10, 4:28 pm, mma marco.m.al...@gmail.com wrote: Hi there, I'm implementing an auto-login method for google users, where if a user is already logged in the GWT App won't show the welcome page and will go directly to the page that is relevant for that particular user. If the user is

Difference between URL.decode and URL.decodeComponent

2010-09-10 Thread Kady
What is the difference between URL.decode and URL.decodeComponent methods ? Any example is appreciated. Thank you. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To

PagingScrollTable Auto Resize

2010-09-10 Thread Maurice
Hi, I understand that a PagingScrollTable must have its size specified in pixels. So far I have successfully created a PagingScrollTable and setup a handler to listen for browser resize events like so: Window.addResizeHandler(new ResizeHandler() {...}) When I resize the browser my

How to intercept ONPASTE events

2010-09-10 Thread jjd
In order to modify what gets pasted to my application, I'm attempting to intercept ONPASTE events as described by Jim Douglas in this thread: http://groups.google.com/group/google-web-toolkit/browse_thread/thread/09a3527707d22be0?fwc=1 The problem is that I'm never seeing the ONPASTE event

Re: Variable UI

2010-09-10 Thread pete
Yes, worldofsolitaire.com seems to handle the problems I'm encountering, no ugly wrong layout and no need to refresh. But I couldn't find a clue how this page was created... (doesn't look like GWT, does it? No obfuscated javascript...) I have firebug installed, and the way the cards are handled

Re: No GWT support found for this system.

2010-09-10 Thread Eric Clayberg
I'm not familiar with the Eclipse SOA build, but in general GWT Designer requires the full Eclipse SDK including the JDT and PDE. If those aren't present in the SOA build, you will need to add them first. The specific error you are seeing is the result of the GWT Designer Core portion of GWT

javascript eval() does not have scope to a local variable

2010-09-10 Thread dane.molotok
I have a JSNI method that I want to pass two strings, one that is the JSON response from a server, and one that is a JavaScript snippet that will parse the JSON and return a list of JavaScriptObjects to be displayed in a combo box (the JavaScriptObjects will contain displays and values). The

Re: GWT Newbie:: devmode (same origin policy) with PHP REST backend

2010-09-10 Thread Ketan Shah
Thanks Brett. I received similar advice on IRC ###gwt . Worked wonderfully ! On Sep 9, 11:28 pm, Brett Thomas brettptho...@gmail.com wrote: Are you familiar with the -noserver option? Check it outhttp://code.google.com/webtoolkit/doc/latest/FAQ_DebuggingAndCompilin... On Thu, Sep 9, 2010

Re: FTP download link for GWT

2010-09-10 Thread Ikai L (Google)
Is HTTP completely blocked? For instance, can you use Maven? If you can, try this: http://googlewebtoolkit.blogspot.com/2010/08/how-to-use-google-plugin-for-eclipse.html (Seems strange HTTP would be blocked, as you are emailing over Gmail right now) On Fri, Sep 10, 2010 at 12:47 AM, Mayuresh

Re: JSNI Reserved Word ?

2010-09-10 Thread Ikai L (Google)
JSNI is just an interface to Javascript, so you won't be able to use Javascript reserved words. Here's a list: http://www.quackit.com/javascript/javascript_reserved_words.cfm export is on that list. On Thu, Sep 9, 2010 at 3:53 PM, nino ekambi jazzmatad...@googlemail.comwrote: Hello People,

Re: How to use external JS from GWT?

2010-09-10 Thread marius.andreiana
On Sep 10, 1:42 am, Zack Grossbart zgrossb...@gmail.com wrote: In your example, where and how do you include the jQuery UI datepicker widget? I defined them in the HTML file containing my GWT code.  Just a simple JavaScript reference the same way I would in any other HTML page. Right. I was

Re: PagingScrollTable Auto Resize

2010-09-10 Thread daniel
query the container widget's size in a deferred command (http:// code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/com/ google/gwt/user/client/DeferredCommand.java?r=1061) so the browser has time to calculate the containers size before you ask for it On 10 Sep., 18:06, Maurice

ScrolPanel Question

2010-09-10 Thread skippy
I need to ack a scrolPanel if its vertical scrol bar is visible, If so, I need to adjust the width of the table. Thanks -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

Re: GWT Spring integration - what is the best method in late 2010?

2010-09-10 Thread Deepak Singh
Any solution pls. I am stuck with the error. On Wed, Sep 8, 2010 at 11:46 PM, Deepak Singh deepaksingh...@gmail.comwrote: Hi Mark, yes i refreshed the page but no luck. Also googling could not find an aswer needed. Later i changed from jdk 1.6 to jdk 1.5 then i got a different error as

Re: Difference between URL.decode and URL.decodeComponent

2010-09-10 Thread Thomas Broyer
On Sep 10, 6:00 pm, Kady kaushika...@gmail.com wrote: What is the difference between URL.decode and URL.decodeComponent methods ? Any example is appreciated. The exact same difference as between decodeURI and decodeURIComponent in plain old JS:

Re: Gwt-platform vs Guit

2010-09-10 Thread notcourage
Thx for your contributions this lively exchange. Am I the only one surprised that it is almost 2011 yet GWT doesn't have input validation data binding? (I'm going to study SmartGWT shortly.) Does guit or gwt-platform? How will google's upcoming mvp framework impact yours? On Aug 24, 10:36 am,

Re: Gwt-platform vs Guit

2010-09-10 Thread Gal Dolber
Guit is a low level, general purpose framework, thats why it will never have validation or data bindings. For validation you can wait to gwt 2.1, or look into trunk, there is some work on a jrs-303 generator. Gwt 2.1 also have some work on bean binding, but I have only used the new cell widgets...

Re: Difference between URL.decode and URL.decodeComponent

2010-09-10 Thread lineman78
decode and encode component is intended to be used in parts of the query. Take the following url for example: http://www.google.com/search?q=fox%26hound |___| component The bigggest difference between encode and encodeComponent is what

Change Cursor Shape

2010-09-10 Thread udayanga ranasinghe
Hi All, Please tell me how to change the cursor shape in MouseMoveEvent event. Thanks Regards. Udayanga. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Deletes the bikeshed. (issue816801)

2010-09-10 Thread Joel Webber
Don't worry, I'm sure it will come back next time we need to do something big that needs time to settle. This ended up being a much, much better pattern than the incubator, which just became a dumping ground with version-skew hell... Le 10 septembre 2010 03:28, edwin...@gmail.com a écrit :

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread bobv
I think you can still lose the explicit removeHandler. http://gwt-code-reviews.appspot.com/841804/diff/11002/17020 File user/src/com/google/gwt/event/shared/EventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34

[gwt-contrib] Re: Enum name obfuscation. (issue827802)

2010-09-10 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: JsArray enhancement

2010-09-10 Thread Thomas Broyer
On Sep 9, 11:50 pm, Sebastian use...@laliluna.de wrote: I wanted to provide a patch for JsArray* to support common methods like sort and reverse. I found the issuehttp://code.google.com/p/google-web-toolkit/issues/detail?id=2793 which is not completed and wants to provide all ECMA methods.

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-10 Thread pdr
http://gwt-code-reviews.appspot.com/847801/diff/8002/13005 File user/src/com/google/gwt/user/client/ui/Anchor.java (right): http://gwt-code-reviews.appspot.com/847801/diff/8002/13005#newcode117 user/src/com/google/gwt/user/client/ui/Anchor.java:117: this(html.asString(), true); On 2010/09/10

[gwt-contrib] [google-web-toolkit] r8745 committed - Move the packages to include in the javadoc out of the build.xml file ...

2010-09-10 Thread codesite-noreply
Revision: 8745 Author: b...@google.com Date: Fri Sep 10 03:21:10 2010 Log: Move the packages to include in the javadoc out of the build.xml file and into a properties file. Patch by: bobv Review by: rjrjr Review at http://gwt-code-reviews.appspot.com/856801

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread Ray Ryan
Love it. Sold. On Sep 10, 2010 5:27 AM, b...@google.com wrote: I think you can still lose the explicit removeHandler. http://gwt-code-reviews.appspot.com/841804/diff/11002/17020 File user/src/com/google/gwt/event/shared/EventBus.java (right):

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread jlabanca
http://gwt-code-reviews.appspot.com/841804/diff/11002/17020 File user/src/com/google/gwt/event/shared/EventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34 user/src/com/google/gwt/event/shared/EventBus.java:34: public H extends EventHandler void

[gwt-contrib] GWT Compiler or widget.gwt.xml file optimisation for 2.1 ?

2010-09-10 Thread stuckagain
Hi, I managed to finally factor our the incubator widgets from my medium sized application and now that I have no dependencies left I saw the compile time decrease with 66%. Which is an amazing. We were only using 2 widgets yet this library had such a huge impact. Are there any plans to improve

[gwt-contrib] Re: Enum name obfuscation. (issue827802)

2010-09-10 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation. (issue827802)

2010-09-10 Thread bobv
derpc changes LGTM http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation. (issue827802)

2010-09-10 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GWT Compiler or widget.gwt.xml file optimisation for 2.1 ?

2010-09-10 Thread Joel Webber
Wait, are you saying that your compile time went down *by* 2/3 (meaning to 1/3 of its original duration)? And this is a result of pulling the incubator off of the classpath (and hoisting out a couple of widgets)? That would seem to be a pretty big difference! @Eric: This might be interesting

[gwt-contrib] [google-web-toolkit] r8748 committed - Enum name obfuscation. Added configuration property...

2010-09-10 Thread codesite-noreply
Revision: 8748 Author: jbrosenb...@google.com Date: Fri Sep 10 06:27:47 2010 Log: Enum name obfuscation. Added configuration property (compiler.enum.obfuscate.names) to optionally obfuscatate enum names from production output. Review at http://gwt-code-reviews.appspot.com/827802

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-10 Thread Christoph Kern
On Friday, September 10, 2010, p...@google.com wrote: One of the reasons to delegate to setHTML() is to support external implementations that have overridden setHTML(). Your suggestion makes a lot of sense, but to support the external users, I think we should stick with the setHTML() version.

[gwt-contrib] [google-web-toolkit] r8749 committed - Update HistoryTest to ensure that non-safari browsers also:...

2010-09-10 Thread codesite-noreply
Revision: 8749 Author: gwt.mirror...@gmail.com Date: Fri Sep 10 07:02:13 2010 Log: Update HistoryTest to ensure that non-safari browsers also: - run testHistory - verify the current hash value as part of testTokenEscaping and testTokenNonescaping Review at

[gwt-contrib] [google-web-toolkit] r8750 committed - Resubmitting r8722, which was a continuation of r8542, with changes to...

2010-09-10 Thread codesite-noreply
Revision: 8750 Author: fre...@google.com Date: Fri Sep 10 07:37:39 2010 Log: Resubmitting r8722, which was a continuation of r8542, with changes to the way Image is tested in DoubleClickEventSinkTest. Fixes double click where it was broken and adds tests to ensure that events are sunk.

[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-10 Thread jlabanca
Why did you remove classes/marker? Its needed by Eclipse or it throws an error because it can't find the classes/ directory where it is supposed to dump compiled files. http://gwt-code-reviews.appspot.com/845801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

2010-09-10 Thread unnurg
Reviewers: rjrjr, Description: Add the option to use JSON rather than GWT RPC in remote logging Please review this at http://gwt-code-reviews.appspot.com/830802/show Affected files: M user/src/com/google/gwt/logging/Logging.gwt.xml A

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

2010-09-10 Thread unnurg
http://gwt-code-reviews.appspot.com/830802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

2010-09-10 Thread rjrjr
Bob, can you take this one? http://gwt-code-reviews.appspot.com/830802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: TypeSerializerCreator generates pure Java code path for DevMode. (issue831801)

2010-09-10 Thread bobv
lgtm. When the codegen code is hard to read, it's useful to add some example comments showing what the generated code might look at. It would pull up your code:comment ratio :-) http://gwt-code-reviews.appspot.com/831801/diff/7013/9009 File

[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-10 Thread Nick Chalko
Unintentional. I am OOO today, so I can't fix it till at least tonight. I will be happy to review a CL. On Fri, Sep 10, 2010 at 10:54 AM, jlaba...@google.com wrote: Why did you remove classes/marker? Its needed by Eclipse or it throws an error because it can't find the classes/ directory

Re: [gwt-contrib] GWT Compiler or widget.gwt.xml file optimisation for 2.1 ?

2010-09-10 Thread Eric Ayers
Hi David, Are you using the -draftCompile option? The reason I ask is that using this option cuts out the optimization steps to make the compile run faster. The end result i that running the JDT compiler takes dominates the compile time when using it. Everything on the sourcepath is compiled

[gwt-contrib] Re: GWT Compiler or widget.gwt.xml file optimisation for 2.1 ?

2010-09-10 Thread Fushion
I can confirm the 2/3 drop in compile time, did the same a few months ago... On 10 sep, 18:06, Joel Webber j...@google.com wrote: Wait, are you saying that your compile time went down *by* 2/3 (meaning to 1/3 of its original duration)? And this is a result of pulling the incubator off of the

[gwt-contrib] Re: TypeSerializerCreator generates pure Java code path for DevMode. (issue831801)

2010-09-10 Thread scottb
Thanks for the feedback. I'm in a good functional state, so I'm going to go ahead and commit this as-is, and add comments in a follow-up change. http://gwt-code-reviews.appspot.com/831801/diff/7013/9009 File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java (right):

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
http://gwt-code-reviews.appspot.com/841804/diff/11002/17020 File user/src/com/google/gwt/event/shared/EventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34 user/src/com/google/gwt/event/shared/EventBus.java:34: public H extends EventHandler void

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
Oh, damn. Forgot to put John's null check back. One more moment. http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8751 committed - Update i18n Messages to include:...

2010-09-10 Thread codesite-noreply
Revision: 8751 Author: j...@google.com Date: Fri Sep 10 08:58:12 2010 Log: Update i18n Messages to include: - SafeHtml support - extended plurals support - list rendering - static placeholders - format arguments Patch by: jat, xtof Review by: pdr, xtof Review at

[gwt-contrib] [google-web-toolkit] r8752 committed - TypeSerializerCreator generates pure Java code path for DevMode....

2010-09-10 Thread codesite-noreply
Revision: 8752 Author: gwt.mirror...@gmail.com Date: Fri Sep 10 09:02:53 2010 Log: TypeSerializerCreator generates pure Java code path for DevMode. http://gwt-code-reviews.appspot.com/831801/show http://code.google.com/p/google-web-toolkit/source/detail?r=8752 Added:

[gwt-contrib] [google-web-toolkit] r8753 committed - Renamed getStableId() to stableId()...

2010-09-10 Thread codesite-noreply
Revision: 8753 Author: amitman...@google.com Date: Fri Sep 10 09:06:14 2010 Log: Renamed getStableId() to stableId() Patch by: amitmanjhi Review (and suggested) by: rjrjr Review at http://gwt-code-reviews.appspot.com/857801 Review by: rj...@google.com

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
Null checks are in place, and tested. Found some stray garbage and bugs along the way, including a redundant fire method (oops). I think it's done, but I'm getting sloppy. http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] RR : Initial add of IsEditor interface to allow views to work in an Editor (issue858801)

2010-09-10 Thread bobv
Reviewers: rjrjr, Message: Review requested. Description: Initial add of IsEditor interface to allow views to work in an Editor hierarchy without being an Editor. This patch will serve as a base for an error-aware Editor decorator panel. Patch by: bobv Review by: rjrjr Please review this at

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-10 Thread Fred Sauer
Commited as http://code.google.com/p/google-web-toolkit/source/detail?r=8749 Filed HtmlUnit bug https://sourceforge.net/tracker/?func=detailaid=3063896group_id=47038atid=448266 On Thu, Sep 9, 2010 at 5:37 PM, sco...@google.com wrote: Still LGTM. May want to file a bug against HtmlUnit.

[gwt-contrib] Re: RR : Initial add of IsEditor interface to allow views to work in an Editor (issue858801)

2010-09-10 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/858801/diff/1/6 File user/src/com/google/gwt/editor/rebind/model/EditorAccess.java (right): http://gwt-code-reviews.appspot.com/858801/diff/1/6#newcode76 user/src/com/google/gwt/editor/rebind/model/EditorAccess.java:76: TypeOracle oracle =

[gwt-contrib] Minor refactor of ClientBundles used in Cell Widgets. Ensures that all method names in ClientBun... (issue859801)

2010-09-10 Thread jlabanca
Reviewers: bobv, Description: Minor refactor of ClientBundles used in Cell Widgets. Ensures that all method names in ClientBundle and CssResource are globally unique. Adds missing flipRtl tags to ImageResources. Adds @ImportedWithPrefix annotation to CssResources. Breaks out the path to the

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread jlabanca
LGTM Just take a look at the assertsOn thing in the tests. http://gwt-code-reviews.appspot.com/841804/diff/58001/45043 File user/test/com/google/gwt/event/shared/HandlerManagerTest.java (right): http://gwt-code-reviews.appspot.com/841804/diff/58001/45043#newcode197

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread bobv
LGTM, just some minor suggestions. http://gwt-code-reviews.appspot.com/841804/diff/31001/3028 File user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java (right): http://gwt-code-reviews.appspot.com/841804/diff/31001/3028#newcode81

[gwt-contrib] Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE event and implemented the... (issue860801)

2010-09-10 Thread amitmanjhi
Reviewers: rjrjr, Description: Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE event and implemented the copy-on-write semantics. Patch by: amitmanjhi Review by: rjrjr (desk review) Please review this at http://gwt-code-reviews.appspot.com/860801/show Affected files:

[gwt-contrib] Re: Improve locale handling for default scripts and languages where some (issue851802)

2010-09-10 Thread jat
http://gwt-code-reviews.appspot.com/851802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add stack trace display to the rest of the log handlers in dev mode (issue861801)

2010-09-10 Thread unnurg
Reviewers: rjrjr, Description: Add stack trace display to the rest of the log handlers in dev mode Please review this at http://gwt-code-reviews.appspot.com/861801/show Affected files: M user/src/com/google/gwt/logging/client/ConsoleLogHandler.java M

[gwt-contrib] Re: Adds a -strict option to the GWT compiler. If this option is specified, (issue853801)

2010-09-10 Thread spoon
http://gwt-code-reviews.appspot.com/853801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a -strict option to the GWT compiler. If this option is specified, (issue853801)

2010-09-10 Thread spoon
Those two changes are made now. It's ready for another round of review. http://gwt-code-reviews.appspot.com/853801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

2010-09-10 Thread Unnur Gretarsdottir
Asking Fred to pick up the 2 logging CL's since they're fairly independent of vega stuff and you guys sound swamped - Unnur On Fri, Sep 10, 2010 at 11:24 AM, rj...@google.com wrote: Bob, can you take this one? http://gwt-code-reviews.appspot.com/830802/show --

[gwt-contrib] [google-web-toolkit] r8754 committed - Initial add of IsEditor interface to allow views to work in an Editor...

2010-09-10 Thread codesite-noreply
Revision: 8754 Author: b...@google.com Date: Fri Sep 10 12:29:13 2010 Log: Initial add of IsEditor interface to allow views to work in an Editor hierarchy without being an Editor. This patch will serve as a base for an error-aware Editor decorator panel. Patch by: bobv Review by: rjrjr Review at

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
Last changes made, submitting. On 2010/09/10 23:21:27, rjrjr wrote: http://gwt-code-reviews.appspot.com/841804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-10 Thread rjrjr
http://gwt-code-reviews.appspot.com/841804/diff/58001/45022 File user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java (right): http://gwt-code-reviews.appspot.com/841804/diff/58001/45022#newcode22 user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java:22: *

[gwt-contrib] Fix the logging sample - somehow the client and shared directories got deleted. Also a minor fix... (issue842802)

2010-09-10 Thread unnurg
Reviewers: fredsa, Description: Fix the logging sample - somehow the client and shared directories got deleted. Also a minor fix for devmode, so that LogRecords with no logger name set are handled gracefully Please review this at http://gwt-code-reviews.appspot.com/842802/show Affected files:

[gwt-contrib] Re: Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE event and implemented the... (issue860801)

2010-09-10 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/860801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a -strict option to the GWT compiler. If this option is specified, (issue853801)

2010-09-10 Thread scottb
LGTM. Just nits, no need to re-review if you decide to fix them. http://gwt-code-reviews.appspot.com/853801/diff/4001/5008 File user/test/com/google/gwt/dev/StrictModeTest.java (right): http://gwt-code-reviews.appspot.com/853801/diff/4001/5008#newcode45

[gwt-contrib] Comments / cleanup for RPC generators (issue862801)

2010-09-10 Thread scottb
Reviewers: bobv, http://gwt-code-reviews.appspot.com/862801/diff/2001/3001 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (left): http://gwt-code-reviews.appspot.com/862801/diff/2001/3001#oldcode372

[gwt-contrib] [google-web-toolkit] r8755 committed - Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE...

2010-09-10 Thread codesite-noreply
Revision: 8755 Author: amitman...@google.com Date: Fri Sep 10 13:31:52 2010 Log: Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE event and implemented the copy-on-write semantics. Patch by: amitmanjhi Review by: rjrjr (desk review) Review at

[gwt-contrib] Public: Restore the samples/validation classes/marker (issue856802)

2010-09-10 Thread nchalko
Reviewers: robertvawter, jlabanca, Description: Public: Restore the samples/validation classes/marker Its needed by Eclipse or it throws an error because it can't find the classes/ directory where it is supposed to dump compiled files. Please review this at

[gwt-contrib] Public: First take at GWT validation that actually validates on the client side. (issue863801)

2010-09-10 Thread nchalko
Reviewers: robertvawter, Description: Public: First take at GWT validation that actually validates on the client side. Please review this at http://gwt-code-reviews.appspot.com/863801/show Affected files: M eclipse/samples/Validation/.classpath M eclipse/user/.classpath M

[gwt-contrib] Re: Public: First take at GWT validation that actually validates on the client side. (issue863801)

2010-09-10 Thread nchalko
This is not ready for a full review yet. But I want to get some early feed back. I am using using the HibernateValidator during the compile. To do this I created user/src/org/hibernate/validator/HibernateValidator.gwt.xml and associated files. It might be better if this actually lived in the

[gwt-contrib] Re: Public: First take at GWT validation that actually validates on the client side. (issue863801)

2010-09-10 Thread nchalko
http://gwt-code-reviews.appspot.com/863801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors