[gwt-contrib] [google-web-toolkit] r8465 committed - Fixes UiBinder MenuBar parser to allow MenuItemSeparator, and custom...

2010-08-03 Thread codesite-noreply
Revision: 8465 Author: rj...@google.com Date: Mon Aug 2 18:45:49 2010 Log: Fixes UiBinder MenuBar parser to allow MenuItemSeparator, and custom subclasses of MenuItem. Patch by konstantin.scheg...@gmail.com Review by rj...@google.com http://gwt-code-reviews.appspot.com/702803 Fixes gwt issue

[gwt-contrib] [google-web-toolkit] r8455 committed - Remove 1.6isms from RequestFactory, and fix DynaTableRf (id's...

2010-08-03 Thread codesite-noreply
Revision: 8455 Author: rj...@google.com Date: Mon Aug 2 10:03:54 2010 Log: Remove 1.6isms from RequestFactory, and fix DynaTableRf (id's still must be Long, and at the moment it actually counts). Review at http://gwt-code-reviews.appspot.com/721804 Review by: robertvaw...@google.com

[gwt-contrib] [google-web-toolkit] r8454 committed - Adds integral BiDi support to Label.java and its descendants. Introduc...

2010-08-03 Thread codesite-noreply
Revision: 8454 Author: tomer...@google.com Date: Mon Aug 2 09:47:24 2010 Log: Adds integral BiDi support to Label.java and its descendants. Introduces a new interface, HasAutoHorizontalAlignment. Review at http://gwt-code-reviews.appspot.com/642803

[gwt-contrib] [google-web-toolkit] r8461 committed - Disabling part of HTMLTest because it fails cross browser.

2010-08-03 Thread codesite-noreply
Revision: 8461 Author: jlaba...@google.com Date: Mon Aug 2 14:09:21 2010 Log: Disabling part of HTMLTest because it fails cross browser. http://code.google.com/p/google-web-toolkit/source/detail?r=8461 Modified: /trunk/user/test/com/google/gwt/user/client/ui/HTMLTest.java

[gwt-contrib] [google-web-toolkit] r8463 committed - Change the way we include the User Auth files, keeping more of them...

2010-08-03 Thread codesite-noreply
Revision: 8463 Author: unn...@google.com Date: Mon Aug 2 15:57:18 2010 Log: Change the way we include the User Auth files, keeping more of them checked into GWT code rather than generated by roo Review at http://gwt-code-reviews.appspot.com/721803 Review by: rj...@google.com

[gwt-contrib] [google-web-toolkit] r8459 committed - Fixing HTMLTest so that it doesn't assume tag names returned from getI...

2010-08-03 Thread codesite-noreply
Revision: 8459 Author: jlaba...@google.com Date: Mon Aug 2 13:10:45 2010 Log: Fixing HTMLTest so that it doesn't assume tag names returned from getInnerHtml are lowercase. IE automatically converts tag names to uppercase. http://code.google.com/p/google-web-toolkit/source/detail?r=8459

[gwt-contrib] [google-web-toolkit] r8462 committed - SpeedTracerLogger: Don't throw exceptions on missed events. Instead, t...

2010-08-03 Thread codesite-noreply
Revision: 8462 Author: con...@google.com Date: Mon Aug 2 14:49:52 2010 Log: SpeedTracerLogger: Don't throw exceptions on missed events. Instead, try to recover gracefully. Review at http://gwt-code-reviews.appspot.com/674805 Review by: zun...@google.com

[gwt-contrib] [google-web-toolkit] r8460 committed - Add a file check to handle edge cases like broken symbolic links when ...

2010-08-03 Thread codesite-noreply
Revision: 8460 Author: con...@google.com Date: Mon Aug 2 13:26:01 2010 Log: Add a file check to handle edge cases like broken symbolic links when scanning directories for resources. Review at http://gwt-code-reviews.appspot.com/711803 Review by: sco...@google.com

[gwt-contrib] [google-web-toolkit] r8456 committed - Fixes many compiler warnings in JsonRequestProcessor.

2010-08-03 Thread codesite-noreply
Revision: 8456 Author: rj...@google.com Date: Mon Aug 2 10:40:29 2010 Log: Fixes many compiler warnings in JsonRequestProcessor. http://code.google.com/p/google-web-toolkit/source/detail?r=8456 Modified: /trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java

[gwt-contrib] [google-web-toolkit] r8453 committed - Reintroduces changes from r8440...

2010-08-03 Thread codesite-noreply
Revision: 8453 Author: con...@google.com Date: Sat Jul 31 10:16:08 2010 Log: Reintroduces changes from r8440 Review at http://gwt-code-reviews.appspot.com/707804 Review by: unn...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8453 Deleted:

[gwt-contrib] [google-web-toolkit] r8464 committed - Finish modernizing the DynaTableRF sample to use an event-based applic...

2010-08-03 Thread codesite-noreply
Revision: 8464 Author: b...@google.com Date: Mon Aug 2 18:09:28 2010 Log: Finish modernizing the DynaTableRF sample to use an event-based application model. Patch by: bobv Review by: rjrjr Review at http://gwt-code-reviews.appspot.com/733802

[gwt-contrib] Re: Add two new ClientBundle annotations: (issue714801)

2010-08-03 Thread bobv
LGTM, just a couple of code style nits I saw re-reading the patch. http://gwt-code-reviews.appspot.com/714801/diff/48001/6003 File user/src/com/google/gwt/resources/client/DataResource.java (right): http://gwt-code-reviews.appspot.com/714801/diff/48001/6003#newcode35

Re: [gwt-contrib] [google-web-toolkit] r8452 committed - Implement ROO-933 and ROO-935. Handle java.lang.{Byte/Short/Character/...

2010-08-03 Thread Pascal Patry
On Tuesday, August 03, 2010 00:15:14 codesite-nore...@google.com wrote: Revision: 8452 Author: cromwell...@google.com Date: Fri Jul 30 17:29:09 2010 Log: Implement ROO-933 and ROO-935. Handle java.lang.{Byte/Short/Character/Integer/Long/BigDecimal/BigInteger/Date/Flo at/Double} as return

[gwt-contrib] Re: Add the ability to change the size of a widget in the (issue719802)

2010-08-03 Thread jgw
On 2010/08/02 18:38:29, toms wrote: On Mon, Aug 2, 2010 at 2:14 PM, mailto:j...@google.com wrote: http://gwt-code-reviews.appspot.com/719802/diff/1/2 File user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/719802/diff/1/2#newcode315

[gwt-contrib] Made the error messages thrown in case of GWTTestCase timeouts more informative, as requested in (issue734801)

2010-08-03 Thread mmendez
http://gwt-code-reviews.appspot.com/734801/diff/1/2 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/734801/diff/1/2#newcode1019 user/src/com/google/gwt/junit/JUnitShell.java:1019: + Try increasing this timeout using the '-testMethodTimeout number'

[gwt-contrib] Re: Adding support for non-propagating events in Cell based widgets. In modern browsers, we make the... (issue720801)

2010-08-03 Thread jlabanca
committed as r8457 http://gwt-code-reviews.appspot.com/720801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread nchalko
Reviewers: Ray Ryan, Description: Public: Add default validators for the standard constraints. Include super source version of the Pattern constraint that does not reference java.util.regex.Pattern Please review this at http://gwt-code-reviews.appspot.com/735801/show Affected files: M

[gwt-contrib] Re: Always show more link when pager's list view has an inexact item count. More should set a rang... (issue708803)

2010-08-03 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/708803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread nchalko
On 2010/08/03 16:07:07, Nick Chalko wrote: Found some spelling errors and pushed a new version for review. http://gwt-code-reviews.appspot.com/735801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread rjrjr
I don't see a new patch http://gwt-code-reviews.appspot.com/735801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread nchalko
On 2010/08/03 17:03:03, Ray Ryan wrote: I don't see a new patch rietveld was waiting for me to enter a online description on its way now. http://gwt-code-reviews.appspot.com/735801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread nchalko
http://gwt-code-reviews.appspot.com/735801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread nchalko
On 2010/08/03 17:04:19, Nick Chalko wrote: On 2010/08/03 17:03:03, Ray Ryan wrote: I don't see a new patch rietveld was waiting for me to enter a online description on its way now. Ok new patch uploaded. http://gwt-code-reviews.appspot.com/735801/show --

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread rjrjr
Holy combinatorial explosion! I assume the stuff that is copyright Google is either by you or by Chris R? A few nits, and one real concern about DefaultConstraints. http://gwt-code-reviews.appspot.com/735801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right):

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread rjrjr
Holy combinatorial explosion! I assume the stuff that is copyright Google is either by you or by Chris R? A few nits, and one real concern about DefaultConstraints. http://gwt-code-reviews.appspot.com/735801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right):

[gwt-contrib] De-bounce built-in selection models (issue722802)

2010-08-03 Thread rice
Reviewers: Ray Ryan, Description: De-bounce built-in selection models Please review this at http://gwt-code-reviews.appspot.com/722802/show Affected files: M user/src/com/google/gwt/view/client/DefaultSelectionModel.java M user/src/com/google/gwt/view/client/MultiSelectionModel.java M

[gwt-contrib] Re: De-bounce built-in selection models (issue722802)

2010-08-03 Thread rjrjr
If I do this: sm.setSelected(!foo, sm.isSelected()); sm.setSelected(!foo, sm.isSelected()); I'll still see an event. Given your nifty event coalescing, I wouldn't have to. Should you do it there instead? Also, I wonder if NoSelectionModel is the exception to the no bounces please rule.

[gwt-contrib] Re: De-bounce built-in selection models (issue722802)

2010-08-03 Thread rjrjr
http://gwt-code-reviews.appspot.com/722802/diff/1/2 File user/src/com/google/gwt/view/client/DefaultSelectionModel.java (right): http://gwt-code-reviews.appspot.com/722802/diff/1/2#newcode84 user/src/com/google/gwt/view/client/DefaultSelectionModel.java:84: scheduleSelectionChangeEvent();

[gwt-contrib] Re: Put in a new fix for DevMode logging that uses bytecode rewriting rather than swapping out (issue725801)

2010-08-03 Thread unnurg
http://gwt-code-reviews.appspot.com/725801/diff/12001/13004 File dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java (right): http://gwt-code-reviews.appspot.com/725801/diff/12001/13004#newcode26 dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java:26: protected static

[gwt-contrib] Re: Put in a new fix for DevMode logging that uses bytecode rewriting rather than swapping out (issue725801)

2010-08-03 Thread unnurg
http://gwt-code-reviews.appspot.com/725801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Ability to support null data in Record (issue712802)

2010-08-03 Thread iscy
Reviewers: , Description: When a record has a property (for instance a Long property) set to 'null', the client side parser will throw out an exception instead of gracefully returning null. Please review this at http://gwt-code-reviews.appspot.com/712802/show Affected files:

[gwt-contrib] Tests and tweaks for DisclosurePanel and StackLayoutPanel parsers (issue736801)

2010-08-03 Thread Konstantin . Scheglov
Reviewers: Ray Ryan, Description: 1. Problems in assertFirstHeader(). 1.1. invalid condition; 1.2. invalid reference on second argument. 2. Use addStatement() instead of addInitStatement(), because same is done everywhere. 3. Small tweaks. 4. Set of tests, including all bad cases. Please review

[gwt-contrib] Fixes various warnings in RequestFactory, most of them generics (issue737801)

2010-08-03 Thread rjrjr
Reviewers: cromwellian, Description: Fixes various warnings in RequestFactory, most of them generics related. Review by: cromwell...@google.com Please review this at http://gwt-code-reviews.appspot.com/737801/show Affected files: M

[gwt-contrib] Re: Put in a new fix for DevMode logging that uses bytecode rewriting rather than swapping out (issue725801)

2010-08-03 Thread tobyr
LGTM http://gwt-code-reviews.appspot.com/725801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add two new ClientBundle annotations: (issue714801)

2010-08-03 Thread fredsa
Thanks, Bob http://gwt-code-reviews.appspot.com/714801/diff/48001/6003 File user/src/com/google/gwt/resources/client/DataResource.java (right): http://gwt-code-reviews.appspot.com/714801/diff/48001/6003#newcode35 user/src/com/google/gwt/resources/client/DataResource.java:35: * Specifies the

[gwt-contrib] Re: Fixes various warnings in RequestFactory, most of them generics (issue737801)

2010-08-03 Thread rjrjr
http://gwt-code-reviews.appspot.com/737801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add login widgets to Expenses and the Mobile versions (issue713802)

2010-08-03 Thread unnurg
Reviewers: Ray Ryan, Description: Add login widgets to Expenses and the Mobile versions Please review this at http://gwt-code-reviews.appspot.com/713802/show Affected files: M bikeshed/src/com/google/gwt/sample/expenses/gwt/client/Expenses.java M

[gwt-contrib] Re: Put in a new fix for DevMode logging that uses bytecode rewriting rather than swapping out (issue725801)

2010-08-03 Thread Fred Sauer
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread nchalko
http://gwt-code-reviews.appspot.com/735801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right): http://gwt-code-reviews.appspot.com/735801/diff/1/2#newcode81 tools/api-checker/config/gwt20_21userApi.conf:81: :user/src/com/google/gwt/validation/client/constraints/*.java\ On

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread nchalko
http://gwt-code-reviews.appspot.com/735801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: Add default validators for the standard constraints. (issue735801)

2010-08-03 Thread nchalko
http://gwt-code-reviews.appspot.com/735801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right): http://gwt-code-reviews.appspot.com/735801/diff/1/2#newcode81 tools/api-checker/config/gwt20_21userApi.conf:81: :user/src/com/google/gwt/validation/client/constraints/*.java\ Well I