On 21 août, 20:13, Patrick Julien pjul...@gmail.com wrote:
I've been experimenting with PlaceHistoryManager and company. So far,
I have the following comments:
First, I've only read through the design-doc Wave and the code, I
haven't yet experimented with it (as I first have to migrate my
On Mon, Aug 23, 2010 at 5:16 AM, Thomas Broyer t.bro...@gmail.com wrote:
On 21 août, 20:13, Patrick Julien pjul...@gmail.com wrote:
I've been experimenting with PlaceHistoryManager and company. So far,
I have the following comments:
First, I've only read through the design-doc Wave and the
http://gwt-code-reviews.appspot.com/771801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/771801/diff/11002/15007
File
user/src/com/google/gwt/safehtml/shared/OnlyToBeUsedInGeneratedCodeStringBlessedAsSafeHtml.java
(right):
http://gwt-code-reviews.appspot.com/771801/diff/11002/15007#newcode26
http://gwt-code-reviews.appspot.com/766802/diff/1/2
File
user/src/com/google/gwt/validation/client/AbstractBeanDescriptor.java
(right):
http://gwt-code-reviews.appspot.com/766802/diff/1/2#newcode27
user/src/com/google/gwt/validation/client/AbstractBeanDescriptor.java:27:
* Abstract
http://gwt-code-reviews.appspot.com/760802/diff/6001/1029
File
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/760802/diff/6001/1029#newcode3
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:3:
!--
http://gwt-code-reviews.appspot.com/771801/diff/28002/6006
File
user/src/com/google/gwt/safehtml/shared/OnlyToBeUsedInGeneratedCodeStringBlessedAsSafeHtml.java
(right):
http://gwt-code-reviews.appspot.com/771801/diff/28002/6006#newcode32
Reviewers: cramsdale,
Description:
Removing the Expenses sample from bikeshed now that it has been
converted to a sample. I'm leaving the Scaffold app for now until I
know that its safe to delete it.
Please review this at http://gwt-code-reviews.appspot.com/791801/show
Affected files:
M
LGTM
On Mon, Aug 23, 2010 at 8:31 AM, jlaba...@google.com wrote:
Reviewers: cramsdale,
Description:
Removing the Expenses sample from bikeshed now that it has been
converted to a sample. I'm leaving the Scaffold app for now until I
know that its safe to delete it.
Please review this at
On 23 août, 14:49, Patrick Julien pjul...@gmail.com wrote:
On Mon, Aug 23, 2010 at 5:16 AM, Thomas Broyer t.bro...@gmail.com wrote:
On 21 août, 20:13, Patrick Julien pjul...@gmail.com wrote:
I've been experimenting with PlaceHistoryManager and company. So far,
I have the following
LGTM
http://gwt-code-reviews.appspot.com/791801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/789801/diff/1/2
File
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
(right):
http://gwt-code-reviews.appspot.com/789801/diff/1/2#newcode702
Revision: 8622
Author: gwt.mirror...@gmail.com
Date: Mon Aug 23 09:33:42 2010
Log: Tag 2.1.0-ms3
http://code.google.com/p/google-web-toolkit/source/detail?r=8622
Added:
/tags/2.1.0-ms3
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Mon, Aug 23, 2010 at 12:07 PM, Thomas Broyer t.bro...@gmail.com wrote:
implementation you want, even with the stock Proxy{,List}Place places.
No it's not. This is the tokens returns by RequestFactory based on
your record classes. The *Place objects that you use have no bearing
on what
committed as r8624
http://gwt-code-reviews.appspot.com/791801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8625
Author: sco...@google.com
Date: Mon Aug 23 07:33:33 2010
Log: ClientBundleWithLookup.getResource(String) now uses a HashMap in
DevMode.
This is the first of a couple of patches that will remove certain JSNI code
paths in generated code from being traversed in DevMode. This
Revision: 8626
Author: gwt.mirror...@gmail.com
Date: Mon Aug 23 11:11:04 2010
Log: svn merge https://google-web-toolkit.googlecode.com/svn/trunk
-r8599:8600 .
Plus, updated branch-info.txt with this information
http://code.google.com/p/google-web-toolkit/source/detail?r=8626
Modified:
Revision: 8627
Author: gwt.mirror...@gmail.com
Date: Mon Aug 23 11:12:23 2010
Log: Put the commit number in branch-info.txt
http://code.google.com/p/google-web-toolkit/source/detail?r=8627
Modified:
/branches/2.1M3/branch-info.txt
===
---
Reviewers: rjrjr,
Description:
This patch contains changes required for reliable editing of ui:field
attribute in template and corresponding @UiField in Java. Solved
problems:
1. When GWT Designer calls createAndBindUi(), it can not provide
owner, because we can not instantiate it, and it is
http://gwt-code-reviews.appspot.com/784801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Discussed in person with jat and scottb:
Tests are failing for this change because the ThreadLocal assumptions
don't actually hold under JUnit. As a result, I'm going to be dropping
this change in favor of more explicitly caching based on the generator
context lifecycle.
On 2010/08/20 20:46:05,
LGTM
http://gwt-code-reviews.appspot.com/784801/diff/3002/7001
File dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.js (right):
http://gwt-code-reviews.appspot.com/784801/diff/3002/7001#newcode4
dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.js:4: var
$moduleName =
Revision: 8628
Author: gwt.mirror...@gmail.com
Date: Mon Aug 23 10:16:50 2010
Log: Turn down noise level on AbstractLocalizableImplCreator from INFO to
TRACE.
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8628
Modified:
Revision: 8629
Author: gwt.mirror...@gmail.com
Date: Mon Aug 23 11:34:16 2010
Log: Cleanups on NameFactory and AbstractClientBundleGenerator.
Suggested by: bobv
Review by: bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=8629
Modified:
Bob do you think the Contacts App from
http://code.google.com/webtoolkit/articles/mvp-architecture.html#model
Is a better starting place
http://gwt-code-reviews.appspot.com/760802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat, rice, knorton, xtof,
Description:
SafeHtml Templates
The SafeHtml Templates were removed from the main SafeHtml review, but
are being added again here so that widgets can start using this api,
even while a newer parser is in the works. This is a first pass at
templates, and the
Revision: 8630
Author: amitman...@google.com
Date: Mon Aug 23 16:33:22 2010
Log: Fix for bad create requests. Get rid of the squirrely logic in
RequestFactory tracking creates.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Reviewers: amitmanjhi,
Description:
AbstractEditView now requests all the paths it needs
Review by: amitman...@google.com
Please review this at http://gwt-code-reviews.appspot.com/786802/show
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/786802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8631
Author: gwt.mirror...@gmail.com
Date: Mon Aug 23 18:21:12 2010
Log: AbstractEditView now requests all the paths it needs
Review at http://gwt-code-reviews.appspot.com/786802
Review by: amitman...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8631
Revision: 8633
Author: cromwell...@google.com
Date: Mon Aug 23 19:35:44 2010
Log: Fix infinite recursion in JsonRequestProcessor
http://code.google.com/p/google-web-toolkit/source/detail?r=8633
Modified:
/trunk/user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
Revision: 8634
Author: gwt.mirror...@gmail.com
Date: Mon Aug 23 22:48:15 2010
Log: svn merge https://google-web-toolkit.googlecode.com/svn/trunk
-r8629:8633 .
Merged r8630, 8631, 8632, 8633
http://code.google.com/p/google-web-toolkit/source/detail?r=8634
Modified:
Revision: 8635
Author: gwt.mirror...@gmail.com
Date: Mon Aug 23 22:49:44 2010
Log: Updated branch-info.txt
http://code.google.com/p/google-web-toolkit/source/detail?r=8635
Modified:
/branches/2.1M3/branch-info.txt
===
--- /branches/2.1M3/branch-info.txt
33 matches
Mail list logo
