a customer is a broad concept :-)
On Wed, Nov 17, 2010 at 10:04 PM, Stephen Haberman
stephen.haber...@gmail.com wrote:
I complained about the same subject when 2.1 was released. After 2
years of waiting very little functionality in the new table was
released. I can understand the motivation
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27004
File
user/src/com/google/gwt/uibinder/elementparsers/DateLabelParser.java
(right):
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27004#newcode36
user/src/com/google/gwt/uibinder/elementparsers/DateLabelParser.java:36:
static
LGTM
http://gwt-code-reviews.appspot.com/1098801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/11/15 19:53:51, conroy wrote:
lgtm
http://gwt-code-reviews.appspot.com/1084801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1116801/diff/1/6
File plugins/ie/installer/build.cmd (right):
http://gwt-code-reviews.appspot.com/1116801/diff/1/6#newcode8
plugins/ie/installer/build.cmd:8: echo IMPORTANT: Make sure
%~dp0oophm.wsx is checked out and writable!
Rather than just blindly
Reviewers: rjrjr,
Description:
Fix Alignment Attribute Parsing for HasAlignment
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1121801/show
Affected files:
A user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
M
http://gwt-code-reviews.appspot.com/1117801/diff/1/21
File
samples/validationtck/test/com/google/gwt/sample/validationtck/validation/ValidatePropertyTest.java
(right):
http://gwt-code-reviews.appspot.com/1117801/diff/1/21#newcode38
http://gwt-code-reviews.appspot.com/1121801/diff/1/2
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1121801/diff/1/2#newcode34
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:34:
public class
LGTM
http://gwt-code-reviews.appspot.com/1122801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9250
Author: porte...@google.com
Date: Thu Nov 18 07:58:46 2010
Log: Minor little fix in DefaultSuggestionDisplay
Review at http://gwt-code-reviews.appspot.com/1122801
Review by: jlaba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9250
Modified:
Reviewers: kathrin,
Description:
Makes part of the Compiler Report (SOYC) smaller by
replacing a flat HTML output with output
that is generated with JavaScript from a dictionary of
strings. This decreases the size of the dependency
reports by a factor of 5 and the overall report by a
factor of
http://gwt-code-reviews.appspot.com/1121801/diff/1/2
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1121801/diff/1/2#newcode34
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:34:
public class
The general direction of the patch looks great to me.
@jat, I'll be on vacation from tomorrow through Thanksgiving. Will you
be able to land this for Thomas, and get it on to the 2.1.1 branch while
I'm gone?
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27004
File
http://gwt-code-reviews.appspot.com/1121801/diff/1/2
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1121801/diff/1/2#newcode34
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:34:
public class
On Thu, Nov 18, 2010 at 2:35 PM, rj...@google.com wrote:
@jat, I'll be on vacation from tomorrow through Thanksgiving. Will you
be able to land this for Thomas, and get it on to the 2.1.1 branch while
I'm gone?
Sure.
--
John A. Tamplin
Software Engineer (GWT), Google
--
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27026
File
user/test/com/google/gwt/uibinder/elementparsers/NumberLabelParserTest.java
(right):
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27026#newcode145
http://gwt-code-reviews.appspot.com/1121801/diff/1/2
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1121801/diff/1/2#newcode34
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:34:
public class
http://gwt-code-reviews.appspot.com/1082801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: cromwellian, drfibonacci,
Description:
Expenses sample pom.xml. Fixes Issues:
5438: Expenses sample pom.xml points to outdated Roo version
5497: Expenses sample cannot find jdo2-api-2.3-ec.jar
Please review this at http://gwt-code-reviews.appspot.com/1124801/show
Affected files:
http://gwt-code-reviews.appspot.com/1121801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1124801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1124801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: pdr,
Description:
Adding CellPreviewEvents to Cell Widgets to preview all events that are
fired to Cells. This allows us to add DefaultSelectionEventManager,
which adds shift/ctrl selection support to the Cell Widgets.
Please review this at
Revision: 9251
Author: rchan...@google.com
Date: Thu Nov 18 10:24:21 2010
Log: Expenses sample pom.xml. Fixes Issues:
5438: Expenses sample pom.xml points to outdated Roo version
5497: Expenses sample cannot find jdo2-api-2.3-ec.jar
Review at http://gwt-code-reviews.appspot.com/1124801
LGTM as long as you fix the nits below and disable the failing tests in
FF.
http://gwt-code-reviews.appspot.com/1082801/diff/78001/79009
File user/src/com/google/gwt/canvas/dom/client/CssColor.java (right):
http://gwt-code-reviews.appspot.com/1082801/diff/78001/79009#newcode27
LGTM with nits.
http://gwt-code-reviews.appspot.com/1084801/diff/57001/58001
File plugins/npapi/DevModeOptions/.classpath (right):
http://gwt-code-reviews.appspot.com/1084801/diff/57001/58001#newcode3
plugins/npapi/DevModeOptions/.classpath:3: classpathentry kind=src
path=src/
Shouldn't this
On Thu, Nov 18, 2010 at 11:59 AM, sbruba...@google.com wrote:
http://gwt-code-reviews.appspot.com/1121801/diff/1/2
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1121801/diff/1/2#newcode34
http://gwt-code-reviews.appspot.com/1126801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
fabio, can you respond to the windows questions?
http://gwt-code-reviews.appspot.com/1084801/diff/57001/58001
File plugins/npapi/DevModeOptions/.classpath (right):
http://gwt-code-reviews.appspot.com/1084801/diff/57001/58001#newcode3
plugins/npapi/DevModeOptions/.classpath:3: classpathentry
Thanks for the review, will submit with ValueProxy validation strategy
previously discussed.
http://gwt-code-reviews.appspot.com/1108802/diff/1/20
File
user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
(right):
C'mon, give me a little credit; I wouldn't suggest a change without having
tested to prove that it works:) I changed HorizontalPanel to implement
HasHorizontalAlignment and HasVerticalAlignment instead of implementing
HasAlignment. The parsers generate in the correct order and the resulting
code
Revision: 9253
Author: b...@google.com
Date: Thu Nov 18 16:56:53 2010
Log: Edited wiki page RequestFactory_2_1_1 through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9253
Modified:
/wiki/RequestFactory_2_1_1.wiki
===
---
Reviewers: rchandia, rjrjr,
Message:
This should be the last big change to the RequestFactory wire format and
data-processing code for 2.1.1.
The next change will be the ServiceeLayer API cleanup to let end-users
have more control. Then expect a bugfix / cleanup patch beyond that.
http://gwt-code-reviews.appspot.com/1117801/diff/1/21
File
samples/validationtck/test/com/google/gwt/sample/validationtck/validation/ValidatePropertyTest.java
(right):
http://gwt-code-reviews.appspot.com/1117801/diff/1/21#newcode38
http://gwt-code-reviews.appspot.com/1117801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1121801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1121801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9254
Author: gwt.mirror...@gmail.com
Date: Thu Nov 18 23:14:02 2010
Log: Fixes issue
http://code.google.com/p/google-web-toolkit/issues/detail?id=5578
Restores the domain class upcasting behavior of RequestFactoryServlet,
which is relied upon by our UserInformation class.
Also
38 matches
Mail list logo
