On Fri, Jan 14, 2011 at 5:56 PM, Thomas Broyer t.bro...@gmail.com wrote:
(well, now I have 5 open issues with RequestFactory assigned to me by my
team, let's see if they're RF issues of –much more likely– issues with
either user code or my heavy use of ServiceLayerDecorator)
Feedback is the
Reviewers: pdr,
Description:
Fixing HasWidgetsTester#testAll to actually call
testDoDetachChildrenWithError. Currently, it calls
testDoAttachChildrenWithError twice. HTMLTableTestBase needs to be
modified to work with the test.
Please review this at
Reviewers: pdr,
Description:
Adding a new widget ResizeLayoutPanel that can trigger a resize event
when it changes size. The widget uses hidden scrollable divs to detect
resize on non-IE browsers. This allow users to embed widgets that
RequireResize in their app without having an unbroken chain
@jeff -
Can you upload a patch relative to trunk/ instead of trunk/user? I have
some comments, but I'm getting a 500 error when I try to publish them.
I think its because the patch isn't relative to trunk/.
http://gwt-code-reviews.appspot.com/1149803/show
--
Great work. I found a few nitpicks that should be easy to fix.
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001#newcode113
Also, can you sign a CLA so we can accept patch. If you scroll down to
the bottom of the link below, you can sign it electronically.
http://code.google.com/legal/individual-cla-v1.0.html
http://gwt-code-reviews.appspot.com/1149803/show
--
On Tuesday, January 18, 2011 3:40:23 PM UTC+1, Bob Vawter wrote:
On Fri, Jan 14, 2011 at 5:56 PM, Thomas Broyer t.br...@gmail.com wrote:
(well, now I have 5 open issues with RequestFactory assigned to me by my
team, let's see if they're RF issues of –much more likely– issues with
either
http://gwt-code-reviews.appspot.com/1296801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
It looks like you no longer have a public way to check if a canvas is
supported without trying to create one? That seems bad.
http://gwt-code-reviews.appspot.com/1296801/diff/7001/8002
File user/src/com/google/gwt/canvas/client/Canvas.java (right):
I take your point about UiBinder support. You can have your invariant and
bind it too by updating DialogBoxParser (and DialogBoxParserTest) to
optionally handle the new constructor argument.
On Tue, Jan 18, 2011 at 8:02 AM, jlaba...@google.com wrote:
Also, can you sign a CLA so we can accept
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001#newcode113
user/src/com/google/gwt/user/client/ui/DialogBox.java:113: public
interface Caption extends
Reviewers: rchandia,
Description:
Mark some test as Failing. Note these test only fail on IE.
See
http://code.google.com/p/google-web-toolkit/issues/detail?id=5882
Please review this at http://gwt-code-reviews.appspot.com/1303801/show
Affected files:
M
LGTM
On 2011/01/18 18:35:52, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1303801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Tue, Jan 18, 2011 at 10:29 AM, larse...@gmail.com wrote:
http://gwt-code-reviews.appspot.com/1149803/show
Thanks so much for reviewing this guys.
@Ray,
Do you want me to go back to allowing a setter for the caption?
I certainly wouldn't want to see both the setter and the constructor.
http://gwt-code-reviews.appspot.com/1296801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Updated this patch with a hack to ApiChecker that allows it to find the
external javax.validation source jars.
http://gwt-code-reviews.appspot.com/1260801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm
http://gwt-code-reviews.appspot.com/1260801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1296801/diff/13001/14002
File user/src/com/google/gwt/canvas/client/Canvas.java (right):
http://gwt-code-reviews.appspot.com/1296801/diff/13001/14002#newcode45
user/src/com/google/gwt/canvas/client/Canvas.java:45:
CanvasElementSupportDetector detector =
Reviewers: knorton,
Description:
Removes a Java 1.6-ism.
Please review this at http://gwt-code-reviews.appspot.com/1304801/show
Affected files:
M user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java
Index:
lgtm. thanks.
http://gwt-code-reviews.appspot.com/1304801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Good catch Thomas, didn't see the a.. but yeah, it isn't very clear.
--
Arthur Kalmenson
On Fri, Jan 14, 2011 at 3:42 AM, Thomas Broyer t.bro...@gmail.com wrote:
I guess that's why it says *a* BasicPlace rather than just BasicPlace.
Yes, it's up to you to define such a class. David Chandler
Mostly LGTM.
http://gwt-code-reviews.appspot.com/1273801/diff/1/6
File
user/src/com/google/gwt/user/client/rpc/core/java/lang/Double_CustomFieldSerializer.java
(right):
http://gwt-code-reviews.appspot.com/1273801/diff/1/6#newcode45
I'll hopefully have a chance to poke around at that code tonight and make a
decision then as to what I have time to implement.
On Tue, Jan 18, 2011 at 12:41 PM, Ray Ryan rj...@google.com wrote:
On Tue, Jan 18, 2011 at 10:29 AM, larse...@gmail.com wrote:
Revision: 9562
Author: b...@google.com
Date: Tue Jan 18 08:32:58 2011
Log: Add support for mapping ConstraintViolation objects into
SimpleBeanEditor.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/1260801
http://gwt-code-reviews.appspot.com/1296801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1296801/diff/7001/8002
File user/src/com/google/gwt/canvas/client/Canvas.java (right):
http://gwt-code-reviews.appspot.com/1296801/diff/7001/8002#newcode42
user/src/com/google/gwt/canvas/client/Canvas.java:42: public static
Canvas createCanvasIfSupported() {
Submitted as of r9563
On 2011/01/18 19:23:21, knorton wrote:
lgtm. thanks.
http://gwt-code-reviews.appspot.com/1304801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9563
Author: gwt.mirror...@gmail.com
Date: Tue Jan 18 08:45:31 2011
Log: Removes a Java 1.6-ism.
Review at http://gwt-code-reviews.appspot.com/1304801
Review by: knor...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9563
Modified:
Reviewers: scottb,
Description:
Make production mode stack traces match JRE spec more closely
- Fix StackTraceElement#getFileName(), so that it returns null instead
of Unknown Source
- Fix StackTraceElement#getLineNumber(), so that it returns -1 instead
of 0
- Fix StackTraceElement#toString(),
Revision: 9564
Author: ncha...@google.com
Date: Tue Jan 18 08:56:33 2011
Log: Mark some test as Failing. Note these test only fail on IE.
See
http://code.google.com/p/google-web-toolkit/issues/detail?id=5882
Review at http://gwt-code-reviews.appspot.com/1303801
Review by: rchan...@google.com
http://gwt-code-reviews.appspot.com/1294801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM with nits.
http://gwt-code-reviews.appspot.com/1296801/diff/21001/22002
File user/src/com/google/gwt/canvas/client/Canvas.java (right):
http://gwt-code-reviews.appspot.com/1296801/diff/21001/22002#newcode61
user/src/com/google/gwt/canvas/client/Canvas.java:61: public static
final boolean
http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002
File user/test/com/google/gwt/dom/client/FrameTests.java (right):
http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002#newcode49
user/test/com/google/gwt/dom/client/FrameTests.java:49: final Timer
timer = new Timer() {
On
LGTM
http://gwt-code-reviews.appspot.com/1294801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1296801/diff/21001/22004
File user/src/com/google/gwt/user/client/IsSupported.java (left):
http://gwt-code-reviews.appspot.com/1296801/diff/21001/22004#oldcode32
user/src/com/google/gwt/user/client/IsSupported.java:32: public
interface IsSupported {
Is this
Revision: 9565
Author: r...@google.com
Date: Tue Jan 18 10:26:55 2011
Log: Optimize redundant 'switch' statements
Review at http://gwt-code-reviews.appspot.com/1286801
Review by: sco...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9565
Added:
I'm curious, has there been any measurement/data as to the effect this
has on output size?
On Mon, Jan 17, 2011 at 1:18 PM, sco...@google.com wrote:
LGTM, just nits. No need to re-review.
http://gwt-code-reviews.appspot.com/1286801/diff/5002/6002
File
On Tue, Jan 18, 2011 at 11:53 AM, p...@google.com wrote:
http://gwt-code-reviews.appspot.com/1296801/diff/7001/8002
File user/src/com/google/gwt/canvas/client/Canvas.java (right):
http://gwt-code-reviews.appspot.com/1296801/diff/7001/8002#newcode42
I saw 4.5% on the uncompressed size.
Dan
On Tue, Jan 18, 2011 at 4:39 PM, Ray Cromwell cromwell...@google.com wrote:
I'm curious, has there been any measurement/data as to the effect this
has on output size?
On Mon, Jan 17, 2011 at 1:18 PM, sco...@google.com wrote:
LGTM, just nits. No
http://gwt-code-reviews.appspot.com/1296801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1296801/diff/21001/22002
File user/src/com/google/gwt/canvas/client/Canvas.java (right):
http://gwt-code-reviews.appspot.com/1296801/diff/21001/22002#newcode61
user/src/com/google/gwt/canvas/client/Canvas.java:61: public static
final boolean isSupported() {
Reviewers: rjrjr,
Description:
Implement an isDirty() method for Editor framework drivers.
Issue 5881.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1306801/show
Affected files:
M user/src/com/google/gwt/editor/client/EditorDelegate.java
M
LGTM
http://gwt-code-reviews.appspot.com/1296801/diff/28001/29002
File user/src/com/google/gwt/canvas/client/Canvas.java (right):
http://gwt-code-reviews.appspot.com/1296801/diff/28001/29002#newcode64
user/src/com/google/gwt/canvas/client/Canvas.java:64:
CanvasElementSupportDetector.class);
Reviewers: rchandia,
Description:
Implement spec section 2.2. Applying multiple constraints of the same
type.
[JSR 303 TCK Result] 63 of 257 (24.51%) Pass with 26 Failures and 5
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1288802/show
Affected files:
M
LGTM w/ nit.
http://gwt-code-reviews.appspot.com/1295802/diff/1/3
File user/super/com/google/gwt/emul/java/lang/StackTraceElement.java
(right):
http://gwt-code-reviews.appspot.com/1295802/diff/1/3#newcode65
user/super/com/google/gwt/emul/java/lang/StackTraceElement.java:65: +
(lineNumber 0 ?
Revision: 9566
Author: j...@google.com
Date: Tue Jan 18 20:55:47 2011
Log: Fix MIME type and EOL style on javadocs.
http://code.google.com/p/google-web-toolkit/source/detail?r=9566
Modified:
/javadoc/2.1/com/google/gwt/autobean/server/AutoBeanFactoryMagic.html
http://gwt-code-reviews.appspot.com/1288802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
47 matches
Mail list logo
