[gwt-contrib] [google-web-toolkit] r9815 committed - Adding jernhen...@gmail.com to CLA Signers. CLA signed and on file.

2011-03-07 Thread codesite-noreply
Revision: 9815 Author: jlaba...@google.com Date: Mon Mar 7 07:03:40 2011 Log: Adding jernhen...@gmail.com to CLA Signers. CLA signed and on file. http://code.google.com/p/google-web-toolkit/source/detail?r=9815 Modified: /CLA-SIGNERS === --- /CLA-SIGNERS

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-07 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9816 committed - Correct broken javadoc

2011-03-07 Thread codesite-noreply
Revision: 9816 Author: tomer...@google.com Date: Mon Mar 7 04:00:14 2011 Log: Correct broken javadoc http://code.google.com/p/google-web-toolkit/source/detail?r=9816 Modified: /trunk/user/src/com/google/gwt/i18n/shared/HasDirectionEstimator.java

[gwt-contrib] [google-web-toolkit] r9817 committed - Add bidi support comments to CheckBox and RadioButton

2011-03-07 Thread codesite-noreply
Revision: 9817 Author: tomer...@google.com Date: Mon Mar 7 04:00:58 2011 Log: Add bidi support comments to CheckBox and RadioButton http://code.google.com/p/google-web-toolkit/source/detail?r=9817 Modified: /trunk/user/src/com/google/gwt/user/client/ui/CheckBox.java

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-07 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java File user/src/com/google/gwt/storage/client/Storage.java (right): http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java#newcode107

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-07 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: HTML5 Storage API in GWT. (issue1374803)

2011-03-07 Thread pdr
http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java File user/src/com/google/gwt/storage/client/Storage.java (right): http://gwt-code-reviews.appspot.com/1374803/diff/7004/user/src/com/google/gwt/storage/client/Storage.java#newcode107

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

2011-03-07 Thread rchandia
http://gwt-code-reviews.appspot.com/1371808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

2011-03-07 Thread rchandia
http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java File user/src/com/google/gwt/user/tools/WebAppCreator.java (right): http://gwt-code-reviews.appspot.com/1371808/diff/1/user/src/com/google/gwt/user/tools/WebAppCreator.java#newcode154

[gwt-contrib] Re: Fixing ActionCell and ButtonCell clicks outside of the Button element are ignored. (issue1371810)

2011-03-07 Thread jlabanca
adapted from http://gwt-code-reviews.appspot.com/1183801/show http://gwt-code-reviews.appspot.com/1371810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

2011-03-07 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1371808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fixing ActionCell and ButtonCell clicks outside of the Button element are ignored. (issue1371810)

2011-03-07 Thread jlabanca
Reviewers: pdr, Description: Fixing ActionCell and ButtonCell clicks outside of the Button element are ignored. Issue: 5641 Author: hekke, jlabanca Please review this at http://gwt-code-reviews.appspot.com/1371810/ Affected files: M user/src/com/google/gwt/cell/client/ActionCell.java M

[gwt-contrib] Re: SafeHtml Rendering for UiBinder (issue1305801)

2011-03-07 Thread rjrjr
http://gwt-code-reviews.appspot.com/1305801/diff/48001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right):

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

2011-03-07 Thread zundel
http://gwt-code-reviews.appspot.com/1371808/diff/1003/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/client/_moduleShortName_.javasrc File user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/client/_moduleShortName_.javasrc (right):

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

2011-03-07 Thread rchandia
http://gwt-code-reviews.appspot.com/1371808/diff/1003/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/client/_moduleShortName_.javasrc File user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/client/_moduleShortName_.javasrc (right):

[gwt-contrib] Re: SafeHtml Rendering for UiBinder (issue1305801)

2011-03-07 Thread rjrjr
LGTM!! http://gwt-code-reviews.appspot.com/1305801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: WebAppCreator now has the ability to create apps from templates. (issue1371808)

2011-03-07 Thread rchandia
Submitted as of r9819 http://gwt-code-reviews.appspot.com/1371808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: CompileModule / GwtAstBuilder (issue1373805)

2011-03-07 Thread zundel
http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode2

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

2011-03-07 Thread zundel
http://gwt-code-reviews.appspot.com/1375802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

2011-03-07 Thread zundel
updated patch http://gwt-code-reviews.appspot.com/1375802/diff/1/dev/core/src/com/google/gwt/dev/DevModeBase.java File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/1375802/diff/1/dev/core/src/com/google/gwt/dev/DevModeBase.java#newcode1042

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

2011-03-07 Thread scottb
I'm looking at PUC itself now, but I wanted to go ahead and get out some quick comments on everything else. High-level: - My gut reaction is that it's odd to make it a command-line option. It's not really a user-facing 'option' in the same way that draftCompile or style=PRETTY is, it's just an

[gwt-contrib] [google-web-toolkit] r9820 committed - Records names of JSNI calls and callbacks in SpeedTracer events....

2011-03-07 Thread codesite-noreply
Revision: 9820 Author: to...@google.com Date: Mon Mar 7 09:15:21 2011 Log: Records names of JSNI calls and callbacks in SpeedTracer events. Review at http://gwt-code-reviews.appspot.com/1356806 http://code.google.com/p/google-web-toolkit/source/detail?r=9820 Modified:

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

2011-03-07 Thread scottb
Reading the code, I think what I'm missing is some kind of theory of operation. I don't have a good mental model of the life cycle of individual files as they relate to GWT processes, refreshes, builds, etc. I can't easily answer questions like: - Does PUC use a different cache file each

[gwt-contrib] Re: Switching to the junit4 jars, although the @annotation stuff isn't (issue1374801)

2011-03-07 Thread fabbott
http://gwt-code-reviews.appspot.com/1374801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Removing junit from testng in svn/tools (issue1377801)

2011-03-07 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1377801/diff/1/lib/testng/README File lib/testng/README (right): http://gwt-code-reviews.appspot.com/1377801/diff/1/lib/testng/README#newcode2 lib/testng/README:2: its jar. Since we now run with junit4, even thoguh we aren't yet using though

[gwt-contrib] Re: CompileModule / GwtAstBuilder (issue1373805)

2011-03-07 Thread scottb
http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1373805/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode2

[gwt-contrib] Re: Switching to the junit4 jars, although the @annotation stuff isn't (issue1374801)

2011-03-07 Thread jat
LGTM Why do some of our .classpath entries reference the JUnit jar directly, and others reference the Eclipse library JUNIT_CONTAINER? It seems likely that you need to update the latter ones to 4 rather than 3, or change them to specifically reference the jar.

[gwt-contrib] [google-web-toolkit] r9821 committed - Added note to Javadoc about running in Eclipse....

2011-03-07 Thread codesite-noreply
Revision: 9821 Author: drfibona...@google.com Date: Mon Mar 7 10:21:02 2011 Log: Added note to Javadoc about running in Eclipse. Review at http://gwt-code-reviews.appspot.com/1371807/ Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9821 Modified:

[gwt-contrib] [google-web-toolkit] r9822 committed - Format changes only. Applied new auto-formatter in prep for real chang...

2011-03-07 Thread codesite-noreply
Revision: 9822 Author: drfibona...@google.com Date: Mon Mar 7 10:48:21 2011 Log: Format changes only. Applied new auto-formatter in prep for real changes. Review at http://gwt-code-reviews.appspot.com/1370807 Review by: rj...@google.com

[gwt-contrib] Re: Phase 1 of I18n Rewrite - support extended plurals/etc for export to property/etc files (issue1355802)

2011-03-07 Thread jat
http://gwt-code-reviews.appspot.com/1355802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Phase 1 of I18n Rewrite - support extended plurals/etc for export to property/etc files (issue1355802)

2011-03-07 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1355802/diff/15004/user/src/com/google/gwt/i18n/server/AbstractMessage.java File user/src/com/google/gwt/i18n/server/AbstractMessage.java (right):

[gwt-contrib] Re: Comment on AutoBean in google-web-toolkit

2011-03-07 Thread codesite-noreply
Comment by ali.sak...@gmail.com: _Boilerplate, yes boilerplate_ What are those interfaces, factories and categories if not boilerplate?! Have ever looked at Gson?! For more information: http://code.google.com/p/google-web-toolkit/wiki/AutoBean --

[gwt-contrib] Re: Comment on AutoBean in google-web-toolkit

2011-03-07 Thread codesite-noreply
Comment by ali.sak...@gmail.com: _Boilerplate, yes boilerplate_ What are those interfaces, factories and categories if not boilerplate?! Have you ever looked at Gson?! For more information: http://code.google.com/p/google-web-toolkit/wiki/AutoBean --

[gwt-contrib] Re: Adds a cache (PersistenUnitCache) to store CompilationUnits (issue1375802)

2011-03-07 Thread tobyr
http://gwt-code-reviews.appspot.com/1375802/diff/5002/dev/core/src/com/google/gwt/dev/DevMode.java File dev/core/src/com/google/gwt/dev/DevMode.java (right): http://gwt-code-reviews.appspot.com/1375802/diff/5002/dev/core/src/com/google/gwt/dev/DevMode.java#newcode417