[gwt-contrib] [google-web-toolkit] r10173 committed - Multiple improvements and fixes to the mobile web app. Tasks are now ...

Revision: 10173 Author: jlaba...@google.com Date: Tue May 10 20:04:34 2011 Log: Multiple improvements and fixes to the mobile web app. Tasks are now stored in local storage using the TaskProxyLocalStorage class, which is also used when refreshing a task offline in the

[gwt-contrib] [google-web-toolkit] r10174 committed - Adding favicon and app_icon to the app cache manifest file.

Revision: 10174 Author: jlaba...@google.com Date: Tue May 10 20:32:44 2011 Log: Adding favicon and app_icon to the app cache manifest file. http://code.google.com/p/google-web-toolkit/source/detail?r=10174 Modified:

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. (issue1427810)

http://gwt-code-reviews.appspot.com/1427810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10175 committed - Adding additional testing for GWT RPC. Some custom serialized objects...

Revision: 10175 Author: gwt.mirror...@gmail.com Date: Wed May 11 08:32:59 2011 Log: Adding additional testing for GWT RPC. Some custom serialized objects were previously untested, at least explicitly. Testing put in place now provides coverage to test future changes. Review at

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/05/09 21:06:01, zhuyi wrote: On 2011/04/18 18:56:30, Stephen Chenney wrote: http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java

[gwt-contrib] SafeHtmlRenderer code gen for UiBinder. (issue1442803)

Reviewers: rjrjr, Description: SafeHtmlRenderer code gen for UiBinder. Picking-up patch from rietveld issue 1426803. Please review this at http://gwt-code-reviews.appspot.com/1442803/ Affected files: M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml M

[gwt-contrib] SafeHtmlRenderer code gen for UiBinder. (issue1447801)

Reviewers: rjrjr, Description: SafeHtmlRenderer code gen for UiBinder. Picking-up patch from rietveld issue 1426803. Please review this at http://gwt-code-reviews.appspot.com/1447801/ Affected files: M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml M

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. (issue1442803)

Please ignore, sorry for the noise. It seems that I can now send rietveld issues OK, but updates to the issue do not produce separate patch sets. On 2011/05/11 15:57:34, rchandia wrote: http://gwt-code-reviews.appspot.com/1442803/ --

[gwt-contrib] Re: Minor refactoring of dashboard interfaces in GWT. I'd made these changes this week in another ... (issue1439801)

Nice. LGTM http://gwt-code-reviews.appspot.com/1439801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] SafeHtmlRenderer code gen for UiBinder. Picking up from Issue 1426803. (issue1447802)

Reviewers: rodrigo.chandia_gmail.com, Description: SafeHtmlRenderer code gen for UiBinder. Picking up from Issue 1426803. Please review this at http://gwt-code-reviews.appspot.com/1447802/ Affected files: M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml M

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. Picking up from Issue 1426803. (issue1447802)

http://gwt-code-reviews.appspot.com/1447802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. Picking up from Issue 1426803. (issue1447802)

http://gwt-code-reviews.appspot.com/1447802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] SafeHtmlRenderer code gen for UiBinder. Picking up issue 1426803 (issue1442804)

Reviewers: rjrjr, Description: SafeHtmlRenderer code gen for UiBinder. Picking up issue 1426803 Please review this at http://gwt-code-reviews.appspot.com/1442804/ Affected files: M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml M

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder. Picking up issue 1426803 (issue1442804)

http://gwt-code-reviews.appspot.com/1442804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder (issue1426803)

PTAL. Changes posted in http://gwt-code-reviews.appspot.com/1442804 http://gwt-code-reviews.appspot.com/1426803/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java File user/src/com/google/gwt/uibinder/rebind/FieldWriter.java (right):

[gwt-contrib] Removing the recently added RPC test for LogRecord, as it seems to (issue1447803)

Reviewers: unnurg, Description: Removing the recently added RPC test for LogRecord, as it seems to cause more problems than it is worth. Please review this at http://gwt-code-reviews.appspot.com/1447803/ Affected files: M user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java Index:

[gwt-contrib] Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

Reviewers: scottb, tobyr, jbrosenberg, Description: Rescues cached entries from jar files that are the same, save for the timestamp. Also updates the key value used for the cache to include the prefix for RerootedResource instances. Please review this at

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

Crap, the reformatter went nuts, I'll post when its ready. http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Auto format pass of some files before review (issue1444802)

Reviewers: scottb, tobyr, jbrosenberg, Description: Auto format pass of some files before review Please review this at http://gwt-code-reviews.appspot.com/1444802/ Affected files: M dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java M

[gwt-contrib] Re: Auto format pass of some files before review (issue1444802)

I ran the eclipse autoformatter and edited one comment that got trashed. http://gwt-code-reviews.appspot.com/1444802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Auto format pass of some files before review (issue1444802)

On 2011/05/11 20:20:07, zundel wrote: I ran the eclipse autoformatter and edited one comment that got trashed. FYI, I went ahead and committed this change. http://gwt-code-reviews.appspot.com/1444802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

Patch with just reformatting is up at http://gwt-code-reviews.appspot.com/1444802/ http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

And yes, this patch is now ready for review. http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Auto format pass of some files before review (issue1444802)

On 2011/05/11 20:54:26, zundel wrote: On 2011/05/11 20:20:07, zundel wrote: I ran the eclipse autoformatter and edited one comment that got trashed. FYI, I went ahead and committed this change. LGTM http://gwt-code-reviews.appspot.com/1444802/ --

[gwt-contrib] GWT 2.4beta

Hi All, What is new in GWT 2.4beta. The wiki of GWT is not working :(. Regards, Allahbaksh -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

Mostly LGTM w/ comments. http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

http://gwt-code-reviews.appspot.com/1441803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):

[gwt-contrib] [google-web-toolkit] r10176 committed - Minor refactoring of dashboard interfaces in GWT. I'd made these cha...

Revision: 10176 Author: jhumphr...@google.com Date: Wed May 11 07:35:17 2011 Log: Minor refactoring of dashboard interfaces in GWT. I'd made these changes this week in another branch (while initial changes were still in review) to make the implementation and some of its tests

[gwt-contrib] [google-web-toolkit] r10177 committed - Auto format pass of some files before review...

Revision: 10177 Author: zun...@google.com Date: Wed May 11 10:50:46 2011 Log: Auto format pass of some files before review Review at http://gwt-code-reviews.appspot.com/1444802 http://code.google.com/p/google-web-toolkit/source/detail?r=10177 Modified:

[gwt-contrib] [google-web-toolkit] r10178 committed - Rolling back submission due to test flakiness.

Revision: 10178 Author: schen...@google.com Date: Wed May 11 11:14:46 2011 Log: Rolling back submission due to test flakiness. http://code.google.com/p/google-web-toolkit/source/detail?r=10178 Deleted: /trunk/user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):

[gwt-contrib] Misc gwtc cleanups (issue1446802)

Reviewers: zundel, jbrosenberg, Message: Just a few things I ran into doing some other work. http://gwt-code-reviews.appspot.com/1446802/diff/1/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java File dev/core/src/com/google/gwt/core/ext/linker/impl/StandardSymbolData.java

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

Mostly LG. http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

http://gwt-code-reviews.appspot.com/1441803/diff/4003/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java (right):

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

On Wed, May 11, 2011 at 10:57 PM, zun...@google.com wrote: this needs to return a copy. all other implementations of asCachedCompilationUnit() already return a copy. That would make CachedCompilationUnit.writeReplace() be weird tho, right? --

[gwt-contrib] Re: Rescues cached entries from jar files that are the same, save for the timestamp. (issue1441803)

http://gwt-code-reviews.appspot.com/1441803/diff/4001/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):