[gwt-contrib] Re: Remove duplicate loop over cached units. (issue1463802)

2011-08-15 Thread zundel
http://gwt-code-reviews.appspot.com/1463802/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (left):

[gwt-contrib] ClientBundle compilation performance

2011-08-15 Thread Paul Robinson
Hi, I recently introduced an ImageBundle to my code with 1000 images. Everything worked ok, but I then converted it to a ClientBundle and found a couple of problems: (1) It seems that ClientBundle holds files open during the compilation where ImageBundle does not. I had to dramatically

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread zundel
Please add acleung as a reviewer On 2011/08/05 21:19:37, stephenh wrote: http://gwt-code-reviews.appspot.com/1513803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java File dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java (left):

[gwt-contrib] [google-web-toolkit] r10524 committed - Edited wiki page RequestFactory_2_4 through web user interface.

2011-08-15 Thread codesite-noreply
Revision: 10524 Author: bobv%google@gtempaccount.com Date: Mon Aug 15 07:40:18 2011 Log: Edited wiki page RequestFactory_2_4 through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=10524 Modified: /wiki/RequestFactory_2_4.wiki

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread cromwellian
http://gwt-code-reviews.appspot.com/1513803/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java File dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java (right):

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread stephen . haberman
Did you try this against trunk or GWT 2.3/2.4? I made some changes recently to the way liveness of class literals are calculated that may or may not have an effect relative to this. If you mean the Roll seed-function optimization forward again commit [1] (or others before it), yeah, I was

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread stephen . haberman
On 2011/08/15 13:53:06, zundel wrote: Please add acleung as a reviewer Done. (The edit issue form didn't recognize just acleung, so I added acleung@google.com. Hope that's okay.) http://gwt-code-reviews.appspot.com/1513803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Remove duplicate loop over cached units. (issue1463802)

2011-08-15 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1463802/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (left):

[gwt-contrib] Re: scheglov pointed out a leak in compilation units in dev mode after a refresh (issue1490801)

2011-08-15 Thread zundel
http://gwt-code-reviews.appspot.com/1490801/diff/5002/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java (right):

[gwt-contrib] Re: Misc TypeOracle cleanup (issue1505805)

2011-08-15 Thread zundel
http://gwt-code-reviews.appspot.com/1505805/diff/1/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeParser.java File dev/core/src/com/google/gwt/dev/javac/typemodel/TypeParser.java (right):

Re: [gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread Ray Cromwell
On Mon, Aug 15, 2011 at 9:58 AM, stephen.haber...@gmail.com wrote: If you mean the Roll seed-function optimization forward again commit [1] (or others before it), yeah, I was hoping that would fix it, but it did not. It surprises me that CFA doesn't take care of this and that it needs to be

[gwt-contrib] Re: Misc TypeOracle cleanup (issue1505805)

2011-08-15 Thread stephen . haberman
public class TypeParser { Are you intending to turn this into an API? My inclination is to make the class package protected. Oh, no, no plans for an API, just the default that I didn't catch. I agree, package protected is preferable. http://gwt-code-reviews.appspot.com/1505805/ --

[gwt-contrib] Re: Pretty massive refactoring of FieldManager and HtmlTemplates to make (issue1522803)

2011-08-15 Thread rjrjr
http://gwt-code-reviews.appspot.com/1522803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Pretty massive refactoring of FieldManager and HtmlTemplates to make (issue1522803)

2011-08-15 Thread rjrjr
I still need to add a test for IsRenderable, but I think this patch is ready for review. http://gwt-code-reviews.appspot.com/1522803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixup class literals across fragments (issue1513803)

2011-08-15 Thread stephen . haberman
The thing is, if B is a subtype of A, and B is rescued, then A is also rescued. Yeah, the rub is that B did not get rescued into FragmentB, it just ended up there because it was in the set of FragmentA+FragmentB, but not FragmentA or FragmentB individually, in which case it ends up in

[gwt-contrib] Re: Adding some extra capabilities to CountingEventBus so that we can reduce the boilerplate involve... (issue1526803)

2011-08-15 Thread skybrian
http://gwt-code-reviews.appspot.com/1526803/diff/1/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java File user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java (right):

[gwt-contrib] Re: Fixes problem with datanucleus enhancement and Appengine deployment (issue1521803)

2011-08-15 Thread rchandia
http://gwt-code-reviews.appspot.com/1521803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes problem with datanucleus enhancement and Appengine deployment (issue1521803)

2011-08-15 Thread rchandia
http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml (right): http://gwt-code-reviews.appspot.com/1521803/diff/1/samples/mobilewebapp/pom.xml#newcode34 samples/mobilewebapp/pom.xml:34: idJBoss Repo/id On 2011/08/12 22:38:29, rjrjr

[gwt-contrib] [google-web-toolkit] r10525 committed - Add missing gecko 5 libs for Linux--they were dropped from the origina...

2011-08-15 Thread codesite-noreply
Revision: 10525 Author: gwt.mirror...@gmail.com Date: Mon Aug 15 16:11:24 2011 Log: Add missing gecko 5 libs for Linux--they were dropped from the original commit due to size http://code.google.com/p/google-web-toolkit/source/detail?r=10525 Added:

[gwt-contrib] [google-web-toolkit] r10526 committed - Add missing gecko 5 libs for Linux64--they were dropped from the origi...

2011-08-15 Thread codesite-noreply
Revision: 10526 Author: gwt.mirror...@gmail.com Date: Mon Aug 15 16:12:14 2011 Log: Add missing gecko 5 libs for Linux64--they were dropped from the original commit due to size http://code.google.com/p/google-web-toolkit/source/detail?r=10526 Added:

[gwt-contrib] Re: Adding a new CellTableHeaderBuilder API, which allows custom headers and footers in CellTable. C... (issue1499808)

2011-08-15 Thread skybrian
http://gwt-code-reviews.appspot.com/1499808/diff/14004/samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java File samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCustomDataGrid.java (right):