Re: [gwt-contrib] Work to do for bug 3042

2013-06-11 Thread Adolfo Panizo Touzon
Thanks James! But I have done those steps yet (*indeed I read in that link I should ask here first :D*) . When I said the necessary work I meant the steps for develop the RichTextArea according to the GWT steering committee (for this issue I think Daniel is responsible) so I need to wait for his

Re: [gwt-contrib] Work to do for bug 3042

2013-06-11 Thread Daniel Kurka
Hi Adolfo, this is not my issue and I am not solely responsible for it. We should see wait and see if anybody opposes to adding this to GWT, before you actually start working on it, so that your time will not be wasted. On the other hand you can already setup your IDE and tools to be able to

[gwt-contrib] Issue 8083, needs some input from GWT team

2013-06-11 Thread stuckagain
Hi, I am working on a fix for this issue: https://code.google.com/p/google-web-toolkit/issues/detail?id=8083 I am avoiding converting from string to the internal format of BigInteger because it has a big performance impact on IE8 when sending it over RPC. It performs much better in IE9 and

[gwt-contrib] Re: Issue 8083, needs some input from GWT team

2013-06-11 Thread Thomas Broyer
On Tuesday, June 11, 2013 10:56:13 AM UTC+2, stuckagain wrote: Hi, I am working on a fix for this issue: https://code.google.com/p/google-web-toolkit/issues/detail?id=8083 I am avoiding converting from string to the internal format of BigInteger because it has a big performance impact

[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events

2013-06-11 Thread Leif Åstrand
Leif Åstrand has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: (3 comments) Commit

[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events

2013-06-11 Thread Leif Åstrand
Leif Åstrand has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: (1 comment) File

Re: [gwt-contrib] Work to do for bug 3042

2013-06-11 Thread Adolfo Panizo Touzon
Oh! Sorry I saw you were the owner and I thought you had plenty of responsability. Thanks, but everything is fine, the installation process is quite simple/clear, so, all is up and running. :D. Keep an eye into the Issue 1127https://code.google.com/p/google-web-toolkit/issues/detail?id=1127

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-06-11 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Either way should be fine. We could have a visitor pass after all

[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...

2013-06-11 Thread John Stalcup
John Stalcup has submitted this change and it was merged. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. The job of defineSeed

[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...

2013-06-11 Thread John Stalcup
Hello Roberto Lublinerman, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3320 to look at the new patch set (#2). Change subject: fixes a compiler crash when parsing illegal runAsync definitions

[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...

2013-06-11 Thread John Stalcup
John Stalcup has posted comments on this change. Change subject: fixes a compiler crash when parsing illegal runAsync definitions .. Patch Set 2: tests were passing, but not with enable assertions. added an immediate

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-06-11 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Regarding git procedure, I've already rolled back on google/pu and we

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

2013-06-11 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Oops, that wasn't very clear. Let me try again: If think you're going to

Re: [gwt-contrib] Re: code review policy

2013-06-11 Thread Bhaskar Janakiraman
It would be good to formalize the process, and appoint 'maintainers' for different parts of GWT, who should be people who are knowledgeable, have key contributions, and are willing to take on that role. The advantages of doing this are: 1. Avoid bike-shedding. 2. Build up specialized knowledge,

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-06-11 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Add hasClassName method in com.google.gwt.dom.client.Element Fixes issue 7550

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-06-11 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 6: What I was saying is that your overridden getElement will return GxtElement as

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-11 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Emulate java.util.Objects .. Emulate java.util.Objects Fixes issue 8173 Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 --- M

[gwt-contrib] Change in gwt[master]: Use correct return types for createFooInputBuilder() methods...

2013-06-11 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Use correct return types for createFooInputBuilder() methods in HtmlBuilderFactory. Also adjust the return types of affected methods in HtmlBuilderImpl. ..

[gwt-contrib] Change in gwt[master]: Wrong JavaDoc for MouseWheelEvent.getDeltaY()

2013-06-11 Thread Thomas Broyer
Thomas Broyer has submitted this change and it was merged. Change subject: Wrong JavaDoc for MouseWheelEvent.getDeltaY() .. Wrong JavaDoc for MouseWheelEvent.getDeltaY() Fixes issue 6400 Change-Id:

[gwt-contrib] Change in gwt[master]: Add show relative to Element in PopupPanel

2013-06-11 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Add show relative to Element in PopupPanel .. Patch Set 1: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3340 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...

2013-06-11 Thread Roberto Lublinerman
Roberto Lublinerman has posted comments on this change. Change subject: fixes a compiler crash when parsing illegal runAsync definitions .. Patch Set 2: Code-Review+2 -- To view, visit

[gwt-contrib] Change in gwt[master]: fixes a compiler crash when parsing illegal runAsync definit...

2013-06-11 Thread John Stalcup
John Stalcup has submitted this change and it was merged. Change subject: fixes a compiler crash when parsing illegal runAsync definitions .. fixes a compiler crash when parsing illegal runAsync definitions Change-Id: