[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-03 Thread Uwe Maurer
I submitted this patch: http://code.google.com/p/google-web-toolkit-incubator/source/detail?r=1553 Uwe On Mar 2, 3:14 pm, Emily Crutcher e...@google.com wrote: LGTM On Mon, Mar 2, 2009 at 7:49 AM, Uwe Maurer uwe.mau...@google.com wrote: Hi, I moved the SliderBar

[gwt-contrib] Re: Code Review: ValueSpinner, inject style only once

2009-03-03 Thread Uwe Maurer
else? Daniel On 2 Mrz., 14:35, Uwe Maurer uwe.mau...@google.com wrote: Hi, I noticed that the ValueSpinner has code in the constructor which injects the style (default or user provided). This means it gets injected everytime a ValueSpinner is created. This patch changes this so

[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-02 Thread Uwe Maurer
Hi Emily, thanks for code review. On Fri, Feb 27, 2009 at 5:13 PM, Emily Crutcher e...@google.com wrote: The changes look great. Thank you for doing this. Any chance you could you create a gen2 version of SliderBar and deprecate the widgetideas version instead on modifying the widgetideas

[gwt-contrib] Re: Code Review: Updated SliderBar to use the new event handling

2009-03-02 Thread Uwe Maurer
into a gen2 package instead. In this case, as the slider is a way to pick a value from a range, it would go into the gen2.picker.client package. Cheers, Emily On Fri, Feb 27, 2009 at 10:32 AM, Uwe Maurer uwe.mau...@google.com wrote: Hi, I added methods to use the new

[gwt-contrib] Code Review: ValueSpinner, inject style only once

2009-03-02 Thread Uwe Maurer
Hi, I noticed that the ValueSpinner has code in the constructor which injects the style (default or user provided). This means it gets injected everytime a ValueSpinner is created. This patch changes this so that the default style only gets injected once. Also it changes from KeyboardListener

[gwt-contrib] Compiling demos in incubator

2009-02-27 Thread Uwe Maurer
Hi, I am trying to compile the demos which are included in incubator. I tried ant build.demos but this only builds the demos which are in src-demo/, not the ones in src/com/google/gwt/demos How can I compile them ? Thanks, Uwe --~--~-~--~~~---~--~~

[gwt-contrib] Re: Compiling demos in incubator

2009-02-27 Thread Uwe Maurer
=**/GlassPanelDemo.gwt.xml Note that many of the src/com/google/gwt/demos modules are obsolete and at least one (CurrencyWidgetDemo) no longer compiles. - Isaac On Fri, Feb 27, 2009 at 8:35 AM, Uwe Maurer uwe.mau...@google.com wrote: Hi, I am trying to compile the demos which are included in incubator. I

[gwt-contrib] Code Review: Updated SliderBar to use the new event handling

2009-02-27 Thread Uwe Maurer
Hi, I added methods to use the new event handling to the Slider Bar. Also I changed to order of the two public interfaces to make CheckStyle happy. Thanks, Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] A wee code review: Fix bug with date in DataTable

2008-11-11 Thread uwe . maurer
Reviewers: zundel, dglibicki, Description: Fix bug with date in DataTable private native void setValueDate(int rowIndex, int columnIndex, int value) /*-{ -this.setValue(rowIndex, columnIndex, new Date(value)); +this.setValue(rowIndex, columnIndex, new $wnd.Date(value)); }-*/;

[gwt-contrib] Re: Code Review: Example how to create a GWT based visualization.

2008-11-10 Thread Uwe Maurer
On Nov 10, 3:36 pm, [EMAIL PROTECTED] wrote: I added some code to have a callback from GWT to javascript, to make sure the GWT visualization is loaded before using it. I am wondering what is the preferred way to make sure a GWT application is loaded before some other javascript (non GWT) in

[gwt-contrib] Re: Code Review: visualization Adds launch scripts to the HelloVisualization demo

2008-10-21 Thread Uwe Maurer
Hi Eric, thanks for adding the launch scripts! LGTM Uwe On Mon, Oct 20, 2008 at 8:23 PM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Uwe, Attached is a patch that adds launch scripts to the HelloVisualization sample. You have to build the project with 'ant', then the launch scripts get

[gwt-contrib] Re: Code Review: Visualization API, added DataView

2008-10-20 Thread Uwe Maurer
On Mon, Oct 20, 2008 at 4:15 PM, Eric Ayers [EMAIL PROTECTED] wrote: LGTM, just address the issue in DataView: M visualization/src/com/google/gwt/visualization/client/Visualization.java LG A visualization/src/com/google/gwt/visualization/client/DataView.java I don't see any real

[gwt-contrib] Re: Code Review: Visualization API, improved hello world example

2008-10-20 Thread Uwe Maurer
want to use a Grid or FlexTable to hold your 2 visualizations and labels side by side. 2008/10/14 Uwe Maurer [EMAIL PROTECTED] Hi, I added a TabPanel to the hello world example, with a tab for each example. I added an example for the new DataView. Thanks, Uwe -- Eric Z. Ayers

[gwt-contrib] Re: Code Review: Visualization API, improved hello world example

2008-10-20 Thread Uwe Maurer
Hi Eric, thanks for the review! The new patch is attached. On Mon, Oct 20, 2008 at 3:24 PM, Eric Ayers [EMAIL PROTECTED] wrote: General: I see this coming out a lot in the hosted mode shell window - do you think it is from our visualization wrappers? [WARN] Malformed JSNI reference

[gwt-contrib] Code Review: Visualization API, improved hello world example

2008-10-14 Thread Uwe Maurer
Hi, I added a TabPanel to the hello world example, with a tab for each example. I added an example for the new DataView. Thanks, Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Code Review: Visualization API, added DataView

2008-10-14 Thread Uwe Maurer
Hi, I added the new DataView class that allows read only access to a DataTable for selected columns. Thanks, Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- Index: