Reviewers: rjrjr,
Description:
Overhaul Editor framework traversal logic to use a visitor pattern.
Add a base EditorDriver interface, with isDirty().
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/1340802/show
Affected files:
A
Reviewers: sbrubaker,
Description:
Handling errors more from user code more gracefully in HasDataPresenter.
If Cells, Cell Widgets, or the SelectionModel throw exceptions during
the rendering loop, we no longer lock the presenter's rendering loop
indefinitely.
Please review this at
Rietveld makes this look like a bigger patch than it is. It really just
adds some try/catch blocks around potentional calls to User code.
http://gwt-code-reviews.appspot.com/1310804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1310804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rice,
Description:
Remove unnecessary script src=... from MediaTest.gwt.xml to avoid
virus scanner false positives
A user reported that Sophos antivirus was flagging MediaTest.gwt.xml
(see: http://savmac7-20.p.link.sophos.com/t/en/Mal/Badsrc-D). The script
src=... line isn't
Revision: 9660
Author: jlaba...@google.com
Date: Tue Feb 1 07:22:51 2011
Log: Handling errors more from user code more gracefully in
HasDataPresenter. If Cells, Cell Widgets, or the SelectionModel throw
exceptions during the rendering loop, we no longer lock the presenter's
rendering loop
http://gwt-code-reviews.appspot.com/1340802/diff/1/2
File user/src/com/google/gwt/editor/client/EditorContext.java (right):
http://gwt-code-reviews.appspot.com/1340802/diff/1/2#newcode114
user/src/com/google/gwt/editor/client/EditorContext.java:114: * Traverse
a editor created by
an editor
On Tue, Feb 1, 2011 at 2:07 PM, t.bro...@gmail.com wrote:
If I understand correctly, the answer to
http://code.google.com/p/google-web-toolkit/issues/detail?id=5892 would
be to do it in user-code? (or at least it would make it possible)
That kind of problem is exactly the reason that the
Revision: 9661
Author: zun...@google.com
Date: Tue Feb 1 08:37:27 2011
Log: Refactors DefaultFilters and DefaultFiltersTest to accept a filter
that will return .class files.
Review at http://gwt-code-reviews.appspot.com/1336801
http://gwt-code-reviews.appspot.com/1340801/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
(right):
http://gwt-code-reviews.appspot.com/1340801/diff/1/2#newcode453
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java:453:
public void
committed as r9660
http://gwt-code-reviews.appspot.com/1310804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9662
Author: gwt.mirror...@gmail.com
Date: Tue Feb 1 14:42:07 2011
Log: Update plural rules for Gaelic and Welsh.
Patch by: jat
Review by: pdr
http://code.google.com/p/google-web-toolkit/source/detail?r=9662
Modified:
Reviewers: scottb,
Description:
Adds option to override JsInliner's max complexity ratio heuristic with
JVM property 'gwt.jsinlinerratio'. The default is 5.0, smaller values
tend to reduce code size. Empirically, 1.2 seems to be a good value.
Please review this at
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1340802/diff/1/4
File user/src/com/google/gwt/editor/client/EditorVisitor.java (right):
http://gwt-code-reviews.appspot.com/1340802/diff/1/4#newcode27
user/src/com/google/gwt/editor/client/EditorVisitor.java:27: public T
void endVisit(EditorContextT ctx) {
Patch updated.
http://gwt-code-reviews.appspot.com/1340802/diff/1/2
File user/src/com/google/gwt/editor/client/EditorContext.java (right):
http://gwt-code-reviews.appspot.com/1340802/diff/1/2#newcode114
user/src/com/google/gwt/editor/client/EditorContext.java:114: * Traverse
a editor created
Revision: 9663
Author: to...@google.com
Date: Tue Feb 1 13:54:46 2011
Log: Speed up DevMode by getting rid of excessive JS to Java calls.
Review at http://gwt-code-reviews.appspot.com/1337801
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9663
LGTM
On Tue, Feb 1, 2011 at 6:40 PM, b...@google.com wrote:
Patch updated.
http://gwt-code-reviews.appspot.com/1340802/diff/1/2
File user/src/com/google/gwt/editor/client/EditorContext.java (right):
http://gwt-code-reviews.appspot.com/1340802/diff/1/2#newcode114
SGTM.
Call it gwt.js.inlinerRatio maybe? There's wiki page somewhere that has
all the existing ones... there's probably a pattern that will emerge. (And
yours should be added.)
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9664
Author: sco...@google.com
Date: Tue Feb 1 16:12:57 2011
Log: Fully process annotation types.
Binary annotations never become TypeDeclarations, so this short-circuit
code is unnecessarily preventing us from fully processing annotation
types. This is bad, because it's
20 matches
Mail list logo
