[gwt-contrib] Re: FastTreeItem Selection problem

2009-07-31 Thread Joel Webber
Gabriel, If you could enter an issue for this and cc' me on it, that would be great. It's not immediately obvious to me whether it would make more sense to add a click event, to change the selection event semantics (probalby not the best idea), or to make the method overridable, but we can discuss

[gwt-contrib] Add Name class and some uses of it

2009-07-31 Thread jat
Reviewers: scottb, Description: The Name class deals with converting between various types of Java names: - source names (org.test.Foo.Bar) - binary names (org.test.Foo$Bar) - internal names (org/test/Foo$Bar) ASM typically uses internal names, classloaders use binary names, and

[gwt-contrib] NOTICE - removing all @deprecated code for GWT 2.0

2009-07-31 Thread Fred Sauer
To all GWT contributors- As you may know, there many exciting thingshttp://code.google.com/webtoolkit/makinggwtbetter.html#roadmap we're working on for GWT 2.0. With all the new features coming your way we thought GWT 2.0 would be a good opportunity to clean house and remove previously deprecated

[gwt-contrib] Re: Announcing the Google Plugin for Eclipse 1.1.0

2009-07-31 Thread Scott Blum
2009/7/30 Miguel Méndez mmen...@google.com The first is something that we call contributor SDKs. These allow you to define a GWT SDK that is backed by the gwt-user, gwt-dev-PLAT/gwt-dev-oophm projects in your eclipse workspace. Configure your workspace per

[gwt-contrib] Re: Instant Hosted Mode

2009-07-31 Thread scottb
Awesome, thanks. http://gwt-code-reviews.appspot.com/51826/diff/1/65 File dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java (right): http://gwt-code-reviews.appspot.com/51826/diff/1/65#newcode203 Line 203: private void fail() { I just meant this visitor itself could throw the

[gwt-contrib] gwt-mac-1.5.0 hosted mode UnsatisfiedLinkError with Java 6

2009-07-31 Thread Jim Tomlinson
One of the reviewers of http://code.google.com/p/google-web-toolkit/issues/detail?id=2507 asked that I forward to this group the question I asked of those involved in fixingclosing this issue. Is someone going to re-open this bug? Every mac developer out there trying to do GWT agrees that

[gwt-contrib] JSNI Break/Continue statements broken

2009-07-31 Thread cromwellian
Reviewers: scottb, Description: Attempt #2. JsBreak and JsContinue traverse() methods do not visit their labels. Please review this at http://gwt-code-reviews.appspot.com/51828 Affected files: dev/core/src/com/google/gwt/dev/js/ast/JsBreak.java

[gwt-contrib] Re: JSNI Break/Continue statements broken

2009-07-31 Thread scottb
LGTM, just make sure tests pass and stuff. :) http://gwt-code-reviews.appspot.com/51828 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: NOTICE - removing all @deprecated code for GWT 2.0

2009-07-31 Thread Sam Gross
Nice! I love house cleaning. :-) Is there any plan for removing com.google.gwt.user.client.Element in GWT 2.0 or some time in the future? -Sam On Fri, Jul 31, 2009 at 12:22 PM, Fred Sauerfre...@google.com wrote: To all GWT contributors- As you may know, there many exciting things we're 

[gwt-contrib] Re: NOTICE - removing all @deprecated code for GWT 2.0

2009-07-31 Thread Isaac Truett
Woo and, may I say, hoo, for removing deprecated code. Will deprecated code in the Incubator be disappearing as well? Obviously if that deprecated code depends on deprecated GWT code, it will at least have to be updated. On Fri, Jul 31, 2009 at 12:22 PM, Fred Sauerfre...@google.com wrote: To 

[gwt-contrib] Re: SOYC filenames all end with .html

2009-07-31 Thread spoon
Thanks! Commited at r5857. http://gwt-code-reviews.appspot.com/54813 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] fix and test the runAsync lightweight metrics

2009-07-31 Thread spoon
Reviewers: bobv, Description: In some cases, the runAsync lightweight metrics generated the wrong event or dropped an event entirely. This patch fixes the two known problems and adds two tests of the lightweight metrics. First, AsyncFragmentLoaderTest now also verifies that the correct

[gwt-contrib] Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Fred Sauer
Web mode stack traces are steadily improving. You can even get line numbers (by inheriting com.google.gwt.core.EmulateJsStack). Without the extra instrumentation you web mode stack traces might look something like this: at Unknown.$NullPointerException() at Unknown.onClick_6() at

[gwt-contrib] Issue 3907 - Implement StackTraceElement#toString and fix Unknown Source - null

2009-07-31 Thread fredsa
Reviewers: bobv, Description: 1. Change StackTraceElement#getFileName() to return null instead of Unknown Source to. See Javadoc which indicates null should be returned when filename is not available http://java.sun.com/j2se/1.4.2/docs/api/java/lang/StackTraceElement.html#getFileName() 2.

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Bruce Johnson
I prefer Unknown because it's an indication you are looking at suboptimal stack trace output. JavaScript makes it sound like we actually intend for you to be looking at that output, when in fact, you really want to use symbol maps to reverse lookup the Java idents. On Fri, Jul 31, 2009 at 2:42 PM,

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Fred Sauer
Indeed, Out of the box (-style OBF) you get: at Unknown.lG(Unknown Source:0) at Unknown.Ccb(Unknown Source:0) at Unknown.kD(Unknown Source:0) at Unknown.nK(Unknown Source:0) at Unknown.vO(Unknown Source:0) at Unknown.cP(Unknown Source:0) at Unknown.f_(Unknown Source:0)

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Ray Cromwell
On Fri, Jul 31, 2009 at 4:33 PM, Fred Sauer fre...@google.com wrote: You get the following, which notably can be pasted into Eclipse's Stack Trace Console view so that the filename:lineNumber pairs become clickable hyperlinks: That's just awesome beyond belief.

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Fred Sauer
I can't wait! On Fri, Jul 31, 2009 at 4:58 PM, Bruce Johnson br...@google.com wrote: 4 cheers for Bob! w00t, w00t, w00t and w00t. Also, note that this is phase 1 in a larger plan. For Bob's next feat of magic, he's going to provide better control over permutations, allowing you to, say,

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Fred Sauer
Perhaps one of bobs tricks will involve taking the `-style DETAILED` information which looks like this:at Unknown.com_allen_1sauer_gwt_log_demo_client_InteractiveDemoPanel$5_onClick__Lcom_google_gwt_event_dom_client_ClickEvent_2V(InteractiveDemoPanel.java:135) and magically reverse transform

[gwt-contrib] Re: Web mode stack traces - propose stackElement.getFileName() return 'JavaScript' instead of 'Unknown'

2009-07-31 Thread Bruce Johnson
Isn't that already there, if you wire up the symbol maps correctly? On Fri, Jul 31, 2009 at 5:38 PM, Fred Sauer fre...@google.com wrote: Perhaps one of bobs tricks will involve taking the `-style DETAILED` information which looks like this:at