Comment by cromwellian:
Not currently. GWT Exporter was created under the paradigm that it only
exports what is explicitly requested, or what is absolutely necessary. I
felt at the time that 'inheriting' annotations could lead to a lot of
bloat, as well as asking the TypeOracle to give
LGTM.
There is a tricky problem here, probably deserving a comment in the SOYC
code. Ideally, the XML file should be non-lossy, and the original
string text should be recoverable. The best way I have run into to
accomplish that would be to convert the string data back into string
literal
Personally, I would just transform every character ==0 or 127 into a \x
or \u escape (or since this is XML you could use an entity reference,
#x;). There shouldn't be a ton of them and it isn't like XML is small
anyway.
http://gwt-code-reviews.appspot.com/61801
I like the #x; idea. There is just one potential problem: will XML
readers support it? The linked XML spec has the same restrictions on
encoded character entities as on raw characters appearing in the file.
Does anyone know if that restriction is honored in practice? Anyone
want to test on
On Wed, Aug 19, 2009 at 6:28 AM, sp...@google.com wrote:
I like the #x; idea. There is just one potential problem: will XML
readers support it? The linked XML spec has the same restrictions on
encoded character entities as on raw characters appearing in the file.
Does anyone know if that
Reviewers: kplatfoot, Ray Ryan,
Message:
Review requested.
Description:
This change declares the default filename suffixes on the resource types
instead of constants in the ResourceGenerators.
Please review this at http://gwt-code-reviews.appspot.com/61802
Affected files:
M
Shouldn't com.google.gwt.resources.ext.DefaultExtensions have been
included in this patch?
http://gwt-code-reviews.appspot.com/61802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/61802/diff/1011/17
File user/src/com/google/gwt/resources/ext/DefaultExtensions.java
(right):
http://gwt-code-reviews.appspot.com/61802/diff/1011/17#newcode28
Line 28: * {...@link
com.google.gwt.resources.client.ClientBundle.SourceSource} annotation
The @link
Here is an updated patch with the method rename and the updated docs.
I'm still waiting on trunk to stabilize before committing. -Lex
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 5977
Author: b...@google.com
Date: Wed Aug 19 11:04:00 2009
Log: Fix JUnit enabling emulated stack traces.
Patch by: bobv
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=5977
Modified:
/trunk/user/src/com/google/gwt/junit/JUnit.gwt.xml
LGTM
http://gwt-code-reviews.appspot.com/61803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
This is a nice cleanup, but I have questions about your annotation
search
http://gwt-code-reviews.appspot.com/61802/diff/1011/18
File user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java
(right):
http://gwt-code-reviews.appspot.com/61802/diff/1011/18#newcode135
Line 135: public
Thanks, Lex.
I didn't try the #x; idea (see Ian's comment), but I also added the
other illegal characters. I'll leave the recoverability (in the
dashboard) for another day: (x00) and (u) seem good to me for human
consumption, and the surrogate blocks characters shouldn't really ever
in an
Reviewers: jgw, knorton,
Description:
This patch fixes the issue Kelly found where the iframe used to display
an OOPHM troubleshooting page might not be ready to redirect to the URL.
The fix is to simply specify the URL when the iframe is created, as the
javascript:'' hack is not needed here.
LGTM w/a couple of javadoc tweaks.
http://gwt-code-reviews.appspot.com/61802/diff/28/1039
File dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java
(right):
http://gwt-code-reviews.appspot.com/61802/diff/28/1039#newcode368
Line 368: * which this type is assignable. Annotations present
Hi there,
seems like a easy question and I hope that someone can point me into
the right direction, how can i write the css rule -moz-box-
sizing:border-box; so that the CssResource parser accepts it?
I tried
-moz-box-sizing:literal(border-box);
or
literal(-moz-box-sizing:border-box);
both
On Wed, Aug 19, 2009 at 9:26 PM, Dominik Steiner
dominik.j.stei...@googlemail.com wrote:
Hi there,
seems like a easy question and I hope that someone can point me into
the right direction, how can i write the css rule -moz-box-
sizing:border-box; so that the CssResource parser accepts it?
On Mac OS X running Eclipse 3.5 with the latest Google Plugin, if you
create and run a new web application that's configured with GWT trunk
r5922+, it fails with the following 'SAXParserFactoryImpl not found'
error (since Xerces is now bundled with gwt-dev-*.jar):
LGTM
http://gwt-code-reviews.appspot.com/61807
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: Ray Ryan,
Description:
This patch removes the META-INF/services dir from xercesImpl.jar that
was causing conflicts with AppEngine and internal Tomcat. Also, rolls
back the changes made by now unnecessary c5916.
Please review this at http://gwt-code-reviews.appspot.com/61807
Affected
Is there an appropriate more general home for this? I know I do it all
the time.
Could it be an instance method on JClassType?
Moved to JClassType.findAnnotationInTypeHierarchy()
For annotations marked @Inherited, would the super-crawl even be
necessary?
@Inherited doesn't work for
Thanks Stefan for the fast reply,
I tried it and it works!
On 19 Aug., 16:40, Stefan Haustein haust...@google.com wrote:
On Wed, Aug 19, 2009 at 9:26 PM, Dominik Steiner
dominik.j.stei...@googlemail.com wrote:
Hi there,
seems like a easy question and I hope that someone can point me
Reviewers: ,
Description:
This is an internal contribution that extends FakeMessagesMaker to work
with Constants as well. I'll submit it if the c-build every turns green
again.
Please review this at http://gwt-code-reviews.appspot.com/61808
Affected files:
Thanks for the review.
http://gwt-code-reviews.appspot.com/59801/diff/2001/2011
File dev/oophm/src/com/google/gwt/dev/ModuleTabPanel.java (right):
http://gwt-code-reviews.appspot.com/59801/diff/2001/2011#newcode89
Line 89: public synchronized void addModule(String moduleName,
On 2009/08/20
On Wed, Aug 19, 2009 at 8:29 PM, j...@google.com wrote:
Thanks for the review.
http://gwt-code-reviews.appspot.com/59801/diff/2001/2011
File dev/oophm/src/com/google/gwt/dev/ModuleTabPanel.java (right):
http://gwt-code-reviews.appspot.com/59801/diff/2001/2011#newcode89
Line 89: public
Success!
Thanks all around,
Aaron
On Wed, Aug 19, 2009 at 5:48 PM, Amit Manjhiamitman...@google.com wrote:
Hi Aaron,
We are aware of this issue. I will commit a fix as soon our build becomes
green again.
Btw, here is the patch: http://gwt-code-reviews.appspot.com/61807
Additionally, you
Amir,
After your post, I have been investigating PureMVC a bit. Since you
used it, I have a question. In PureMVC, in the typical
ApplicationFacade class there is an initializeController() override
which registers all the commands. How does this fit with code-
splitting? Currently our
Joel,
Will be happy to test new layouts and review API. Unfortunately, I
don't use Dock, Stack, or Split in my app. I do use Absolute. And
because of an interior scrolling area that fills the client, a
sprinkling of resize code (after beating my head against CSS for a few
days). I do use
28 matches
Mail list logo
