Reviewers: jat, scottb,
Description:
Hi John/Scott,
Please review this simple patch that fixes issue 2979.
Regards,
Amit
Please review this at http://gwt-code-reviews.appspot.com/34807
Affected files:
dev/windows/src/org/eclipse/swt/browser/WebSite.java
Index:
Reviewers: jat, scottb,
Description:
Hi John/Scott,
Please review this patch that fixes issue 3057. I also added testcases
and verified that the testcases pass in both web and hosted mode.
Thanks,
Amit
Please review this at http://gwt-code-reviews.appspot.com/33813
Affected files:
Reviewers: jat, scottb,
Description:
Simple fix and accompanying testcase for toString() method in
TreeMap.Entry
Please review this at http://gwt-code-reviews.appspot.com/33814
Affected files:
user/super/com/google/gwt/emul/java/util/TreeMap.java
LGTM except the simple changes for the test code. Once everyone has
weighed in and the patch is ready to go in, I volunteer to commit it on
your behalf.
Thanks for the patch!
http://gwt-code-reviews.appspot.com/34811/diff/1/3
File user/super/com/google/gwt/emul/java/lang/String.java (right):
Hi Danny,
Sorry for the delay in getting back. Overall the changes look great. The
implementation looks correct and the tests look exhaustive. I have a few
high level comments:
(i) Can you refactor some of the code in BitSet.java to make it more
concise? For example, can't you write andNot in
O(N) temporary memory usage, which having the three native methods
approach (getWordPositions, setWord, getWord) is likely to have, is a
reasonable tradeoff to make since it will greatly enhance readability.
Your approach of using array indexing already saves a lot of memory as
it only uses O(N)
The bottomline is breaking down most operations integer-by-integer. If
you can extract the core of nextSetBit to do it, that is fine.
You might need to introduce other methods than the 3 Jsni methods we
have discussed (it would be great to use just 3), but length() and
delete() don't fall in
Hi John,
Besides Scott's suggestion, I have one more thing to add. For any method
that mutates the Date, wouldn't it be more useful to call
th...@java.util.date::checkJsDate()(); both when entering and exiting
the method? Then, we can get a stack trace of the problem code
immediately.
After
Reviewers: jat,
Please review this at http://gwt-code-reviews.appspot.com/33838
Affected files:
user/src/com/google/gwt/i18n/client/Dictionary.java
user/test/com/google/gwt/i18n/client/I18NTest.java
Index: user/src/com/google/gwt/i18n/client/Dictionary.java
---
Reviewers: Ray Ryan, scottb,
Description:
It will be less confusing for new users. Anyone see any downsides?
Please review this at http://gwt-code-reviews.appspot.com/39803
Affected files:
user/src/com/google/gwt/user/tools/Module.gwt.xmlsrc
Index:
LGTM with one inline comment and one design question Is it better to
have a special case handling of null or is it better to introduce a
default non-null value for this purpose?
http://gwt-code-reviews.appspot.com/47804/diff/1/3
File user/src/com/google/gwt/junit/client/GWTTestCase.java
LGTM with adding the ToDo to replace ? by a type variable, wherever
possible.
http://gwt-code-reviews.appspot.com/51803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM
http://gwt-code-reviews.appspot.com/54801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
The next patch I will upload contains the fixes I have indicated as
done.
I also did not review carefully all the broken tests. I mostly
mechanically put the annotation just to get the whole test suite to
pass.
Currently, batching will not work with htmlUnit because the batching
code does not
LGTM for changes to tools/api-checker/config/gwt16_20userApi.conf
http://gwt-code-reviews.appspot.com/51831/diff/1017/1019
File tools/api-checker/config/gwt16_20userApi.conf (right):
http://gwt-code-reviews.appspot.com/51831/diff/1017/1019#newcode82
Line 82: :com.google.gwt.uibinder.parsers\
:user/src/com/google/gwt/uibinder/parsers\
http://gwt-code-reviews.appspot.com/51831/diff/1017/1019#newcode82
Line 82: :com.google.gwt.uibinder.parsers\
On 2009/08/04 21:43:58, amitmanjhi wrote:
Changes to this file looks good to me.
My bad. I did not look at enough context. Remove these two
LGTM.
I do want you to add additional test cases and fix whatever the tests
break, if any.
http://gwt-code-reviews.appspot.com/56812/diff/1/2
File dev/oophm/test/com/google/gwt/dev/shell/BrowserChannelTest.java
(right):
http://gwt-code-reviews.appspot.com/56812/diff/1/2#newcode240
Line 240: }
Reviewers: Ray Ryan,
Description:
This patch removes the META-INF/services dir from xercesImpl.jar that
was causing conflicts with AppEngine and internal Tomcat. Also, rolls
back the changes made by now unnecessary c5916.
Please review this at http://gwt-code-reviews.appspot.com/61807
Affected
+ ((HtmlPage) page).asXml());
-// TODO(amitmanjhi): call webClient.closeAllWindows()
} catch (FailingHttpStatusCodeException e) {
treeLogger.log(TreeLogger.ERROR, HTTP request failed, e);
-return;
} catch (MalformedURLException e
Comments inline.
NativeString -- In htmlUnit, after a call like:
String foo = new String();
'foo' is of type NativeString. While on the java side, the object is
assumed to be of type String. So, we need to the appropriate massaging
in makeValueFromJsVal.
Hi John,
It seems that the changes to JUnitShell.java is a sort format change.
Can you commit that change separately?
The remaining changes should then be confined to user/build.xml,
GWTTestCase.java and DoNotRunWith.java. Those look good to me. Please go
ahead and commit.
Regards,
Amit
Reviewers: fabbott, jat,
Description:
The changes are for the farewellSwt branch.
The swt stuff and the mac specific stuff is no longer necessary with
HtmlUnit. Have tested the changes on Mac and linux, by running the
test.hosted and test.web targets.
Please review this at
LGTM
http://gwt-code-reviews.appspot.com/78802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jlabanca,
Description:
Simple patch to adjust timeout based on BatchingStrategy
Please review this at http://gwt-code-reviews.appspot.com/88808
Affected files:
user/src/com/google/gwt/junit/BatchingStrategy.java
user/src/com/google/gwt/junit/JUnitShell.java
Index:
Reviewers: jlabanca,
Description:
Added a new method to RunStyle.java that governs how many times the test
should be tried, in case of a failure. Added JUnit infrastructure to do
so, along with tests.
Please review this at http://gwt-code-reviews.appspot.com/91806
Affected files:
Uploading another patch. Did not know how to do it with this message.
http://gwt-code-reviews.appspot.com/91806/diff/1/2
File user/src/com/google/gwt/junit/JUnitMessageQueue.java (right):
http://gwt-code-reviews.appspot.com/91806/diff/1/2#newcode413
Line 413: assert (result != null);
Good
As mentioned in the detailed comments, because more classes will pass
the isAnonymous() filter, the matching algorithm will break.
Perhaps isAnonymous() can be renamed to isLocal() (since that is exactly
what is being computed).
isAnonymous() can then be isLocal()
http://gwt-code-reviews.appspot.com/89817/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right):
http://gwt-code-reviews.appspot.com/89817/diff/1/3#newcode80
Line 80: boolean anonymous = false;
a small nit: perhaps move this to a separate method? as in
this.anonymous =
LGTM other than minor comments below.
ApiContainerTest and ApiCompatibilityTest throw console errors, even
though the tests pass.
Validating newly compiled units
[ERROR] No JavaScript body found for native method 'protected
native int protectedMethod();' in type 'java.lang.Object'
Reviewers: jat,
Description:
Remove the no longer necessary startOnFirstThread hacks for mac.
Please review this at http://gwt-code-reviews.appspot.com/103808
Affected files:
user/src/com/google/gwt/user/tools/App.launchsrc
user/src/com/google/gwt/user/tools/WebAppCreator.java
Reviewers: jat, knorton, bruce,
Description:
Remove distro-source/windows, distro-source/linux and distro-source/mac
dirs and their contents.
There is a libswt-webkit-carbon-3235.jnilib that looks safe to remove,
since I could not find any references to it. I just wanted to confirm
before
LGTM, if the tests pass.
http://gwt-code-reviews.appspot.com/105805/diff/1/2
File user/src/com/google/gwt/junit/JUnitShell.java (right):
http://gwt-code-reviews.appspot.com/105805/diff/1/2#newcode751
Line 751: // CHECKSTYLE_ON
Please confirm that this change works.
LGTM. One minor suggestion.
I like this version.
http://gwt-code-reviews.appspot.com/111810/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/ShellMainWindow.java (right):
http://gwt-code-reviews.appspot.com/111810/diff/1/2#newcode233
Line 233: loadingMessage.setText(No URLs to Launch);
Looks great. I still have to look over the update to tools. Just a few
comments on the patch to gwt-trunk:
- Does the CL pass 100% even in repeated runs of dev, prod, emma, and
other relevant modes?
- CreateEventTest.java: sorting of imports seems incorrect.
- For every test where you add a
The README file could be clearer since some of the previous instructions
don't apply. I will fix it when I commit the patch on your behalf.
Otherwise, looks good.
http://gwt-code-reviews.appspot.com/134806
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/139803
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I quickly looked at the changes and they look okay. We can get this
patch into trunk sooner than a few weeks.
@tbroyer: Can you update the patch to address John's concerns?
Basically, just push methods, as appropriate, from SessionHandler to
SessionHandlerClient and SessionHandlerServer that
http://gwt-code-reviews.appspot.com/161801/diff/1/3
File samples/showcase/war/Showcase.html (right):
http://gwt-code-reviews.appspot.com/161801/diff/1/3#newcode4
Line 4: script language='javascript'
Any disadvantage to leaving the title here (even though you are setting
it later)? At least,
Ray and I pair-programmed and commited this patch
http://code.google.com/p/google-web-toolkit/source/detail?r=7687
Ray: please close this issue.
http://gwt-code-reviews.appspot.com/160809/diff/1/9
File bikeshed/src/com/google/gwt/valuestore/shared/Property.java
(right):
Reviewers: jat,
Description:
Fix the escaping of a String used in one of test methods of
JsonpRequestTest
Please review this at http://gwt-code-reviews.appspot.com/163801
Affected files:
user/test/com/google/gwt/jsonp/client/JsonpRequestTest.java
Index:
On 2010/03/09 02:56:39, jat wrote:
LGTM
Thanks. Commited
http://code.google.com/p/google-web-toolkit/source/detail?r=7688
http://gwt-code-reviews.appspot.com/163801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2010/03/09 18:27:31, kathrin wrote:
Continuing the code review here. The only remaining issue I have is with
the 3 constructors in CrawlableHyperlink that don't do anything. Do you
need to override all 3? Also, while you are at it, perhaps you can
deprecate/refactor/cleanup some of the
LGTM -- I assume you have checked that it still works correctly. The
only minor comment I have is extracting out the string constant ! used
at two places.
http://gwt-code-reviews.appspot.com/161801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/192801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2010/03/12 22:52:08, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/193801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2010/03/13 00:13:15, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/195801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Those 2 additional files look good and I'm assuming everything
else is fine. Please run checkstyle before commiting.
On 2010/03/13 01:47:23, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/198801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/200801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The LongString and ServerType annotation files look good.
btw, I was unable to view some diffs. But the diff looked okay for the
files I checked.
On 2010/03/13 03:54:27, amitmanjhi wrote:
LGTM
http://gwt-code-reviews.appspot.com/200801
--
http://groups.google.com/group/Google-Web-Toolkit
Reviewers: Ray Ryan,
Description:
Initial CL that sends an update across the wire and persists it.
Please review this at http://gwt-code-reviews.appspot.com/221802
Affected files:
M
bikeshed/src/com/google/gwt/sample/expenses/gen/ExpenseRequestFactoryImpl.java
M
Additional checkstyle problems (Eclipse output). Please run checkstyle
:)
Description ResourcePathLocationType
forProperties is not
alphabetical. EntityListRequest.java
Bikeshed/src/com/google/gwt/requestfactory/shared line
35 Checkstyle Problem
getDetailsPlaceFor
Reviewers: Ray Ryan,
Description:
Use reflection on the server side to have a shared code for handling all
GET
requests. The output of these requests is assumed to be a List of
Entity.
This list is then converted automatically to a JSON string and sent over
the
wire.
Patch by: amitmanjhi
http://gwt-code-reviews.appspot.com/240801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words REMOVE ME as the subject.
Addressed your comments.
http://gwt-code-reviews.appspot.com/240801/diff/1/3
File
bikeshed/src/com/google/gwt/sample/expenses/gen/ReportRequestImpl.java
(right):
http://gwt-code-reviews.appspot.com/240801/diff/1/3#newcode63
http://gwt-code-reviews.appspot.com/240801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words REMOVE ME as the subject.
EntityKey.java seems to be missing from the patch
On 2010/03/19 07:52:39, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/243801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
LGTM. Thanks for the patch, the code is much cleaner now.
http://gwt-code-reviews.appspot.com/250801/diff/2001/18
File
bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java
(right):
http://gwt-code-reviews.appspot.com/250801/diff/2001/18#newcode3
Reviewers: Ray Ryan,
Description:
Got rid of the MethodName enum. This small CL is on way to relying
solely on RequestFactory config
Patch by: amitmanjhi
Review by: rjrjr.
Please review this at http://gwt-code-reviews.appspot.com/255801/show
Affected files:
M
bikeshed/src/com/google/gwt
Reviewers: Ray Ryan, kathrin, Frank,
Description:
Upgraded to a dethreaded HtmlUnit r5607. Removed @DoNotRunWith
annotation
from many tests. Classified all other failures as either HtmlUnitLayout,
HtmlUnitUnknown, or HtmlUnitBug.
Please review this at
On 2010/03/24 20:48:28, amitmanjhi wrote:
Even though this patch is large, the changes are fairly minor. Almost
all the changes are @DoNotRunWith annotations being deleted from test
methods and test classes.
The changes to src files (in user/src) are minor -- in response to
updates to HtmlUnit
http://gwt-code-reviews.appspot.com/268801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this group, send email to
google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with
the words REMOVE ME as the subject.
Reviewers: jlabanca,
Description:
Ant changes in response to a stable htmlUnit.
Patch by: amitmanjhi
Review by: jlabanca
Please review this at http://gwt-code-reviews.appspot.com/269801/show
Affected files:
M user/build.xml
Index: user/build.xml
Reviewers: Ray Ryan,
Description:
The servlet now reads the enum name from a properties file. Thus, the
servlet
portion responsible for all READ operations is a stock servlet.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/286802
LGTM. thanks for taking care of this.
On 2010/04/01 21:27:08, jlabanca wrote:
http://gwt-code-reviews.appspot.com/300801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using remove me as the subject.
Reviewers: Ray Ryan,
Description:
1) The service methods will now be annotated with a @ServerOperation.
Used during code-gen.
2) The code generator now exists.
3) Other updates to the app code and gwt.xml to make use of the code
generator.
Patch by: amitmanjhi
Review by: rjrjr (desk review
Reviewers: Ray Ryan,
Description:
Move the enum config to the proper place in web.xml
Thanks Ben!
Patch by: amitmanjhi
Review by: rjrjr (TBR)
Please review this at http://gwt-code-reviews.appspot.com/303801/show
Affected files:
M
bikeshed/src/com/google/gwt/sample/expenses/server
LGTM
On 2010/04/02 00:59:08, Ray Ryan wrote:
Much better. Ready for my LGTM, Mr. Spoon.
http://gwt-code-reviews.appspot.com/302801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using remove me as the subject.
Looks good. I like this new structure, as per we discussed offline. Have
the contents of any file changed that I should carefully look at?
On 2010/04/03 21:28:52, Ray Ryan wrote:
Amit, I'll be TBR'ing this.
http://gwt-code-reviews.appspot.com/294802/show
--
LGTM. Nit: rename ExpensesRequests to ExpensesServerOperation or
something like that.
On 2010/04/05 19:18:26, Ray Ryan wrote:
http://gwt-code-reviews.appspot.com/311801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using remove me as the
LGTM, except some comments below.
http://gwt-code-reviews.appspot.com/328801/diff/1/3
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/place/ApplicationListPlace.java
(right):
http://gwt-code-reviews.appspot.com/328801/diff/1/3#newcode25
w00t! for this change. LGTM. I assume GWTShell and associated cruft
removal will follow soon. Some minor comments below.
http://gwt-code-reviews.appspot.com/361801/diff/1/3
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/361801/diff/1/3#newcode451
LGTM
http://gwt-code-reviews.appspot.com/375801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
.
- DeltaValueStore can handle a sequence of CREATE, DELETE, UPDATE calls
on records.
- ExpenseDataServlet now just does database initialization, all sync
functionality is carried out using reflection in the generic servlet.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http
Reviewers: Ray Ryan,
Description:
Goodbye fake storage, welcome JPA with appEngine. Notes:
1) Currently there are just 2 entities: Employee and Report. Any new
entity must be added to the list in persistence.xml
2) Fixed findReportsByEmployee call.
3) A Report entity cannot refer to an Employee
Reviewers: Ray Ryan,
Description:
Removed LongString and fixed the currently simple sync operation.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/358801/show
Affected files:
D bikeshed/src/com/google/gwt/requestfactory/shared
Reviewers: Ray Ryan,
Description:
Fixed inclusion of json2.js in the html files
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/394802/show
Affected files:
M trunk/bikeshed/war/ExpensesCustomized.html
M trunk/bikeshed/war
Reviewers: Ray Ryan,
Description:
changed the version number to Integer. Some other small fixes for
compile
errors.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/422802/show
Affected files:
M
trunk/bikeshed/src/com/google
Reviewers: Ray Ryan,
Description:
Adds the generator for generating the Editor code.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/392803/show
Affected files:
M trunk/bikeshed/src/com/google/gwt/app/App.gwt.xml
A trunk
Reviewers: Ray Ryan,
Description:
Cleaned up the generator code.
Patch by: amitmanjhi
Review by: rjrjr (tbr)
Please review this at http://gwt-code-reviews.appspot.com/404803/show
Affected files:
M trunk/bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java
--
http
Reviewers: Ray Ryan,
Description:
Use Long ids instead of String for server-side domain objects. Fixed the
swizzling code so that Longs are represented as String on the client
side.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com
Reviewers: Ray Ryan,
Description:
Added server side validation using JSR 303. On the server side, one can
now do
validations before persisting an entity. Also, added a callback for sync
request so that any validation errors can be shown on the client.
Patch by: amitmanjhi
Review by: rjrjr (desk
Reviewers: Ray Ryan,
Description:
Moved the showErrors method into the generator.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/451801/show
Affected files:
M trunk/bikeshed/src/com/google/gwt/app/client/EditorSupport.java
M
Reviewers: Ray Ryan,
Description:
added the validation-api jar reference in ant so that bikeshed can be
built
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/460801/show
Affected files:
M trunk/bikeshed/build.xml
Index: trunk
Reviewers: Ray Ryan,
Description:
The TOKEN on a Record class is now a field instead of an annotation. The
field
can be generated by a JPA-savvy tool. The TOKEN, in addition to being
used for
SYNC requests, will also be used for DeltaValueStore.create(..) method
Patch by: amitmanjhi
Review
Reviewers: Ray Ryan,
Description:
Updates the RequestFactory generator to build a class that can map the
String tokens on Record classes to internal 'schemas'.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/488801/show
Affected
it.
RecordListView no longer extends ListView, which always was a bit
awkward. Now it provides access to the wrapped table view
instead. Needed to do this to give access to paging related calls
without wrapping them.
Patch by: amitmanjhi, rjrjr
Review by: rjrjr, amitmanjhi
Please review this at http://gwt
Reviewers: Ray Ryan,
Description:
Doubles can now be sent over the wire.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/503801/show
Affected files:
M
trunk/bikeshed/src/com/google/gwt/requestfactory/server
Reviewers: Ray Ryan,
Description:
Added: (i) a DataGenerator factored out of ExpensesDataServlet to
generate
sample data, (ii) SampleDataPopulator that can populate the datastore
using a
json-format datafile (iii) a dataPopulator script to invoke
SampleDataPopulator.
Review by: rj...@google.com
Reviewers: Ray Ryan,
Description:
The department field is now present on the client side as well. Updated
the
sample JSON records.
Review by: rj...@google.com
Please review this at http://gwt-code-reviews.appspot.com/500802/show
Affected files:
M trunk/bikeshed/scripts/expensesJsonData.txt
Reviewers: Ray Ryan,
Description:
Added a countExpenses method to the Expenses entity.
Patch by: amitmanjhi
Review by: rjrjr (TBR)
Please review this at http://gwt-code-reviews.appspot.com/507801/show
Affected files:
M
trunk/bikeshed/src/com/google/gwt/sample/expenses/server/domain
Reviewers: Ray Ryan,
Description:
Removed ExpensesDataServlet, updated the URL mapping in web.xml. Updated
client code to use URL relative to the host page.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/498802/show
Affected
Reviewers: Ray Ryan,
Description:
Added error-checking to SampleDataPopulator and updated the example in
dataPopulator.
Patch by: amitmanjhi
Review by: rjrjr (TBR)
Please review this at http://gwt-code-reviews.appspot.com/511801/show
Affected files:
M trunk/bikeshed/scripts/dataPopulator
Reviewers: jgw,
Description:
The generated data was missing an Expense - Report link. Fixed it.
Updated the sample Json data.
Patch by: amitmanjhi
Review by: jgw (tbr)
Please review this at http://gwt-code-reviews.appspot.com/512801/show
Affected files:
M trunk/bikeshed/scripts
Reviewers: Ray Ryan,
Description:
Configure the logging level to not show the warning by default.
Patch by: amitmanjhi
Review by: rjrjr (tbr)
Please review this at http://gwt-code-reviews.appspot.com/495803/show
Affected files:
M trunk/bikeshed/scripts/dataPopulator
Index: trunk/bikeshed
Reviewers: Ray Ryan,
Description:
The employee records now have a supervisorId that is propagated to the
reports. Plus, minor cleanup.
Patch by: amitmanjhi
Review by: rjrjr (tbr)
Please review this at http://gwt-code-reviews.appspot.com/518801/show
Affected files:
A trunk/bikeshed/scripts
Reviewers: amitmanjhi,
Description:
Factored out the invoke method for a READ request.
Patch by: jon...@gmail.com
Commited by: amitmanjhi
Review by: amitmanjhi
Please review this at http://gwt-code-reviews.appspot.com/519801/show
Affected files:
M
trunk/bikeshed/src/com/google/gwt
Reviewers: Ray Ryan,
Description:
Removed dead code.
Please review this at http://gwt-code-reviews.appspot.com/514802/show
Affected files:
M
trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java
Index:
Reviewers: Ray Ryan,
Description:
Deleting a managed entity makes all its fields null. Updated the code to
account for this behavior.
Please review this at http://gwt-code-reviews.appspot.com/520801/show
Affected files:
M
Reviewers: Ray Ryan,
Description:
updated the large dataset. Plus misc cleanups: nixed unused import,
added copyright header
Patch by: amitmanjhi
Review by: rjrjr (tbr)
Please review this at http://gwt-code-reviews.appspot.com/521801/show
Affected files:
M trunk/bikeshed/scripts
LGTM++ for cleanup.
Few nits in comment below. Is the com/google/gwt/app/util dir empty now?
If so, it should be removed and so should the following line in
App.gwt.xml
source path=util /
http://gwt-code-reviews.appspot.com/522803/diff/1/44
File
1 - 100 of 194 matches
Mail list logo
