w00t! for this change. LGTM. I assume GWTShell and associated cruft removal will follow soon. Some minor comments below.
http://gwt-code-reviews.appspot.com/361801/diff/1/3 File dev/core/src/com/google/gwt/dev/DevMode.java (right): http://gwt-code-reviews.appspot.com/361801/diff/1/3#newcode451 dev/core/src/com/google/gwt/dev/DevMode.java:451: } Is this method used anywhere? http://gwt-code-reviews.appspot.com/361801/diff/1/4 File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/361801/diff/1/4#newcode168 dev/core/src/com/google/gwt/dev/DevModeBase.java:168: public ArgHandlerBlacklist() { The default constructor is not visible. Making the class public instead of protected fixes it. On 2010/04/19 19:34:57, scottb wrote:
I wrinkled my brow on this for ~5 minutes. For some reason I don't
understand,
Eclipse really want this to exist. I gave up trying to figure it out.
http://gwt-code-reviews.appspot.com/361801/diff/1/4#newcode416 dev/core/src/com/google/gwt/dev/DevModeBase.java:416: public ArgHandlerWhitelist() { See above. Can remove the default constructor by making the class public instead of protected. On 2010/04/19 19:31:17, jlabanca wrote:
Necessary?
http://gwt-code-reviews.appspot.com/361801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
