http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):
http://gwt-code-reviews.appspot.com/1420804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):
LGTM
http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):
http://gwt-code-reviews.appspot.com/1420804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1420804/diff/1/user/src/com/google/gwt/uibinder/client/UiBinderUtil.java
File user/src/com/google/gwt/uibinder/client/UiBinderUtil.java (right):
Thanks for the quick update, looking now.
One thought (doesn't gate this patch): I wonder if your code bloat problem
would go away if your Widgets classes were JSOs.
On Wed, Apr 20, 2011 at 9:03 AM, her...@google.com wrote:
Nearly there!
http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):
Both comments are somewhat related and reflect my phobia of big CLs.
I'll address them still today. Thanks.
http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):
http://gwt-code-reviews.appspot.com/1420804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Once again SQ passed with success and orkut seems ok. I'll take a deeper
look at your doc today morning, looks promising...
On Wed, Apr 20, 2011 at 8:14 PM, her...@google.com wrote:
http://gwt-code-reviews.appspot.com/1420804/
--
--Hermes Freitas
--
I don't see any show stoppers. Going to try patching it in now and look
at the generated code.
http://gwt-code-reviews.appspot.com/1420804/diff/1/user/src/com/google/gwt/uibinder/client/UiBinderUtil.java
File user/src/com/google/gwt/uibinder/client/UiBinderUtil.java (right):
You're missing a definition of that new property in UiBinder.gwt.xml
http://gwt-code-reviews.appspot.com/1420804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'm having trouble applying the patch. I'll keep looking for an
appropriately stale patch point, but if you get a chance to sync that
will be helpful.
http://gwt-code-reviews.appspot.com/1420804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
14 matches
Mail list logo
