Re: [PATCH v4 01/12] misc: add z length modifier support

2025-10-13 Thread Daniel Kiper
On Mon, Oct 13, 2025 at 04:03:28PM +0200, Heinrich Schuchardt via Grub-devel wrote: > On 10/13/25 15:53, Daniel Kiper wrote: > > On Thu, Oct 09, 2025 at 03:18:34PM +0800, Michael Chang via Grub-devel > > wrote: > > > Add support for the 'z' length modifi

Re: [PATCH v4 10/13] disk/luks2: Add Argon2 support

2025-10-13 Thread Daniel Kiper
On Tue, Sep 02, 2025 at 03:18:02PM +0800, Gary Lin via Grub-devel wrote: > Leverage the new grub_crypto_argon2() function to add support for the > Argon2i and Argon2id KDFs in LUKS2 > > Signed-off-by: Gary Lin > Tested-By: Waldemar Brodkorb I think this patch should be after patch #7. Daniel _

Re: [PATCH v4 01/12] misc: add z length modifier support

2025-10-13 Thread Daniel Kiper
On Thu, Oct 09, 2025 at 03:18:34PM +0800, Michael Chang via Grub-devel wrote: > Add support for the 'z' length modifier in the printf code. This allows > printing of size_t and ssize_t values using %zu, %zd and related > formats. The parser maps 'z' to the correct integer width based on > sizeof (s

Re: [PATCH v4 04/12] util/grub-editenv: add basic structures and probe call for external envblk

2025-10-13 Thread Daniel Kiper
On Mon, Oct 13, 2025 at 01:39:37PM +0200, Daniel Kiper wrote: > On Thu, Oct 09, 2025 at 03:18:37PM +0800, Michael Chang via Grub-devel wrote: > > This patch prepares for using an environment block stored in a reserved > > area of the filesystem. It uses constant GRUB_ENV_BTRF

Re: [PATCH v1] docs/grub.texi: Fix build warnings in libgcrypt and blsuki doc

2025-10-02 Thread Daniel Kiper
is > `trust' in menu > grub.texi:8600: warning: node prev pointer for `verify_detached' is `uki' but > prev is `unset' in menu > > Fix order of gcry_aria_module and unset nodes > > Signed-off-by: Sridhar Markonda > Reviewed-by: Andrew Hamilton >

Re: GRUB 2.14 release

2025-10-02 Thread Daniel Kiper via Grub-devel
On Fri, Aug 22, 2025 at 04:20:12PM +0200, Daniel Kiper wrote: > Hi, > > It is time to start planning 2.14 release. Sadly once again we are behind the > schedule mostly due to lack of resources. I do not like it but it is what it > is. I am working on improving situation but it go

Re: [PATCH v3 0/7] TPM2 PCR Capping

2025-10-02 Thread Daniel Kiper
apping > tests/tpm2_key_protector_test: Add a test for PCR Capping Except a nitpick mentioned above for all patches Reviewed-by: Daniel Kiper ... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 7/9] btrfs: add environment block to reserved header area

2025-10-02 Thread Daniel Kiper
On Thu, Oct 02, 2025 at 02:46:20PM +0800, Michael Chang via Grub-devel wrote: > This patch reserves space for the GRUB environment block inside the > Btrfs header. The block is placed at an offset of 256 KiB from the start > of the device and occupies one sector. To protect the space, overflow > gu

Re: [PATCH v3 9/9] docs: add Btrfs env block and special env vars

2025-10-02 Thread Daniel Kiper
env_block > variables. > > Signed-off-by: Michael Chang > Reviewed-by: Neal Gompa Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 8/9] 00_header.in: wire grub.cfg to use env_block when present

2025-10-02 Thread Daniel Kiper
e. In this way the external environment > block is used automatically, and existing commands like savedefault or > save_env do not need to change. > > Signed-off-by: Michael Chang > Reviewed-by: Neal Gompa Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v3 5/9] util/grub-editenv: wire unset_variables to optional fs_envblk

2025-10-02 Thread Daniel Kiper
On Thu, Oct 02, 2025 at 02:46:18PM +0800, Michael Chang via Grub-devel wrote: > This patch updates unset_variables so that removals are also applied to Again s/unset_variables/unset_variables()/... > the external environment block when it is present. The code opens the > external block, deletes t

Re: [PATCH v3 4/9] util/grub-editenv: wire set_variables to optional fs_envblk

2025-10-02 Thread Daniel Kiper
On Thu, Oct 02, 2025 at 02:46:17PM +0800, Michael Chang via Grub-devel wrote: > This patch changes set_variables so that it can use an external s/set_variables/set_variables()/ In general please mark function names in the commit messages and comments with "()". > environment block when one is pr

Re: [PATCH v3 3/9] util/grub-editenv: add fs_envblk write helper

2025-10-02 Thread Daniel Kiper
for an external environment block is complete. The > choice of which variables should be written externally will be handled > by later patches. > > Signed-off-by: Michael Chang > Reviewed-by: Neal Gompa Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v3 2/9] util/grub-editenv: add fs_envblk open helper

2025-10-02 Thread Daniel Kiper
On Thu, Oct 02, 2025 at 02:46:15PM +0800, Michael Chang via Grub-devel wrote: > This patch adds the logic to locate and open an environment block that > is stored in a reserved area on the device. It introduces the function > fs_envblk_open together with helper routines to read the block pointed s

Re: [PATCH v3 1/9] util/grub-editenv: add basic structures and probe call for external envblk

2025-10-02 Thread Daniel Kiper
On Thu, Oct 02, 2025 at 02:46:14PM +0800, Michael Chang via Grub-devel wrote: > This patch prepares for using an environment block stored in a reserved > area of the filesystem. It adds a constant ENV_BTRFS_OFFSET at 256 KiB > in the Btrfs header. It also introduces the fs_envblk_spec and fs_envblk

Re: [PATCH] hfsplus: Allow reading files created by Mac OS 9

2025-10-02 Thread Daniel Kiper
On Wed, Oct 01, 2025 at 05:03:48PM -0400, Dave Vasilevsky wrote: > The `permissions` field of hfsplus files is only used by Mac OS X. This > causes Grub to skip reading files created by Mac OS 9, since their > file mode is read as unknown. Instead, assume files with zero mode > are regular files. >

Re: [PATCH] loader/i386/linux: Transfer EDID information to kernel

2025-10-02 Thread Daniel Kiper
ecent addition of the efidrm > and vesadrm drivers to the kernel, it becomes much more useful. As with > the initial screen setup, these drivers can make use of the provided > EDID information for basic display output. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Kipe

Re: [PATCH v13 11/20] powerpc_ieee1275: Read the db and dbx secure boot variables

2025-10-01 Thread Daniel Kiper
On Tue, Sep 30, 2025 at 05:10:05PM +0530, Sudhakar Kuppusamy wrote: > Enhancing the infrastructure to enable the Platform Keystore (PKS) feature, > which provides access to the SB_VERSION, db, and dbx secure boot variables > from PKS. > > If PKS is enabled, it will read secure boot variables such a

Re: [PATCH v3] command/extcmd: perform explicit NULL check in both the unregister helpers

2025-10-01 Thread Daniel Kiper
On Mon, Sep 29, 2025 at 05:47:59PM +0530, Srish Srinivasan wrote: > On 9/29/25 5:25 PM, Daniel Kiper wrote: > > On Mon, Sep 22, 2025 at 11:32:46AM +0530, Srish Srinivasan wrote: > > > During command registration, grub_register_command_prio > > > returns a 0 when t

Re: [PATCH v3] command/extcmd: perform explicit NULL check in both the unregister helpers

2025-09-29 Thread Daniel Kiper
erger Patch LGTM to me but it does not seem to be posted earlier to the grub-devel. So, I cannot accept Sudhakar's and Stefan's RBs until they are confirmed here. Though Reviewed-by: Daniel Kiper ... Daniel ___ Grub-devel mailing list Gr

Re: [PATCH v2 1/2] Make grub_error() more verbose

2025-09-29 Thread Daniel Kiper
On Wed, Sep 24, 2025 at 10:55:11PM +0300, Vladimir 'phcoder' Serbinenko wrote: > What is the influence on core.img size on i386-pc? Are we still within our > promises for supporting 31K gaps with simple config? Vladimir, long time ago we stated that this setup is not recommended [1] and I think we

Re: [PATCH v12 21/22] docs/grub: Document signing GRUB with an appended signature

2025-09-25 Thread Daniel Kiper
On Mon, Sep 22, 2025 at 02:58:02PM +0530, Sudhakar Kuppusamy wrote: > Signing GRUB for firmware that verifies an appended signature is a > bit fiddly. I don't want people to have to figure it out from scratch > so document it here. > > Signed-off-by: Daniel Axtens > Signed-off-by: Sudhakar Kuppusa

Re: [PATCH v12 18/22] appended signatures: GRUB commands to manage the hashes

2025-09-25 Thread Daniel Kiper
On Mon, Sep 22, 2025 at 02:57:59PM +0530, Sudhakar Kuppusamy wrote: > Introducing the following GRUB commands to manage certificate/binary > hashes. > > 1. append_list_dbx: > Show the list of distrusted certificates and binary/certificate > hashes from the dbx list. > 2. append_add_

Re: [PATCH v12 15/22] appended signatures: GRUB commands to manage the certificates

2025-09-25 Thread Daniel Kiper
On Mon, Sep 22, 2025 at 02:57:56PM +0530, Sudhakar Kuppusamy wrote: > Introducing the following GRUB commands to manage the certificates. > > 1. append_list_db: > Show the list of trusted certificates from the db list > 2. append_add_db_cert: > Add the trusted certificate to the db li

Re: [PATCH v12 17/22] appended signatures: Read default db keys from the ELF Note

2025-09-25 Thread Daniel Kiper
On Thu, Sep 25, 2025 at 05:19:33PM +0200, Daniel Kiper wrote: > On Mon, Sep 22, 2025 at 02:57:58PM +0530, Sudhakar Kuppusamy wrote: > > If secure boot is enabled with dynamic key management mode and the > > use_static_keys flag is set, then read the static keys as a db default &g

Re: [PATCH v12 17/22] appended signatures: Read default db keys from the ELF Note

2025-09-25 Thread Daniel Kiper
On Mon, Sep 22, 2025 at 02:57:58PM +0530, Sudhakar Kuppusamy wrote: > If secure boot is enabled with dynamic key management mode and the > use_static_keys flag is set, then read the static keys as a db default > keys from the GRUB ELF Note and add them into the db list. > > Signed-off-by: Sudhakar

Re: [PATCH v2 1/2] Make grub_error() more verbose

2025-09-24 Thread Daniel Kiper
On Tue, Sep 23, 2025 at 05:33:31PM -0600, Leo Sandoval via Grub-devel wrote: > From: Peter Jones > > Signed-off-by: Peter Jones For both patches Reviewed-by: Daniel Kiper ... Next time please add a cover letter to the patch series..

Re: [PATCH v12 13/22] appended signatures: Create db and dbx lists

2025-09-24 Thread Daniel Kiper
On Mon, Sep 22, 2025 at 02:57:54PM +0530, Sudhakar Kuppusamy wrote: > If secure boot is enabled with static key management mode, the trusted > certificates will be extracted from the GRUB ELF Note and added to db list. > > If secure boot is enabled with dynamic key management mode, the trusted > ce

Re: [PATCH v12 11/22] powerpc_ieee1275: Read the db and dbx secure boot variables

2025-09-24 Thread Daniel Kiper
On Mon, Sep 22, 2025 at 02:57:52PM +0530, Sudhakar Kuppusamy wrote: > Enhancing the infrastructure to enable the Platform Keystore (PKS) feature, > which provides access to the SB_VERSION, db, and dbx secure boot variables > from PKS. > > If PKS is enabled, it will read secure boot variables such a

Re: [PATCH 2/8] util/grub-editenv: add fs_envblk open helper

2025-09-05 Thread Daniel Kiper
On Tue, Sep 02, 2025 at 02:45:58PM +0800, Michael Chang via Grub-devel wrote: > This patch adds the logic to locate and open an environment block that > is stored in a reserved area on the device. It introduces the function > fs_envblk_open together with helper routines to read the block pointed >

Re: [PATCH 4/8] util/grub-editenv: wire set_variables to optional fs_envblk

2025-09-05 Thread Daniel Kiper
On Tue, Sep 02, 2025 at 02:46:00PM +0800, Michael Chang via Grub-devel wrote: > This patch changes set_variables so that it can use an external > environment block when one is present. The variable next_entry is > written into the external block, env_block is treated as read only, and > all other v

Re: [PATCH 0/8] Add support for external environment block on Btrfs

2025-09-05 Thread Daniel Kiper
On Tue, Sep 02, 2025 at 02:45:56PM +0800, Michael Chang via Grub-devel wrote: > This patch series adds support for storing the GRUB environment block in > a reserved area of the Btrfs header. On copy on write filesystems such > as Btrfs, the normal file based envblk cannot be updated safely at > ru

Re: [PATCH 3/8] util/grub-editenv: add fs_envblk write helper

2025-09-05 Thread Daniel Kiper
On Tue, Sep 02, 2025 at 02:45:59PM +0800, Michael Chang via Grub-devel wrote: > This patch adds the function fs_envblk_write to update the reserved > environment block on disk. The helper takes an in memory envblk buffer > and writes it back to the device at the location defined by the > fs_envblk

Re: [PATCH 1/8] util/grub-editenv: add basic structures and probe call for external envblk

2025-09-05 Thread Daniel Kiper
On Tue, Sep 02, 2025 at 02:45:57PM +0800, Michael Chang via Grub-devel wrote: > This patch prepares for using an environment block stored in a reserved > area of the filesystem. It adds a constant ENV_BTRFS_OFFSET at 256 KiB Where this value come from? Please explain how did you come up with it? W

Re: [PATCH v2] tcp: Fix TCP port number reused on reboot

2025-09-04 Thread Daniel Kiper
n 100 > connections total, well below the reuse threshold. This makes the > approach robust against short reboot intervals while keeping the logic > simple and deterministic. > > Signed-off-by: Michael Chang > Reviewed-by: Sudhakar Kuppusamy Reviewed-by: Daniel Kiper Dan

Re: [PATCH v8] efi: new 'connectefi' command

2025-09-04 Thread Daniel Kiper
On Tue, Sep 02, 2025 at 01:56:50PM +0200, Renaud Métrich via Grub-devel wrote: > When network booting is used, trying to chainload to the local disk > (which is used in deployment tools such as Red Hat Satellite) may fail > when searching for the boot loader, e.g. /EFI/redhat/shimx64.efi: > the boo

Re: [PATCH v2] lsefi: fixed memory leaks

2025-09-04 Thread Daniel Kiper
On Tue, Sep 02, 2025 at 01:55:15PM +0200, Renaud Métrich via Grub-devel wrote: > Signed-off-by: Renaud Métrich > --- > grub-core/commands/efi/lsefi.c | 4 > include/grub/efi/efi.h | 27 +++ > 2 files changed, 31 insertions(+) > > diff --git a/grub-core/comman

Re: [PATCH v9 20/21] docs/grub: Document signing GRUB with an appended signature

2025-09-03 Thread Daniel Kiper
On Mon, Aug 25, 2025 at 04:38:42PM +0530, Sudhakar Kuppusamy wrote: > Signing GRUB for firmware that verifies an appended signature is a > bit fiddly. I don't want people to have to figure it out from scratch > so document it here. > > Signed-off-by: Daniel Axtens > Signed-off-by: Sudhakar Kuppusa

Re: [PATCH v9 21/21] docs/grub: Document appended signature

2025-09-02 Thread Daniel Kiper
On Mon, Aug 25, 2025 at 04:38:43PM +0530, Sudhakar Kuppusamy wrote: > This explains how appended signatures can be used to form part of > a secure boot chain, and documents the commands and variables > introduced. > > Signed-off-by: Daniel Axtens > Signed-off-by: Sudhakar Kuppusamy > Reviewed-by:

Re: [PATCH] util/grub-image: fix riscv32 relocation offset

2025-09-02 Thread Daniel Kiper
s patch adds an explicit int64_t cast to compute the offset as a > 64bit subtraction. > > Signed-off-by: Anaëlle Cazuc Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] b64dec: use grub_size_t for function definition

2025-09-02 Thread Daniel Kiper
ing grub_size_t in the definition prototype > > Signed-off-by: Anaëlle Cazuc Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] tests: Add test ISO files to Dist Package

2025-09-02 Thread Daniel Kiper via Grub-devel
On Sun, Aug 31, 2025 at 09:40:49PM -0500, Andrew Hamilton wrote: > Add test ISO files to dist package to allow ISO test to > pass. > > Signed-off-by: Andrew Hamilton Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-d

Re: [PATCH] libgcrypt: Allow GRUB to Build With Clang

2025-09-02 Thread Daniel Kiper via Grub-devel
Clang "typedef-redefinition" warnings. This required an update > to crypto.h and the import_gcry.py script to add the pragma > to libgcrypt-grub's types.h due to "u16" and similar types. > > Signed-off-by: Andrew Hamilton Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH v9 17/21] appended signatures: Introduce GRUB commands to access db and dbx

2025-08-28 Thread Daniel Kiper
On Mon, Aug 25, 2025 at 04:38:39PM +0530, Sudhakar Kuppusamy wrote: > Introducing the following db and dbx commands > > 1. append_list_db: > Show the list of trusted certificates and binary hashes > from the db list. > 2. append_list_dbx: > Show the list of distrusted certific

Re: [PATCH v9 16/21] appended signatures: Read default db keys from the ELF Note

2025-08-28 Thread Daniel Kiper
On Mon, Aug 25, 2025 at 04:38:38PM +0530, Sudhakar Kuppusamy wrote: > If Secure Boot is enabled with dynamic key management mode and the > use_static_keys flag is not set, then read the keys from the PKS > keystore as well from ELF Note, and add them into the db. > Otherwise, it only reads the stat

Re: [PATCH v9 08/21] appended signatures: Parse X.509 certificates

2025-08-28 Thread Daniel Kiper
# key usage issue > Signed-off-by: Daniel Axtens > Signed-off-by: Sudhakar Kuppusamy > Reviewed-by: Stefan Berger > Reviewed-by: Avnish Chouhan > Reviewed-by: Daniel Kiper > --- > grub-core/commands/appendedsig/appendedsig.h | 38 + > grub-core/commands/appendedsig/x

Re: [PATCH v9 13/21] appended signatures: Create db and dbx lists

2025-08-28 Thread Daniel Kiper
On Mon, Aug 25, 2025 at 04:38:35PM +0530, Sudhakar Kuppusamy wrote: > If secure boot is enabled with static key management mode, the trusted > certificates will be extracted from the GRUB ELF Note and added to db list. > > If secure boot is enabled with dynamic key management mode, the trusted > ce

Re: [PATCH v9 11/21] appended signatures: Introducting GRUB commands to manage the db list

2025-08-28 Thread Daniel Kiper
On Wed, Aug 27, 2025 at 10:07:35PM +0530, Sudhakar Kuppusamy wrote: > Thank you Daniel for the review. > > > On 27 Aug 2025, at 9:11 PM, Daniel Kiper wrote: > > On Mon, Aug 25, 2025 at 04:38:33PM +0530, Sudhakar Kuppusamy wrote: [...] > >> +static grub_comman

Re: [PATCH v6 0/2] Support dates outside of 1901..2038 range

2025-08-28 Thread Daniel Kiper via Grub-devel
comment to "Leap year, after Feb" instead of "prior to Feb" > Add "reviewed by" from Daniel Kiper for patches with permission. > > V4 -> V5: > datetime.c / h: > Rename variables "is_bisextile" to "bisextile". > Change some boolean a

Re: [PATCH v9 12/21] powerpc_ieee1275: Read the db and dbx secure boot variables

2025-08-27 Thread Daniel Kiper
On Mon, Aug 25, 2025 at 04:38:34PM +0530, Sudhakar Kuppusamy wrote: > Enhancing the infrastructure to enable the Platform Keystore (PKS) feature, > which provides access to the SB_VERSION, db, and dbx secure boot variables > from PKS. > > If PKS is enabled, it will read secure boot variables such a

Re: [PATCH v9 11/21] appended signatures: Introducting GRUB commands to manage the db list

2025-08-27 Thread Daniel Kiper
ate to the db list > 3. append_rm_dbx_cert: > Remove the distrusted certificate from the db list > 4. append_verify: > Verify the signed file using db list > > Signed-off-by: Daniel Axtens > Signed-off-by: Sudhakar Kuppusamy Reviewed-by: Daniel Kiper Just

Re: [PATCH v9 10/21] appended signatures: Support verifying appended signatures

2025-08-27 Thread Daniel Kiper
n will be enabled, and trusted > keys will be extracted from the GRUB ELF Note and stored in the db and > locked automatically. > > Signed-off-by: Daniel Axtens > Signed-off-by: Sudhakar Kuppusamy Except two nits below Reviewed-by: Daniel Kiper ... [...] > diff --git a/grub-core/c

Re: [PATCH v5 2/2] date_unit_test: test dates outside of 32-bit unix range

2025-08-27 Thread Daniel Kiper via Grub-devel
On Tue, Aug 26, 2025 at 09:11:10PM -0500, Andrew Hamilton wrote: > Add tests outside the date range possible with 32-bit time > calculation. Also add a few more nominal date/time test values > to the 32-bit "tests" array. Add min / max tests for years 0001 > and . > > Signed-off-by: Vladimir Se

Re: [PATCH v5 1/2] datetime: Support dates outside of 1901..2038 range

2025-08-27 Thread Daniel Kiper via Grub-devel
On Tue, Aug 26, 2025 at 09:11:09PM -0500, Andrew Hamilton wrote: > Support dates outside of 1901..2038. > > Fixes: https://savannah.gnu.org/bugs/?63894 > Fixes: https://savannah.gnu.org/bugs/?66301 > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > grub-core/lib/date

Re: [PATCH v4 1/2] datetime: Support dates outside of 1901..2038 range

2025-08-26 Thread Daniel Kiper via Grub-devel
On Tue, Aug 26, 2025 at 10:28:08AM -0500, Andrew Hamilton wrote: > I will make the requested changes tonight in a v5. > > Just so I understand, is there some coding standard for preferring ternary > operators and comparing bools to true? No, I have not seen one but I think if we have defined const

Re: [PATCH v4 2/2] date_unit_test: test dates outside of 32-bit unix range

2025-08-26 Thread Daniel Kiper via Grub-devel
On Mon, Aug 25, 2025 at 10:17:38PM -0500, Andrew Hamilton wrote: > Add tests outside the date range possible with 32-bit time > calculation. > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > tests/date_unit_test.c | 44 +- > 1

Re: [PATCH v4 1/2] datetime: Support dates outside of 1901..2038 range

2025-08-26 Thread Daniel Kiper via Grub-devel
On Mon, Aug 25, 2025 at 10:17:37PM -0500, Andrew Hamilton wrote: > Support dates outside of 1901..2038. > > Fixes: https://savannah.gnu.org/bugs/?63894 > Fixes: https://savannah.gnu.org/bugs/?66301 > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > grub-core/lib/date

Re: [PATCH v3 2/2] date_unit_test: test dates outside of 32-bit unix range

2025-08-25 Thread Daniel Kiper via Grub-devel
On Fri, Apr 18, 2025 at 09:54:00AM -0500, Andrew Hamilton wrote: > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > static void [...] > date_test_iter (void) > { > - grub_int32_t tests[] = { -1, 0, +1, -2133156255, GRUB_INT32_MIN, > + grub_int32_t tests[] = { -1, 0, +1

Re: [PATCH v3 2/2] date_unit_test: test dates outside of 32-bit unix range

2025-08-25 Thread Daniel Kiper via Grub-devel
On Fri, Apr 18, 2025 at 09:54:00AM -0500, Andrew Hamilton wrote: > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > tests/date_unit_test.c | 35 ++- > 1 file changed, 26 insertions(+), 9 deletions(-) > > diff --git a/tests/date_unit_test

Re: [PATCH v3 1/2] datetime: Support dates outside of 1901..2038 range

2025-08-25 Thread Daniel Kiper via Grub-devel
On Fri, Apr 18, 2025 at 09:53:59AM -0500, Andrew Hamilton wrote: > Support dates outside of 1901..2038. > > Fixes: https://savannah.gnu.org/bugs/?63894 > Fixes: https://savannah.gnu.org/bugs/?66301 > > Signed-off-by: Vladimir Serbinenko > Signed-off-by: Andrew Hamilton > --- > grub-core/lib/date

Re: [PATCH v2 1/1] bootstrap: Ensure shallow GNULIB clone Works on Newer GIT

2025-08-25 Thread Daniel Kiper via Grub-devel
ulled the latest GNULIB version > from GNULIB GIT, commit 9a1a6385 > This change avoids a full clone on GNULIB, saving > something like 50 MB. > > Fixes: https://savannah.gnu.org/bugs/?66357 > > Signed-off-by: Andrew Hamilton OK, let's

Re: [PATCH 0/4] Several GRUB documentation improvements

2025-08-25 Thread Daniel Kiper via Grub-devel
x Wording > docs: Document New libgrypt Modules > docs: Update Future Section to Reflect Current Release > docs: Correct Some URLs For all patches Reviewed-by: Daniel Kiper ... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gn

Re: [PATCH 0/2] Document grub-protect Dependency and Cleanup

2025-08-25 Thread Daniel Kiper via Grub-devel
2): > INSTALL: Document Libtasn1 Needed for grub-protect > BUGS: Update to Point to Bug Tracking System For both patches Reviewed-by: Daniel Kiper ... Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/1] po: Update Translations to Build with Gettext 0.26

2025-08-25 Thread Daniel Kiper via Grub-devel
ines use the correct escape > sequence. > > This avoids build errors such as: > d...@hebrew.po:8192: 'msgstr' is not a valid Shell printf format string, > unlike 'msgid'. Reason: This escape sequence is invalid. > > Fixes: https://savannah.gnu.org/bugs/?67353 >

Re: [PATCH v8 11/20] powerpc_ieee1275: Read the db and dbx secure boot variables

2025-08-22 Thread Daniel Kiper
On Thu, Aug 21, 2025 at 01:25:04PM +0530, Sudhakar Kuppusamy wrote: > Enhancing the infrastructure to enable the Platform Keystore (PKS) feature, > which provides access to the SB_VERSION, db, and dbx secure boot variables > from PKS. > > If PKS is enabled, it will read secure boot variables such a

GRUB 2.14 release

2025-08-22 Thread Daniel Kiper via Grub-devel
Hi, It is time to start planning 2.14 release. Sadly once again we are behind the schedule mostly due to lack of resources. I do not like it but it is what it is. I am working on improving situation but it goes slow. Though there is a chance for some improvements after 2.14 release... Anyway, at

Re: [PATCH v8 10/20] appended signatures: Support verifying appended signatures

2025-08-21 Thread Daniel Kiper
On Thu, Aug 21, 2025 at 01:25:03PM +0530, Sudhakar Kuppusamy wrote: > Building on the parsers and the ability to embed X.509 certificates, as > well as the existing gcrypt functionality, add a module for verifying > appended signatures. > > This includes a verifier that requires that Linux kernels

Re: [PATCH] Support environment block in btrfs reserved area

2025-08-21 Thread Daniel Kiper
On Fri, Jul 11, 2025 at 12:21:11PM +0800, Michael Chang via Grub-devel wrote: > On Btrfs, GRUB cannot update the environment block (grubenv) because > file based writes via blocklists are incompatible with Btrfs COW (Copy > On Write) design. Although GRUB’s filesystem drivers are read only, > envir

Re: [PATCH] efi/console: treat scan_code 0x0102 (suspend) as enter.

2025-08-21 Thread Daniel Kiper
> > On such devices, the power key is commonly used as the "Enter" (confirm) > button, > since no dedicated Enter key exists. This patch treats scan_code 0x0102 > as Enter to improve usability on these platforms. > > Signed-off-by: Kan

Re: [PATCH] util/bash-completion.d/Makefile.am: s/mkrescure/mkrescue/g

2025-08-21 Thread Daniel Kiper
On Tue, Aug 19, 2025 at 02:13:10PM +0100, k...@mkukri.xyz wrote: > From: Mate Kukri > > This is a typo that was stopping this bash-completion from being > installed. > > Signed-off-by: Mate Kukri Reviewed-by: Daniel Kiper Daniel

Re: [PATCH v5 3/3] kern/xen: Add Xen command line parsing

2025-08-18 Thread Daniel Kiper
nv_". This also allows room for expanding the command line > arguments accepted by GRUB in the future, should other arguments end up > becoming desirable in the future. > > Signed-off-by: Aaron Rainbolt Reviewed-by: Daniel Kiper ... but two nits below.

Re: [PATCH v5 2/3] include/xen: Add warning comment for cmd_line

2025-08-18 Thread Daniel Kiper
mment so future consumers of > this field know to check it for a NUL terminator before using it. > > Signed-off-by: Aaron Rainbolt Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v6 0/5] Add commands to load BLS and UKI files

2025-08-18 Thread Daniel Kiper via Grub-devel
c: Change offset type for grub_util_write_image_at() > blsuki: Add uki command to load Unified Kernel Image entries > > Peter Jones (1): > blsuki: Add blscfg command to parse Boot Loader Specification snippets > > Robbie Harwood (1): > blsuki: Check for mo

Re: [PATCH v6 1/5] kern/misc: Implement grub_strtok()

2025-08-14 Thread Daniel Kiper via Grub-devel
s to implement the code in the GRUB based > on gnulib's implementation. For more information on these functions, visit the > Linux Programmer's Manual("man strtok"). > > Signed-off-by: Alec Brown Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH v6 20/20] docs/grub: Document appended signature

2025-08-14 Thread Daniel Kiper
On Tue, Jul 29, 2025 at 08:21:56PM +0530, Sudhakar Kuppusamy wrote: > This explains how appended signatures can be used to form part of > a secure boot chain, and documents the commands and variables > introduced. > > Signed-off-by: Daniel Axtens > Signed-off-by: Sudhakar Kuppusamy > Reviewed-by:

Re: [PATCH v6 19/20] docs/grub: Document signing GRUB with an appended signature

2025-08-13 Thread Daniel Kiper
On Tue, Jul 29, 2025 at 08:21:55PM +0530, Sudhakar Kuppusamy wrote: > Signing GRUB for firmware that verifies an appended signature is a > bit fiddly. I don't want people to have to figure it out from scratch > so document it here. > > Signed-off-by: Daniel Axtens > Signed-off-by: Sudhakar Kuppusa

Re: [PATCH v6 16/20] appended signatures: Introduce GRUB commands to access db and dbx

2025-08-13 Thread Daniel Kiper
On Tue, Jul 29, 2025 at 08:21:52PM +0530, Sudhakar Kuppusamy wrote: > Introducing the following db and dbx commands > > 1. append_list_db: > Show the list of trusted certificates and binary hashes > from the db list. > 2. append_list_dbx: > Show the list of distrusted certific

Re: [PATCH v6 15/20] appended signatures: Read default db keys from the ELF Note

2025-08-13 Thread Daniel Kiper
On Tue, Jul 29, 2025 at 08:21:51PM +0530, Sudhakar Kuppusamy wrote: > If Secure Boot is enabled with dynamic key management mode and the > use_static_keys flag is set, then read the static keys as a db default > keys from the ELF Note and add stored in the db list. s/stored in the db list/them int

Re: [PATCH v6 10/20] appended signatures: Support verifying appended signatures

2025-08-13 Thread Daniel Kiper
On Tue, Aug 12, 2025 at 05:16:22PM +0530, Sudhakar Kuppusamy wrote: > > On 12 Aug 2025, at 5:00 PM, Daniel Kiper wrote: > > On Tue, Aug 12, 2025 at 10:30:55AM +0530, Sudhakar Kuppusamy wrote: > >> Thank you Daniel. > >> > >>> On 11 Aug 2025, at 9:24 PM,

Re: [PATCH v4 2/2] kern/xen: Add Xen command line parsing

2025-08-13 Thread Daniel Kiper
On Tue, Aug 12, 2025 at 06:55:15PM -0500, Aaron Rainbolt wrote: > On Tue, 12 Aug 2025 19:02:11 +0200 Daniel Kiper wrote: > > On Mon, Aug 04, 2025 at 11:50:09PM -0500, Aaron Rainbolt wrote: > > > Xen traditionally allows customizing guest behavior by passing > > > arg

Re: [PATCH v4 2/2] kern/xen: Add Xen command line parsing

2025-08-12 Thread Daniel Kiper
On Mon, Aug 04, 2025 at 11:50:09PM -0500, Aaron Rainbolt wrote: > Xen traditionally allows customizing guest behavior by passing arguments > to the VM kernel via the kernel command line. This is no longer possible > when using GRUB with Xen, as the kernel command line is decided by the > GRUB confi

Re: [PATCH v4 1/2] include/xen: Rename MAX_GUEST_CMDLINE to GRUB_XEN_MAX_GUEST_CMDLINE

2025-08-12 Thread Daniel Kiper
Aaron Rainbolt Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2] relocator: Switch to own page table while moving chunks

2025-08-12 Thread Daniel Kiper
. > > Fixes 64-bit GhostBSD on 64-bit EFI > > Signed-off-by: Vladimir Serbinenko Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v6 12/20] appended signatures: Create db and dbx lists

2025-08-12 Thread Daniel Kiper
On Mon, Aug 11, 2025 at 11:04:03PM +0530, Sudhakar Kuppusamy wrote: > Thank you Daniel. > > > On 11 Aug 2025, at 10:51 PM, Daniel Kiper wrote: > > On Tue, Jul 29, 2025 at 08:21:48PM +0530, Sudhakar Kuppusamy wrote: [...] > >> + else if (grub_pks_use_keystore ==

Re: [PATCH v6 11/20] powerpc_ieee1275: Read the db and dbx secure boot variables

2025-08-12 Thread Daniel Kiper
On Mon, Aug 11, 2025 at 10:10:12PM +0530, Sudhakar Kuppusamy wrote: > Thank you Daniel. > > > On 11 Aug 2025, at 9:54 PM, Daniel Kiper wrote: > > > > On Tue, Jul 29, 2025 at 08:21:47PM +0530, Sudhakar Kuppusamy wrote: > >> Enhancing the infrastructure to enable th

Re: [PATCH v6 10/20] appended signatures: Support verifying appended signatures

2025-08-12 Thread Daniel Kiper
On Tue, Aug 12, 2025 at 10:30:55AM +0530, Sudhakar Kuppusamy wrote: > Thank you Daniel. > > > On 11 Aug 2025, at 9:24 PM, Daniel Kiper wrote: > > On Tue, Jul 29, 2025 at 08:21:46PM +0530, Sudhakar Kuppusamy wrote: [...] > >> + if (is_cert_removed_from_db (ce

Re: [PATCH v6 12/20] appended signatures: Create db and dbx lists

2025-08-11 Thread Daniel Kiper
On Tue, Jul 29, 2025 at 08:21:48PM +0530, Sudhakar Kuppusamy wrote: > If secure boot is enabled with static key management mode, the trusted > certificates will be extracted from the GRUB ELF Note and added to db list. > This is introduced by a subsequent patch. > > If secure boot is enabled with d

Re: [PATCH v6 11/20] powerpc_ieee1275: Read the db and dbx secure boot variables

2025-08-11 Thread Daniel Kiper
On Tue, Jul 29, 2025 at 08:21:47PM +0530, Sudhakar Kuppusamy wrote: > Enhancing the infrastructure to enable the Platform Keystore (PKS) feature, > which provides access to the SB_VERSION, db, and dbx secure boot variables > from PKS. > > If secure boot is enabled with dynamic key management mode,

Re: [PATCH v6 10/20] appended signatures: Support verifying appended signatures

2025-08-11 Thread Daniel Kiper
On Tue, Jul 29, 2025 at 08:21:46PM +0530, Sudhakar Kuppusamy wrote: > Building on the parsers and the ability to embed X.509 certificates, as > well as the existing gcrypt functionality, add a module for verifying > appended signatures. > > This includes a verifier that requires that Linux kernels

Re: [PATCH vRESEND] relocator: Switch to own page table while moving chunks on x86-64

2025-08-11 Thread Daniel Kiper
On Fri, May 17, 2024 at 10:46:28AM +0300, Vladimir Serbinenko wrote: > We need to avoid clobering existing table between starting of chunk movers > and the moment we install target page table. Generate temporary table for > this rather than hoping that we don't clober existing one. > > Fixes 64-bit

Re: [PATCH v5 5/5] blsuki: Add uki command to load Unified Kernel Image entries

2025-08-05 Thread Daniel Kiper via Grub-devel
On Sun, Jul 27, 2025 at 01:54:36AM +, Alec Brown wrote: > A Unified Kernel Image is a single UEFI PE file that combines a UEFI boot > stub, > a Linux kernel image, an initrd, and further resources. The uki command will > locate where the UKI file is and create a GRUB menu entry to load it. > >

Re: [PATCH v5 4/5] blsuki: Check for mounted /boot in emu

2025-08-04 Thread Daniel Kiper via Grub-devel
On Sun, Jul 27, 2025 at 01:54:35AM +, Alec Brown wrote: > From: Robbie Harwood > > Irritatingly, BLS defines paths relative to the mountpoint of the > filesystem which contains its snippets, not / or any other fixed > location. So grub2-emu needs to know whether /boot is a separate > filesyste

Re: [PATCH v5 3/5] util/misc.c: Change offset type for grub_util_write_image_at()

2025-08-04 Thread Daniel Kiper via Grub-devel
type from off_t to > grub_off_t. > > Signed-off-by: Alec Brown Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v5 2/5] blsuki: Add blscfg command to parse Boot Loader Specification snippets

2025-08-04 Thread Daniel Kiper via Grub-devel
On Sun, Jul 27, 2025 at 01:54:33AM +, Alec Brown wrote: > From: Peter Jones > > The BootLoaderSpec (BLS) defines a scheme where different bootloaders can > share a format for boot items and a configuration directory that accepts > these common configurations as drop-in files. > > The BLS Speci

Re: [PATCH v5 1/5] kern/misc: Implement grub_strtok()

2025-08-04 Thread Daniel Kiper via Grub-devel
On Fri, Aug 01, 2025 at 04:51:54PM +0300, Vladimir 'phcoder' Serbinenko wrote: > Please don't put it into kernel unless it's used by the kernel. lib/ would be > a > better fit Whole family of grub_str*() functions live in grub-core/kern/misc.c. So, I am not sure why we should make an exception he

Re: [RESEND PATCH v3 1/1] kern/xen: Add Xen command line parsing

2025-08-04 Thread Daniel Kiper
On Sun, Aug 03, 2025 at 10:57:03AM -0500, Aaron Rainbolt wrote: > On Fri, 1 Aug 2025 14:55:36 +0200 Daniel Kiper wrote: > > On Fri, Jul 25, 2025 at 03:31:12PM -0500, Aaron Rainbolt wrote: > > > Xen traditionally allows customizing guest behavior by passing > > > argumen

Re: [PATCH v5 1/5] kern/misc: Implement grub_strtok()

2025-08-01 Thread Daniel Kiper via Grub-devel
On Mon, Jul 28, 2025 at 02:21:50PM +0100, Frediano Ziglio wrote: > On Sun, Jul 27, 2025 at 2:57 AM Alec Brown via Grub-devel > wrote: > > > > Add the functions grub_strtok() and grub_strtok_r() to help parse strings > > into > > tokens separated by characters in the 'delim' parameter. These func

Re: [PATCH v5 1/5] kern/misc: Implement grub_strtok()

2025-08-01 Thread Daniel Kiper via Grub-devel
s to implement the code in the GRUB based > on gnulib's implementation. For more information on these functions, visit the > Linux Programmer's Manual("man strtok"). > > Signed-off-by: Alec Brown Reviewed-by: Daniel Kiper Daniel ___

Re: [RESEND PATCH v3 1/1] kern/xen: Add Xen command line parsing

2025-08-01 Thread Daniel Kiper
On Fri, Jul 25, 2025 at 03:31:12PM -0500, Aaron Rainbolt wrote: > Xen traditionally allows customizing guest behavior by passing arguments > to the VM kernel via the kernel command line. This is no longer possible > when using GRUB with Xen, as the kernel command line is decided by the > GRUB confi

Re: [RESEND PATCH v3 0/1] kern/xen: Add Xen command line parsing

2025-07-25 Thread Daniel Kiper
On Fri, Jul 25, 2025 at 09:31:28AM -0500, Aaron Rainbolt wrote: > On Fri, Jul 25, 2025 at 7:43 AM Daniel Kiper wrote: > > > > Hey, > > > > I will review this patch set when you CC Xen-devel ML. I have asked > > about this last time... > > Hi Daniel, the V3 v

  1   2   3   4   5   6   7   8   9   10   >