Re: [PATCH] BUG/MINOR: cfgparse: Fix type of second calloc() parameter

On Fri, Feb 21, 2020 at 12:59:53PM +0100, Tim Düsterhus wrote: > Willy, > > Am 16.02.20 um 12:36 schrieb Tim Düsterhus: > >> instead of sizeof(*pointer) because these are hard to find the day the > >> type changes and can cause bugs later. > >> > >> So I'd rather tag it as cleanup and not backport

Re: [PATCH 0/2] Stop negating (un|)likely

Hi Tim, On Fri, Feb 21, 2020 at 01:02:02PM +0100, Tim Duesterhus wrote: > Willy, > > I'm not sure whether there is a deeper purpose behind the old versions, but > I found them hard to read when stumbling upon them in the code. Especially > the ones in net_helper. I agree. There was a reason for

Re: Segfault on HAProxy 2.0.11 on HTX mode

Le 19/02/2020 à 11:35, Olivier D a écrit : Hello, I would like to report a segfault on HAProxy 2.0.11 ; this version has been running fine for two months, and this morning starting segfaulting over and over. Mitigation was performed by adding "no option http-use-htx" on 'defaults' block. I kn

[PATCH 2/2] CLEANUP: net_helper: Do not negate the result of unlikely

This patch turns the double negation of 'not unlikely' into 'likely' and then turns the negation of 'not smaller' into 'greater or equal' in an attempt to improve readability of the condition. --- include/common/net_helper.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 0/2] Stop negating (un|)likely

Willy, I'm not sure whether there is a deeper purpose behind the old versions, but I found them hard to read when stumbling upon them in the code. Especially the ones in net_helper. Please carefully check that I did not break anything and that the intended optimizations still apply. Best regards

[PATCH 1/2] CLEANUP: conn: Do not pass a pointer to likely

Move the `!` inside the likely and negate it to unlikely. The previous version should not have caused issues, because it is converted to a boolean / integral value before being passed to __builtin_expect(), but it's certainly unusual. --- include/proto/connection.h | 4 ++-- 1 file changed, 2 ins

Re: [PATCH] BUG/MINOR: cfgparse: Fix type of second calloc() parameter

Willy, Am 16.02.20 um 12:36 schrieb Tim Düsterhus: >> instead of sizeof(*pointer) because these are hard to find the day the >> type changes and can cause bugs later. >> >> So I'd rather tag it as cleanup and not backport it since it will not >> change the output code. > > I'm fine with that. I

Re: haproxy 2.1.2 and 2.1.3

On 02/21/2020 12:32 PM, Tim Düsterhus wrote: Miroslav, I order to save you duplicated effort in helping I'd like to let you know that Marcel also created a GitHub issue upon request from Ilya: https://github.com/haproxy/haproxy/issues/512 Hello Tim, ah.. okay, i missed that. Thank you. :)

RE: haproxy 2.1.2 and 2.1.3

Hi all, I tried to recompile all previously compiled haproxy version. All gave same output during compilation, but all newly compiled versions do not seem to work... As far as I can see in my history I compiled haproxy 2.0.0 with gcc version 4.8.2: root@SYSTEM:/export/home/USER/haproxy-2.0.0#

Re: haproxy 2.1.2 and 2.1.3

Miroslav, Am 21.02.20 um 12:22 schrieb Miroslav Zagorac: > You can start gdb like this: > > % gdb -core core-file program > > , and in your case it would look like this: > > % gdb -core core_sz4203_haproxy_0_0_1582273479_18461 > /usr/local/sbin/haproxy > > After that, in gdb program you write

Re: haproxy 2.1.2 and 2.1.3

On 02/21/2020 11:42 AM, marcel.klooster...@kpn.com wrote: Hi, It's not working on test-server also. Test-server is a solaris zone on T7 with 11.4 sru 950, production is a solaris zone on T8 with 11.4 sru 950. You can start gdb like this: % gdb -core core-file program , and in your case it

RE: haproxy 2.1.2 and 2.1.3

Hi, It's not working on test-server also. Test-server is a solaris zone on T7 with 11.4 sru 950, production is a solaris zone on T8 with 11.4 sru 950. What I also tried is: root@SYSTEM:~# gdb GNU gdb (GDB) 8.0 Copyright (C) 2017 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3

Unique ID for PROXYv2: Get 'struct stream' from 'struct connection'

Hi List I'm currently attempting to extend Proxy Protocol v2 by a new TLV to send a unique ID for TCP connections, similar to the unique-id-header for HTTP. I'm currently struggling to get the `struct stream` within `make_proxy_line_v2`. I could find out that I can get the `struct session` via `r

RE: haproxy 2.1.2 and 2.1.3

Hi, I created issue: haproxy 2.1.3 issue with ssl on solaris 11 sru 950 #512 Nut really sure about gdb and bt full. First time using it… had to install it first. Is this what you need: root@SYSTEM:/var/core# gdb --core=core_sz4203_haproxy_0_0_1582279635_18282 GNU gdb (GDB) 8.0 Copyright (C) 201

Re: haproxy 2.1.2 and 2.1.3

Hello, On Fri, Feb 21, 2020 at 08:52:05AM +, marcel.klooster...@kpn.com wrote: > Hi all, > > At this moment we’re using HA-Proxy version 2.0.0 2019/06/16 - > https://haproxy.org/ > And we’re running solaris 11.4 sru 950 for SPARC and I used developer studio > version 12.6 to compile the ne

Re: haproxy 2.1.2 and 2.1.3

useful things to debug would be 1) haorpxy -vv 2) config 3) bt full can you please open a github issue at https://github.com/haproxy/haproxy/issues ? пт, 21 февр. 2020 г. в 13:55, : > Hi all, > > > > At this moment we’re using HA-Proxy version 2.0.0 2019/06/16 - > https://haproxy.org/ > > An

haproxy 2.1.2 and 2.1.3

Hi all, At this moment we’re using HA-Proxy version 2.0.0 2019/06/16 - https://haproxy.org/ And we’re running solaris 11.4 sru 950 for SPARC and I used developer studio version 12.6 to compile the newer versions and 12.5 to compile the 2.0.0 version. And because of a known bug in haproxy, we