[PATCH] BUILD/MEDIUM defer-accept flag support for FreeBSD proposal

2021-02-11 Thread David CARLIER
Hi hope this little patch will find its use. Thanks. Regards. From 02dc058b4f0f41ad1deeb581653e1c3cfb2b2432 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Sat, 6 Feb 2021 12:11:11 + Subject: [PATCH] BUILD/MEDIUM: proto_tcp defer-accept flag support for FreeBSD. FreeBSD has a kernel

Re: minconn, maxconn and fullconn (again, sigh!)

2021-02-11 Thread Victor Sudakov
Lukas Tribus wrote: [dd] > > > It would be nice however to understand minconn/fullconn too. If a > > backend has several servers with identical minconn, maxconn and weight, > > what's the point of having minconn? The load will be always distributed > > evenly between all the servers

Re: minconn, maxconn and fullconn (again, sigh!)

2021-02-11 Thread Lukas Tribus
On Thu, 11 Feb 2021 at 05:31, Victor Sudakov wrote: > > Lukas Tribus wrote: > > > > On Wed, 10 Feb 2021 at 16:55, Victor Sudakov wrote: > > > > > > I can even phrase my question in simpler terms. What happens if the sum > > > total of all servers' maxconns in a backend is less than the maxconn >

[PATCH v3 4/5] MEDIUM: server: support {check,agent}_addr, agent_port in server state

2021-02-11 Thread William Dauchy
logical followup from cli commands addition, so that the state server file stays compatible with the changes made at runtime; use previously added helper to load server attributes. also alloc a specific chunk to avoid mixing with other called functions using it Signed-off-by: William Dauchy ---

[PATCH v3 1/5] MEDIUM: cli: add check-addr command

2021-02-11 Thread William Dauchy
this patch allows to set server health check address at runtime. In order to align with `addr` command, also allow to set port optionnaly. This led to a small refactor in order to use the same function for both `check-addr` and `check-port` commands. for `check-port`, we however don't permit the

[PATCH v3 5/5] MINOR: server: enhance error precision when applying server state

2021-02-11 Thread William Dauchy
server health checks and agent parameters are written the same way as others to be able to enahcne code reuse: basically we make use of parsing and assignment at the same place. It makes it difficult for error handling to know whether srv object was modified partially or not. The problem was

[PATCH v3 3/5] MEDIUM: server: add server-states version 2

2021-02-11 Thread William Dauchy
Even if it is possibly too much work for the current usage, it makes sure we don't break states file from v2.3 to v2.4; indeed, since v2.3, we introduced two new fields, so we put them aside to guarantee we can easily reload from a version 1. The diff seems huge but there is no specific change

[PATCH v3 2/5] MEDIUM: cli: add agent-port command

2021-02-11 Thread William Dauchy
this patch allows to set agent port at runtime. In order to align with both `addr` and `check-addr` commands, also add the possibility to optionnaly set port on `agent-addr` command. This led to a small refactor in order to use the same function for both `agent-addr` and `agent-port` commands.

[PATCH v3 0/5] cli commands for checks and agent

2021-02-11 Thread William Dauchy
Hello Christopher, Here is some work to finish you week. I believe I addressed all the points raised: - warning are no longer emitted when we have "0" or "-" values - I enhanced the warning output as well, and understood my mistake for my previous CLEANUP patch removing a space... so I removed

[PATCH] fix freebsd ci, update freebsd image

2021-02-11 Thread Илья Шипицин
Hello, attached patch fix freebsd builds. Ilya From 6b2c848cfa563f5b0c8cd34f3fa5ce99847d91a3 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 11 Feb 2021 23:32:30 +0500 Subject: [PATCH] CI: cirrus: update FreeBSD image to 12.2 we already tried to run FreeBSD-stable. it is pain, so we

Re: [PATCH] cleanup: remove unused variable assignment

2021-02-11 Thread Christopher Faulet
Le 10/02/2021 à 09:09, Илья Шипицин a écrit : Hello, this is pure cleanup. should fix #1048 Thanks Ilya, now merged ! -- Christopher Faulet

Re: TCP mode and ultra short lived connection

2021-02-11 Thread Максим Куприянов
Thank you very much, Willy! Turning off abortonclose (it was enabled globally) for this particular session really helped :) -- Best regards, Maksim вт, 9 февр. 2021 г. в 17:46, Willy Tarreau : > Hi guys, > > > > I faced a problem dealing with l4 (tcp mode) haproxy-based proxy over > > >