Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-21 Thread Thierry Fournier
> On 20 Aug 2018, at 15:15, Adis Nezirovic wrote: > > On Mon, Aug 20, 2018 at 02:11:13PM +0200, Adis Nezirovic wrote: >> Hi guys, >> >> I've attached a patch to add stick table support to Lua. Operations are >> mostly similar to "show table" functionality from admin socket, namely: >> >> -

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-21 Thread Thierry Fournier
Hi Adis, Thanks for this patch, it is a very useful class. Some remark about the documentation and the formats: js:function:: StickTable.info() js:function:: StickTable.lookup(key) Maybe the specification and an example of the returnes

Re: 100% cpu usage 1.9-dev0-48d92ee 2018/07/30, task.?. but keeps working.. (nbthread 1)

2018-08-21 Thread Olivier Houchard
Hi Pieter, On Mon, Aug 20, 2018 at 09:33:49PM +0200, PiBa-NL wrote: > Hi Olivier, > > Op 17-8-2018 om 14:51 schreef Willy Tarreau: > > On Fri, Aug 17, 2018 at 01:41:54PM +0200, Olivier Houchard wrote: > > > That is true, this one is not a bug, but a pessimization, by using the > > > global > >

Fwd: [haproxy/haproxy] MAJOR: server: make server state changes synchronous again (3ff577e)

2018-08-21 Thread Tim Düsterhus
Hi list the following comment has been posted to GitHub on commit 3ff577e165486de87d1c0923e84f72cc7ad790c0 "MAJOR: server: make server state changes synchronous again" https://github.com/haproxy/haproxy/commit/3ff577e165486de87d1c0923e84f72cc7ad790c0#commitcomment-30217983 I'll make the author

Re: Fwd: [haproxy/haproxy] MAJOR: server: make server state changes synchronous again (3ff577e)

2018-08-21 Thread Willy Tarreau
Hi Tim, On Tue, Aug 21, 2018 at 12:51:05PM +0200, Tim Düsterhus wrote: > Hi list > > the following comment has been posted to GitHub on commit > 3ff577e165486de87d1c0923e84f72cc7ad790c0 > "MAJOR: server: make server state changes synchronous again" > >

HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Hi Willy, I'm afraid there's still some issues with HTTP/2 in the current dev branch :-( This morning, I've upgraded a test server and discovered that some HTTPS sites did not work anymore (content hangs and is not sent to the client), I've also noticed some segfaults in haproxy. As this is a

Clarification re Timeouts and Session State in the Logs

2018-08-21 Thread Daniel Schneller
Hi! I am trying to wrap my head around an issue we are seeing where there are many HTTP 504 responses sent out to clients. I suspect that due to a client bug they stop sending data midway during the data phase of the request, but they keep the connection open. What I see in the haproxy logs

Re: haproxy-1.9-dev [0c026f49e]: 100% CPU when a server goes DOWN with option redispatch

2018-08-21 Thread Cyril Bonté
> De: "Cyril Bonté" > À: "Willy Tarreau" > Cc: "HAProxy" > Envoyé: Mardi 21 Août 2018 16:09:55 > Objet: haproxy-1.9-dev [0c026f49e]: 100% CPU when a server goes DOWN with > option redispatch > > Hi Willy, > Here is another issue seen today with the current dev branch [tests > were also made

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
Cyril, if you want to test, please be sure to update to at least 1b13bfd as we've just added another fix on top of this series. Cheers, Willy

Need Clarification

2018-08-21 Thread Jordan Finsbel
Hello my name is Jordan Finsbell and interested to get involved

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Le 22/08/2018 à 00:40, Cyril Bonté a écrit : Hi again Willy, Le 21/08/2018 à 22:55, Cyril Bonté a écrit : Thanks for the diag. I don't remember changing anything around the proxy protocol, but it's possible that something subtle changed. Also it's not on the regular send/receive path so maybe

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Wed, Aug 22, 2018 at 04:32:49AM +0200, Willy Tarreau wrote: > Excellent, I think I found it : > > trash.data = recv(conn->handle.fd, trash.area, trash.size, > MSG_PEEK); > if (trash.data < 0) { > if (errno

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Tue, Aug 21, 2018 at 10:55:40PM +0200, Cyril Bonté wrote: > > > OK, that one is my fault, I used a "listen" section for use_backend (maybe > > > we'll have to secure such configuration error to prevent segfaults). > > > > I don't see how it could be an issue, that's a completely supported > >

BUG: LUA txn:get_priv() scoped to connection, not transaction

2018-08-21 Thread Patrick Hemmer
There is a bug in the current stable haproxy (1.8.13) where the LUA function txn:get_priv() is returning data stored from other transactions. This was discovered as we have code that triggers on certain requests, and it was triggering on requests it should not have been. You can reproduce with

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Hi again Willy, Le 21/08/2018 à 22:55, Cyril Bonté a écrit : Thanks for the diag. I don't remember changing anything around the proxy protocol, but it's possible that something subtle changed. Also it's not on the regular send/receive path so maybe I overlooked certain parts and broke it by

Re: haproxy processing request of a disconnected client

2018-08-21 Thread Patrick Hemmer
On 2018/8/9 13:00, Patrick Hemmer wrote: > So I just noticed the behavior that when a request is queued and the > client closes the connection, once a server slot frees up that request > is still sent to the server which processes it and sends a response back. > What's even more interesting is

Re: [PATCH 0/2] sample fetches for available connections

2018-08-21 Thread Patrick Hemmer
On 2018/8/9 18:46, Patrick Hemmer wrote: > These are 2 new sample fetches which provide the available connections. > The be_conn_free fetch is similar to connslots, but has significant > difference in that it does not count queue slots, nor backup servers > (unless all servers are down). > >

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Wed, Aug 22, 2018 at 12:46:47AM +0200, Cyril Bonté wrote: > Le 22/08/2018 à 00:40, Cyril Bonté a écrit : > > Hi again Willy, > > > > Le 21/08/2018 à 22:55, Cyril Bonté a écrit : > > > > Thanks for the diag. I don't remember changing anything around the proxy > > > > protocol, but it's possible

Re: [PATCH] MINOR: crypto: Add digest and hmac converters

2018-08-21 Thread Patrick Hemmer
On 2018/6/17 14:02, Baptiste wrote: > > > Le dim. 17 juin 2018 à 14:10, Patrick Gansterer > a écrit : > > > > On 17 Jun 2018, at 13:36, Baptiste > wrote: > > > > Can they be used to validate oauth tokens too? > > Depends on

Re: connection leak (stuck in CLOSE_WAIT) on master

2018-08-21 Thread Patrick Hemmer
On 2018/8/9 01:01, Patrick Hemmer wrote: > There's an issue on current master (287527a) where haproxy is losing > track of its connections, and they're getting stuck in CLOSE_WAIT. And > it's counting these connections towards limits (such as maxconn). > Eventually maxconn is reached and

Re: BUG: Tw is negative with lua sleep

2018-08-21 Thread Patrick Hemmer
On 2018/7/18 09:03, Frederic Lecaille wrote: > Hello Patrick, > > On 07/17/2018 03:59 PM, Patrick Hemmer wrote: >> Ping? >> >> -Patrick >> >> On 2018/6/22 15:10, Patrick Hemmer wrote: >>> When using core.msleep in lua, the %Tw metric is a negative value. >>> >>> For example with the following

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-21 Thread Adis Nezirovic
On Tue, Aug 21, 2018 at 11:32:34AM +0200, Thierry Fournier wrote: > Some remark about the documentation and the formats: > > > js:function:: StickTable.info() > js:function:: StickTable.lookup(key) > > Maybe the specification and an example of

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Le 21/08/2018 à 21:56, Willy Tarreau a écrit : On Tue, Aug 21, 2018 at 07:00:39PM +0200, Cyril Bonté wrote: Le 21/08/2018 à 18:36, Willy Tarreau a écrit : Cyril, if you want to test, please be sure to update to at least 1b13bfd as we've just added another fix on top of this series. OK, I

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Le 21/08/2018 à 19:00, Cyril Bonté a écrit : Le 21/08/2018 à 18:36, Willy Tarreau a écrit : Cyril, if you want to test, please be sure to update to at least 1b13bfd as we've just added another fix on top of this series. OK, I was performing some tests, I've now updated with this patch. It

Re: Need Clarification

2018-08-21 Thread Jonathan Matthews
On Tue, 21 Aug 2018 at 17:53, Jordan Finsbel wrote: > Hello my name is Jordan Finsbell and interested to get involved That's great! What areas are you interested in? J -- Jonathan Matthews London, UK http://www.jpluscplusm.com/contact.html

Need Clarification

2018-08-21 Thread Jordan Finsbel
Hello my name is Jordan Finsbell and interested to get involved

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Tue, Aug 21, 2018 at 07:00:39PM +0200, Cyril Bonté wrote: > Le 21/08/2018 à 18:36, Willy Tarreau a écrit : > > Cyril, > > > > if you want to test, please be sure to update to at least 1b13bfd as > > we've just added another fix on top of this series. > > OK, I was performing some tests, I've

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Willy Tarreau
On Tue, Aug 21, 2018 at 06:01:59PM +0200, Olivier Houchard wrote: > Hi Cyril, > > On Tue, Aug 21, 2018 at 12:51:13PM +0200, Cyril Bonté wrote: > > Hi Willy, > > > > I'm afraid there's still some issues with HTTP/2 in the current dev branch > > :-( > > > > This morning, I've upgraded a test

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Olivier Houchard
Hi Cyril, On Tue, Aug 21, 2018 at 12:51:13PM +0200, Cyril Bonté wrote: > Hi Willy, > > I'm afraid there's still some issues with HTTP/2 in the current dev branch :-( > > This morning, I've upgraded a test server and discovered that some HTTPS > sites did not work anymore (content hangs and is

Re: haproxy-1.9-dev [0c026f49e]: 100% CPU when a server goes DOWN with option redispatch

2018-08-21 Thread Willy Tarreau
Hi Cyril, I've just committed and pushed a fix for the double locking that happens when calling pendconn_redistribute() from srv_update_status() and it fixes your report (just checked). Actually I'm realising that I should have credited you and Francis for the report since it's the same one :-(

Re: haproxy-1.9-dev [0c026f49e]: 100% CPU when a server goes DOWN with option redispatch

2018-08-21 Thread Willy Tarreau
On Tue, Aug 21, 2018 at 04:09:55PM +0200, Cyril Bonté wrote: > Hi Willy, > Here is another issue seen today with the current dev branch [tests were also > made after pulling recent commit 3bcc2699b]. > > Since 0c026f49e, when a server status is set to DOWN and option redispatch is > enabled,

haproxy-1.9-dev [0c026f49e]: 100% CPU when a server goes DOWN with option redispatch

2018-08-21 Thread Cyril Bonté
Hi Willy, Here is another issue seen today with the current dev branch [tests were also made after pulling recent commit 3bcc2699b]. Since 0c026f49e, when a server status is set to DOWN and option redispatch is enabled, the haproxy process hits 100% CPU. Even more, with the latest commits, if

Re: haproxy-1.9-dev [0c026f49e]: 100% CPU when a server goes DOWN with option redispatch

2018-08-21 Thread Willy Tarreau
Hi Cyril, On Tue, Aug 21, 2018 at 04:13:38PM +0200, Cyril Bonté wrote: > > De: "Cyril Bonté" > > À: "Willy Tarreau" > > Cc: "HAProxy" > > Envoyé: Mardi 21 Août 2018 16:09:55 > > Objet: haproxy-1.9-dev [0c026f49e]: 100% CPU when a server goes DOWN with > > option redispatch > > > > Hi Willy,

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-21 Thread Cyril Bonté
Le 21/08/2018 à 18:36, Willy Tarreau a écrit : Cyril, if you want to test, please be sure to update to at least 1b13bfd as we've just added another fix on top of this series. OK, I was performing some tests, I've now updated with this patch. It looks better as now I don't see anymore hangs,

Re: Observations about reloads and DNS SRV records

2018-08-21 Thread francis Lavalliere
This is related to the discourse thread (And also discuss the issues in ML instead of discourse). https://discourse.haproxy.org/t/config-reload-with-dynamic-service-discovery-via-dns/2625/10 Here are the findings from my ends: 1 - State file / Port range invalid conversion In the haproxy