Re: [PATCH] drop coverity scan from travis-ci matrix

2020-12-22 Thread Илья Шипицин
Bad news. I thought to keep arm64, s390, ppc64le builds On Wed, Dec 23, 2020, 12:10 AM Tim Düsterhus wrote: > Willy, > > Am 22.12.20 um 19:51 schrieb Willy Tarreau: > >> Open Source projects can get additional top-ups, but not recurring, so > >> one would need to send an email every few weeks wh

stable-bot: Bugfixes waiting for a release 2.3 (23), 2.2 (17), 2.1 (26), 2.0 (24)

2020-12-22 Thread stable-bot
Hi, This is a friendly bot that watches fixes pending for the next haproxy-stable release! One such e-mail is sent periodically once patches are waiting in the last maintenance branch, and an ideal release date is computed based on the severity of these fixes and their merge date. Responses t

stick table conn_cur broken with peer synchronization

2020-12-22 Thread James Brown
I've noticed that sc0_conn_cur (tracking the current number of connections for a request tracked based on and extracted field from the body) is much higher in 2.2 than it was in 2.1 and seems to no longer be correct. For example, on one relatively un-loaded load balancer which only has around 940

Re: [PATCH] drop coverity scan from travis-ci matrix

2020-12-22 Thread Tim Düsterhus
Willy, Am 22.12.20 um 19:51 schrieb Willy Tarreau: >> Open Source projects can get additional top-ups, but not recurring, so >> one would need to send an email every few weeks whenever the minutes run >> out. >> >> And also to qualify for the Open Source credits *not a single* paid >> employee may

Re: [PATCH] drop coverity scan from travis-ci matrix

2020-12-22 Thread Willy Tarreau
On Tue, Dec 22, 2020 at 07:37:00PM +0100, Tim Düsterhus wrote: > Am 22.12.20 um 19:30 schrieb ???: > > I think minutes are renewed monthly, or not? > > > > I thought so as well after their initial announcement, but no: The 10k > credits (= 1000 Linux minutes) were a one-time top-up. I i

Re: [PATCH] drop coverity scan from travis-ci matrix

2020-12-22 Thread Tim Düsterhus
Ilya, Am 22.12.20 um 19:30 schrieb Илья Шипицин: > I think minutes are renewed monthly, or not? > I thought so as well after their initial announcement, but no: The 10k credits (= 1000 Linux minutes) were a one-time top-up. Open Source projects can get additional top-ups, but not recurring, so

Re: [PATCH] drop coverity scan from travis-ci matrix

2020-12-22 Thread Илья Шипицин
I think minutes are renewed monthly, or not? On Tue, Dec 22, 2020, 11:27 PM Tim Düsterhus wrote: > Ilya, > Willy, > > Am 22.12.20 um 18:56 schrieb Илья Шипицин: > > as we already exhausted travis limits, let us move coverity scan to > github > > actions. > > Our minutes lasted longer than I expe

Re: [PATCH] drop coverity scan from travis-ci matrix

2020-12-22 Thread Tim Düsterhus
Ilya, Willy, Am 22.12.20 um 18:56 schrieb Илья Шипицин: > as we already exhausted travis limits, let us move coverity scan to github > actions. Our minutes lasted longer than I expected. I'm not sure whether preserving the .travis.yml is helpful, as I don't think we are going to get any new minu

[PATCH] drop coverity scan from travis-ci matrix

2020-12-22 Thread Илья Шипицин
Hello, as we already exhausted travis limits, let us move coverity scan to github actions. (next patch will be adding new GH action) Ilya From 1cc02dbd402f40d41f398e594094ec368e988736 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 22 Dec 2020 22:51:52 +0500 Subject: [PATCH] CI: travis

Re: [PATCH] MINOR: converter: adding support for url_enc

2020-12-22 Thread Tim Düsterhus
William, Am 22.12.20 um 15:36 schrieb William Dauchy: > diff --git a/doc/configuration.txt b/doc/configuration.txt > index 95b020c03..fd8c709fa 100644 > --- a/doc/configuration.txt > +++ b/doc/configuration.txt > @@ -16230,6 +16230,12 @@ url_dec([]) >space (' '). Otherwise this will only happe

[PATCH] MINOR: converter: adding support for url_enc

2020-12-22 Thread William Dauchy
add base support for url encode following RFC3986, supporting `query` type only. - add test checking url_enc/url_dec/url_enc - update documentation - leave the door open for future changes this should resolve github issue #941 Signed-off-by: William Dauchy --- doc/configuration.txt |

Re: [PATCH] MINOR: contrib/prometheus-exporter: export build_info

2020-12-22 Thread William Dauchy
Hi Willy, Thank you for the review. On Tue, Dec 22, 2020 at 2:50 PM Willy Tarreau wrote: > We must not renumber these entries because it directly impacts their > output order in the "show info" output, that some tools rely on since > these entries have remained stable from day one (hence the com

Re: [PATCH] MINOR: contrib/prometheus-exporter: export build_info

2020-12-22 Thread Willy Tarreau
Hi William, On Tue, Dec 22, 2020 at 11:32:41AM +0100, William Dauchy wrote: > This patch follows prometheus best pratices to export specific software > informations. While being there, I added compiler and release date. This is great, however there are two problems here: > diff --git a/include/h

Re: [PATCH] BUG/???: mux_h2: Add missing braces

2020-12-22 Thread Tim Düsterhus
Willy, Am 22.12.20 um 09:14 schrieb Willy Tarreau: >> please fill in the severity yourself, because I don't know what effects this >> bug causes. > > Thank you for catching this one. I remember I was extra cautious when adding > the traces, precisely because I feared making this exact mistake. Ap

Re: [PR] hpack-tbl-t.h uses VAR_ARRAY and requires compiler.h to be included

2020-12-22 Thread Christian Ruppert
No Problem at all. Feel free :) On 2020-12-21 12:59, Willy Tarreau wrote: On Mon, Dec 21, 2020 at 12:20:36PM +0100, Christian Ruppert wrote: > 2) we include from this file so that it becomes > consistent > with everything else ; > > 3) we add the ifdef VAR_ARRAY directly into the file

[PATCH] MINOR: contrib/prometheus-exporter: export build_info

2020-12-22 Thread William Dauchy
commit c55a626217a7e676e1cc ("MINOR: contrib/prometheus-exporter: Add missing global and per-server metrics") is renaming two metrics between v2.2 and v2.3: server_idle_connections_current server_idle_connections_limit It is breaking some tools which are making use of those metrics while suppo

Re: [PATCH] BUG/???: mux_h2: Add missing braces

2020-12-22 Thread Willy Tarreau
Hi Tim, On Mon, Dec 21, 2020 at 07:40:16PM +0100, Tim Duesterhus wrote: > Willy, > > please fill in the severity yourself, because I don't know what effects this > bug causes. Thank you for catching this one. I remember I was extra cautious when adding the traces, precisely because I feared maki