Re: [PATCH spoa-server] BUG/MINOR: build: install binary inside bin/ directory

On Sun, Jun 13, 2021 at 01:13:52AM +0100, Bertrand Jacquin wrote: > Prior to the change, spoa is installed under DESTDIR with name `bin` Thanks Bertrand. I've merged it now, after realizing that I still had access to this now external repo :-) Willy

Re: [EXTERNAL] Re: built in ACL, REQ_CONTENT

On Tue, Jun 08, 2021 at 06:32:50PM +0200, Lukas Tribus wrote: > Please try to ask the actual question directly next time, so we can > help you right away (https://xyproblem.info/). I didn't know this extremely common problem had a name, thanks Lukas for the link, I'll share it more often! Willy

Re: MINOR: fixes haiku linkage

On Sat, Jun 19, 2021 at 02:47:52PM +0100, David CARLIER wrote: > Hi here a little change proposal to fix haproxy at runtime in this platform. > Cheers. Thanks David, now merged. Willy

Re: Fix small bug in srv_parse_agent_check

Hi Dirkjan, On Fri, Jun 18, 2021 at 10:03:17PM +0200, Dirkjan Bussink wrote: > Hi all, > > I was building HAProxy using scan-build to see if there were any issues and > it called out an unused variable write. I think this was due to a bug that > the err_code was not used in

Re: SSL Labs says my server isn't doing ssl session resumption

On Sun, Jun 20, 2021 at 05:20:41PM -0600, Shawn Heisey wrote: > On 6/20/2021 3:16 PM, Lukas Tribus wrote: > > It's a haproxy bug, affecting 2.4 releases, I've filed an issue in our > > tracker: > > > > https://github.com/haproxy/haproxy/issues/1297 > > Almost always when I report a problem I'm

Re: Line 47 in src/queue.c "s * queue's lock."

On Thu, Jun 24, 2021 at 11:35:51PM +0200, Aleksandar Lazic wrote: > Hi. > > when someone works again on src/queue.c could be this typo fixed. > > http://git.haproxy.org/?p=haproxy.git;a=blob;f=src/queue.c;h=6d3aa9a12bcd6078d1b5a76969da4104a6adb1bd;hb=HEAD#l47 > > ``` > 44 * - a

Re: SNI spoofing in HAproxy?

On Thu, Jun 24, 2021 at 04:07:33PM +0200, Tim Düsterhus wrote: > Julien, > > On 6/24/21 3:40 PM, Julien Pivotto wrote: > > >use_backend bob if { hdr(host) -m dom bob.com } > > >use_backend alice if { hdr(host) -m dom alice.com } > > > > Thanks for taking the time to write this report. >

Re: [PATCH 0/1] Replace issue templates by issue forms

Hi Lukas, On Wed, Jun 23, 2021 at 11:27:55PM +0200, Lukas Tribus wrote: > Full Ack from me for this change, this will be very beneficial as we > get higher quality reports and people won't be required to navigate > through raw markdown, which is not user-friendly at all. Thanks for this fast

Re: [PATCH 0/1] Replace issue templates by issue forms

Hi Tim, Max, On Wed, Jun 23, 2021 at 09:38:12PM +0200, Tim Duesterhus wrote: > Hi Willy, Lukas, List! > > GitHub finally launched their next evolution of issue templates, called issue > forms, as a public beta: >

Re: SSL Labs says my server isn't doing ssl session resumption

On Sun, Jun 20, 2021 at 11:31:10PM +0200, Willy Tarreau wrote: > On Sun, Jun 20, 2021 at 11:16:15PM +0200, Lukas Tribus wrote: > > Hello Shawn, > > > > On Sun, 20 Jun 2021 at 14:03, Shawn Heisey wrote: > > > > > > On 6/20/2021 1:52 AM, Lukas Tribus wrote:

Re: SSL Labs says my server isn't doing ssl session resumption

On Sun, Jun 20, 2021 at 11:16:15PM +0200, Lukas Tribus wrote: > Hello Shawn, > > On Sun, 20 Jun 2021 at 14:03, Shawn Heisey wrote: > > > > On 6/20/2021 1:52 AM, Lukas Tribus wrote: > > > Can you try disabling threading, by putting nbthread 1 in your config? > > > > That didn't help. From

Re: [PATCH] CLEANUP: Prevent channel-t.h from being detected as C++ by GitHub

Hi Tim, On Sat, Jun 19, 2021 at 04:56:30PM +0200, Tim Duesterhus wrote: > GitHub uses github/linguist to determine the programming language used for > each > source file to show statistics and to power the search. In cases of unique > file > extensions this is easy, but for `.h` files the

Re: Bad backend selected

On Fri, Jun 18, 2021 at 05:08:56PM +0200, Tim Düsterhus wrote: > > So I had some thoughts about that discussion that started off-list. And > > now I think that the right thing to do is to always drop the port part > > of the authority when we have a scheme for which it's the default. I.e. > > if

Re: [PATCH] BUG/MINOR: cache: Correctly handle existing-but-empty, 'accept-encoding' header

On Fri, Jun 18, 2021 at 04:07:10PM +0200, Tim Düsterhus, WoltLab GmbH wrote: > Remi, > > On 6/18/21 3:46 PM, Remi Tricot-Le Breton wrote: > > > please find a small fix for the 'Vary' support of the cache to > > > correctly handle the difference between a missing 'accept-encoding' > > > and an

Re: [PATCH] BUG/MINOR: cache: Correctly handle existing-but-empty, 'accept-encoding' header

On Fri, Jun 18, 2021 at 03:46:26PM +0200, Remi Tricot-Le Breton wrote: > Hello Tim, > > On 18/06/2021 15:26, Tim Düsterhus, WoltLab GmbH wrote: > > Remi, > > > > please find a small fix for the 'Vary' support of the cache to correctly > > handle the difference between a missing 'accept-encoding'

Re: [PATCH 0/4] Use 'feature cmd' in regtests

On Thu, Jun 17, 2021 at 05:03:23PM +0200, Tim Düsterhus wrote: > On 6/17/21 3:27 PM, Willy Tarreau wrote: > > Whole series merged, thanks Tim. I feel like the selection is slightly > > faster than before, but that might just be a placebo effect. > > > > I would assum

Re: Speeding up opentracing build in CI ?

On Thu, Jun 17, 2021 at 04:48:45PM +0200, Tim Düsterhus wrote: > To clarify: This specific timing also includes the wait times until the > build VMs are available. It's basically the wall time elapsed between the > push happening and the *last* build reporting the status. So the time the >

Re: Speeding up opentracing build in CI ?

On Thu, Jun 17, 2021 at 04:31:57PM +0200, Tim Düsterhus wrote: > Willy, William, > > On 6/17/21 3:55 PM, William Lallemand wrote: > > > OK that's a net win, openssl-3.0.0-alpha17 dropped from 8'29 to 2'55. > > > I've just excluded versions 1.x from both the parallel build and the > > > build_sw

Re: [PATCH] CLEANUP: server: a separate function for initializing the per_thr field

Hi Miroslav, On Tue, Jun 15, 2021 at 03:53:39PM +0200, Miroslav Zagorac wrote: > Hello all, > > To avoid repeating the same source code, allocating memory and > initializing the per_thr field from the server structure is > transferred to a separate function. Makes sense, indeed. Now merged,

Re: Speeding up opentracing build in CI ?

On Thu, Jun 17, 2021 at 03:29:58PM +0200, Willy Tarreau wrote: > On Thu, Jun 17, 2021 at 03:24:19PM +0200, Willy Tarreau wrote: > > On Thu, Jun 10, 2021 at 08:55:13PM +0500, ??? wrote: > > > I was mistaken. LibreSSL does not like parallel install > > > > &

Re: Speeding up opentracing build in CI ?

On Thu, Jun 17, 2021 at 03:24:19PM +0200, Willy Tarreau wrote: > On Thu, Jun 10, 2021 at 08:55:13PM +0500, ??? wrote: > > I was mistaken. LibreSSL does not like parallel install > > > > libressl fails on `make -j4 install` · Issue #461 · > > libressl-po

Re: [PATCH 0/4] Use 'feature cmd' in regtests

On Fri, Jun 11, 2021 at 07:56:14PM +0200, Tim Duesterhus wrote: > This series updates the regtests to make use of VTest's 'feature cmd' syntax > to skip tests that are not supported in the current environment. (...) Whole series merged, thanks Tim. I feel like the selection is slightly faster

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

On Thu, Jun 17, 2021 at 12:31:45PM +0200, Tim Düsterhus wrote: > Willy, > > On 6/13/21 3:02 PM, Tim Duesterhus wrote: > > Using 'sudo' required quite a few workarounds in various places. Setting an > > explicit 'ulimit -n' removes the requirement for 'sudo', resulting in a > > cleaner > >

Re: Speeding up opentracing build in CI ?

On Thu, Jun 10, 2021 at 08:55:13PM +0500, ??? wrote: > I was mistaken. LibreSSL does not like parallel install > > libressl fails on `make -j4 install` · Issue #461 · > libressl-portable/portable (github.com) > > > > anyway, if

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

Hi Tim, On Thu, Jun 17, 2021 at 12:31:45PM +0200, Tim Düsterhus wrote: > Willy, > > On 6/13/21 3:02 PM, Tim Duesterhus wrote: > > Using 'sudo' required quite a few workarounds in various places. Setting an > > explicit 'ulimit -n' removes the requirement for 'sudo', resulting in a > > cleaner >

[ANNOUNCE] haproxy-2.4.1

acro William Lallemand (1): BUILD: make tune.ssl.keylog available again Willy Tarreau (21): BUG/MINOR: pools: fix a possible memory leak in the lockless pool_flush() BUG/MINOR: pools: make DEBUG_UAF always write to the to-be-freed location MINOR: pools: do not maintain

Re: [PATCH] typo fixes

On Sat, Jun 12, 2021 at 03:57:40PM +0500, ??? wrote: > Hello, > > yet more typo and spelling fixes. Merged, thank you Ilya! Willy

Re: SSL Labs says my server isn't doing ssl session resumption

On Fri, Jun 11, 2021 at 06:48:09PM -0600, Shawn Heisey wrote: > I'm fiddling with ssl labs to see how I can improve my TLS setup. > > Here's what they say about a site I have behind haproxy with TLS: > > https://www.elyograg.org/foo/haproxy-ssllabs-session-resumption-not-working.png > > They

Re: [PATCH 0/4] Use 'feature cmd' in regtests

On Mon, Jun 14, 2021 at 02:18:57PM +0200, William Lallemand wrote: > On Mon, Jun 14, 2021 at 02:03:55PM +0200, Willy Tarreau wrote: > > On Mon, Jun 14, 2021 at 03:49:05PM +0500, ??? wrote: > > > I believe William means conditions like "openssl is 1.1.0 or hi

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

On Mon, Jun 14, 2021 at 02:33:20PM +0200, William Lallemand wrote: > On Mon, Jun 14, 2021 at 12:01:11PM +0200, Tim Düsterhus wrote: > > We only run Travis once weekly, because of the limited credits we have. > > Thus only the newest commit at time of running will have a Travis CI > > Status

Re: [PATCH 0/4] Use 'feature cmd' in regtests

On Mon, Jun 14, 2021 at 03:49:05PM +0500, ??? wrote: > I believe William means conditions like "openssl is 1.1.0 or higher", but > that's possible using grep And anyway I do want to add config predicates that will provide this. As I said when I added a few of them for ".if", the main use

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

On Sat, Jun 12, 2021 at 03:47:46PM +0500, ??? wrote: > final apline/musl patch attached Applied, thank you Ilya! Willy

HAProxyConf 2021 - Call for papers

Hi all, some of you have probably already noticed the announce in [1], the 2021 edition of the HAProxyConf will take place on November 16-17 as a "virtual event" (I personally prefer to say "online" as "virtual" always makes me feel that I'm losing something important). For sure we'll all miss

Re: [PATCH 1/2] REGTESTS: Remove REQUIRE_VERSION=1.6 from all tests

On Fri, Jun 11, 2021 at 06:16:24PM +0200, Tim Duesterhus wrote: > HAProxy 1.6 is EOL, thus this always matches. (...) Both applied, thanks Tim! willy

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

On Fri, Jun 11, 2021 at 08:14:49PM +0500, ??? wrote: > @Willy Tarreau , do you think it is good idea to display libc > variant in "haproxy -vv" ? If needed we can (for those that are detectable), but I'm not convinced of the benefits. If it's in order to exclude some t

Re: how to write to a file safely in haproxy

Hello, On Fri, Jun 11, 2021 at 11:38:38AM +0530, reshma r wrote: > Hello all, > I Had a follow up query, sorry if it is an obvious question. once I > implement the socket call as a sidecar process, say as a lua script that > reads the new configuration from portal into a variable, how would I

Re: Speeding up opentracing build in CI ?

On Thu, Jun 10, 2021 at 09:00:32AM +0300, ??? wrote: > openssl does not support -j for make install > I filed a bug on them, they told me "OK, just don't use it" I don't care about install, which I didn't touch, but about "all". I never install anything with -j anyway. The savings are

Re: Speeding up opentracing build in CI ?

On Thu, Jun 10, 2021 at 07:19:37AM +0200, Willy Tarreau wrote: > On Thu, Jun 10, 2021 at 10:15:46AM +0500, ??? wrote: > > OT takes about 30 sec (it is built with almost everything disabled). the > > biggest time eater is openssl-3.0.0 > > Maybe that one could be s

Re: Speeding up opentracing build in CI ?

On Thu, Jun 10, 2021 at 10:15:46AM +0500, ??? wrote: > OT takes about 30 sec (it is built with almost everything disabled). the > biggest time eater is openssl-3.0.0 Maybe that one could be sped up too, I haven't checked if it uses parallel builds. > hopefully, OT will speed up to 10

Re: Speeding up opentracing build in CI ?

On Thu, Jun 10, 2021 at 07:55:17AM +0300, ??? wrote: > First one is supposed to be cached one day together with "opt" folder. > > However, we can indeed use parallel builds until cache is enabled for > github actions OK. The other use case I saw was that it's more convenient for

Speeding up opentracing build in CI ?

Tim, Ilya, while testing Miroslav's fix, I found the opentracing build to be quite slow and figured it doesn't use parallel builds. Do you have any objection against patching the script like this ? diff --git a/scripts/build-ot.sh b/scripts/build-ot.sh index 59d6af587..1c296b64b 100755 ---

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

On Thu, Jun 10, 2021 at 04:40:47AM +0200, Miroslav Zagorac wrote: > On 06/10/2021 04:20 AM, Willy Tarreau wrote: > > Thank you Miroslav. Just to be sure, is this in anyway related to the > > fix or not ? We need to make sure that we maintain a smooth upgrade > > path for those

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

On Thu, Jun 10, 2021 at 02:56:46AM +0200, Miroslav Zagorac wrote: > I forgot to mention that one should take the latest version of the > opentracing c wrapper (it is now 1.1.0). > > https://github.com/haproxytech/opentracing-c-wrapper Thank you Miroslav. Just to be sure, is this in anyway

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

Hi Miroslav, On Mon, Jun 07, 2021 at 04:55:21PM +0200, Miroslav Zagorac wrote: > From 4bbbe5fd3e66a37ec9703723ba22b742e7926a07 Mon Sep 17 00:00:00 2001 > From: Miroslav Zagorac > Date: Mon, 7 Jun 2021 16:21:31 +0200 > Subject: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot

Re: [PATCH] CI: Make matrix.py executable and add shebang

On Tue, Jun 08, 2021 at 06:25:40PM +0500, ??? wrote: > ack from me. Now merged, thanks! Willy

Re: [PATCH 3/3] MINOR: haproxy: Add `-cc` argument

On Tue, Jun 08, 2021 at 11:41:29AM +0200, Tim Düsterhus wrote: > Willy, > > On 6/8/21 11:26 AM, Willy Tarreau wrote: > > I couldn't figure how the VTC was OK but not testing it by hand. I finally > > found it, the outlen variable was not initialized, it should

Re: [PATCH 3/3] MINOR: haproxy: Add `-cc` argument

Tim, Max, On Sun, Jun 06, 2021 at 12:50:22AM +0200, Maximilian Mader wrote: > This is a cleaned-up version of Tim's PoC patch. > The documentation has been updated to reflect the changes. > A simple VTest test is included as well. Note the use of VTest's cmd > feature to skip the test if the

Re: [PATCH 2/3] CLEANUP: Make errptr const in `parse_line()`

Hi Max, On Sun, Jun 06, 2021 at 12:50:21AM +0200, Maximilian Mader wrote: > Hi, > I'm not sure whether this change causes any non-obvious issues but the > compiler was happy. There's no issue for this. Adding a const somewhere will either cause build failures or have no visible consequences,

Re: [PATCH] DOC: use the req.ssl_sni in examples

Hi Alex, On Sat, Jun 05, 2021 at 01:31:07PM +0200, Aleksandar Lazic wrote: > Hi. > > This patch fixes the usage of req_ssl_sni in the doc. Ah good catch, applied, thank you! > Any plan to remove the old keyword or add some warning that this > keyword is deprecated? Good question, could be,

Re: Official ubuntu 20 repository

On Tue, Jun 08, 2021 at 10:50:11AM +0300, Valters Jansons wrote: > > > term "official" maybe treated as "ubuntu official" or "haproxy official". > > > while "ubuntu official" are indeed slow, vbernat PPA is considered as > > > "haproxy official". > > > > I agree, that's what I was about to add as

Re: Official ubuntu 20 repository

On Mon, Jun 07, 2021 at 12:58:22PM +0500, ??? wrote: > ??, 7 ???. 2021 ?. ? 12:20, Valters Jansons : > > > On Mon, Jun 7, 2021 at 12:34 AM Ismail Azerty > > wrote: > > > For some security reasons, our security teams want us to use the > > official repository, or recompile the whole

Re: Bad backend selected

On Mon, Jun 07, 2021 at 07:13:43PM +0200, t...@bastelstu.be wrote: > Artur, > > [cc'ing Amaury] > > Am 2021-06-07 16:46, schrieb Artur: > > However the only difference is the 443 port explicitly specified in the > > later request. > > I am not sure it's something specific to 2.4.0, but I've

Re: [PATCH] CI: enable openssl-3.0.0 builds

On Sun, Jun 06, 2021 at 12:51:53AM +0200, Tim Düsterhus wrote: > Ilya, > > On 6/5/21 5:10 AM, ??? wrote: > > here are two patches: > > > > - deprecated warnings suppressed > > - openssl-3.0.0 enabled > > > > In the second patch you forgot the 'CI:' prefix in the commit message. > >

Re: [PATCH] CLEANUP: reg-tests: Remove obsolete no-htx parameter for reg-tests

On Mon, May 31, 2021 at 11:07:29PM +0200, Tim Duesterhus wrote: > The legacy HTTP subsystem has been removed. HTX is always enabled. Now merged, thank you Tim! Willy

Re: [PR] DOC: Fix typo in starter guide

On Sat, May 22, 2021 at 08:23:02PM +0200, PR Bot wrote: > Dear list! > > Author: Mark Mullan > Number of patches: 1 > > This is an automated relay of the Github pull request: >DOC: Fix typo in starter guide > > Patch title(s): >DOC: Fix typo in starter guide (...) Applied, thanks.

Re: Software Design for source code?

Hi, On Fri, May 21, 2021 at 12:30:26PM +0200, Robert Ionescu wrote: > Hi, > > Are there any sources which are overviewing the HAProxy software design in > images or similar? > I would like to get a better understanding of the HAProxy components. There are *some* docs in doc/internals/, in

Re: [ANNOUNCE] haproxy-2.4.0

On Wed, May 26, 2021 at 02:40:22PM +0200, William Dauchy wrote: > Regarding prometheus, it should probably noted some major changes > regarding some metrics, such as for health check, where the value is > now located in a label, instead of the value of the metric itself: > see also >

Re: how to write to a file safely in haproxy

Hi, On Wed, May 26, 2021 at 10:43:17PM +0530, reshma r wrote: > Hi Tim thanks a lot for the reply. I am not familiar with what a sidecar > process is. I will look into it. If it is specific to haproxy, if you could > point to some relevant documentation that would be helpful. It's not specific

Re: [PATCH] MINOR: cfgparse: Fail when encountering extra arguments in macro

On Wed, May 26, 2021 at 05:45:33PM +0200, Tim Duesterhus wrote: > This resolves GitHub issue #1124. > > This change should be backported as a *warning* to 2.4. Merged, thank you Tim! Willy

Re: [EXTERNAL] Re: Connections initiated from back end timeout if routed to same back end

On Wed, May 26, 2021 at 03:46:36PM -0700, Peter Scott (US 172D) wrote: > > > frontend internal_http_80 > > >    bind xxx.xxx.xxx.xxx:80 transparent > > >    default_backend internal_http_80_backend > > > > > > backend internal_http_80_backend > > >    balance leastconn > > >    source 0.0.0.0

Re: Termination Code 'CC' + HTTP status?

On Tue, May 25, 2021 at 11:09:22AM +0200, Tim Düsterhus, WoltLab GmbH wrote: > Okay, here it is: > > https://github.com/haproxy/haproxy/issues/1266 Thank you! Willy

Re: Termination Code 'CC' + HTTP status?

On Tue, May 25, 2021 at 10:30:27AM +0200, Tim Düsterhus, WoltLab GmbH wrote: > > The 503 is just a byproduct of the aborted connection. That can sound > > strange but what happens here is that the status was set after it was > > noticed the processing ended without being able to connect to any

Re: Termination Code 'CC' + HTTP status?

Hi Tim, On Fri, May 21, 2021 at 10:22:15AM +0200, Tim Düsterhus, WoltLab GmbH wrote: > Hi List > > [this email is not subscribed, please keep it in Cc] > > I'd like your advice on a few log entries that confuse me. I am seeing HTTP > 2.0 requests dying with a termination code of 'CC', i.e.: >

Re: haproxy 1.8.30 lots of CD-- errors

Hi Jonathan, On Thu, May 20, 2021 at 08:22:59AM +1200, Jonathan Opperman wrote: > Hi All, > > I've had to remove h2 from all my front-ends, the issue seems to be gone > after doing this, any ideas? I saw a similar > post from a previous release of haproxy, but in all my >

Re: [PATCH] BUILD/MINOR: opentracing: fixed build when using clang

On Tue, May 18, 2021 at 08:15:15PM +0200, Miroslav Zagorac wrote: > Hello, > > this patch should solve the github issue #1242. Applied, thank you Miroslav! Willy

Re: Connections initiated from back end timeout if routed to same back end

Hello, On Wed, May 19, 2021 at 01:52:10PM -0700, Peter Scott (US 172D) wrote: > We have observed some behavior we do not understand with > haproxy-1.5.18-6.e17.x86_64 and need help determining what is going on and > how to get the desired behavior. > > The behavior: When an HTTP request is

Re: HAProxy-1.8 sometimes sends a shorter html when using multithread function

Hi Ryan, On Tue, May 18, 2021 at 10:54:11AM -0500, Ryan O'Hara wrote: > > > I confirmed haoproxy's log message corresponded to the > > > shorter html, the following line is one of them. > > > > > > 2021-03-23T15:54:46.869626+09:00 lb01 [err] haproxy[703957]: > > > 192.168.1.73:60572

Re: [PATCH] CI: enable OpenTracing feature

On Tue, May 18, 2021 at 01:32:56PM +0200, Tim Düsterhus wrote: > Willy, > > On 5/18/21 12:42 PM, ??? wrote: > > this enables OpenTracing for CI builds. > > This one looks good to me. Applied, thanks guys. Willy

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

On Tue, May 18, 2021 at 12:07:17PM +0200, Tim Düsterhus wrote: > Ilya, > > On 5/18/21 11:50 AM, ??? wrote: > > I wonder if we can benefit from dependent steps, i.e. build VTest just once > > and deliver binary to other containers (instead of building it every time). > > > > The

Re: HAProxy-1.8 sometimes sends a shorter html when using multithread function

Hello, On Mon, May 17, 2021 at 09:47:10AM +0900, Kazuhiro Takenaka wrote: > Hello > > This is my first post to this mailing list. > I am not good at using English, so feel free to ask me > if my text is hard to understand. Rest assured that the majority of participants here (me included) do not

Re: unexpected asan behaviour

On Tue, May 18, 2021 at 01:16:05PM +0500, ??? wrote: > Maybe sudo drops env variables Most sudo do that by default, indeed. Usually you have to use "sudo -E": $ sudo env|wc -l 19 $ sudo -E env|wc -l 70 Willy

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

On Sat, May 15, 2021 at 05:53:57PM +0200, Tim Düsterhus wrote: > Willy, > Ilya, > > On 5/15/21 8:58 AM, ??? wrote: > > I attached a patch that uses "curl". on a distance it seems to be faster > > for 50% > > > > This one looks good to me. Now merged, thanks guys. A quick comment

Re: [ANNOUNCE] haproxy-2.4.0

On Fri, May 14, 2021 at 02:23:21PM +0200, Tim Düsterhus wrote: > Willy, > > On 5/14/21 11:56 AM, Willy Tarreau wrote: > > And of course there's all the invisible stuff being done on the internals > > to improve the code, make it more extensible, more reliable or faster. I &

[ANNOUNCE] haproxy-2.4.0

Tricot-Le Breton, Thierry Fournier, Tim Duesterhus, William Dauchy, William Lallemand, Willy Tarreau, Yves Lafon It's really great to see more and more participation in multiple areas, turning good ideas into usable features, and with increasing quality overall. Let's continue like this, it's

Re: [PATCH] DOC: config: Fix configuration example for mqtt

On Thu, May 13, 2021 at 11:13:29AM -0400, Daniel Corbett wrote: > This patch fixes the example for mqtt_is_valid(), which was missing > curly braces within the ACL. Applied, thanks Daniel! Willy

Re: Inconsistent reading of txn vars from Lua script

On Thu, May 13, 2021 at 12:24:02PM +0200, Tim Düsterhus wrote: > > So what I'm proposing is to simply change vars_get_by_name() to call > > register_name() with alloc=0 in order to fix this mess. We can then > > check during 2.5 how to refine this to also consider the scope with > > the variable's

Re: Inconsistent reading of txn vars from Lua script

Hi guys, On Wed, May 12, 2021 at 09:44:28AM +0200, Willy Tarreau wrote: > On Wed, May 12, 2021 at 09:12:25AM +0200, Tim Düsterhus wrote: > > Willy, > > > > On 5/12/21 7:47 AM, Willy Tarreau wrote: > > > Interestingly, the code for variables was initially made for t

Re: [PATCH] Revert "CI: Build VTest with clang"

On Wed, May 12, 2021 at 09:08:49PM +0200, Tim Duesterhus wrote: > The issue with VTest not building properly in gcc is fixed since commit > vtest/VTest@0730540c43a2a23436b43f46327d6bac644d816d. Revert the patch to keep > the CI configuration simple. Pushed, thanks Tim! Willy

Re: [PR] Correct example reload command in the document

Hello, On Mon, May 10, 2021 at 05:23:02PM +0200, PR Bot wrote: > Description: >Current example is: > >`echo "reload" | socat /var/run/haproxy- >master.sock` > >it will cause socat error: > >`exactly 2 >addresses required (there are 1); use option "-h" for help`

Re: Inconsistent reading of txn vars from Lua script

On Wed, May 12, 2021 at 02:12:44PM -0300, Joao Morais wrote: > > It's not a matter of first or second access. It's that the function > > you used initially resulted in always allocating an entry for the > > variable's name, causing some huge memory usage for those who were > > using them like maps

Re: [PATCH] BUILD/MINOR: opentracing: fixed compilation with filter, enabled

On Wed, May 12, 2021 at 12:37:04PM +0500, ??? wrote: > I did not mean to postpone Miroslav's patch :) Ah got it, then it's not postponing it's just getting his patch in before 2.4 :-) Willy

Re: [PATCH] BUILD/MINOR: opentracing: fixed compilation with filter, enabled

Hi Miroslav, On Tue, May 11, 2021 at 07:34:05PM +0200, Miroslav Zagorac wrote: > Hello, > > The inclusion of header files proxy.h and tools.h was added to the > addons/ot/include/include.h file. Without this HAProxy cannot be > compiled if the OpenTracing filter is to be used. Thank you, now

Re: Inconsistent reading of txn vars from Lua script

On Wed, May 12, 2021 at 09:12:25AM +0200, Tim Düsterhus wrote: > Willy, > > On 5/12/21 7:47 AM, Willy Tarreau wrote: > > Interestingly, the code for variables was initially made for the config, > > so it doesn't seem to destroy variable names when they're released since &

Re: Inconsistent reading of txn vars from Lua script

On Tue, May 11, 2021 at 05:41:28PM -0300, Joao Morais wrote: > > > > Em 10 de mai. de 2021, à(s) 18:04, Willy Tarreau escreveu: > > > > On Mon, May 10, 2021 at 10:41:36PM +0200, Willy Tarreau wrote: > >>> core.register_action("auth", { "http-

Re: [PATCH] BUILD/MINOR: opentracing: fixed compilation with filter, enabled

Hi Ilya, On Tue, May 11, 2021 at 10:59:46PM +0500, ??? wrote: > I tried opentracing ci, I estimate 1-2 weeks to stabilize. Can we delay 2.4 > after that? If you mean delaying 2.4 after some extra CI is ready, not at all. What would delay it is a big last minute regression, but

Re: Error "line too long" after adding some conditions

On Tue, May 11, 2021 at 05:35:17PM +0200, Tim Düsterhus wrote: > Willy, > > On 5/11/21 5:21 PM, Willy Tarreau wrote: > > What do you guys think a more acceptable limit would be for each of them ? > > Both can be increased if needed, they will only use a little bit m

Re: [PATCH] BUG/MINOR: http_act: Fix normalizer names in error messages

Hi Tim, On Mon, May 10, 2021 at 11:21:20PM +0200, Tim Duesterhus wrote: > These places were forgotten when the normalizers were renamed. (...) All of your 3 patches applied, thank you! Willy

Re: Error "line too long" after adding some conditions

Hello, On Tue, May 11, 2021 at 04:23:09PM +0200, Adis Nezirovic wrote: > On 5/11/21 4:15 PM, Tom wrote: > > When I add some more conditions, then I got an error after reloading the > > daemon: > > > > "line too long, truncating at word 65, position 783:..." > > I'm also interested in technical

Re: [PATCH] CI: Build VTest with clang

On Tue, May 11, 2021 at 06:31:36AM +0500, ??? wrote: > There are vtest build in cirrus and travis as well. > > What if we move vtest building into "scripts/build-vtest.sh" ? That's a good idea, it would also encourage developers to update it by easing its installation. Feel free to

Re: [PATCH] spell check fixes

On Mon, May 10, 2021 at 12:51:45PM +0500, ??? wrote: > Hello, > > yet another spell check improvements. Merged, thanks Ilya! Willy

Re: Inconsistent reading of txn vars from Lua script

On Mon, May 10, 2021 at 10:41:36PM +0200, Willy Tarreau wrote: > > core.register_action("auth", { "http-req" }, function(txn) > > txn:set_var("txn.code", 401, true) So the problem is exactly here and it

Re: [PATCH] CI: Build VTest with clang

On Mon, May 10, 2021 at 10:54:31PM +0200, Tim Duesterhus wrote: > Willy, > Ilya, > > not tested, but it should be simple enough to not mess it up. Ah thank you Tim, I was also a bit annoyed by the recent failures. I've just pushed it, let's see if it works! Wlily

Re: Inconsistent reading of txn vars from Lua script

On Mon, May 10, 2021 at 07:59:56AM -0300, Joao Morais wrote: > Hello again! Here are the snippets running with 2.4-dev18 - docker image > haproxy:2.4-dev18-alpine: > > $ cat h.cfg > global > log stdout format raw local0 > lua-load /tmp/h/svc1.lua > lua-load /tmp/h/svc2.lua > defaults >

Re: [PATCH] CLEANUP: cli/activity: Remove double spacing in set profiling

On Mon, May 10, 2021 at 03:52:26PM -0400, Daniel Corbett wrote: > It was found that when viewing the help output from the CLI that > "set profiling" had 2 spaces in it, which was pushing it out from > the rest of similar commands. > > i.e. it looked like this: > prepare acl > prepare map >

Re: [ANNOUNCE] haproxy-2.4-dev19

Hi Tim, On Mon, May 10, 2021 at 10:48:38AM +0200, Tim Düsterhus wrote: > As this is expected to be the last "release candidate" I just threw > 2.4-dev19 onto one of our HAProxy machines: > > > # > > 3932master 0 *snip* > >

[ANNOUNCE] haproxy-2.4-dev19

dule check on observe mode only if fastinter is set Daniel Corbett (1): DOC: Fix a few grammar/spelling issues and casing of HAProxy Ilya Shipitsin (2): CI: Github Actions: switch to LibreSSL-3.3.3 CI: Github Actions: enable USE_QUIC=1 for BoringSSL builds Remi Tricot-Le Bre

Re: Read req scoped var from a Lua service

Hi Joao, On Sun, May 09, 2021 at 07:22:14PM -0300, Joao Morais wrote: > Hello list, following a few questions about Lua and HAProxy vars: > > Is there a way to read req scoped vars from a Lua script registered with > core.register_service()? My attempts so far didn't succeed, I need to copy >

Re: [PATCH] enable QUIC for CI builds when appropriate

Hi Ilya, On Sun, May 09, 2021 at 09:29:18PM +0500, ??? wrote: > Hello, > > USE_QUIC=1 added for BoringSSL builds. Good idea, especially as being one of those touching stuff around from time to time and not building it sometimes makes me a bit nervous. Applied, thanks! Willy

Re: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy

On Sun, May 09, 2021 at 01:33:11AM -0400, Daniel Corbett wrote: > Sorry, I forgot to add the area the patch touches to the commit title. > New patch attached to add that. Too late, already merged, but don't worry, it's neither the first one nor the last one :-) Willy

Re: [PATCH] DOC: Fix a few grammar/spelling issues and casing of HAProxy

Hi Daniel, On Sat, May 08, 2021 at 12:57:57PM -0400, Daniel Corbett wrote: > Hello, > > This patch fixes a few grammar and spelling issues in configuration.txt. > It was also noted that there was a wide range of case usage > (i.e. haproxy, HAproxy, HAProxy, etc... ). This patch updates them >

<    5   6   7   8   9   10   11   12   13   14   >