Re: [PATCH]: MEDIUM: enabling threads on osx

2019-09-13 Thread Willy Tarreau
On Fri, Sep 13, 2019 at 05:17:59AM +0100, David CARLIER wrote: > Hi ok fair points I forgot the haproxy's policy for more targeted changes :-). > For the the thread_info it is both, as it is a pointer type in macOS. But if it's a pointer type it doesn't have any reason to clash with a symbol. I'm

Re: [PATCH]: MEDIUM: enabling threads on osx

2019-09-12 Thread David CARLIER
Hi ok fair points I forgot the haproxy's policy for more targeted changes :-). For the the thread_info it is both, as it is a pointer type in macOS. Here 3 patchset. Regards. On Fri, 13 Sep 2019 at 04:03, Willy Tarreau wrote: > > Hi David, > > On Sun, Sep 08, 2019 at 04:48:54PM +0100, David CARL

Re: [PATCH]: MEDIUM: enabling threads on osx

2019-09-12 Thread Willy Tarreau
On Fri, Sep 13, 2019 at 05:03:34AM +0200, Willy Tarreau wrote: > - enable USE_CPU_AFFINITY for OSX. Please try to improve your change > using "#if defined(__APPLE__)" instead of "#if !defined(__APPLE__)" > as the construct looks quite confusing with nested #ifs. On this last point, if th

Re: [PATCH]: MEDIUM: enabling threads on osx

2019-09-12 Thread Willy Tarreau
Hi David, On Sun, Sep 08, 2019 at 04:48:54PM +0100, David CARLIER wrote: > Hi, > > Another little patch for improving osx support. Well, you should split your patch as it does at least 3 different things: - rename thread_info to ha_thread_info (it's not even clear if it's the type or the v

[PATCH]: MEDIUM: enabling threads on osx

2019-09-08 Thread David CARLIER
Hi, Another little patch for improving osx support. Cheers ! 0001-BUILD-MEDIUM-hathread-osx-support.patch Description: Binary data