[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511047#comment-16511047
]
Hudson commented on HDFS-13641:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14420 (See
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510880#comment-16510880
]
genericqa commented on HDFS-13641:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510668#comment-16510668
]
Chao Sun commented on HDFS-13641:
-
Thanks [~linyiqun]. I think the previous patch was checking metrics
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502889#comment-16502889
]
Chao Sun commented on HDFS-13641:
-
Hmm. Did you get error message like this:
{code}
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502855#comment-16502855
]
Yiqun Lin commented on HDFS-13641:
--
For the test of {{MutableRate/MutableStat}} type metrics, we can use
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502025#comment-16502025
]
Chao Sun commented on HDFS-13641:
-
bq. As I see we have added some new metrics, can we update the unit
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501355#comment-16501355
]
Yiqun Lin commented on HDFS-13641:
--
Thanks for updating the patch, [~csun]! As I see we have added some
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501137#comment-16501137
]
genericqa commented on HDFS-13641:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501044#comment-16501044
]
genericqa commented on HDFS-13641:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500872#comment-16500872
]
Erik Krogen commented on HDFS-13641:
LGTM, thanks [~csun]! Hopefully [~linyiqun] can take another
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500853#comment-16500853
]
Chao Sun commented on HDFS-13641:
-
Oops sorry I misunderstood you [~xkrogen]. Posted patch v2 to address
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500788#comment-16500788
]
Erik Krogen commented on HDFS-13641:
Thanks for addressing the comments [~csun]! I think we had a
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500716#comment-16500716
]
Chao Sun commented on HDFS-13641:
-
Thanks [~xkrogen]. Attached patch v1.
> Add metrics for edit log
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500588#comment-16500588
]
Erik Krogen commented on HDFS-13641:
{quote}
Curious: do you know roughly how much performance hit it
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500569#comment-16500569
]
Chao Sun commented on HDFS-13641:
-
Thanks [~linyiqun] and [~xkrogen] for the very helpful comments!
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500535#comment-16500535
]
Erik Krogen commented on HDFS-13641:
I really support this change, thanks for taking it up [~csun]! A
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500114#comment-16500114
]
genericqa commented on HDFS-13641:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500088#comment-16500088
]
genericqa commented on HDFS-13641:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499913#comment-16499913
]
Yiqun Lin commented on HDFS-13641:
--
Thanks for addressing the comments, [~csun]. Almost looks good, two
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499828#comment-16499828
]
Chao Sun commented on HDFS-13641:
-
Uploaded patch v0 on trunk. [~linyiqun], [~xkrogen]: could you take a
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498274#comment-16498274
]
Chao Sun commented on HDFS-13641:
-
Thanks [~linyiqun]. Will add unit test and update the doc later. Also
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497677#comment-16497677
]
Yiqun Lin commented on HDFS-13641:
--
This will be also nice to have in trunk. [~csun], would you mind
[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496264#comment-16496264
]
genericqa commented on HDFS-13641:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
23 matches
Mail list logo
