[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965003#comment-16965003
]
Hudson commented on HDFS-14927:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17596 (See
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964992#comment-16964992
]
Íñigo Goiri commented on HDFS-14927:
Thanks [~LeonG] for the patch and [~ayushtkn] for the review.
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964687#comment-16964687
]
Ayush Saxena commented on HDFS-14927:
-
v009 LGTM +1
> RBF: Add metrics for async callers thread pool
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964598#comment-16964598
]
Leon Gao commented on HDFS-14927:
-
Thanks [~inigoiri] and [~ayushtkn] for the review ^
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964502#comment-16964502
]
Íñigo Goiri commented on HDFS-14927:
+1 on [^HDFS-14927.009.patch].
> RBF: Add metrics for async
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964451#comment-16964451
]
Hadoop QA commented on HDFS-14927:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964431#comment-16964431
]
Hadoop QA commented on HDFS-14927:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964407#comment-16964407
]
Íñigo Goiri commented on HDFS-14927:
I don't think you need to catch the exception and then throw it.
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963646#comment-16963646
]
Ayush Saxena commented on HDFS-14927:
-
Thanx [~LeonG] for the patch.
Had a quick look, Just a doubt :
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962646#comment-16962646
]
Íñigo Goiri commented on HDFS-14927:
[^HDFS-14927.007.patch].
[~ayushtkn] do you mind taking a second
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962635#comment-16962635
]
Hadoop QA commented on HDFS-14927:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962610#comment-16962610
]
Hadoop QA commented on HDFS-14927:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962568#comment-16962568
]
Leon Gao commented on HDFS-14927:
-
Got it [~inigoiri], I was hesitating for that as well ^
Updated
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962558#comment-16962558
]
Íñigo Goiri commented on HDFS-14927:
Thanks for [~LeonG].
A comment, in the waitFor, we shouldn't do
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962503#comment-16962503
]
Íñigo Goiri commented on HDFS-14927:
So we are relying on the delay added when doing the slow DN.
Not
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962488#comment-16962488
]
Leon Gao commented on HDFS-14927:
-
Ah I got your question.
How it works is that
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962457#comment-16962457
]
Íñigo Goiri commented on HDFS-14927:
I think I'm missing how this call of renewLease() is done in the
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962309#comment-16962309
]
Leon Gao commented on HDFS-14927:
-
[~inigoiri] Thanks for the review
Resolved 1) and 2) in your comments
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961683#comment-16961683
]
Hadoop QA commented on HDFS-14927:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961582#comment-16961582
]
Íñigo Goiri commented on HDFS-14927:
A couple style comments:
* In TestRouterClientRejectOverload#373
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961476#comment-16961476
]
Leon Gao commented on HDFS-14927:
-
Fix checkstyle ^
[~elgoiri] I think the failure is unrelated (the
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961459#comment-16961459
]
Hadoop QA commented on HDFS-14927:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960242#comment-16960242
]
Hadoop QA commented on HDFS-14927:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960221#comment-16960221
]
Leon Gao commented on HDFS-14927:
-
Add UT and update function name to getAsyncCallerPool
> RBF: Add
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959358#comment-16959358
]
Hadoop QA commented on HDFS-14927:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959348#comment-16959348
]
Íñigo Goiri commented on HDFS-14927:
The name {{getAsyncCallerServiceThreadPoolJson()}} seems a
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959331#comment-16959331
]
Leon Gao commented on HDFS-14927:
-
[~elgoiri] Please let me know the change makes sense to you, then I
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959320#comment-16959320
]
Leon Gao commented on HDFS-14927:
-
Submitting patch and update the ticket name.. As executorService is
[
https://issues.apache.org/jira/browse/HDFS-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959321#comment-16959321
]
Leon Gao commented on HDFS-14927:
-
Example metrics:
"AsyncCallerServiceThreadPool" :
29 matches
Mail list logo
