[jira] [Updated] (HDFS-9116) Suppress false positives from Valgrind on uninitialized variables in tests

2015-09-21 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9116: - Attachment: HDFS-9116.000.patch > Suppress false positives from Valgrind on uninitialized variables in

[jira] [Created] (HDFS-9116) Suppress false positives from Valgrind on uninitialized variables in tests

2015-09-21 Thread Haohui Mai (JIRA)
Haohui Mai created HDFS-9116: Summary: Suppress false positives from Valgrind on uninitialized variables in tests Key: HDFS-9116 URL: https://issues.apache.org/jira/browse/HDFS-9116 Project: Hadoop HDFS

[jira] [Commented] (HDFS-9111) Move hdfs-client protobuf convert methods from PBHelper to PBHelperClient

2015-09-19 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14877268#comment-14877268 ] Haohui Mai commented on HDFS-9111: -- The patch looks good to me. Thanks for the work! {noformat}

[jira] [Commented] (HDFS-8696) Reduce the variances of latency of WebHDFS

2015-09-19 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14877265#comment-14877265 ] Haohui Mai commented on HDFS-8696: -- Thanks everybody. I talked to a bunch of folks offline. Here is the

[jira] [Commented] (HDFS-9101) Remove deprecated NameNode.getUri() static helper method

2015-09-18 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876789#comment-14876789 ] Haohui Mai commented on HDFS-9101: -- +1 > Remove deprecated NameNode.getUri() static helper method >

[jira] [Updated] (HDFS-9101) Remove deprecated NameNode.getUri() static helper method

2015-09-18 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9101: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-9039) Split o.a.h.hdfs.NameNodeProxies class into two classes in hadoop-hdfs-client and hadoop-hdfs modules respectively

2015-09-18 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876035#comment-14876035 ] Haohui Mai commented on HDFS-9039: -- Thanks for the work. It might make sense to to separate the work of

[jira] [Commented] (HDFS-9103) Retry reads on DN failure

2015-09-18 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876361#comment-14876361 ] Haohui Mai commented on HDFS-9103: -- It's an explicit design choice to make the failures visible to the

[jira] [Updated] (HDFS-9101) Remove deprecated NameNode.getUri() static helper method

2015-09-18 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9101: - Status: Patch Available (was: Open) > Remove deprecated NameNode.getUri() static helper method >

[jira] [Commented] (HDFS-9022) Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client

2015-09-17 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803170#comment-14803170 ] Haohui Mai commented on HDFS-9022: -- The patch looks good to me. bq. This is expected as we will file a

[jira] [Updated] (HDFS-9095) RPC client should fail gracefully when the connection is timed out or reset

2015-09-17 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9095: - Status: Patch Available (was: Open) > RPC client should fail gracefully when the connection is timed out

[jira] [Updated] (HDFS-9093) Initialize protobuf fields in RemoteBlockReaderTest

2015-09-17 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9093: - Status: Patch Available (was: Open) > Initialize protobuf fields in RemoteBlockReaderTest >

[jira] [Commented] (HDFS-9022) Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client

2015-09-17 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804459#comment-14804459 ] Haohui Mai commented on HDFS-9022: -- +1 > Move NameNode.getAddress() and NameNode.getUri() to

[jira] [Commented] (HDFS-7037) Using distcp to copy data from insecure to secure cluster via hftp doesn't work (branch-2 only)

2015-09-17 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14804594#comment-14804594 ] Haohui Mai commented on HDFS-7037: -- bq. adding this capability to HFTP does not change the security

[jira] [Updated] (HDFS-9022) Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client

2015-09-17 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9022: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Updated] (HDFS-9022) Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client

2015-09-17 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9022: - Component/s: (was: namenode) > Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client

[jira] [Updated] (HDFS-7995) Implement chmod in the HDFS Web UI

2015-09-16 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-7995: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-7995) Implement chmod in the HDFS Web UI

2015-09-16 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790912#comment-14790912 ] Haohui Mai commented on HDFS-7995: -- +1. I'll commit it shortly. > Implement chmod in the HDFS Web UI >

[jira] [Updated] (HDFS-9095) RPC client should fail gracefully when the connection is timed out or reset

2015-09-16 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9095: - Attachment: HDFS-9095.000.patch > RPC client should fail gracefully when the connection is timed out or

[jira] [Created] (HDFS-9095) RPC client should fail gracefully when the connection is timed out or reset

2015-09-16 Thread Haohui Mai (JIRA)
Haohui Mai created HDFS-9095: Summary: RPC client should fail gracefully when the connection is timed out or reset Key: HDFS-9095 URL: https://issues.apache.org/jira/browse/HDFS-9095 Project: Hadoop HDFS

[jira] [Updated] (HDFS-9093) Initialize protobuf fields in RemoteBlockReaderTest

2015-09-16 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9093: - Attachment: HDFS-9093.000.patch > Initialize protobuf fields in RemoteBlockReaderTest >

[jira] [Created] (HDFS-9093) Initialize protobuf fields in RemoteBlockReaderTest

2015-09-16 Thread Haohui Mai (JIRA)
Haohui Mai created HDFS-9093: Summary: Initialize protobuf fields in RemoteBlockReaderTest Key: HDFS-9093 URL: https://issues.apache.org/jira/browse/HDFS-9093 Project: Hadoop HDFS Issue Type:

[jira] [Commented] (HDFS-7995) Implement chmod in the HDFS Web UI

2015-09-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746806#comment-14746806 ] Haohui Mai commented on HDFS-7995: -- There is no need to give every single checkbox an id, and it can be

[jira] [Updated] (HDFS-7995) Implement chmod in the HDFS Web UI

2015-09-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-7995: - Attachment: HDFS-7995.005.patch > Implement chmod in the HDFS Web UI > --

[jira] [Updated] (HDFS-7986) Allow files / directories to be deleted from the NameNode UI

2015-09-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-7986: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-7986) Allow files / directories to be deleted from the NameNode UI

2015-09-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746510#comment-14746510 ] Haohui Mai commented on HDFS-7986: -- +1. I'll commit it shortly. > Allow files / directories to be deleted

[jira] [Commented] (HDFS-7037) Using distcp to copy data from insecure to secure cluster via hftp doesn't work (branch-2 only)

2015-09-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746350#comment-14746350 ] Haohui Mai commented on HDFS-7037: -- It looks like nothing has changed so far. The security concerns remain

[jira] [Commented] (HDFS-9055) WebHDFS REST v2

2015-09-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745880#comment-14745880 ] Haohui Mai commented on HDFS-9055: -- I agree with [~cmccabe] that the main focus of WebHDFS is

[jira] [Updated] (HDFS-8961) Surpress findbug warnings of o.a.h.hdfs.shortcircuit.DfsClientShmManager.EndpointShmManager in hdfs-client

2015-09-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8961: - Summary: Surpress findbug warnings of o.a.h.hdfs.shortcircuit.DfsClientShmManager.EndpointShmManager in

[jira] [Commented] (HDFS-8961) Surpress findbug warnings of o.a.h.hdfs.shortcircuit.DfsClientShmManager.EndpointShmManager in hdfs-client

2015-09-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746273#comment-14746273 ] Haohui Mai commented on HDFS-8961: -- Updated the jira title to reflect the final solution. Please feel free

[jira] [Commented] (HDFS-9065) Include commas on # of files, blocks, total filesystem objects in NN Web UI

2015-09-14 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744392#comment-14744392 ] Haohui Mai commented on HDFS-9065: -- Looks good to me. One nit: {code} +data['fs']['ObjectsTotal']

[jira] [Commented] (HDFS-9010) Replace NameNode.DEFAULT_PORT with HdfsClientConfigKeys.DFS_NAMENODE_RPC_PORT_DEFAULT config key

2015-09-14 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744646#comment-14744646 ] Haohui Mai commented on HDFS-9010: -- LGTM. +1. I'll commit it shortly. > Replace NameNode.DEFAULT_PORT

[jira] [Updated] (HDFS-9010) Replace NameNode.DEFAULT_PORT with HdfsClientConfigKeys.DFS_NAMENODE_RPC_PORT_DEFAULT config key

2015-09-14 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9010: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-7986) Allow files / directories to be deleted from the NameNode UI

2015-09-14 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744797#comment-14744797 ] Haohui Mai commented on HDFS-7986: -- Thanks for the work. {code} + + + + + +

[jira] [Updated] (HDFS-9065) Include commas on # of files, blocks, total filesystem objects in NN Web UI

2015-09-14 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9065: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-8545) Add an API to fetch the total file length from a specific path, apart from getting by default from root

2015-09-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742181#comment-14742181 ] Haohui Mai commented on HDFS-8545: -- The implementation looks good to me. My question is whether there are

[jira] [Created] (HDFS-9067) o.a.h.hdfs.server.datanode.fsdataset.impl.TestLazyWriter is failing in trunk

2015-09-12 Thread Haohui Mai (JIRA)
Haohui Mai created HDFS-9067: Summary: o.a.h.hdfs.server.datanode.fsdataset.impl.TestLazyWriter is failing in trunk Key: HDFS-9067 URL: https://issues.apache.org/jira/browse/HDFS-9067 Project: Hadoop

[jira] [Commented] (HDFS-9041) Move entries in META-INF/services/o.a.h.fs.FileSystem to hdfs-client

2015-09-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742167#comment-14742167 ] Haohui Mai commented on HDFS-9041: -- The test failures are unrelated. TestSafeMode did not fail in the test

[jira] [Commented] (HDFS-9065) Include commas on # of files, blocks, total filesystem objects in NN Web UI

2015-09-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742164#comment-14742164 ] Haohui Mai commented on HDFS-9065: -- The patch looks good. {code} {@addFmtNum key="{FilesTotal}"

[jira] [Updated] (HDFS-9041) Move entries in META-INF/services/o.a.h.fs.FileSystem to hdfs-client

2015-09-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9041: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-9022) Move NameNode.getAddress() and NameNode.getUri() to hadoop-hdfs-client

2015-09-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742171#comment-14742171 ] Haohui Mai commented on HDFS-9022: -- Thanks for the work. The patch looks good. I think it makes sense to

[jira] [Commented] (HDFS-9055) WebHDFS REST v2

2015-09-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741337#comment-14741337 ] Haohui Mai commented on HDFS-9055: -- bq. Adding a third protocol which nothing really supports yet doesn't

[jira] [Resolved] (HDFS-8952) InputStream.PositionRead() should be aware of available DNs

2015-09-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai resolved HDFS-8952. -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: HDFS-8707 Committed to the HDFS-8707

[jira] [Updated] (HDFS-9025) Fix compilation issues on arch linux

2015-09-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9025: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: HDFS-8707 Target

[jira] [Commented] (HDFS-9055) WebHDFS REST v2

2015-09-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741133#comment-14741133 ] Haohui Mai commented on HDFS-9055: -- Can you elaborate where and how WebHDFS v1 is broken? Do you have a

[jira] [Commented] (HDFS-9055) WebHDFS REST v2

2015-09-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741828#comment-14741828 ] Haohui Mai commented on HDFS-9055: -- bq. it does not work with curl or wget despite the above assurances.

[jira] [Commented] (HDFS-9065) Include commas on # of files, blocks, total filesystem objects in NN Web UI

2015-09-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741835#comment-14741835 ] Haohui Mai commented on HDFS-9065: -- Thanks! It might make sense to use {{Number.toLocaleString}}:

[jira] [Commented] (HDFS-7966) New Data Transfer Protocol via HTTP/2

2015-09-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741145#comment-14741145 ] Haohui Mai commented on HDFS-7966: -- I never understand the the performance numbers. What does 4% means in

[jira] [Created] (HDFS-9048) DistCp documentation is out-of-dated

2015-09-10 Thread Haohui Mai (JIRA)
Haohui Mai created HDFS-9048: Summary: DistCp documentation is out-of-dated Key: HDFS-9048 URL: https://issues.apache.org/jira/browse/HDFS-9048 Project: Hadoop HDFS Issue Type: Bug

[jira] [Resolved] (HDFS-9045) DatanodeHttpServer is not setting Endpoint based on configured policy and not loading ssl configuration.

2015-09-10 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai resolved HDFS-9045. -- Resolution: Invalid This is invalid as the Netty serves as a reverse proxy for the Jetty server. The

[jira] [Commented] (HDFS-9049) Make Datanode Netty reverse proxy port to be configurable

2015-09-10 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739352#comment-14739352 ] Haohui Mai commented on HDFS-9049: -- Why does it need to be configurable? How does it benefit deployment?

[jira] [Commented] (HDFS-9041) Move entries in META-INF/services/o.a.h.fs.FileSystem to hdfs-client

2015-09-10 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739776#comment-14739776 ] Haohui Mai commented on HDFS-9041: -- {code} + + +${basedir}/src/main/resources +

[jira] [Created] (HDFS-9041) Move entries in META-INF/services/o.a.h.fs.FileSystem to hdfs-client

2015-09-09 Thread Haohui Mai (JIRA)
Haohui Mai created HDFS-9041: Summary: Move entries in META-INF/services/o.a.h.fs.FileSystem to hdfs-client Key: HDFS-9041 URL: https://issues.apache.org/jira/browse/HDFS-9041 Project: Hadoop HDFS

[jira] [Commented] (HDFS-9037) Trash messages should be handled by Logger instead of being delivered on System.out

2015-09-09 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737742#comment-14737742 ] Haohui Mai commented on HDFS-9037: -- Why this is an incompatible change? > Trash messages should be

[jira] [Commented] (HDFS-8545) Add an API to fetch the total file length from a specific path, apart from getting by default from root

2015-09-09 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737162#comment-14737162 ] Haohui Mai commented on HDFS-8545: -- Why this should be a function in FileSystem instead of a shell

[jira] [Commented] (HDFS-9025) fix compilation issues on arch linux

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731116#comment-14731116 ] Haohui Mai commented on HDFS-9025: -- Thanks Owen for the patch. Instead of including pthread directly, it

[jira] [Commented] (HDFS-9012) Move o.a.h.hdfs.protocol.datatransfer.PipelineAck class to hadoop-hdfs-client module

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731128#comment-14731128 ] Haohui Mai commented on HDFS-9012: -- +1 > Move o.a.h.hdfs.protocol.datatransfer.PipelineAck class to

[jira] [Commented] (HDFS-9025) Fix compilation issues on arch linux

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731213#comment-14731213 ] Haohui Mai commented on HDFS-9025: -- The v2 patch pokes maven to get jenkins running. > Fix compilation

[jira] [Updated] (HDFS-9025) Fix compilation issues on arch linux

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9025: - Attachment: HDFS-9025.HDFS-8707.002.patch > Fix compilation issues on arch linux >

[jira] [Updated] (HDFS-8984) Move replication queues related methods in FSNamesystem to BlockManager

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8984: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-8128) hadoop-hdfs-client dependency convergence error

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731241#comment-14731241 ] Haohui Mai commented on HDFS-8128: -- I'm unsure whether this is the right thing to do as hadoop-hdfs-client

[jira] [Updated] (HDFS-9025) fix compilation issues on arch linux

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9025: - Attachment: HDFS-9025.HDFS-8707.001.patch > fix compilation issues on arch linux >

[jira] [Updated] (HDFS-9025) Fix compilation issues on arch linux

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9025: - Summary: Fix compilation issues on arch linux (was: fix compilation issues on arch linux) > Fix

[jira] [Updated] (HDFS-9012) Move o.a.h.hdfs.protocol.datatransfer.PipelineAck class to hadoop-hdfs-client module

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9012: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-9010) Replace NameNode.DEFAULT_PORT with HdfsClientConfigKeys.DFS_NAMENODE_RPC_PORT_DEFAULT config key

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731145#comment-14731145 ] Haohui Mai commented on HDFS-9010: -- Please do not submit the same patch for multiple times. You can

[jira] [Commented] (HDFS-9018) Update the pom to add junit dependency and move TestXAttr to client project

2015-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731148#comment-14731148 ] Haohui Mai commented on HDFS-9018: -- Yes. Pulling in some client-based related unit tests would be very

[jira] [Commented] (HDFS-8984) Move replication queues related methods in FSNamesystem to BlockManager

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729488#comment-14729488 ] Haohui Mai commented on HDFS-8984: -- Thanks for the reviews. Speaking of the race conditions, this patch

[jira] [Commented] (HDFS-8966) Separate the lock used in namespace and block management layer

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729491#comment-14729491 ] Haohui Mai commented on HDFS-8966: -- The final goal is to allow the namespace and the blockmanager run

[jira] [Updated] (HDFS-8984) Move replication queues related methods in FSNamesystem to BlockManager

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8984: - Attachment: HDFS-8984.004.patch > Move replication queues related methods in FSNamesystem to BlockManager

[jira] [Commented] (HDFS-9012) Move o.a.h.hdfs.protocol.datatransfer.PipelineAck class to hadoop-hdfs-client module

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729813#comment-14729813 ] Haohui Mai commented on HDFS-9012: -- The patch looks good to me. {code} + + /** + * Get the timeout to

[jira] [Commented] (HDFS-9018) Update the pom to add junit dependency and move TestXAttr to client project

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729817#comment-14729817 ] Haohui Mai commented on HDFS-9018: -- Maybe it makes more sense to combine this patch with actual code

[jira] [Commented] (HDFS-9002) Move o.a.h.hdfs.net/*Peer classes to client module

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729880#comment-14729880 ] Haohui Mai commented on HDFS-9002: -- Thanks. It looks good overall. {code} +++

[jira] [Commented] (HDFS-8981) Adding revision to data node jmx getVersion() method

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729990#comment-14729990 ] Haohui Mai commented on HDFS-8981: -- Thanks for the explanation. That way the JMX is consistent across NN

[jira] [Updated] (HDFS-8981) Adding revision to data node jmx getVersion() method

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8981: - Target Version/s: 3.0.0 > Adding revision to data node jmx getVersion() method >

[jira] [Commented] (HDFS-8984) Move replication queues related methods in FSNamesystem to BlockManager

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730041#comment-14730041 ] Haohui Mai commented on HDFS-8984: -- Thanks for the reviews! I'll hold off the commit until tomorrow in

[jira] [Commented] (HDFS-9002) Move o.a.h.hdfs.net/*Peer classes to client module

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729919#comment-14729919 ] Haohui Mai commented on HDFS-9002: -- Got it. Thanks. +1. > Move o.a.h.hdfs.net/*Peer classes to client

[jira] [Updated] (HDFS-9002) Move o.a.h.hdfs.net/*Peer classes to hdfs-client

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9002: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-8981) Adding revision to data node jmx getVersion() method

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729929#comment-14729929 ] Haohui Mai commented on HDFS-8981: -- It might make sense to file a new jira to deprecate the old method in

[jira] [Commented] (HDFS-9020) Support hflush/hsync in WebHDFS

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729975#comment-14729975 ] Haohui Mai commented on HDFS-9020: -- I think supporting hflush / hsync has a lot of values. I think making

[jira] [Updated] (HDFS-9002) Move o.a.h.hdfs.net/*Peer classes to hdfs-client

2015-09-03 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-9002: - Summary: Move o.a.h.hdfs.net/*Peer classes to hdfs-client (was: Move o.a.h.hdfs.net/*Peer classes to

[jira] [Commented] (HDFS-9002) Move o.a.h.hdfs.net/*Peer classes to client module

2015-09-02 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727729#comment-14727729 ] Haohui Mai commented on HDFS-9002: -- Methods in PeerUtilsClient should reside in DFSClientUtil. Other than

[jira] [Updated] (HDFS-8984) Move replication queues related methods in FSNamesystem to BlockManager

2015-09-02 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8984: - Attachment: HDFS-8984.003.patch > Move replication queues related methods in FSNamesystem to BlockManager

[jira] [Updated] (HDFS-8967) Create a BlockManagerLock class to represent the lock used in the BlockManager

2015-09-01 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8967: - Attachment: HDFS-8967.002.patch > Create a BlockManagerLock class to represent the lock used in the

[jira] [Commented] (HDFS-8967) Create a BlockManagerLock class to represent the lock used in the BlockManager

2015-09-01 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725817#comment-14725817 ] Haohui Mai commented on HDFS-8967: -- Kicking the jenkins again. > Create a BlockManagerLock class to

[jira] [Updated] (HDFS-8984) Move replication queues related methods in FSNamesystem to BlockManager

2015-09-01 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8984: - Attachment: HDFS-8984.002.patch > Move replication queues related methods in FSNamesystem to BlockManager

[jira] [Commented] (HDFS-8990) Move RemoteBlockReader to hdfs-client module

2015-08-31 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724014#comment-14724014 ] Haohui Mai commented on HDFS-8990: -- +1. I'll commit it shortly. > Move RemoteBlockReader to hdfs-client

[jira] [Updated] (HDFS-8990) Move RemoteBlockReader to hdfs-client module

2015-08-31 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8990: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Updated] (HDFS-8984) Move replication queues related methods in FSNamesystem to BlockManager

2015-08-31 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8984: - Attachment: HDFS-8984.001.patch > Move replication queues related methods in FSNamesystem to BlockManager

[jira] [Created] (HDFS-8991) Provide information on BPOfferService in DN JMX and UI

2015-08-29 Thread Haohui Mai (JIRA)
Haohui Mai created HDFS-8991: Summary: Provide information on BPOfferService in DN JMX and UI Key: HDFS-8991 URL: https://issues.apache.org/jira/browse/HDFS-8991 Project: Hadoop HDFS Issue Type:

[jira] [Updated] (HDFS-8938) Extract BlockToMarkCorrupt and ReplicationWork as standalone classes from BlockManager

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8938: - Status: Patch Available (was: Reopened) Extract BlockToMarkCorrupt and ReplicationWork as standalone

[jira] [Commented] (HDFS-8779) WebUI can't display randomly generated block ID

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720375#comment-14720375 ] Haohui Mai commented on HDFS-8779: -- -1 on the 03 patch. For 04 patch the javascript needs

[jira] [Commented] (HDFS-8779) WebUI can't display randomly generated block ID

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720399#comment-14720399 ] Haohui Mai commented on HDFS-8779: -- I'll upload a patch to demonstrate the idea later

[jira] [Commented] (HDFS-8990) Move RemoteBlockReader to hdfs-client module

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720793#comment-14720793 ] Haohui Mai commented on HDFS-8990: -- {code} public int available() throws IOException {

[jira] [Updated] (HDFS-8925) Move BlockReaderLocal to hdfs-client

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8925: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.0 Status: Resolved

[jira] [Commented] (HDFS-8967) Create a BlockManagerLock class to represent the lock used in the BlockManager

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720640#comment-14720640 ] Haohui Mai commented on HDFS-8967: -- Ran the test locally and they passed. [~daryn] can you

[jira] [Updated] (HDFS-8779) WebUI can't display randomly generated block ID

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8779: - Attachment: HDFS-8779.005.patch WebUI can't display randomly generated block ID

[jira] [Updated] (HDFS-8779) WebUI can't display randomly generated block ID

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8779: - Attachment: HDFS-8779.006.patch WebUI can't display randomly generated block ID

[jira] [Commented] (HDFS-8779) WebUI can't display randomly generated block ID

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720569#comment-14720569 ] Haohui Mai commented on HDFS-8779: -- The v06 patch is based on the idea of the v4 patch

[jira] [Commented] (HDFS-8938) Extract BlockToMarkCorrupt and ReplicationWork as standalone classes from BlockManager

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720575#comment-14720575 ] Haohui Mai commented on HDFS-8938: -- +1 on the v8 patch. Ran failed tests locally and all

[jira] [Commented] (HDFS-8925) Move BlockReader to hdfs-client

2015-08-28 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-8925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720582#comment-14720582 ] Haohui Mai commented on HDFS-8925: -- +1. The checkstyle warnings can be addressed in

<    1   2   3   4   5   6   7   8   9   10   >