[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972642#comment-16972642
]
hemanthboyina commented on HDFS-14922:
--
[~elgoiri] can you push the patch forward
> On StartUp ,
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968726#comment-16968726
]
Íñigo Goiri commented on HDFS-14922:
I would like for FSEditLogOp#3463 to be a full proper javadoc
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968674#comment-16968674
]
Hadoop QA commented on HDFS-14922:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968005#comment-16968005
]
Íñigo Goiri commented on HDFS-14922:
I meant the full javadoc:
{code}
/**
* Log that a snapshot is
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967843#comment-16967843
]
Hadoop QA commented on HDFS-14922:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967035#comment-16967035
]
Íñigo Goiri commented on HDFS-14922:
Places to add the javadoc:
* FSEditLog#logCreateSnapshot().
*
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966990#comment-16966990
]
Hadoop QA commented on HDFS-14922:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966867#comment-16966867
]
hemanthboyina commented on HDFS-14922:
--
thanks for the review [~elgoiri] [~virajith]
{quote}
It
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965208#comment-16965208
]
Virajith Jalaparti commented on HDFS-14922:
---
Thanks for fixing this [~hemanthboyina]. The edit
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965027#comment-16965027
]
Íñigo Goiri commented on HDFS-14922:
It would be good to add the javadoc through all the code path
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965012#comment-16965012
]
hemanthboyina commented on HDFS-14922:
--
can you please review the patch [~elgoiri]
> On StartUp ,
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963418#comment-16963418
]
Hadoop QA commented on HDFS-14922:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961680#comment-16961680
]
hemanthboyina commented on HDFS-14922:
--
can you review the patch [~elgoiri] [~tasanuma]
> On
[
https://issues.apache.org/jira/browse/HDFS-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959700#comment-16959700
]
Hadoop QA commented on HDFS-14922:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
14 matches
Mail list logo