[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997012#comment-14997012 ] Chris Nauroth commented on HDFS-9255: - This patch introduced a Findbugs warning, which is tracked in

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997015#comment-14997015 ] Zhe Zhang commented on HDFS-9255: - Good catch. Thanks Chris! > Consolidate block recovery related

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978676#comment-14978676 ] Hudson commented on HDFS-9255: -- SUCCESS: Integrated in Hadoop-trunk-Commit #8719 (See

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978849#comment-14978849 ] Hudson commented on HDFS-9255: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #608 (See

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978929#comment-14978929 ] Hudson commented on HDFS-9255: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #2484 (See

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978796#comment-14978796 ] Hudson commented on HDFS-9255: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #595 (See

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14978910#comment-14978910 ] Hudson commented on HDFS-9255: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #1331 (See

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979056#comment-14979056 ] Hudson commented on HDFS-9255: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #546 (See

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979118#comment-14979118 ] Hudson commented on HDFS-9255: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2538 (See

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977111#comment-14977111 ] Zhe Zhang commented on HDFS-9255: - Thanks Walter for the update. +1 on the latest patch (listing a few nits

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977209#comment-14977209 ] Jing Zhao commented on HDFS-9255: - +1 on the latest patch. Thanks Walter! > Consolidate block recovery

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977294#comment-14977294 ] Zhe Zhang commented on HDFS-9255: - [~walter.k.su] Could you set a target version? There's a conflict when

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14973952#comment-14973952 ] Hadoop QA commented on HDFS-9255: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971591#comment-14971591 ] Jing Zhao commented on HDFS-9255: - Thanks for working on this, Walter! The patch looks pretty good to me.

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970735#comment-14970735 ] Hadoop QA commented on HDFS-9255: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968707#comment-14968707 ] Walter Su commented on HDFS-9255: - The old way trims the invalid targets, shrinks the array ( by using a

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970049#comment-14970049 ] Zhe Zhang commented on HDFS-9255: - [~walter.k.su] Yes I think it makes more sense to make the

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968172#comment-14968172 ] Zhe Zhang commented on HDFS-9255: - Thanks for the clarification Walter. IIUC

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966342#comment-14966342 ] Walter Su commented on HDFS-9255: - The changes in {{commitBlockSynchronization}} is to utilize

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965937#comment-14965937 ] Zhe Zhang commented on HDFS-9255: - Thanks Walter for the work. The 04 patch looks good overall. Some

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962814#comment-14962814 ] Hadoop QA commented on HDFS-9255: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962251#comment-14962251 ] Rakesh R commented on HDFS-9255: Adding one more comment, - Please add {{@InterfaceAudience.Private}} to

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962246#comment-14962246 ] Rakesh R commented on HDFS-9255: Thanks [~walter.k.su]. Nice work! I've few comments, please see # In unit

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961210#comment-14961210 ] Hadoop QA commented on HDFS-9255: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-9255) Consolidate block recovery related implementation into a single class

[ https://issues.apache.org/jira/browse/HDFS-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960395#comment-14960395 ] Hadoop QA commented on HDFS-9255: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem