[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2018-03-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16410472#comment-16410472 ] Hudson commented on HDFS-10874: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2017-07-20 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094909#comment-16094909 ] James Clampffer commented on HDFS-10874: Thanks for the reviews [~swalk...@yahoo.c

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2017-07-20 Thread Stephen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094905#comment-16094905 ] Stephen commented on HDFS-10874: +1 > libhdfs++: Public API headers should not depend on

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2017-07-20 Thread Deepak Majeti (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094833#comment-16094833 ] Deepak Majeti commented on HDFS-10874: -- Yes! We should fix all such instances separat

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2017-07-20 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094830#comment-16094830 ] James Clampffer commented on HDFS-10874: Note: I updated tests to use the new API

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2017-07-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094727#comment-16094727 ] Hadoop QA commented on HDFS-10874: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2017-07-20 Thread Deepak Majeti (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094660#comment-16094660 ] Deepak Majeti commented on HDFS-10874: -- [~James C] Thanks for the clarification! I fe

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2017-07-20 Thread Deepak Majeti (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094589#comment-16094589 ] Deepak Majeti commented on HDFS-10874: -- * libhdfspp/lib/common/hdfs_configuration.cc:

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2017-07-19 Thread Stephen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093208#comment-16093208 ] Stephen commented on HDFS-10874: Looks good. A couple of minor suggestions: * Try to avoid

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2016-09-22 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513537#comment-15513537 ] James Clampffer commented on HDFS-10874: Oh wait.. in the current patch URI.h stil

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2016-09-21 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510235#comment-15510235 ] James Clampffer commented on HDFS-10874: Thanks for the review Bob. I'll commit/r

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2016-09-21 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509886#comment-15509886 ] Bob Hansen commented on HDFS-10874: --- +1 > libhdfs++: Public API headers should not depe

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2016-09-20 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506847#comment-15506847 ] Bob Hansen commented on HDFS-10874: --- Perhaps as another task, we should ensure that the

[jira] [Commented] (HDFS-10874) libhdfs++: Public API headers should not depend on internal implementation

2016-09-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505200#comment-15505200 ] Hadoop QA commented on HDFS-10874: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote