Re: iprop: Problem forcing complete database sync

2017-10-09 Thread Harald Barth
Have I got this right? 1. Does write_dump(context, s, database, current_version) always write a comptele dump no matter the value of current_version? 2. Does write_dump(context, s, database, current_version) only use current_version to set the version of the dump? 3. I's named "send_complete",

Re: iprop: Problem forcing complete database sync

2017-10-09 Thread Nico Williams
On Mon, Oct 9, 2017 at 3:19 AM Harald Barth wrote: > > Have I got this right? > > 1. Does write_dump(context, s, database, current_version) always write > a comptele dump no matter the value of current_version? > > 2. Does write_dump(context, s, database, current_version) only use > current_versi

Re: iprop: Problem forcing complete database sync

2017-10-09 Thread Nico Williams
On Mon, Oct 9, 2017 at 3:19 AM Harald Barth wrote: > > Have I got this right? > > 1. Does write_dump(context, s, database, current_version) always write > a comptele dump no matter the value of current_version? Yes. BTW, there's a bug here in that we don't remove the dump on failure or rename

Re: iprop: Problem forcing complete database sync

2017-10-09 Thread Nico Williams
On Mon, Oct 9, 2017 at 3:40 PM Nico Williams wrote: > On Mon, Oct 9, 2017 at 3:19 AM Harald Barth wrote: > >> >> Have I got this right? >> >> 1. Does write_dump(context, s, database, current_version) always write >> a comptele dump no matter the value of current_version? > > > Yes. BTW, there's