[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12830852#action_12830852
]
Zheng Shao commented on HIVE-1123:
--
I prefer the second format too. Ning, does checkstyle
I don't know whether checkstyle can check such a case. So we probably don't
include it in the automatically checking, but just keep in mind to avoid long
statements.
+1 from me.
On Feb 7, 2010, at 10:53 PM, Zheng Shao (JIRA) wrote:
[
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12830019#action_12830019
]
Carl Steinbach commented on HIVE-1123:
--
bq. I talked with a bunch of team members. We
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12830233#action_12830233
]
Ning Zhang commented on HIVE-1123:
--
I think all these rules are good to make the coding
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12830269#action_12830269
]
John Sichi commented on HIVE-1123:
--
+1 on what Ning said. I too prefer the second format
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829816#action_12829816
]
Ashish Thusoo commented on HIVE-1123:
-
Apart from the indentation of throws clause is
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829829#action_12829829
]
Carl Steinbach commented on HIVE-1123:
--
The following checks are common to the Hive
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829831#action_12829831
]
Carl Steinbach commented on HIVE-1123:
--
Here is a summary of the changes I made.
For
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829924#action_12829924
]
Zheng Shao commented on HIVE-1123:
--
Thanks for the list Carl! This does help a lot!
I
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829374#action_12829374
]
Zheng Shao commented on HIVE-1123:
--
Hi Carl, is it true that without the new scopes in the
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829379#action_12829379
]
Carl Steinbach commented on HIVE-1123:
--
I favor doing this:
{code:java}
int i;
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829390#action_12829390
]
Zheng Shao commented on HIVE-1123:
--
For these changes, shall we do it by the *type* of the
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12829404#action_12829404
]
Carl Steinbach commented on HIVE-1123:
--
Things that I did automatically using the
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828931#action_12828931
]
Zheng Shao commented on HIVE-1123:
--
It seems the maximum line length is 100 or something?
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828937#action_12828937
]
Zheng Shao commented on HIVE-1123:
--
Please ignore my question... I asked the same question
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828939#action_12828939
]
Zheng Shao commented on HIVE-1123:
--
It seems you made 2 spaces instead of 4 for the throws
[
https://issues.apache.org/jira/browse/HIVE-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828944#action_12828944
]
Carl Steinbach commented on HIVE-1123:
--
* The Sun coding standard does not specify how
17 matches
Mail list logo