Re: [Ilohamail-devel] where to get source

2005-10-29 Thread Kepi
Hi, my problem is that I'm not subscribed to iloha testers :) But today i browse through sf.net and found it here... IMHO latest code is still in cvs for development 0.9 version and not for stable. Yes, diffs will be great, I think that it will be meaningless if you make some changes without pub

Re: [Ilohamail-devel] Bug with forwarding attachements (need help with testing and coding) ( RESOLVED )

2005-10-29 Thread Ondra Kudlik
So after some time I found that problem is at two places. First and critical is in compose_package.inc where is fetched encoded attachement and crippled while saving to temp location. I correct this bug and attach the patch. Please, test it. Second one is in reading this crippled attachement, oth

[Ilohamail-devel] Bugs with i18n file names - patches attached

2005-10-29 Thread Ondra Kudlik
1/ If you have email with international filename attached and try to forward it, its name in compose screen will be crippled. Patch iloha-compose_fetch_ref-int_filename.patch correct this. 2/ I reported this once before, but nobody respond and I think this need testing. If you have file with wedge

[Ilohamail-devel] Iloha cant make dir in data in some cases - patch attached

2005-10-29 Thread Ondra Kudlik
In some environments Iloha cant make dirs and files in data directory also if it data dir have good permisions and ownered by apache user. This is because umask setting override mkdir mode. Attached patch correct this bug. -- .''`. Ondra 'Kepi' Kudlik : :' : Debian GNU/Linux User `. `' `- h

[Ilohamail-devel] Some strange things in imap.inc

2005-10-29 Thread Ondra Kudlik
Hi all, when I was looking for source of problem with message forwarding I found these two things: 1/ there is function iil_ReadLine($fp, $size) but $size isn't used there. IMHO :) it should be used for fgets instead fixed value, but I'm realy realy not sure. Ryo, can you say? Patch with my opini

Re: [Ilohamail-devel] Missing last character

2005-10-29 Thread Ondra Kudlik
I believe this is fixed in latest cvs by Ryo. Sat, Jun 04, 2005 ve 05:16:01PM +0200, Joerg Mertin napsal: > > >I've run into a small issue, when receiving plain text e-mails. > > > > >I'm finding that the last character is getting cut off for some reason. > > >I've glanced through the code b

[Ilohamail-devel] Howto use ajax version from cvs?

2005-10-29 Thread Ondra Kudlik
Hi, does anybody know how to use actual ajax version of iloha from cvs? It working only halfly for me, because messages are deleted, keys are functional but i.e. after deleting message it is striked but do not dissapear. In javascript console is warning that xmlobj has no params, i think this is

Re: [Ilohamail-devel] Some strange things in imap.inc

2005-10-29 Thread Ryo Chijiiwa
On 10/29/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: >Hi all, > >when I was looking for source of problem with message forwarding I >found these two things: > >1/ there is function iil_ReadLine($fp, $size) but $size isn't used >there. IMHO :) it should be used for fgets instead fixed value,

Re: [Ilohamail-devel] Some strange things in imap.inc

2005-10-29 Thread Ondra Kudlik
Sat, Oct 29, 2005 ve 04:43:26PM -0500, Ryo Chijiiwa napsal: > > > On 10/29/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: > > >Hi all, > > > >when I was looking for source of problem with message forwarding I > >found these two things: > > > >1/ there is function iil_ReadLine($fp, $size) but $s

Re: [Ilohamail-devel] Iloha cant make dir in data in some cases - patch attached

2005-10-29 Thread Andrew Alderwick
I don't quite understand this one, because I'm assuming that if the apache user has insufficient privileges to make the directory, setting the umask then won't help. Am I missing something? I was very impressed with the plethora of patches that welcome me tonight. Keep it up! :-) Cheers Andy On

Re: [Ilohamail-devel] Missing last character

2005-10-29 Thread Andrew Alderwick
Oh, good: I had wondered whether this bug had been squashed yet. Andy On 29/10/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: >I believe this is fixed in latest cvs by Ryo. > >Sat, Jun 04, 2005 ve 05:16:01PM +0200, Joerg Mertin napsal: >> >I've run into a small issue, when receiving plain text e

Re: [Ilohamail-devel] Some strange things in imap.inc

2005-10-29 Thread Andrew Alderwick
On 29/10/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: >Sat, Oct 29, 2005 ve 04:43:26PM -0500, Ryo Chijiiwa napsal: >> This does appear to be a bug. > >Should I commit it to cvs? Go ahead, it's clear that the previous line doesn't do as the author intended. Cheers Andy ---

Re: [Ilohamail-devel] Iloha cant make dir in data in some cases - patch attached

2005-10-29 Thread Ondra Kudlik
Sat, Oct 29, 2005 ve 11:21:54PM +0100, Andrew Alderwick napsal: > I don't quite understand this one, because I'm assuming that if the > apache user has insufficient privileges to make the directory, setting > the umask then won't help. Am I missing something? Yeah :) Apache user has sufficient pri

Re: [Ilohamail-devel] Some strange things in imap.inc

2005-10-29 Thread Ondra Kudlik
Sat, Oct 29, 2005 ve 11:27:13PM +0100, Andrew Alderwick napsal: > On 29/10/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: > >Sat, Oct 29, 2005 ve 04:43:26PM -0500, Ryo Chijiiwa napsal: > >> This does appear to be a bug. > > > >Should I commit it to cvs? > > Go ahead, it's clear that the previous

Re: [Ilohamail-devel] where to get source

2005-10-29 Thread Andrew Alderwick
On 29/10/2005, "Kepi" <[EMAIL PROTECTED]> wrote: >Thu, Oct 27, 2005 ve 10:04:53AM -0500, Commercial napsal: >>there are no previous/next buttons while reading a message and it does >>not display the number of the email ( it says eg. "# of 3" ) > >There are no buttons but previous next ancho

Re: [Ilohamail-devel] Iloha cant make dir in data in some cases - patch attached

2005-10-29 Thread Ondra Kudlik
> I was very impressed with the plethora of patches that welcome me > tonight. Keep it up! :-) I'll try :) It will help me if someone can look at all of them and write some opinions. It is in most cases one line fixes, so looking into patch give you idea what i have done. Tommorow ehm.. to

Re: [Ilohamail-devel] Iloha cant make dir in data in some cases - patch attached

2005-10-29 Thread Andrew Alderwick
On 29/10/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: >Sat, Oct 29, 2005 ve 11:21:54PM +0100, Andrew Alderwick napsal: >> [...] Am I missing something? > >Yeah :) Apache user has sufficient privileges, but... >[...] Thanks for that, Ondra! I see now. + // we must set umask, because it override

Re: [Ilohamail-devel] Some strange things in imap.inc

2005-10-29 Thread Andrew Alderwick
On 29/10/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: >Sat, Oct 29, 2005 ve 11:27:13PM +0100, Andrew Alderwick napsal: >> On 29/10/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: >> >Sat, Oct 29, 2005 ve 04:43:26PM -0500, Ryo Chijiiwa napsal: >> >> This does appear to be a bug. >> > >> >Should I

Re: [Ilohamail-devel] Iloha cant make dir in data in some cases - patch attached

2005-10-29 Thread Andrew Alderwick
On 29/10/2005, "Andrew Alderwick" <[EMAIL PROTECTED]> wrote: >On 29/10/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: >>Sat, Oct 29, 2005 ve 11:21:54PM +0100, Andrew Alderwick napsal: >>> [...] Am I missing something? >> >>Yeah :) Apache user has sufficient privileges, but... >>[...] > >Thanks for