On 5/15/2023 10:45 AM, Suraj Kandpal wrote:
Since topology state is being added to drm_atomic_state now all
drm_modeset_lock required are being taken from core. This raises
an issue when we try to loop over connector and assign vcpi id to
our streams as we did not have atomic state to derive
On 5/11/2023 3:26 PM, Suraj Kandpal wrote:
Since topology state is being added to drm_atomic_state now all
drm_modeset_lock required are being taken from core this raises
an issue when we try to loop over connector and assign vcpi id to
our streams as we did not have atomic state to derive
On 5/3/2023 7:07 AM, Suraj Kandpal wrote:
Check if media_gt exists if we are using gsc cs
--v2
-correct typo [Ankit]
-assign gsc variable if gt exists [Ankit]
Cc: Ankit Nautiyal
Signed-off-by: Suraj Kandpal
Reviewed-by: Gustavo Sousa
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 8
On 5/15/2023 7:21 PM, Ville Syrjälä wrote:
On Fri, May 12, 2023 at 11:54:08AM +0530, Ankit Nautiyal wrote:
In Bigjoiner check for DSC, bigjoiner interface bits for DP for
DISPLAY > 13 is 36 (Bspec: 49259).
v2: Corrected Display ver to 13.
v3: Follow convention for conditional statement.
Thanks Stan and Ville for the review comments.
I agree can have some documentation about the values used, instead of
magic numbers.
Also, Ville's approach for dsc_{sink,source}_{min,max}_bpp() seems good,
and that can be used as helpers in MST case too.
Will add the changes in the next
Thanks Ville and Stan for the comments.
I agree with the changes in _plane_min_cdclk and
intel_pixel_rate_to_cdclk regarding PPC.
But I am a little confused for about the pixel clock.
Please find my comments inline:
On 5/16/2023 3:41 PM, Lisovskiy, Stanislav wrote:
On Mon, May 15, 2023 at
On 5/5/2023 9:55 PM, Ville Syrjälä wrote:
On Thu, Apr 27, 2023 at 06:25:59PM +0530, Ankit Nautiyal wrote:
This patch series is part of a previous series:
https://patchwork.freedesktop.org/series/109470/
This adds new member sink_format to store the final format that the
sink will be using,
On 1/12/2024 1:11 PM, Suraj Kandpal wrote:
Currently we are only checking capability of remote device and not
immediate downstream device but during capability check we need are
concerned with only the HDCP capability of downstream device.
During i915_display_info reporting we need HDCP
On 1/12/2024 1:11 PM, Suraj Kandpal wrote:
Even for MST scenarios we need to do direct reads only on the
immediate downstream device the rest of the authentication is taken
care by that device. Remote reads will only be used to check
capability of the monitors in MST topology.
I think it
On 2/4/2024 7:54 PM, Suraj Kandpal wrote:
Create a remote HDCP capability shim function which can read the
remote monitor HDCP capability when in MST configuration.
--v2
-Add an assertion to make sure only mst encoder call this remote_cap
function [Ankit]
Signed-off-by: Suraj Kandpal
---
On 2/4/2024 7:55 PM, Suraj Kandpal wrote:
Currently we are only checking capability of remote device and not
immediate downstream device but during capability check we need are
concerned with only the HDCP capability of downstream device.
During i915_display_info reporting we need HDCP
On 2/15/2024 10:35 AM, Suraj Kandpal wrote:
Whenever LIC fails instead of moving from ENABLED to DESIRED
CP property we directly enable HDCP without informing the userspace
of this failure in link integrity check.
Now we will just update the value to DESIRED send the event to
userspace and
On 2/15/2024 10:35 AM, Suraj Kandpal wrote:
Allocate stream id after HDCP AKE stage and not before so that it
can also be done during link integrity check.
Right now for MST scenarios LIC fails after hdcp enablement for this
reason.
Signed-off-by: Suraj Kandpal
---
On 2/12/2024 11:06 PM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
-
On 2/5/2024 6:56 PM, Imre Deak wrote:
The DSC HW state of DP connectors is read out during driver loading and
system resume in intel_modeset_update_connector_atomic_state(). This
function is called for all connectors though and so the state of DSI
connectors will also get updated incorrectly,
On 2/12/2024 11:06 PM, Mitul Golani wrote:
Add necessary functions definitions to enable
and compute AS SDP data. The new `intel_dp_compute_as_sdp`
function computes AS SDP values based on the display
configuration, ensuring proper handling of Variable Refresh
Rate (VRR).
--v2:
- Add
On 2/12/2024 11:06 PM, Mitul Golani wrote:
Compute TRANS_VRR_VSYNC which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
---
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/display/intel_vrr.c |
Needs to be sent to dri-devel as well.
Regards,
Ankit
On 2/12/2024 11:06 PM, Mitul Golani wrote:
Add structure representing Adaptive Sync Secondary Data
Packet (AS SDP). Also, add Adaptive Sync SDP logging in
drm_dp_helper.c to facilitate debugging.
--v2:
- Update logging. [Jani, Ankit]
-
On 2/16/2024 7:50 PM, Mitul Golani wrote:
Compute vrr_vsync_start/end which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit)
- Update bit fields of
On 2/16/2024 7:50 PM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
-
On 2/16/2024 7:50 PM, Mitul Golani wrote:
Write/Read Adaptive sync SDP only when Sink and Source is enabled
for the same. Also along with write TRANS_VRR_VSYNC values.
Signed-off-by: Mitul Golani
---
drivers/gpu/drm/i915/display/intel_ddi.c | 4
On 2/16/2024 7:50 PM, Mitul Golani wrote:
Add necessary functions definitions to enable
and compute AS SDP data. The new `intel_dp_compute_as_sdp`
function computes AS SDP values based on the display
configuration, ensuring proper handling of Variable Refresh
Rate (VRR).
--v2:
- Add
On 2/16/2024 7:50 PM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
-
On 2/16/2024 7:50 PM, Mitul Golani wrote:
Add structure representing Adaptive Sync Secondary Data
Packet (AS SDP). Also, add Adaptive Sync SDP logging in
drm_dp_helper.c to facilitate debugging.
--v2:
- Update logging. [Jani, Ankit]
- use as_sdp instead of async [Ankit]
- Correct define
On 2/15/2024 4:29 PM, Suraj Kandpal wrote:
Rename hdcp_capable and hdcp_2_2_capable to hdcp_get_capability
and hdcp_2_2_get_capability to properly reflect what these functions
are doing.
Signed-off-by: Suraj Kandpal
LGTM.
Reviewed-by: Ankit Nautiyal
---
On 2/15/2024 4:29 PM, Suraj Kandpal wrote:
Whenever LIC fails instead of moving from ENABLED to DESIRED
CP property we directly enable HDCP2.2 without informing the userspace
of this failure in link integrity check.
Now we will just update the value to DESIRED send the event to
userspace and
On 2/15/2024 4:29 PM, Suraj Kandpal wrote:
Whenever LIC fails instead of moving from ENABLED to DESIRED
CP property we directly enable HDCP1.4 without informing the userspace
of this failure in link integrity check.
Now we will just update the value to DESIRED send the event to
userspace and
On 2/15/2024 4:29 PM, Suraj Kandpal wrote:
Allocate stream id after HDCP AKE stage and not before so that it
can also be done during link integrity check.
Right now for MST scenarios LIC fails after hdcp enablement for this
reason.
--v2
-no need for else block in prepare_streams function
On 11/23/2023 11:57 AM, Kandpal, Suraj wrote:
-Original Message-
From: Nautiyal, Ankit K
Sent: Wednesday, November 22, 2023 12:16 PM
To: intel-gfx@lists.freedesktop.org
Cc: Kandpal, Suraj ; Manna, Animesh
; jani.nik...@linux.intel.com; Nautiyal, Ankit K
Subject: [PATCH] drm/i915
Reviewed-by: Ankit Nautiyal
On 12/15/2023 10:39 AM, Suraj Kandpal wrote:
Fail repeater authentication step in case RX_INFO indicates
HDCP1.x or HDCP2.0/2.1 device is present downstream in repeater
topology and content type set by userspace is Type1.
--v2
-Fix build error.
--v3
-remove mst
On 12/11/2023 2:24 PM, Jani Nikula wrote:
On Mon, 11 Dec 2023, Ankit Nautiyal wrote:
Avoid checking for Downstream Facing Port capabilities,
if its not a DP branch device.
Why?
The commit message *always* needs to answer the question why. This
commit message describes what the patch does
On 1/3/2024 2:37 PM, Arun R Murthy wrote:
With a value of '0' read from MSTM_CAP register MST to be enabled.
DP2.1 SCR updates the spec for 128/132b DP capable supporting only one
stream and not supporting single stream sideband MSG.
I think, we still need to read bit
On 11/23/2023 7:32 PM, Mitul Golani wrote:
Add structure representing Adaptive Sync Secondary Data
Packet (AS SDP). Also, add Adaptive Sync SDP logging in
drm_dp_helper.c to facilitate debugging.
Signed-off-by: Mitul Golani
---
drivers/gpu/drm/display/drm_dp_helper.c | 15 +
LGTM.
Reviewed-by: Ankit Nautiyal
Regards,
Ankit
On 12/7/2023 11:05 AM, Suraj Kandpal wrote:
Fail repeater authentication step in case RX_INFO indicates
HDCP1.x or HDCP2.0/2.1 device is present downstream in repeater
topology and content type set by userspace is Type1.
--v2
-Fix build
On 11/24/2023 6:46 PM, Jani Nikula wrote:
On Thu, 23 Nov 2023, Ankit Nautiyal wrote:
Use helpers for source min/max input bpc with DSC.
Signed-off-by: Ankit Nautiyal
Reviewed-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 --
On 11/23/2023 7:32 PM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
Signed-off-by: Mitul Golani
---
.../drm/i915/display/intel_display_types.h| 1 +
Typo in the Subject: s/daptive/adaptive/
On 11/23/2023 7:32 PM, Mitul Golani wrote:
Add necessary functions and register definitions to enable
and compute AS SDP data. The new `intel_dp_compute_as_sdp`
function computes AS SDP values based on the display
configuration, ensuring proper handling
On 11/27/2023 3:07 PM, Jani Nikula wrote:
On Mon, 27 Nov 2023, Ankit Nautiyal wrote:
Use helpers for source min/max input bpc with DSC.
While at it, make them return int instead of u8.
v2: Make the helpers return int instead of u8. (Jani)
Signed-off-by: Ankit Nautiyal
Reviewed-by: Suraj
LGTM.
Reviewed-by: Ankit Nautiyal
On 2/1/2024 1:09 AM, Suraj Kandpal wrote:
Pass drm_dp_aux to intel_dp_hdcp_read_bcaps function
so as to aid in reading the bcaps for the remote monitor
later on.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 12
On 2/1/2024 1:09 AM, Suraj Kandpal wrote:
Allocate stream id after HDCP AKE stage and not before so that it
can also be done during link integrity check.
Right now for MST scenarios LIC fails after hdcp enablement for this
reason.
Signed-off-by: Suraj Kandpal
---
LGTM.
Reviewed-by: Ankit Nautiyal
On 2/1/2024 1:09 AM, Suraj Kandpal wrote:
Move checks on the source side for HDCP2.2 into its own function
so that they can be used in the HDCP remote capability check
function.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_hdcp.c |
LGTM.
Reviewed-by: Ankit Nautiyal
On 2/1/2024 1:09 AM, Suraj Kandpal wrote:
Currently intel_hdcp is not being extracted from primary connector
this patch fixes that.
Fixes: 524240b231ea ("drm/i915/hdcp: Propagate aux info in DP HDCP functions")
Signed-off-by: Suraj Kandpal
---
LGTM.
Reviewed-by: Ankit Nautiyal
On 2/1/2024 1:09 AM, Suraj Kandpal wrote:
Break intel_dp_hdcp2_capable so that the common the code can be
reused for the remote capability check.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 --
1 file
LGTM
Reviewed-by: Ankit Nautiyal
On 2/1/2024 1:09 AM, Suraj Kandpal wrote:
Break intel_dp_hdcp2_capable so that the common the code can be
reused for the remote capability check.
Signed-off-by: Suraj Kandpal
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 14 --
1 file
On 2/2/2024 12:08 PM, Suraj Kandpal wrote:
Currently we are only checking capability of remote device and not
immediate downstream device but during capability check we need are
concerned with only the HDCP capability of downstream device.
During i915_display_info reporting we need HDCP
On 2/2/2024 12:08 PM, Suraj Kandpal wrote:
Create a remote HDCP capability shim function which can read the
remote monitor HDCP capability when in MST configuration.
Signed-off-by: Suraj Kandpal
---
.../drm/i915/display/intel_display_types.h| 4
On 1/27/2024 12:14 PM, Kandpal, Suraj wrote:
=
On 1/24/2024 6:50 PM, Nautiyal, Ankit K wrote:
On 1/12/2024 1:11 PM, Suraj Kandpal wrote:
Currently we are only checking capability of remote device and not
immediate downstream device but during capability check we need are
concerned with only
LGTM.
Reviewed-by: Ankit Nautiyal
On 1/27/2024 12:46 PM, Suraj Kandpal wrote:
Even for MST scenarios we need to do direct reads only on the
immediate downstream device the rest of the authentication is taken
care by that device. Remote reads will only be used to check
capability of the
On 1/12/2024 1:11 PM, Suraj Kandpal wrote:
Now that we have moved back to direct reads the additional timing
is not required hence this can be removed.
Signed-off-by: Suraj Kandpal
Add fixes tag. With that this is,
Reviewed-by: Ankit Nautiyal
---
On 1/29/2024 11:25 PM, Imre Deak wrote:
Add a workaround to fix BS-BS jitter issues on MST links, aligning
DPT/DPTP MTPs.
Bspec: 50050, 55424
Signed-off-by: Imre Deak
LGTM.
As an aside, with these WAs do we also need to re-visit the transcoder
Data M and N values.
There is a note too
On 1/29/2024 11:25 PM, Imre Deak wrote:
Add a workaround to fix BS (blank start) to BS jitter fixes on non-UHBR
MST/FEC and UHBR links. Bspec doesn't provide an actual WA ID for this.
Bspec: 65448, 50054
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_display.c | 3 +++
On 1/29/2024 11:25 PM, Imre Deak wrote:
Add a workaround to fix BS jitter issues on MST links if the HBLANK
period is less than 1 MTP. The WA applies only to UHBR rates while on
non-UHBR the specification requires disabling it explicitly - presumedly
because the register's reset value has the
On 1/30/2024 7:35 PM, Imre Deak wrote:
On Tue, Jan 30, 2024 at 07:18:25PM +0530, Nautiyal, Ankit K wrote:
On 1/29/2024 11:25 PM, Imre Deak wrote:
Add a workaround to fix BS (blank start) to BS jitter issues on MST
links when FEC is enabled. Neither Bspec requires this nor Windows
clears
On 1/29/2024 11:25 PM, Imre Deak wrote:
Add a workaround to fix timing issues on links with DSC enabled -
presumedly related to the audio functionality.
Bspec requires enabling this workaround if audio is enabled on ADLP,
however Windows enables it whenever DSC is enabled ADLP onwards; follow
LGTM.
Reviewed-by: Ankit Nautiyal
On 1/29/2024 11:25 PM, Imre Deak wrote:
Disable the workaround inserting an SF symbol between the last DSC EOC
symbol and the subsequent BS symbol. The WA is enabled by default -
based on the register's reset value - and Bspec requires disabling it
On 1/27/2024 12:46 PM, Suraj Kandpal wrote:
Now that we have moved back to direct reads the additional timing
is not required hence this can be removed.
Signed-off-by: Suraj Kandpal
Add fixes tag. With that, this is:
Reviewed-by: Ankit Nautiyal
---
On 1/24/2024 6:50 PM, Nautiyal, Ankit K wrote:
On 1/12/2024 1:11 PM, Suraj Kandpal wrote:
Currently we are only checking capability of remote device and not
immediate downstream device but during capability check we need are
concerned with only the HDCP capability of downstream device
On 1/29/2024 11:25 PM, Imre Deak wrote:
Add a workaround to fix BS (blank start) to BS jitter issues on MST
links when FEC is enabled. Neither Bspec requires this nor Windows
clears the WA when disabling the output - presumedly because
CHICKEN_MISC_3 gets reset after disabling the
On 1/27/2024 12:46 PM, Suraj Kandpal wrote:
We see some monitors and docks report incorrect hdcp version
and capability in first few reads so we read rx_caps three times
before we conclude the monitor's or docks HDCP capability
Signed-off-by: Suraj Kandpal
---
On 11/9/2023 12:19 PM, Kandpal, Suraj wrote:
-Original Message-
From: Intel-gfx On Behalf Of Ankit
Nautiyal
Sent: Tuesday, November 7, 2023 9:48 AM
To: intel-gfx@lists.freedesktop.org
Cc: Nikula, Jani
Subject: [Intel-gfx] [PATCH 4/4] drm/i915/dp: Ignore max_requested_bpc if its
too
On 11/10/2023 3:40 PM, Ankit Nautiyal wrote:
This patch series adds support for DSC fractional compressed bpp
for MTL+. The series starts with some fixes, followed by patches that
lay groundwork to iterate over valid compressed bpps to select the
'best' compressed bpp with optimal link
On 11/14/2023 7:40 PM, Imre Deak wrote:
Convert crtc_state->pipe_bpp to U6.4 format as expected by the rest of
the function.
Fixes: 59a266f068b4 ("drm/i915/display: Store compressed bpp in U6.4 format")
Cc: Ankit Nautiyal
Cc: Suraj Kandpal
Cc: Sui Jingfeng
Signed-off-by: Imre Deak
---
On 2/26/2024 7:50 PM, Jani Nikula wrote:
On Mon, 26 Feb 2024, "Nautiyal, Ankit K" wrote:
On 2/22/2024 11:27 AM, Golani, Mitulkumar Ajitkumar wrote:
-Original Message-
From: Intel-gfx On Behalf Of
Bhanuprakash Modem
Sent: Wednesday, February 21, 2024 4:42 PM
To:
On 2/22/2024 11:27 AM, Golani, Mitulkumar Ajitkumar wrote:
-Original Message-
From: Intel-gfx On Behalf Of
Bhanuprakash Modem
Sent: Wednesday, February 21, 2024 4:42 PM
To: intel-gfx@lists.freedesktop.org
Cc: Modem, Bhanuprakash
Subject: [PATCH] drm/i915/display/debugfs: New entry
On 2/26/2024 10:40 AM, Suraj Kandpal wrote:
Create a remote HDCP capability shim function which can read the
remote monitor HDCP capability when in MST configuration.
--v2
-Add an assertion to make sure only mst encoder call this remote_cap
function [Ankit]
--v3
-rename remote_hdcp_cap to
On 2/26/2024 10:40 AM, Suraj Kandpal wrote:
Create a remote HDCP capability shim function which can read the
remote monitor HDCP capability when in MST configuration.
--v2
-Add an assertion to make sure only mst encoder call this remote_cap
function [Ankit]
--v3
-rename remote_hdcp_cap to
On 2/29/2024 10:09 PM, Mitul Golani wrote:
Add necessary function definitions to compute AS SDP data.
The new intel_dp_compute_as_sdp function computes AS SDP
values based on the display configuration, ensuring proper
handling of Variable Refresh Rate (VRR).
--v2:
- Added DP_SDP_ADAPTIVE_SYNC
On 2/29/2024 10:09 PM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
-
On 3/1/2024 2:14 PM, Mitul Golani wrote:
Add an API that indicates support for Adaptive Sync SDP in
the sink, which can be utilized by the rest of the DP programming.
--v1:
- Format commit message properly.
Signed-off-by: Mitul Golani
LGTM.
Reviewed-by: Ankit Nautiyal
---
On 3/1/2024 2:14 PM, Mitul Golani wrote:
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP).
Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate
debugging.
--v2:
- Update logging. [Jani, Ankit]
- Use 'as_sdp' instead of 'async' [Ankit]
- Correct define
On 3/1/2024 2:14 PM, Mitul Golani wrote:
Add a wrapper function to check if both the source and
sink support Adaptive Sync SDP.
--v1:
Just use drm/i915/dp in subject line.
Signed-off-by: Mitul Golani
LGTM.
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 8
Add drm/i915/display in subject line.
With that fixed this is:
Reviewed-by: Ankit Nautiyal
On 3/1/2024 2:14 PM, Mitul Golani wrote:
Add crtc state dump for Adaptive Sync SDP to know which
crtc specifically caused the failure.
Signed-off-by: Mitul Golani
---
On 3/1/2024 2:14 PM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
-
On 3/1/2024 2:15 PM, Mitul Golani wrote:
Add necessary function definitions to compute AS SDP data.
The new intel_dp_compute_as_sdp function computes AS SDP
values based on the display configuration, ensuring proper
handling of Variable Refresh Rate (VRR).
--v2:
- Added DP_SDP_ADAPTIVE_SYNC
On 3/1/2024 2:15 PM, Mitul Golani wrote:
Enable infoframe and add state checker for Adaptive Sync
SDP enablement.
--v1:
- crtc_state->infoframes.enable, to add on correct place holder.
Signed-off-by: Mitul Golani
LGTM.
Reviewed-by: Ankit Nautiyal
---
On 3/1/2024 2:15 PM, Mitul Golani wrote:
Compute vrr_vsync_start/end, which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit)
- Updated bit fields of
On 3/1/2024 2:15 PM, Mitul Golani wrote:
Write/Read Adaptive sync SDP only when Sink and Source is enabled
for the same. Also along with write TRANS_VRR_VSYNC values.
The subject line and commit message need to be updated.
Now we are just enabling Adaptive sync SDP.
Regards,
Ankit
On 2/28/2024 8:08 PM, Mitul Golani wrote:
Enable infoframe and add state checker for Adaptive Sync
SDP enablement.
Signed-off-by: Mitul Golani
---
drivers/gpu/drm/i915/display/intel_display.c | 46
drivers/gpu/drm/i915/display/intel_dp.c | 2 +
2 files changed,
On 2/29/2024 4:53 PM, Jani Nikula wrote:
On Thu, 29 Feb 2024, "Nautiyal, Ankit K" wrote:
On 2/28/2024 8:08 PM, Mitul Golani wrote:
+enum operation_mode {
+ DP_AS_SDP_AVT_DYNAMIC_VTOTAL = 0x00,
+ DP_AS_SDP_AVT_FIXED_VTOTAL = 0x01,
+ DP_AS_SDP_FAVT_TRR_NOT_REAC
On 2/28/2024 8:08 PM, Mitul Golani wrote:
Add necessary function definitions to compute AS SDP data.
The new intel_dp_compute_as_sdp function computes AS SDP
values based on the display configuration, ensuring proper
handling of Variable Refresh Rate (VRR).
--v2:
- Added DP_SDP_ADAPTIVE_SYNC
On 2/28/2024 8:08 PM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
-
On 2/28/2024 8:08 PM, Mitul Golani wrote:
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP).
Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate
debugging.
--v2:
- Update logging. [Jani, Ankit]
- Use 'as_sdp' instead of 'async' [Ankit]
- Correct define
On 2/28/2024 8:08 PM, Mitul Golani wrote:
Add a wrapper function to check if both the source and
sink support Adaptive Sync SDP.
Signed-off-by: Mitul Golani
Just use drm/i915/dp in subject line
Otherwise LGTM.
Reviewed-by: Ankit Nautiyal
---
On 2/28/2024 8:08 PM, Mitul Golani wrote:
Add an API that indicates support for Adaptive Sync SDP in
the sink, which can be utilized by the rest of the DP programming.
--v1:
- Format commit message properly.
Signed-off-by: Mitul Golani
LGTM.
Reviewed-by: Ankit Nautiyal
---
On 2/22/2024 5:42 PM, Mitul Golani wrote:
Add necessary functions definitions to enable
and compute AS SDP data. The new `intel_dp_compute_as_sdp`
function computes AS SDP values based on the display
configuration, ensuring proper handling of Variable Refresh
Rate (VRR).
--v2:
- Add
On 2/22/2024 5:42 PM, Mitul Golani wrote:
Compute vrr_vsync_start/end which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit)
- Update bit fields of
On 2/22/2024 5:42 PM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
-
On 3/5/2024 8:56 PM, Ville Syrjälä wrote:
On Mon, Feb 19, 2024 at 11:22:55AM +0530, Ankit Nautiyal wrote:
For Earlier platforms, the Pipe source size is 12-bits so
max pipe source width and height is 4096. For newer platforms it is
13-bits so theoretically max height is 8192, but maximum
On 3/7/2024 11:23 AM, Mitul Golani wrote:
Add read/write calls for Adaptive Sync SDP.
Signed-off-by: Mitul Golani
---
drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 1 +
2 files changed, 2 insertions(+)
diff --git
On 3/7/2024 11:23 AM, Mitul Golani wrote:
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
-
On 3/7/2024 11:23 AM, Mitul Golani wrote:
Compute vrr_vsync_start/end, which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit)
- Updated bit fields of
On 3/11/2024 8:26 PM, Imre Deak wrote:
Commit a62e14598150 ("drm/i915/dp: Fix connector DSC HW state readout")
moved the DSC HW state readout to a connector specific hook, however
only added the hook for DP MST connectors, not for DP SST ones. Fix
adding the hook for SST connectors as well.
On 3/13/2024 9:26 AM, Mitul Golani wrote:
Compute vrr_vsync_start/end, which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit)
- Updated bit fields of
LGTM.
Reviewed-by: Ankit Nautiyal
On 3/20/2024 10:30 AM, Mitul Golani wrote:
Compute vrr_vsync_start/end, which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit)
-
On 3/15/2024 1:56 PM, Ville Syrjälä wrote:
On Wed, Mar 13, 2024 at 08:08:25PM +0530, Ankit Nautiyal wrote:
For Earlier platforms, the Pipe source size is 12-bits so
max pipe source width and height is 4096. For newer platforms it is
13-bits so theoretically max width/height is 8192. For few
On 3/25/2024 8:47 PM, Jani Nikula wrote:
On Fri, 22 Mar 2024, Ankit Nautiyal wrote:
LSPCON can be configured to LS or PCON mode.
Separate the function to set the expected mode from the lspcon probe
function during lspcon init.
Signed-off-by: Ankit Nautiyal
---
On 3/25/2024 8:48 PM, Jani Nikula wrote:
On Fri, 22 Mar 2024, Ankit Nautiyal wrote:
Currently we probe for lspcon, inside lspcon init. Which does 2 things:
probe the lspcon and set the expected LS/PCON mode.
If there is no lspcon connected, the probe expectedly fails and
results in error
On 3/26/2024 12:26 PM, Jani Nikula wrote:
On Tue, 26 Mar 2024, "Nautiyal, Ankit K" wrote:
On 3/25/2024 8:48 PM, Jani Nikula wrote:
On Fri, 22 Mar 2024, Ankit Nautiyal wrote:
Currently we probe for lspcon, inside lspcon init. Which does 2 things:
probe the lspcon and set the e
On 3/27/2024 7:49 PM, Imre Deak wrote:
On Wed, Mar 27, 2024 at 01:40:58PM +0530, Nautiyal, Ankit K wrote:
On 3/21/2024 1:41 AM, Imre Deak wrote:
The DPCD OUI of the logical port on a Dell UHBR monitor - on which the
AUX device is used to enable DSC - is all 0. To detect if the HBLANK
On 3/27/2024 7:55 PM, Imre Deak wrote:
On Wed, Mar 27, 2024 at 02:30:53PM +0530, Nautiyal, Ankit K wrote:
On 3/21/2024 1:41 AM, Imre Deak wrote:
Add a function to get the AUX device of the parent of an MST port, used
by a follow-up i915 patch in the patchset.
Cc: Lyude Paul
Cc: dri-de
401 - 500 of 517 matches
Mail list logo
