*drm_gem_cma_create(struct drm_device *drm,
unsigned int size);
--
1.8.3.2
Looks good
Acked-by: Patrik Jakobsson patrik.r.jakobs...@gmail.com
Thanks
Patrik
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http
the problem.
Thanks
Patrik Jakobsson
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Feb 6, 2014 at 8:30 PM, Paulo Zanoni przan...@gmail.com wrote:
2014-02-06 15:22 GMT-02:00 Chris Wilson ch...@chris-wilson.co.uk:
On Thu, Feb 06, 2014 at 06:16:02PM +0100, Patrik Jakobsson wrote:
On Fri, Dec 6, 2013 at 8:47 PM, Jesse Barnes jbar...@virtuousgeek.org
wrote:
On Fri, 6
: https://bugs.freedesktop.org/show_bug.cgi?id=74628
Cc: Paulo Zanoni paulo.r.zan...@intel.com
Cc: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Patrik Jakobsson patrik.r.jakobs...@gmail.com
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
-wilson.co.uk
Signed-off-by: Patrik Jakobsson patrik.r.jakobs...@gmail.com
---
drivers/gpu/drm/i915/intel_dp.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 57552eb..6da1fcb 100644
--- a/drivers/gpu/drm/i915
On Fri, Mar 14, 2014 at 2:57 PM, Daniel Vetter dan...@ffwll.ch wrote:
On Fri, Mar 14, 2014 at 1:07 PM, Jani Nikula
jani.nik...@linux.intel.com wrote:
Fixes regression introduced by:
commit b3064154dfd37deb386b1e459c54e1ca2460b3d5
Author: Patrik Jakobsson patrik.r.jakobs...@gmail.com
Date
: Patrik Jakobsson patrik.r.jakobs...@gmail.com
Cc: Paulo Zanoni paulo.r.zan...@intel.com
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_ddi.c |1 +
drivers/gpu/drm/i915/intel_dp.c | 10 +-
2 files changed, 10 insertions(+), 1 deletion(-)
diff
outputs.
Cc: Patrik Jakobsson patrik.r.jakobs...@gmail.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/gma500/cdv_intel_lvds.c | 3 +++
drivers/gpu/drm/gma500/oaktrail_lvds.c | 5 +
drivers/gpu/drm/gma500/psb_intel_lvds.c | 3 +++
3 files changed, 11
The Intel PRM says the M1 and M2 divisors must be in the range of 10-20 and 5-9.
Since we do all calculations based on them being register values (which are
subtracted by 2) we need to specify them accordingly.
Signed-off-by: Patrik Jakobsson patrik.r.jakobs...@gmail.com
---
drivers/gpu/drm/i915
The Intel PRM says the M1 and M2 divisors must be in the range of 10-20 and 5-9.
Since we do all calculations based on them being register values (which are
subtracted by 2) we need to specify them accordingly.
Signed-off-by: Patrik Jakobsson patrik.r.jakobs...@gmail.com
---
drivers/gpu/drm/i915
On Fri, Feb 15, 2013 at 1:51 PM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Fri, Feb 15, 2013 at 12:18:49AM +, Chris Wilson wrote:
On Wed, Feb 13, 2013 at 10:20:21PM +0100, Patrik Jakobsson wrote:
The Intel PRM says the M1 and M2 divisors must be in the range of 10-20
and 5-9
On Fri, Feb 15, 2013 at 2:30 PM, Patrik Jakobsson
patrik.r.jakobs...@gmail.com wrote:
On Fri, Feb 15, 2013 at 1:51 PM, Chris Wilson ch...@chris-wilson.co.uk
wrote:
On Fri, Feb 15, 2013 at 12:18:49AM +, Chris Wilson wrote:
On Wed, Feb 13, 2013 at 10:20:21PM +0100, Patrik Jakobsson wrote
According to PRM we need to disable hsync and vsync even though ADPA is
disabled. The previous code did infact do the opposite so we fix it.
Signed-off-by: Patrik Jakobsson patrik.r.jakobs...@gmail.com
---
drivers/gpu/drm/i915/intel_crt.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
Accroding to the docs these bits don't exist on PCH platforms.
intel_crt_dpms() already has a check for this, so I suppose
intel_disable_crt() should have one too.
Also I noticed that we seem to have the hsync and vsync disable
bits reversed. At least that's what the docs are telling me.
On Tue, Mar 5, 2013 at 3:59 PM, Ville Syrjälä
ville.syrj...@linux.intel.com wrote:
On Tue, Mar 05, 2013 at 03:33:26PM +0100, Patrik Jakobsson wrote:
Accroding to the docs these bits don't exist on PCH platforms.
intel_crt_dpms() already has a check for this, so I suppose
intel_disable_crt
Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend
becoming standby and vice versa. Fixed by swapping their bit position.
Reported-by: Ville Syrjälä ville.syrj...@linux.intel.com
Signed-off-by: Patrik Jakobsson patrik.r.jakobs...@gmail.com
---
drivers/gpu/drm/i915
On Wed, Mar 6, 2013 at 12:17 AM, Paul Menzel
paulepan...@users.sourceforge.net wrote:
Dear Patrik,
Hi Paul
Am Dienstag, den 05.03.2013, 19:09 +0100 schrieb Patrik Jakobsson:
Disable bits for ADPA HSYNC and VSYNC where mixed up resulting in suspend
becoming standby and vice versa.
nice find
On Tue, Mar 26, 2013 at 8:57 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Mon, Mar 25, 2013 at 03:40:05PM -0400, Adam Jackson wrote:
f40ebd6b properly disabled the hsync/vsync logic at disable time, but
neglected to re-enable them at enable time.
v2: In the enable hook, restore the connector's
On Mon, Nov 11, 2013 at 6:57 AM, Gohad, Tushar tushar.go...@intel.com wrote:
Folks,
Hi
From what I've seen there are no real HDMI connectors on either Poulsbo or
Cedarview. It's just DVI with HDMI connectors. Though you might know of other
hardware that I don't.
SDVO_CMD_GET_SUPP_ENCODE always
will extend this patch
set if the approach looks ok. The generic drm ioctls are also missing.
Give it a spin with:
strace -e trace=ioctl -p `pidof X`
Patrik Jakobsson (2):
strace/drm: Print extended info for drm and i915 ioctls
strace/drm: Print args for most common i915 ioctls
This adds a dispatcher for extending drm ioctl debugging info and adds
the i915 ioctls to the xlat framework.
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am | 2 +
defs.h | 2 +
drm.c | 104
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
drm_i915.c | 235 +
xlat/drm_i915_getparams.in | 28 ++
xlat/drm_i915_setparams.in | 4 +
3 files changed, 267 insertions(+)
create mode 100644 xlat
On Thu, May 07, 2015 at 08:37:40AM -0700, Jesse Barnes wrote:
On 05/06/2015 07:48 AM, Patrik Jakobsson wrote:
This patch set aims to make strace more useful when tracing i915 ioctls.
The ioctl type is first checked for being drm and then the driver
backing the opened device is identified
On Mon, May 11, 2015 at 12:50:36PM +0200, Gabriel Laskar wrote:
On Wed, 6 May 2015 16:48:01 +0200
Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote:
This patch set aims to make strace more useful when tracing i915 ioctls.
The ioctl type is first checked for being drm
On Mon, May 11, 2015 at 08:08:19PM +0200, Gabriel Laskar wrote:
On Mon, 11 May 2015 15:54:24 +0200
Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote:
On Mon, May 11, 2015 at 12:50:36PM +0200, Gabriel Laskar wrote:
On Wed, 6 May 2015 16:48:01 +0200
Patrik Jakobsson patrik.jakobs
On Wed, May 13, 2015 at 01:10:17AM +0300, Dmitry V. Levin wrote:
On Tue, May 12, 2015 at 07:37:59PM +0200, Gabriel Laskar wrote:
On Tue, 12 May 2015 14:35:28 +0200, Patrik Jakobsson wrote:
On Mon, May 11, 2015 at 08:08:19PM +0200, Gabriel Laskar wrote:
On Mon, 11 May 2015 15:54:24 +0200
Use pkg-config to try to find libdrm. If that fails use the standard
include directory for kernel drm headers in /usr/include/drm.
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
configure.ac | 4
1 file changed, 4 insertions(+)
diff --git a/configure.ac b/configure.ac
There are more ioctls to add but the ones in this patch are most
commonly used.
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am| 1 +
defs.h | 2 +
drm.c | 6 +
drm_i915.c | 287
I've added a function for detecting the driver
based on it's name.
Patrik Jakobsson (4):
drm: Add config for detecting libdrm
drm: Add dispatcher and driver identification for DRM
drm: Add decoding of i915 ioctls
drm: Add decoding of DRM and KMS ioctls
Makefile.am| 2
On Tue, Jun 09, 2015 at 03:51:05PM +0200, Gabriel Laskar wrote:
On Tue, 9 Jun 2015 13:26:40 +0200
Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote:
This set of patches adds a dispatcher for handling DRM ioctls. The
kernel headers for DRM might not be available on all distributions
On Tue, Jun 09, 2015 at 03:51:10PM +0200, Gabriel Laskar wrote:
On Tue, 9 Jun 2015 13:26:42 +0200
Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote:
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am | 1 +
defs.h | 6 -
drm.c
On Tue, Jun 09, 2015 at 03:51:08PM +0200, Gabriel Laskar wrote:
On Tue, 9 Jun 2015 13:26:44 +0200
Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote:
This patch adds many of the DRM and KMS ioctls. The rest can be added as
needed.
Signed-off-by: Patrik Jakobsson patrik.jakobs
On Wed, Jun 10, 2015 at 01:14:20AM +0300, Dmitry V. Levin wrote:
On Tue, Jun 09, 2015 at 01:26:42PM +0200, Patrik Jakobsson wrote:
[...]
--- a/Makefile.am
+++ b/Makefile.am
@@ -121,6 +121,7 @@ strace_SOURCES =\
utime.c \
utimes.c\
v4l2.c
On Wed, Jun 10, 2015 at 01:35:35AM +0300, Dmitry V. Levin wrote:
On Tue, Jun 09, 2015 at 01:26:43PM +0200, Patrik Jakobsson wrote:
[...]
+static int i915_getparam(struct tcb *tcp, const unsigned int code, long
arg)
+{
+ struct drm_i915_getparam param;
+ int value
On Wed, Jun 10, 2015 at 01:46:53AM +0300, Dmitry V. Levin wrote:
On Tue, Jun 09, 2015 at 01:26:44PM +0200, Patrik Jakobsson wrote:
[...]
+static int drm_version(struct tcb *tcp, const unsigned int code, long arg)
+{
+ struct drm_version ver;
+ char *name, *date, *desc;
+ int ret
On Thu, Jun 11, 2015 at 02:26:59AM +0300, Dmitry V. Levin wrote:
On Wed, Jun 10, 2015 at 01:52:33PM +0200, Patrik Jakobsson wrote:
On Wed, Jun 10, 2015 at 01:14:20AM +0300, Dmitry V. Levin wrote:
On Tue, Jun 09, 2015 at 01:26:42PM +0200, Patrik Jakobsson wrote:
[...]
+#define
On Thu, Jun 11, 2015 at 02:27:12AM +0300, Dmitry V. Levin wrote:
On Wed, Jun 10, 2015 at 02:45:24PM +0200, Patrik Jakobsson wrote:
On Wed, Jun 10, 2015 at 01:35:35AM +0300, Dmitry V. Levin wrote:
On Tue, Jun 09, 2015 at 01:26:43PM +0200, Patrik Jakobsson wrote:
[...]
+static int
On Sat, Jun 13, 2015 at 1:48 AM, Dmitry V. Levin l...@altlinux.org wrote:
On Thu, Jun 11, 2015 at 03:34:14PM +0200, Patrik Jakobsson wrote:
On Thu, Jun 11, 2015 at 02:27:12AM +0300, Dmitry V. Levin wrote:
On Wed, Jun 10, 2015 at 02:45:24PM +0200, Patrik Jakobsson wrote:
On Wed, Jun 10, 2015
On Sat, Jun 13, 2015 at 1:41 AM, Dmitry V. Levin l...@altlinux.org wrote:
On Thu, Jun 11, 2015 at 04:11:49PM +0200, Patrik Jakobsson wrote:
On Thu, Jun 11, 2015 at 02:26:59AM +0300, Dmitry V. Levin wrote:
On Wed, Jun 10, 2015 at 01:52:33PM +0200, Patrik Jakobsson wrote:
On Wed, Jun 10, 2015
SETPARAM parameters
* xlat/drm_i915_ioctls.in: List i915 ioctls
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am| 1 +
drm.c | 14 ++
drm_i915.c | 332 +
xlat
of the ioctl.
* defs.h: Add private data field in struct tcb
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
defs.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/defs.h b/defs.h
index c02f810..5b0670e 100644
--- a/defs.h
+++ b/defs.h
@@ -266,6 +266,13 @@ struct tcb
Use pkg-config to try to find libdrm. If that fails use the standard
include directory for kernel drm headers in /usr/include/drm.
* configure.ac: Use pkg-config to find libdrm
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
configure.ac | 4
1 file changed, 4
* Reworked entering() / exiting() handling for all ioctls
* Use printstr() to print strings in properly quoted form
Patrik Jakobsson (5):
drm: Add config for detecting libdrm
drm: Add private data field to trace control block
drm: Add dispatcher and driver identification for DRM
drm: Add decoding
DRM_IOCTL_DIRTYFB
* drm.c: Decode DRM_IOCTL_CREATE_DUMB
* drm.c: Decode DRM_IOCTL_MAP_DUMB
* drm.c: Decode DRM_IOCTL_DESTROY_DUMB
* drm.c: Decode DRM_IOCTL_GEM_CLOSE
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
drm.c | 510
* Makefile.am: Add compilation of drm.c
* defs.h: Declarations of drm functions
* drm.c: Utility functions for drm driver detection
* io.c: Dispatch drm ioctls
* ioctl.c: Distpatch generic and driver specific ioctls
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am
SETPARAM parameters
* xlat/drm_i915_ioctls.in: List i915 ioctls
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am| 1 +
drm.c | 18 ++-
drm_i915.c | 332 +
xlat
* Makefile.am: Add compilation of drm.c
* defs.h: Declarations of drm functions
* drm.c: Utility functions for drm driver detection
* io.c: Dispatch drm ioctls
* ioctl.c: Distpatch generic and driver specific ioctls
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am
of the ioctl.
* defs.h: Add private data field in struct tcb
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
defs.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/defs.h b/defs.h
index c02f810..5b0670e 100644
--- a/defs.h
+++ b/defs.h
@@ -266,6 +266,13 @@ struct tcb
DRM_IOCTL_DIRTYFB
* drm.c: Decode DRM_IOCTL_CREATE_DUMB
* drm.c: Decode DRM_IOCTL_MAP_DUMB
* drm.c: Decode DRM_IOCTL_DESTROY_DUMB
* drm.c: Decode DRM_IOCTL_GEM_CLOSE
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
drm.c | 544
Use pkg-config to try to find libdrm. If that fails use the standard
include directory for kernel drm headers in /usr/include/drm.
* configure.ac: Use pkg-config to find libdrm
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
configure.ac | 4
1 file changed, 4
before private data is freed in drm_ioctl()
Patrik Jakobsson (5):
drm: Add config for detecting libdrm
drm: Add private data field to trace control block
drm: Add dispatcher and driver identification for DRM
drm: Add decoding of i915 ioctls
drm: Add decoding of DRM and KMS ioctls
On Thu, Jun 18, 2015 at 10:42:45AM +0200, Patrik Jakobsson wrote:
This patch adds many of the DRM and KMS ioctls. The rest can be added as
needed.
* drm.c: Decode DRM_IOCTL_VERSION
* drm.c: Decode DRM_IOCTL_GET_UNIQUE
* drm.c: Decode DRM_IOCTL_GET_MAGIC
* drm.c: Decode
On Mon, Jun 29, 2015 at 07:46:50PM +0200, Gabriel Laskar wrote:
On Thu, 18 Jun 2015 10:42:44 +0200
Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote:
There are more ioctls to add but the ones in this patch are most
commonly used.
* Makefile.am: Add compilation of drm_i915.c
On Mon, Jun 29, 2015 at 07:35:00PM +0200, Gabriel Laskar wrote:
On Thu, 18 Jun 2015 10:42:45 +0200
Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote:
This patch adds many of the DRM and KMS ioctls. The rest can be added as
needed.
* drm.c: Decode DRM_IOCTL_VERSION
* drm.c
On Thu, Jun 18, 2015 at 10:42:40AM +0200, Patrik Jakobsson wrote:
This set of patches adds a dispatcher for handling DRM ioctls. The
kernel headers for DRM might not be available on all distributions
so we depend on libdrm for those. If libdrm is not available we fall
back on the kernel
On Fri, Jul 03, 2015 at 03:36:09AM +0300, Dmitry V. Levin wrote:
On Wed, Jul 01, 2015 at 02:52:47PM +0200, Patrik Jakobsson wrote:
[...]
--- a/drm.c
+++ b/drm.c
@@ -35,6 +35,9 @@
#define DRM_MAX_NAME_LEN 128
+extern int drm_i915_decode_number(struct tcb *tcp, unsigned int arg
On Fri, Jul 03, 2015 at 03:33:31AM +0300, Dmitry V. Levin wrote:
On Wed, Jul 01, 2015 at 02:52:45PM +0200, Patrik Jakobsson wrote:
[...]
--- a/defs.h
+++ b/defs.h
@@ -266,6 +266,13 @@ struct tcb {
int u_error;/* Error code */
long scno; /* System call
file.
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am| 1 +
defs.h | 2 +
drm.c | 15 +-
drm_i915.c | 342 +
xlat/drm_i915_getparams.in | 28
Use pkg-config to try to find libdrm headers. If that fails look for
the kernel headers. If no headers are found, drm support will not be
compiled.
* configure.ac: Use pkg-config to find libdrm
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
configure.ac | 5 +
1 file
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
drm.c | 543 ++
1 file changed, 543 insertions(+)
diff --git a/drm.c b/drm.c
index e220309..06f2265 100644
--- a/drm.c
+++ b/drm.c
@@ -104,6 +104,471 @@ int
* Makefile.am: Add compilation of drm.c.
* defs.h: Add extern declaration of drm_ioctl when drm headers are found.
* drm.c: New file.
* ioctl.c (ioctl_decode): Dispatch drm ioctls when drm headers are found.
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
Makefile.am | 1
* Various small fixes
Patrik Jakobsson (5):
drm: Add config for detecting libdrm
drm: Add private data field to trace control block
drm: Add dispatcher and driver identification for DRM
drm: Add decoding of i915 ioctls
drm: Add decoding of DRM and KMS ioctls
Makefile.am| 2
declaration of free_tcb_priv_data.
(struct tcb): Add priv_data and free_priv_data.
* strace.c (free_tcb_priv_data): New function
(drop_tcb): Execute free_tcb_priv_data callback
* syscall.c (trace_syscall_exiting): Execute free_tcb_priv_data callback
Signed-off-by: Patrik Jakobsson patrik.jakobs
Fixes broken build introduced by:
commit 81636fdb79346e415e4726f2b6d439ccff9af1c6
Author: Rodrigo Vivi rodrigo.v...@intel.com
Date: Fri Jun 26 13:55:54 2015 -0700
drm/i915: Fix IPS related flicker
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
drivers/gpu/drm/i915
On Thu, Jul 23, 2015 at 05:48:21AM -0400, Mike Frysinger wrote:
On 01 Jul 2015 14:52, Patrik Jakobsson wrote:
Use pkg-config to try to find libdrm. If that fails use the standard
include directory for kernel drm headers in /usr/include/drm.
* configure.ac: Use pkg-config to find libdrm
in skl_compute_linetime_wm() where pixel_rate
becomes 0 when crtc_clock is 0.
Signed-off-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 38 +---
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm
On Sat, Aug 1, 2015 at 8:22 PM, Dmitry V. Levin l...@altlinux.org wrote:
On Fri, Jul 31, 2015 at 11:09:11AM +0200, Patrik Jakobsson wrote:
On Thu, Jul 30, 2015 at 10:04:49AM -0400, Mike Frysinger wrote:
On 30 Jul 2015 15:30, Patrik Jakobsson wrote:
On Thu, Jul 23, 2015 at 05:48:21AM -0400
On Mon, Aug 3, 2015 at 4:36 PM, Maarten Lankhorst
maarten.lankho...@linux.intel.com wrote:
Hey,
Op 31-07-15 om 15:04 schreef Patrik Jakobsson:
When reading out hw state for planes we disable inactive planes which in
turn triggers an update of the watermarks. The update depends
looks fine to me but I agree with Jani that you can squash
enable/disable into one commit. Now lets hope the bugs uncovered by this series
are trivial to fix.
For the entire patchset:
Reviewed-by: Patrik Jakobsson patrik.jakobs...@linux.intel.com
Thanks,
Paulo
Damien Lespiau (3):
drm
On Wed, Jul 22, 2015 at 04:34:27AM +, Gharpure, Mayuresh S wrote:
Hi Nabendu,
PFA. I came across this patch from Damien Lespiau which prevents the topmost
plane from being exposed to user space.
Once this patch is merged, the following correction in i-g-t won't be
required as it
The current CSR loading code depends on the CSR program memory to be
cleared after boot. This is unfortunately not true on all hardware.
Instead make use of the FW_UNINITIALIZED state in init and check for
FW_LOADED to prevent init path from skipping the actual programming.
Signed-off-by: Patrik
initialization of state to after HAS_CSR() check
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
Tested-by: Rodrigo Vivi <rodrigo.v...@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com>
---
drivers/gpu/drm/i915/intel_csr.c | 4 +++-
1 file changed, 3 inserti
, Patrik Jakobsson wrote:
> The current CSR loading code depends on the CSR program memory to be
> cleared after boot. This is unfortunately not true on all hardware.
> Instead make use of the FW_UNINITIALIZED state in init and check for
> FW_LOADED to prevent init path from skipping the actual
On Thu, Oct 22, 2015 at 6:07 PM, Rodrigo Vivi <rodrigo.v...@gmail.com> wrote:
> regarding your offline question: yes, I had your patch applied here, so
>
> Tested-by: Rodrigo Vivi <rodrigo.v...@intel.com>
>
> On Wed, Oct 21, 2015 at 7:57 AM, Patrik Jakobsson
> <
On Sat, Oct 24, 2015 at 11:03:05AM +0530, Animesh Manna wrote:
>
>
> On 10/23/2015 3:11 PM, Patrik Jakobsson wrote:
> >The current CSR loading code depends on the CSR program memory to be
> >cleared after boot. This is unfortunately not true on all hardware
On Tue, Oct 27, 2015 at 08:41:31PM +0200, Imre Deak wrote:
> On pe, 2015-10-23 at 11:41 +0200, Patrik Jakobsson wrote:
> > The current CSR loading code depends on the CSR program memory to be
> > cleared after boot. This is unfortunately not true on all hardware.
>
call-sites of intel_csr_load_program().
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/intel_csr.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index
oblems if we run out of
bits for power domains. We're already really close to the limit...
[Patrik: Add gmbus string to debugfs output]
Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i
for Skylake in a later patch.
v2: Check both DC5 and DC6 bits in power well enabled function (Ville)
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 6 --
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/dr
ed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
b/dr
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index e6d88f5..31b3a84 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
We need a power domain for disabling DC5/DC6 around modesets to prevent
confusing the DMC.
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 2 ++
drivers/gpu/drm/i915/i915_drv.h | 1 +
2 files changed, 3 insertions(+)
diff
We never make use of the distinction between 2 vs 4 lanes so combine
them into a per port domain instead. This saves us a few bits in the
power domain mask. Change suggested by Ville.
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_deb
://lists.freedesktop.org/archives/intel-gfx/2015-October/078898.html
Patrik Jakobsson (9):
drm/i915: Don't trust CSR program memory contents
drm/i915/gen9: Always set mask memory up when enabling DC5 or DC6
drm/i915: Remove distinction between DDI 2 vs 4 lanes
drm/i915: Add a modeset power
PG2 enabled is not a requirement for disabling DC5. It's just one
of the reasons why the DMC wouldn't enter DC5. During modeset we don't
care about PG2 from a DC perspective, only the fact that DC5/DC6 is not
allowed.
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
Re
Move call to gen9_set_dc_state_debugmask_memory_up() into
gen9_set_dc_state() to prevent us missing it somewhere.
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 35 -
1 file changed, 17 inse
oesn't change anything for CHV at least. But I think it's still a
worthwile change.
Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 40 ++
dr
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 0c7f435..77d183d 100644
--- a/drivers/gpu/dr
v2: Use _unsafe (Jani)
Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_params.c | 6 ++
drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++--
3 files changed, 9 insertions(+), 2 del
On Wed, Nov 11, 2015 at 08:37:36PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 11, 2015 at 08:22:03PM +0200, Imre Deak wrote:
> > On ma, 2015-11-09 at 16:48 +0100, Patrik Jakobsson wrote:
> > > From: Ville Syrjälä <ville.syrj...@linux.intel.com>
On Wed, Nov 11, 2015 at 08:57:19PM +0200, Imre Deak wrote:
> On ma, 2015-11-09 at 16:48 +0100, Patrik Jakobsson wrote:
> > Handle DC off as a power well where enabling the power well will
> > prevent
> > the DMC to enter selected DC states (required around modesets and
On Wed, Nov 11, 2015 at 09:23:32PM +0200, Imre Deak wrote:
> On ma, 2015-11-09 at 16:48 +0100, Patrik Jakobsson wrote:
> > Handle DC off as a power well where enabling the power well will
> > prevent
> > the DMC to enter selected DC states (required around modesets and
On Wed, Nov 11, 2015 at 09:04:09PM +0200, Imre Deak wrote:
> On ma, 2015-11-09 at 16:48 +0100, Patrik Jakobsson wrote:
> > v2: Use _unsafe (Jani)
> >
> > Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i9
On Wed, Nov 11, 2015 at 09:13:27PM +0200, Imre Deak wrote:
> On ma, 2015-11-09 at 16:48 +0100, Patrik Jakobsson wrote:
> > Signed-off-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 2 ++
> > 1 file changed, 2
in ->data. With that said, I don't think it's
worth fixing right here and now and since we add some comments about this in
later patches I'm ok with this.
Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
>
> Signed-off-by: Imre Deak <imre.d...@intel.com&
ells, so fix things up accordingly.
>
Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
> Signed-off-by: Imre Deak <imre.d...@intel.com>
> ---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
ardcoded indexes.
>
> Testcase: igt/pm_rpm/rte (and every other rpm test)
> Signed-off-by: Damien Lespiau <damien.lesp...@intel.com>
> Reviewed-by: Paulo Zanoni <paulo.r.zan...@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zan...@intel.com>
Reviewed-by: Patrik Jak
these fixes/changes in a BXT follow-up series later on.
Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
>
> Signed-off-by: Imre Deak <imre.d...@intel.com>
> ---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 36
> +
>
d if we try to enable DC5 or DC6 so we only have to
care about it at one place in the code. Perhaps we could even move it to
skl_display_core_init() if we do additional testing on when it needs to be
reset. Either way, not a biggie so let's ignore it for now.
Reviewed-by: Patrik Jakobsson <patrik.ja
since we get to the display core uninit step with all power
> domains disabled already).
>
> Signed-off-by: Imre Deak <imre.d...@intel.com>
Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 4
>
1 - 100 of 260 matches
Mail list logo
