Re: [Intel-gfx] [alsa-devel] Timing issues between ALSA and i915 drivers

I tried to narrow down the issue further and my current understanding is that the Skylake driver performs link reset operations without the display power turned on - which does not look like a very smart thing to do in hindsight. In other words, it's not really when snd_hdac_i915_init() is

Re: [Intel-gfx] [alsa-devel] Timing issues between ALSA and i915 drivers

I could use some feedback on HDMI audio issues exposed during the 4.21 merge window. By accident (misleading documentation) we ended up enabling the Skylake driver instead of the HDaudio legacy, and broke audio on a number of Skylake and ApolloLake devices where the HDMI/iDISP codec was not

Re: [Intel-gfx] [alsa-devel] Timing issues between ALSA and i915 drivers

a) compiling both SOUND and DRM as built-ins (y instead of m) b) moving the calls snd_hdac_i915_init() to the probe function instead of the worker queue (code at https://github.com/plbossart/sound/commits/fix/skl-hdmi) I added DRM+audio dmesg logs at the following link for reference:

Re: [Intel-gfx] Timing issues between ALSA and i915 drivers

I could use some feedback on HDMI audio issues exposed during the 4.21 merge window. By accident (misleading documentation) we ended up enabling the Skylake driver instead of the HDaudio legacy, and broke audio on a number of Skylake and ApolloLake devices where the HDMI/iDISP codec was not

[Intel-gfx] Timing issues between ALSA and i915 drivers

Hi, I could use some feedback on HDMI audio issues exposed during the 4.21 merge window. By accident (misleading documentation) we ended up enabling the Skylake driver instead of the HDaudio legacy, and broke audio on a number of Skylake and ApolloLake devices where the HDMI/iDISP codec was

Re: [Intel-gfx] [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

On 7/19/18 1:56 PM, Takashi Iwai wrote: On Thu, 19 Jul 2018 15:05:45 +0200, Pierre-Louis Bossart wrote: On 7/19/18 12:50 AM, Takashi Iwai wrote: On Wed, 18 Jul 2018 22:54:35 +0200, Pierre-Louis Bossart wrote: On 07/17/2018 04:26 AM, Takashi Iwai wrote: Hi, this is a preliminiary patch

Re: [Intel-gfx] [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

On 7/19/18 12:50 AM, Takashi Iwai wrote: On Wed, 18 Jul 2018 22:54:35 +0200, Pierre-Louis Bossart wrote: On 07/17/2018 04:26 AM, Takashi Iwai wrote: Hi, this is a preliminiary patch set to convert the existing i915 / HD-audio component binding to be applicable to other drivers like radeon

Re: [Intel-gfx] [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

On 07/17/2018 04:26 AM, Takashi Iwai wrote: Hi, this is a preliminiary patch set to convert the existing i915 / HD-audio component binding to be applicable to other drivers like radeon / amdgpu. This patchset itself doesn't change the functionality but only renames and split to a new

Re: [Intel-gfx] [alsa-devel] [PATCH v2 00/11] drm/i915: LPE audio runtime PM and multipipe (v2)

On 5/2/17 1:27 PM, Ville Syrjälä wrote: On Mon, May 01, 2017 at 08:29:10PM -0500, Pierre-Louis Bossart wrote: On 04/28/2017 02:37 PM, Ville Syrjälä wrote: On Fri, Apr 28, 2017 at 12:10:31PM -0500, Pierre-Louis Bossart wrote: On 04/28/2017 03:41 AM, Takashi Iwai wrote: On Thu, 27 Apr 2017

Re: [Intel-gfx] [alsa-devel] [PATCH v2 00/11] drm/i915: LPE audio runtime PM and multipipe (v2)

On 04/28/2017 02:37 PM, Ville Syrjälä wrote: On Fri, Apr 28, 2017 at 12:10:31PM -0500, Pierre-Louis Bossart wrote: On 04/28/2017 03:41 AM, Takashi Iwai wrote: On Thu, 27 Apr 2017 18:02:19 +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä <ville.syrj...@linux.intel.com>

Re: [Intel-gfx] [alsa-devel] [PATCH v2 11/11] ALSA: x86: Register multiple PCM devices for the LPE audio card

CM per port instead of per pipe Cc: Takashi Iwai <ti...@suse.de> Cc: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> :04 04 17f94eecd597b97ccc003e2d27c03eadceb279f5 271d4c3130f9cc1334

Re: [Intel-gfx] [alsa-devel] [PATCH v2 00/11] drm/i915: LPE audio runtime PM and multipipe (v2)

y many drivers have already mixed them up. So it's no problem :) Entire series available here: git://github.com/vsyrjala/linux.git lpe_audio_multipipe_2 Cc: Takashi Iwai <ti...@suse.de> Cc: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> All look good, and feel free to take

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Stop pretending to mask/unmask LPE audio interrupts

is enabled, so the IIR bits will never be set in >that case. Cc: Takashi Iwai <ti...@suse.de> Cc: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/i915/i915_irq.c| 15 ++-

Re: [Intel-gfx] [alsa-devel] [PATCH 05/11] drm/i915: Replace tmds_clock_speed and link_rate with just ls_clock

symbol clock. So let's just call the thing ls_clock and simplify the code. there are still occurences of 'tmds' in sound/x86 and there are are couple of debug messages that don't make sense any longer. Cc: Takashi Iwai <ti...@suse.de> Cc: Pierre-Louis Bossart <pierre-louis.boss...@

Re: [Intel-gfx] [alsa-devel] [PATCH 11/11] ALSA: x86: Register multiple PCM devices for the LPE audio card

se.de> Cc: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/i915/intel_lpe_audio.c | 14 - include/drm/intel_lpe_audio.h | 6 ++-- sound/x86/intel_hdm

Re: [Intel-gfx] [RFC PATCH 4/5] drm: i915: add DisplayPort amp unmute for LPE audio mode

+#define AUD_PORT_EN_B_DBG 0x62F20 +#define AUD_PORT_EN_C_DBG 0x62F28 +#define AUD_PORT_EN_D_DBG 0x62F2C These match the spec. But to match the standard i915 convention they should be called _AUD_PORT_EN_B_DBG etc. Same forthe chicken bit register.

Re: [Intel-gfx] [RFC PATCH 4/5] drm: i915: add DisplayPort amp unmute for LPE audio mode

Thanks Jani and Ville for the comments. Couple of precisions needed below: #define GEN6_BSD_RNCID_MMIO(0x12198) #define GEN7_FF_THREAD_MODE _MMIO(0x20a0) diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c index

Re: [Intel-gfx] [alsa-devel] [PATCH RFC 1/3] drm/i915: Avoid MST pipe handling for LPE audio

-audio. Reported-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/intel_audio.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/inte

[Intel-gfx] [RFC PATCH 5/5] ALSA: x86: hdmi: hack to enable DP audio on CHT

-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- sound/x86/intel_hdmi_lpe_audio.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/x86/intel_hdmi_lpe_audio.c b/sound/x86/intel_hdmi_lpe_audio.c index 6ef0ff8..23e5b34 100644 --- a/sou

[Intel-gfx] [RFC PATCH 1/5] drm: i915: add DP support in LPE audio mode

If DisplayPort is detected, pass flag and link rate to audio driver Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/i915_drv.h| 3 ++- drivers/gpu/drm/i915/intel_audio.c | 19 +++ drivers/gpu/dr

[Intel-gfx] [RFC PATCH 3/5] ALSA: x86: intel_hdmi: set config bitfields for DP mode

These bits were set in legacy and not in upstream code, and are apparently tested for when writing a config in DP mode FIXME: is this even needed? Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- sound/x86/intel_hdmi_audio.c | 2 ++ 1 file changed, 2 inse

[Intel-gfx] [RFC PATCH 4/5] drm: i915: add DisplayPort amp unmute for LPE audio mode

Enable chicken bit on LPE mode setup and unmute amp on notification FIXME: should these two phases done somewhere else? Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h| 12 drivers/gpu/drm/i915/intel_lpe_a

[Intel-gfx] [RFC PATCH 0/5] DisplayPort Audio on Cherrytrail

is it available (initial trials showed the pipe is still invalid when the audio notification happens) Feedback welcome! Pierre-Louis Bossart (5): drm: i915: add DP support in LPE audio mode ALSA: x86: intel_hdmi: add definitions and logic for DP audio ALSA: x86: intel_hdmi: set config bitfields

[Intel-gfx] [RFC PATCH 2/5] ALSA: x86: intel_hdmi: add definitions and logic for DP audio

Imported from legacy patches Note: the new code doesn't assume a modified ELD but an explicit notification that DP is present. It appears that the i915 code does change the ELD so we could use the ELD-based tests to check for DP audio Signed-off-by: Pierre-Louis Bossart <pierre-louis.b

Re: [Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

On 1/25/17 3:21 PM, Takashi Iwai wrote: On Tue, 24 Jan 2017 23:57:48 +0100, Jerome Anand wrote: This patch series has only been tested on hardware with a single HDMI connector/pipe and additional work may be needed for newer machines with 2 connectors BTW, I have such a machine, CHV with two

Re: [Intel-gfx] [PATCH v4 2/5] drm/i915: Add support for audio driver notifications

#include @@ -630,6 +631,10 @@ void intel_audio_codec_enable(struct intel_encoder *intel_encoder, if (acomp && acomp->audio_ops && acomp->audio_ops->pin_eld_notify) acomp->audio_ops->pin_eld_notify(acomp->audio_ops->audio_ptr,

Re: [Intel-gfx] [alsa-devel] [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT

On 1/20/17 5:15 AM, Takashi Iwai wrote: On Fri, 20 Jan 2017 23:22:31 +0100, Jerome Anand wrote: + had_ops_v1 = had_ops_v1;/* unused */ Until now I didn't realize that the whole v1 stuff is never used in the current patchset. Will it be ever used in future? If not, can't we

Re: [Intel-gfx] [alsa-devel] [PATCH V2 7/7] ALSA: x86: hdmi: continue playback even when display resolution changes

is enabled with a different N/CTS values Add comment that this patch series has only been tested on hardware with a single HDMI connector/pipe and additional work may be needed for newer machines with 2 connectors. Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com>

Re: [Intel-gfx] [alsa-devel] [PATCH V2 6/7] ALSA: x86: hdmi: Fixup some monitor

. Signed-off-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Jerome Anand <jerome.an...@intel.com> --- sound/x86/intel_hdmi_audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Intel-gfx] [alsa-devel] [PATCH V2 5/7] ALSA: x86: hdmi: Improve position reporting

. Signed-off-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Jerome Anand <jerome.an...@intel.com> --- sound/x86/intel_hdmi_audio.c | 12 +++- 1 file changed, 11 insertions(+), 1

Re: [Intel-gfx] [alsa-devel] [PATCH V2 3/7] ALSA: add shell for Intel HDMI LPE audio driver

d platform device. Since this driver is neither SoC nor PCI, a new x86 folder is added Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Jerome Anand <jerome.an...@intel.com> Change the commit title to remove 'shell', e.g. 'add BYT/CHT-T

Re: [Intel-gfx] [alsa-devel] [PATCH V2 2/7] drm/i915: Add support for audio driver notifications

by the audio driver is added Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Jerome Anand <jerome.an...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h| 3 +++ drivers/gpu/drm/i915/intel_audio.c | 8 ++ drivers/gpu/drm/i915/intel_hdmi

Re: [Intel-gfx] [alsa-devel] [PATCH V2 1/7] drm/i915: setup bridge for HDMI LPE audio driver

-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Jerome Anand <jerome.an...@intel.com> --- Documentation/gpu/i915.rst | 9 + drivers/gpu/drm/i915/Makefile | 3 + drivers/gpu/drm/i915/i915_drv.c| 8 +- drivers/

Re: [Intel-gfx] [alsa-devel] [PATCH 7/7] ALSA: x86: hdmi: continue playback even when display resolution changes

This change itself is OK, but this made me wonder about the driver implementation: the current MAX_PB=1 is the hardware limitation or the soft limitation? That is, can't we play back two streams when we connect two HDMI monitors? Two streams was never validated from hardware per se. So

Re: [Intel-gfx] [alsa-devel] [PATCH 3/7] ALSA: add shell for Intel HDMI LPE audio driver

Subject: Re: [PATCH 3/7] ALSA: add shell for Intel HDMI LPE audio driver Why do we need a "shell" and indirect calls? This is a small driver set, so it's not utterly unacceptable, but it still makes things a bit more complicated than necessary, so I'd like to understand the idea behind it.

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add support for audio driver notifications

On 12/14/16 7:13 AM, Takashi Iwai wrote: On Wed, 14 Dec 2016 13:55:52 +0100, Daniel Vetter wrote: Only noticed it here, but why again do we need to re-roll our intel-only hdmi/eld notification? The one we have for hda is somewhat justified since it went in at roughly the same time as the new

Re: [Intel-gfx] [alsa-devel] [PATCH 1/7] drm/i915: setup bridge for HDMI LPE audio driver

>>> +static void lpe_audio_irq_unmask(struct irq_data *d) { >>> + struct drm_i915_private *dev_priv = d->chip_data; >>> + unsigned long irqflags; >>> + u32 val = (I915_LPE_PIPE_A_INTERRUPT | >>> + I915_LPE_PIPE_B_INTERRUPT); >> >> PIPE_C missing? >> > > No PIPE_C on vlv Good catch

Re: [Intel-gfx] [alsa-devel] [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting

On 12/14/16 8:36 AM, Takashi Iwai wrote: On Wed, 14 Dec 2016 15:09:20 +0100, Pierre-Louis Bossart wrote: On 12/14/16 6:57 AM, Takashi Iwai wrote: On Mon, 12 Dec 2016 19:10:41 +0100, Jerome Anand wrote: Use a hw register to calculate sub-period position reports. This makes PulseAudio happier

Re: [Intel-gfx] [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting

On 12/14/16 6:57 AM, Takashi Iwai wrote: On Mon, 12 Dec 2016 19:10:41 +0100, Jerome Anand wrote: Use a hw register to calculate sub-period position reports. This makes PulseAudio happier. Signed-off-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis B

Re: [Intel-gfx] [PATCH] drm/dp/mst: fix kernel oops when turning off secondary monitor

On 12/5/16 3:39 PM, Pandiyan, Dhinakaran wrote: On Mon, 2016-12-05 at 08:02 +, Chris Wilson wrote: On Sun, Dec 04, 2016 at 07:31:18PM -0600, Pierre-Louis Bossart wrote: 100% reproducible issue found on SKL SkullCanyon NUC with two external DP daisy-chained monitors in DP/MST mode. When

[Intel-gfx] [PATCH v2] drm/dp/mst: fix kernel oops when turning off secondary monitor

lla: https://bugs.freedesktop.org/show_bug.cgi?id=98990 Cc: Dave Airlie <airl...@redhat.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_top

[Intel-gfx] [PATCH] drm/dp/mst: fix kernel oops when turning off secondary monitor

Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index aa64448..5481fde

Re: [Intel-gfx] [RFC PATCH v3 2/7] drm/i915: Add support for audio driver notifications

On 11/28/16 1:30 PM, Ville Syrjälä wrote: On Mon, Nov 28, 2016 at 01:13:31PM -0600, Pierre-Louis Bossart wrote: On 11/28/16 11:01 AM, Ville Syrjälä wrote: + if (pdata->notify_audio_lpe) + pdata->notify_aud

Re: [Intel-gfx] [RFC PATCH v3 2/7] drm/i915: Add support for audio driver notifications

On 11/28/16 11:01 AM, Ville Syrjälä wrote: + if (pdata->notify_audio_lpe) + pdata->notify_audio_lpe( + (eld != NULL) ? >eld : NULL); + else +

Re: [Intel-gfx] [alsa-devel] [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver

On 11/24/16 7:31 AM, Ville Syrjälä wrote: +static void lpe_audio_irq_unmask(struct irq_data *d) +{ + struct drm_device *dev = d->chip_data; + struct drm_i915_private *dev_priv = to_i915(dev); + unsigned long irqflags; + u32 val = (I915_LPE_PIPE_A_INTERRUPT | +

Re: [Intel-gfx] [RFC PATCH v2 0/8] Add support for Legacy Hdmi audio

On 11/9/16 7:19 AM, Mark Brown wrote: On Sun, Nov 06, 2016 at 11:42:31PM -0700, Pierre-Louis Bossart wrote: I am all for convergence when it makes sense but I don't see how hdmi-codec.h provides equivalent functionality for BYT/CHT with what was suggested in this patchset -derived from VED

Re: [Intel-gfx] [RFC PATCH v2 0/8] Add support for Legacy Hdmi audio

On 11/3/16 5:01 PM, Daniel Vetter wrote: On Sat, Oct 1, 2016 at 2:22 AM, Jerome Anand wrote: Legacy Hdmi audio drivers are added. Added support for audio/ gfx interface using irq chip framework Just discussed this with Rakesh here at LPC and also with Mark Brown and

Re: [Intel-gfx] Baytrail MIPI/DSI Black when boot with HDMI connected

On 10/28/16 1:48 AM, Jani Nikula wrote: On Fri, 28 Oct 2016, Fabian Pie wrote: Hi, I'm testing Baytrail device with mipi/dsi display and hdmi output. When I boot without the hdmi connected the mipi/dsi works OK and after connecting the hdmi both mipi/dsi and hdmi display

[Intel-gfx] Screen flicker regression on Baytrail

While testing our upcoming HDMI audio patches, I experienced pretty bad screen flicker regressions on my Baytrail compute stick. This happens with both v09-rc2 and drm-intel-nightly. A quick bisect with all the audio patches removed points to the following commit:

Re: [Intel-gfx] [RFC PATCH v2 4/8] drm/i915: Add support for enabling/disabling hdmi audio interrupts

+/* Added for HDMI Audio */ +int i915_enable_hdmi_audio_int(struct drm_i915_private *dev_priv) +{ + unsigned long irqflags; + u32 imr, int_bit; + int pipe = -1; + + spin_lock_irqsave(_priv->irq_lock, irqflags); + + imr = I915_READ(VLV_IMR); + + if

Re: [Intel-gfx] [RFC PATCH v2 1/8] drm/i915: setup bridge for HDMI LPE audio driver

Thanks Ville for the review. A lot of the comments are related to the initial VED code we took pretty much as is, no issues to clean-up further. BTW, it looks like Jerome's patches were stuck for 10+ days on the intel-gfx server for some reason so not everyone saw the initial post? @@

Re: [Intel-gfx] i915 issues with 4.6

On 5/18/16 3:53 PM, Pierre-Louis Bossart wrote: On 5/18/16 2:08 AM, Ville Syrjälä wrote: On Tue, May 17, 2016 at 07:09:58PM -0500, Pierre-Louis Bossart wrote: On 05/17/2016 01:16 PM, Ville Syrjälä wrote: On Tue, May 17, 2016 at 01:00:13PM -0500, Pierre-Louis Bossart wrote: Hi, I

Re: [Intel-gfx] i915 issues with 4.6

On 5/18/16 2:08 AM, Ville Syrjälä wrote: On Tue, May 17, 2016 at 07:09:58PM -0500, Pierre-Louis Bossart wrote: On 05/17/2016 01:16 PM, Ville Syrjälä wrote: On Tue, May 17, 2016 at 01:00:13PM -0500, Pierre-Louis Bossart wrote: Hi, I was porting the HDMI audio patch to 4.6 as a service

Re: [Intel-gfx] [RFC 04/15] drm/i915: Add headers for non-HDAudio HDMI interface

On 3/15/16 11:21 AM, Vinod Koul wrote: On Tue, Mar 15, 2016 at 03:35:45PM +0200, Ville Syrjälä wrote: I understand the benefits of a parent/child device/subdevice model. What I don't see is whether we need the component framework at all here? It was used in the case of HDaudio since both i915

[Intel-gfx] [PATCH v2] drm: i915: remove intel_hdmi variable declaration

'intel_hdmi' variable was redeclared, use same variable declared in function scope Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/d

Re: [Intel-gfx] [RFC 04/15] drm/i915: Add headers for non-HDAudio HDMI interface

On 3/14/16 10:30 AM, Ville Syrjälä wrote: On Mon, Mar 14, 2016 at 05:21:54PM +0200, Ville Syrjälä wrote: On Mon, Mar 14, 2016 at 10:13:58AM -0500, Pierre-Louis Bossart wrote: On 3/11/16 1:09 PM, Ville Syrjälä wrote: On Fri, Mar 11, 2016 at 11:27:13AM -0600, Pierre-Louis Bossart wrote: Thanks

Re: [Intel-gfx] [RFC 04/15] drm/i915: Add headers for non-HDAudio HDMI interface

On 3/11/16 1:09 PM, Ville Syrjälä wrote: On Fri, Mar 11, 2016 at 11:27:13AM -0600, Pierre-Louis Bossart wrote: Thanks for the review Ville [snip] Kinda hard to see where everything gets used due to the way the patches are split up. Yes, it's far from great... At least the hotplug/mode

Re: [Intel-gfx] [RFC 04/15] drm/i915: Add headers for non-HDAudio HDMI interface

Thanks for the review Ville [snip] Kinda hard to see where everything gets used due to the way the patches are split up. Yes, it's far from great... At least the hotplug/mode change events are not needed. We only have the two points where i915 should inform the audio driver about this

Re: [Intel-gfx] [RFC 02/15] drm: i915: remove intel_hdmi variable declaration

On 3/10/16 11:34 AM, Ville Syrjälä wrote: On Fri, Mar 04, 2016 at 08:50:39PM -0600, Pierre-Louis Bossart wrote: 'intel_hdmi' variable is redeclared, use same variable declared in function scope. Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/g

Re: [Intel-gfx] [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio

Not sure why you skirt around calling the thing by its name. It's called LPE isn't it? No. LPE aka SST is the path to the audio dsp subsystem. This path to HDMI has nothing to do with the audio dsp. Not a single gate is shared. The why are the interrupt bits called LPE_somethingsomething?

Re: [Intel-gfx] [RFC 01/15] drm: i915: fix inversion of definitions for LPE_PIPE_A/B

On 3/5/16 7:27 AM, Ville Syrjälä wrote: On Fri, Mar 04, 2016 at 08:50:38PM -0600, Pierre-Louis Bossart wrote: Definitions for I915_LPE_PIPE_A_INTERRUPT and I915_LPE_PIPE_B_INTERRUPT are inverted. Not according to the docs. Are the docs wrong? Possibly. I compared with the Android code

Re: [Intel-gfx] [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio

On 3/5/16 7:42 AM, Ville Syrjälä wrote: On Fri, Mar 04, 2016 at 08:50:37PM -0600, Pierre-Louis Bossart wrote: When HDaudio is not enabled or fused-out, an alternate hardware interface can be used to provide audio data to the display/HDMI controller on Atom platforms. The code to control

[Intel-gfx] [RFC 15/15] i915: Fix typo in comment.

From: Toyo Abe <toyo@gmail.com> Signed-off-by: Toyo Abe <toyo@gmail.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [RFC 12/15] hdmi_audio: Fixup some monitor

From: David Henningsson <david.hennings...@canonical.com> I think this change was given to us, and they claimed it fixed an issue on some monitor brand. I'm not sure what this patch actually does. Signed-off-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by:

[Intel-gfx] [RFC 10/15] add dependency on PM_RUNTIME

Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- sound/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/Kconfig b/sound/Kconfig index 75c679e..b8b4fce 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -138,6 +138,7 @@ config AC97_BUS

[Intel-gfx] [RFC 14/15] i915: Enable LPE_PIPEA_Interrupt.

<toyo@gmail.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 556fa

[Intel-gfx] [RFC 02/15] drm: i915: remove intel_hdmi variable declaration

'intel_hdmi' variable is redeclared, use same variable declared in function scope. Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [RFC 05/15] drm/i915: changes for non-HDAudio HDMI interface

-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 81 drivers/gpu/drm/i915/intel_display.c | 8 ++ drivers/gpu/drm/i915/intel_hdm

[Intel-gfx] [RFC 04/15] drm/i915: Add headers for non-HDAudio HDMI interface

Signed-off-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/hdmi_audio_if.h | 122 +++ drivers/gpu/drm/i915/i915_drv.h | 31 + dri

[Intel-gfx] [RFC 08/15] drm/i915: enable non-HDAudio HDMI interface Makefile

ngs...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile index 0851de07..b85d6c2 100644 --- a

[Intel-gfx] [RFC 03/15] Doc: sound: add description of Atom HDMI audio interface

Used when HDaudio is not enabled Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- Documentation/sound/alsa/Atom-hdmi-audio.txt | 241 +++ 1 file changed, 241 insertions(+) create mode 100644 Documentation/sound/alsa/Atom-hdmi-audio.txt

[Intel-gfx] [RFC 13/15] hdmi_audio: Fix mishandling of AUD_HDMI_STATUS_v2 register.

From: Toyo Abe <toyo@gmail.com> According to the datasheet, write one to clear these UNDERRUN flag bits. This fixes the following warning in dmesg. [15357.574902] had: Unable to clear UNDERRUN bits Signed-off-by: Toyo Abe <toyo@gmail.com> Signed-off-by: Pierre-Louis Bos

[Intel-gfx] [RFC 06/15] drm/i915: power-related changes non-HDAudio HDMI interface

Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/i915_rpm.c | 476 drivers/gpu/drm/i915/intel_pm.c | 53 + 2 files changed, 529 insertions(+)

[Intel-gfx] [RFC 11/15] hdmi_audio: Improve position reporting

From: David Henningsson <david.hennings...@canonical.com> Using a hw register to calculate sub-period position reports. This makes PulseAudio happier. Signed-off-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@

[Intel-gfx] [RFC 07/15] drm/i915: Add API code for non-HDAudio HDMI interface

Signed-off-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/hdmi_audio_if.c | 410 +++ 1 file changed, 410 insertions(+) create mode 100644 drivers/

[Intel-gfx] [RFC 09/15] ALSA: Intel: Atom: add Atom non-HDAudio HDMI interface

drm by Pierre Bossart Signed-off-by: David Henningsson <david.hennings...@canonical.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- sound/Kconfig |8 + sound/Makefile |1 + sound/hdmi

[Intel-gfx] [RFC 01/15] drm: i915: fix inversion of definitions for LPE_PIPE_A/B

Definitions for I915_LPE_PIPE_A_INTERRUPT and I915_LPE_PIPE_B_INTERRUPT are inverted. Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio

): hdmi_audio: Improve position reporting hdmi_audio: Fixup some monitor Pierre-Louis Bossart (10): drm: i915: fix inversion of definitions for LPE_PIPE_A/B drm: i915: remove intel_hdmi variable declaration Doc: sound: add description of Atom HDMI audio interface drm/i915: Add headers for non