[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2016-10-13

2016-10-13 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-10-13 06:25:55+03:00 commit: 522dbc0 previous commit:6ddfce1 revision date: 2016-10-13 01:33:38+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC] Bug #72811 - Replacing parse_url()

2016-10-13 Thread David Walker
On Mon, Oct 10, 2016 at 1:22 PM Larry Garfield wrote: > Be aware that a user-space definition for a URL object already exists as > part of PSR-7: > > http://www.php-fig.org/psr/psr-7/#3-5-psr-http-message-uriinterface > > A core-provided mutable and incompatible object

[PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()

2016-10-13 Thread Christoph M. Becker
Hi! I suggest to deprecate png2wbmp() and jpeg2wbmp() as of PHP 7.2 and to remove the functions as of PHP 8.0. Both functions are very special for ext/gd; there are no other direct conversion functions, and even their names do not start with "image" like all other ext/gd functions, except

[PHP-DEV] PDOStatement::activeQueryString()

2016-10-13 Thread Adam Baratz
Hi, I'd like to add a new method that would return the prepared statement as it was executed. It's common for people I work with to want this info for debugging, but you can't get it from userland. The functionality is similar to, but distinct from PDOStatement::debugDumpParams(). I figure it's

Re: [PHP-DEV] [RFC] Bug #72811 - Replacing parse_url()

2016-10-13 Thread David Walker
On Thu, Oct 13, 2016 at 10:54 AM Christoph M. Becker wrote: > On 07.10.2016 at 16:45, David Walker wrote: > > > On Fri, Oct 7, 2016 at 4:37 AM Nikita Popov > wrote: > > > >> Are you aware of the WHATWG URL standard [1]? Quoting the first goal > >>

[PHP-DEV] [!] Master merged into PHP-7.1

2016-10-13 Thread Davey Shafik
Hey folks, I have a bit of a mystery on my hands. Yasuo brought to my attention last night that it looked like someone had merged master into the PHP-7.1 branch, and indeed when Joe and I tried to build today that was the case. Proof:

Re: [PHP-DEV] [RFC] Bug #72811 - Replacing parse_url()

2016-10-13 Thread Larry Garfield
On 10/13/2016 10:00 AM, David Walker wrote: On Mon, Oct 10, 2016 at 1:22 PM Larry Garfield wrote: Be aware that a user-space definition for a URL object already exists as part of PSR-7: http://www.php-fig.org/psr/psr-7/#3-5-psr-http-message-uriinterface A

Re: [PHP-DEV] [RFC] Bug #72811 - Replacing parse_url()

2016-10-13 Thread Christoph M. Becker
On 07.10.2016 at 16:45, David Walker wrote: > On Fri, Oct 7, 2016 at 4:37 AM Nikita Popov wrote: > >> Are you aware of the WHATWG URL standard [1]? Quoting the first goal >> statement: >> >>> Align RFC 3986 and RFC 3987 with contemporary implementations and >> obsolete

Re: [PHP-DEV] wordwrap with negative width

2016-10-13 Thread Yasuo Ohgaki
Hi Stas, Niklas, On Thu, Oct 13, 2016 at 2:13 PM, Stanislav Malyshev wrote: >> Sorry for the late reply. Why not keep the current behavior + warning? > > Because current behavior makes no sense, negative length is not really > something that exists. I agree Stas. If we

Re: [PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()

2016-10-13 Thread Kalle Sommer Nielsen
Hi 2016-10-13 19:03 GMT+02:00 Christoph M. Becker : > Hi! > > I suggest to deprecate png2wbmp() and jpeg2wbmp() as of PHP 7.2 and to > remove the functions as of PHP 8.0. > > Both functions are very special for ext/gd; there are no other direct > conversion functions, and even

Re: [PHP-DEV] PDOStatement::activeQueryString()

2016-10-13 Thread Matteo Beccati
Hi, On 13/10/2016 19:59, Adam Baratz wrote: > I'd like to add a new method that would return the prepared statement as it > was executed. It's common for people I work with to want this info for > debugging, but you can't get it from userland. The functionality is similar > to, but distinct from

Re: [PHP-DEV] PDOStatement::activeQueryString()

2016-10-13 Thread Sherif Ramadan
I really doubt this method will prove useful in practice for the use case you mention, and for a number of a reasons. 1) The name is misleading (there is no real query string in the case of native prepared statements - the SQL and data are always separate) 2) You would have to execute the

Re: [PHP-DEV] [!] Master merged into PHP-7.1

2016-10-13 Thread Lauri Kenttä
On 2016-10-13 20:16, Davey Shafik wrote: Can anyone shed some light on: 1) when it was merged 2) who merged it 3) how the dates are messed up 1) and 2) commit fb92482c8ad1e35b82c4d7b758ae0f1f5ecd4929 Merge: b0cacee 4b8bdac Author: Joe Watkins Date: Mon Oct 10 12:17:11

Re: [PHP-DEV] [!] Master merged into PHP-7.1

2016-10-13 Thread Davey Shafik
On Thu, Oct 13, 2016 at 12:20 PM, Lauri Kenttä wrote: > On 2016-10-13 20:16, Davey Shafik wrote: > >> Can anyone shed some light on: >> >> 1) when it was merged >> 2) who merged it >> 3) how the dates are messed up >> > > > 1) and 2) > > commit

Re: [PHP-DEV] [!] Master merged into PHP-7.1

2016-10-13 Thread Lauri Kenttä
On 2016-10-13 22:32, Davey Shafik wrote: On Thu, Oct 13, 2016 at 12:20 PM, Lauri Kenttä wrote: On 2016-10-13 20:16, Davey Shafik wrote: Can anyone shed some light on: 1) when it was merged 2) who merged it 3) how the dates are messed up 1) and 2) commit

[PHP-DEV] IMPORTANT: Git reset after wrong merge

2016-10-13 Thread Johannes Schlüter
Hi, as Davey noted in the thread "Master merged into PHP-7.1" there was a wrong merge in git. This wasn't noticed for a few days. This means we had a few additional commits in between. I've reseted PHP-7.1 to the *old* state *before* that merge. Quite a few commits have been removed and need to

[PHP-DEV] Moving utf8_encode() and utf8_decode() to ext/standard (was: [RFC][DISCUSSION] Remove utf8_decode() and utf8_encode())

2016-10-13 Thread Andrea Faulds
Hi, This is a follow-up to what I wrote in the utf8_encode()/utf8_decode() discussion earlier: Andrea Faulds wrote: I would propose something else: remove them from the XML extension, and move them somewhere more fitting, like ext/intl, ext/mbstring or maybe ext/standard. These are generic

Re: [PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()

2016-10-13 Thread Dan Ackroyd
On 13 October 2016 at 18:03, Christoph M. Becker wrote: > Implementing a fallback in userland would be trivial You should do that first, and get at least some people to use them, if you want them deprecated or removed from PHP. cheers Dan -- PHP Internals - PHP Runtime

Re: [PHP-DEV] [!] Master merged into PHP-7.1

2016-10-13 Thread Yasuo Ohgaki
On Fri, Oct 14, 2016 at 4:51 AM, Lauri Kenttä wrote: > Actually I just followed the lines in the git graph: > > $ git log origin/PHP-7.1.0RC3 --oneline | head -n2 > 8fe9ea3 Update versions/dates for PHP 7.1.0RC3 > 36d5bed Merge branch 'PHP-7.0' into PHP-7.1 > -> 36d5bed is

[PHP-DEV] PHP 7.0.12 is available

2016-10-13 Thread Anatol Belski
Hi, The PHP development team announces the immediate availability of PHP 7.0.12. This is a security release. Several security bugs were fixed in this release. All PHP 7.0 users are encouraged to upgrade to this version. For source downloads of PHP 7.0.12 please visit our downloads page:

RE: [PHP-DEV] Regression between RC1 and RC2?

2016-10-13 Thread Anatol Belski
Hi Nikita, > So the problem basically is that in PHP 7.0 both print_r and var_dump directly > print to output. This means that by the time the exception is thrown, we've > already written output. This makes it unclear how exactly the exception should > be handled. Is it okay to just print

Re: [PHP-DEV] Regression between RC1 and RC2?

2016-10-13 Thread Stanislav Malyshev
Hi! >> So the problem basically is that in PHP 7.0 both print_r and var_dump >> directly >> print to output. This means that by the time the exception is thrown, we've >> already written output. This makes it unclear how exactly the exception >> should >> be handled. Is it okay to just print

Re: [PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()

2016-10-13 Thread Kalle Sommer Nielsen
2016-10-13 23:17 GMT+02:00 Dan Ackroyd : > On 13 October 2016 at 18:03, Christoph M. Becker wrote: >> Implementing a fallback in userland would be trivial > > You should do that first, and get at least some people to use them, if > you want them

Re: [PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()

2016-10-13 Thread Christoph M. Becker
On 13.10.2016 at 22:28, Kalle Sommer Nielsen wrote: > 2016-10-13 19:03 GMT+02:00 Christoph M. Becker : > >> I suggest to deprecate png2wbmp() and jpeg2wbmp() as of PHP 7.2 and to >> remove the functions as of PHP 8.0. >> >> Both functions are very special for ext/gd; there are

RE: [PHP-DEV] IMPORTANT: Git reset after wrong merge

2016-10-13 Thread Anatol Belski
> -Original Message- > From: Johannes Schlüter [mailto:johan...@php.net] > Sent: Friday, October 14, 2016 12:37 AM > To: PHP internals list > Cc: Davey Shafik ; Anatol Belski > Subject: [PHP-DEV] IMPORTANT: Git reset after

RE: [PHP-DEV] IMPORTANT: Git reset after wrong merge

2016-10-13 Thread Anatol Belski
> -Original Message- > From: Anatol Belski [mailto:anatol@belski.net] > Sent: Friday, October 14, 2016 1:11 AM > To: 'Johannes Schlüter' ; 'PHP internals list' > > Cc: 'Davey Shafik' > Subject: RE: [PHP-DEV] IMPORTANT: Git

RE: [PHP-DEV] IMPORTANT: Git reset after wrong merge

2016-10-13 Thread Anatol Belski
Hi Yasuo, > -Original Message- > From: Yasuo Ohgaki [mailto:yohg...@ohgaki.net] > Sent: Friday, October 14, 2016 4:08 AM > To: Anatol Belski > Cc: Johannes Schlüter ; PHP internals list > ; Davey Shafik >

Re: [PHP-DEV] IMPORTANT: Git reset after wrong merge

2016-10-13 Thread Yasuo Ohgaki
Hi Anatol, On Fri, Oct 14, 2016 at 8:11 AM, Anatol Belski wrote: > Yeah, we'll be checking to restore the missing 7.1 commits. Currently merges > 7.0 to 7.1, or 7.1 to master, might have issues. I'd ask to please retain > from pushing there, until the branch is restored.

[PHP-DEV] PHP 7.1 UPGRADING

2016-10-13 Thread Yasuo Ohgaki
Hi Davey, It seems PHP 7.1's UPGRADING is miss merged in last few days. https://github.com/php/php-src/blob/PHP-7.1/UPGRADING This seems the last valid UPGRADING for 7.1. http://git.php.net/?p=php-src.git;a=blob;f=UPGRADING;hb=28edc971e74e7426b496945fe62628ea582f0a72 Regards, -- Yasuo Ohgaki

Re: [PHP-DEV] Merging PHP-5.6 into PHP-7.0 conflicts

2016-10-13 Thread Christoph M. Becker
Hi! On 13.10.2016 at 07:11, Stanislav Malyshev wrote: It seems there has been an unresolved bad merge. When I attempt an empty merge from PHP-5.6 into PHP-7.0, Git reports 18 conflicting files. > > Sorry, that was caused by 5.6 security fixes being in progress of being > merged. I