[PHP-DEV] Introduce ReflectionConstant

2024-04-15 Thread Ilija Tovilo
Hi everyone We recently received a feature request to allow reflection of global constants, primarily to check whether they are deprecated. https://github.com/php/php-src/issues/13570 I created a simple PR to introduce a minimal `ReflectionConstant` class.

Re: [PHP-DEV] [RFC][Vote announcement] Property hooks

2024-04-14 Thread Ilija Tovilo
Hi Matthew We're going to skip over the reiterations of Juliettes arguments, as they have already been responded to. On Thu, Apr 11, 2024 at 12:08 AM Matthew Weier O'Phinney wrote: > > On Mon, Apr 8, 2024 at 4:41 PM Ilija Tovilo wrote: >> >> https://externals.io/message/1224

Re: [PHP-DEV] [RFC][Vote announcement] Property hooks

2024-04-11 Thread Ilija Tovilo
Hi Juliette On 9-4-2024 16:03, Juliette Reinders Folmer wrote: > On 8-4-2024 23:39, Ilija Tovilo wrote: >> >> https://wiki.php.net/rfc/property-hooks >> > > I realize it is late in the discussion period to speak up, but for months > I've been trying to find th

Re: [PHP-DEV] [RFC][Vote announcement] Property hooks

2024-04-09 Thread Ilija Tovilo
Hi Robert On Tue, Apr 9, 2024 at 9:34 PM Robert Landers wrote: > > On Tue, Apr 9, 2024 at 8:56 PM Larry Garfield wrote: > > > > The Aviz RFC was put to a vote last year but didn't pass. > > It would be really nice if votes weren't just a yes/no vote, but > yes/needs-more-work/no vote, where

[PHP-DEV] [RFC][Vote announcement] Property hooks

2024-04-08 Thread Ilija Tovilo
Hi everyone Heads-up: Larry and I would like to start the vote of the property hooks RFC tomorrow: https://wiki.php.net/rfc/property-hooks We have worked long and hard on this RFC, and hope that we have found some middle-ground that works for the majority. One last concern we have not officially

Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-06 Thread Ilija Tovilo
Hi Rowan On Fri, Apr 5, 2024 at 12:28 AM Rowan Tommins [IMSoP] wrote: > > On 03/04/2024 00:01, Ilija Tovilo wrote: > > Regardless of the implementation, there are a lot of interactions we will > want to consider; and we will have to keep considering new ones as we add to

Re: [PHP-DEV] Proposal: retrieve line, filename and if user defined for ReflectionAttribute

2024-04-05 Thread Ilija Tovilo
Hi Joel On Fri, Apr 5, 2024 at 3:10 PM Joel Wurtz wrote: > > Like a lot of libraries, we offer the possibility to configure behaviors with > Attributes. However in some cases it's wrongly configured by the user and > this wrong configuration cannot be detected on the attribute constructor but

Re: [PHP-DEV] RFC idea: using the void type to control maximum arity of user-defined functions

2024-04-04 Thread Ilija Tovilo
On Thu, Apr 4, 2024 at 5:58 PM Tim Düsterhus wrote: > > On 4/4/24 16:36, Pablo Rauzy wrote: > > I strongly agree in theory, but this could break existing code, and > > moreover such a proposal was already rejected: > > https://wiki.php.net/rfc/strict_argcount > > The RFC is 9 years old by now. My

Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-03 Thread Ilija Tovilo
Hi Larry On Wed, Apr 3, 2024 at 12:03 AM Larry Garfield wrote: > > On Tue, Apr 2, 2024, at 6:04 PM, Ilija Tovilo wrote: > > > I think you misunderstood. The intention is to mark both call-site and > > declaration. Call-site is marked with ->method!(), while declaration &g

Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-02 Thread Ilija Tovilo
Hi Rowan On Tue, Apr 2, 2024 at 10:10 PM Rowan Tommins [IMSoP] wrote: > > On 02/04/2024 01:17, Ilija Tovilo wrote: > > I'd like to introduce an idea I've played around with for a couple of > weeks: Data classes, sometimes called structs in other languages (e.g. > Swift and C#)

Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-02 Thread Ilija Tovilo
Hi Niels On Tue, Apr 2, 2024 at 8:16 PM Niels Dossche wrote: > > On 02/04/2024 02:17, Ilija Tovilo wrote: > > Hi everyone! > > > > I'd like to introduce an idea I've played around with for a couple of > > weeks: Data classes, sometimes called structs in other l

Re: [PHP-DEV] Requiring GPG Commit Signing

2024-04-02 Thread Ilija Tovilo
On Tue, Apr 2, 2024 at 9:43 PM Rowan Tommins [IMSoP] wrote: > > Similarly, if you discover a compromised key or signing account, you can look > for uses of that key or account, which might be a tiny number from a non-core > contributor; if you discover a compromised account pushing unsigned

Re: [PHP-DEV] Requiring GPG Commit Signing

2024-04-02 Thread Ilija Tovilo
Hi Rowan On Tue, Apr 2, 2024 at 8:48 PM Rowan Tommins [IMSoP] wrote: > > In fact, you don't need to compromise anybody's key: you could socially > engineer a situation where you have push access to the repository, or break > the security in some other way. As I understand it, this is exactly

Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-02 Thread Ilija Tovilo
Hi Larry On Tue, Apr 2, 2024 at 5:31 PM Larry Garfield wrote: > > On Tue, Apr 2, 2024, at 12:17 AM, Ilija Tovilo wrote: > > Hi everyone! > > > > I'd like to introduce an idea I've played around with for a couple of > > weeks: Data classes, sometimes called s

Re: [PHP-DEV] Requiring GPG Commit Signing

2024-04-02 Thread Ilija Tovilo
Hi Derick On Tue, Apr 2, 2024 at 4:15 PM Derick Rethans wrote: > > What do y'all think about requiring GPG signed commits for the php-src > repository? Let me repost my internal response for visibility. I'm currently struggling to understand what kind of attack signing commits prevents. If

Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-02 Thread Ilija Tovilo
Hi Alexander On Tue, Apr 2, 2024 at 4:53 AM Alexander Pravdin wrote: > > On Tue, Apr 2, 2024 at 9:18 AM Ilija Tovilo wrote: > > > > I'd like to introduce an idea I've played around with for a couple of > > weeks: Data classes, sometimes called structs in other languag

Re: [PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-02 Thread Ilija Tovilo
Hi Marco On Tue, Apr 2, 2024 at 2:56 AM Deleu wrote: > > > > On Mon, Apr 1, 2024 at 9:20 PM Ilija Tovilo wrote: >> >> I'd like to introduce an idea I've played around with for a couple of >> weeks: Data classes, sometimes called structs in other languages (e.g

[PHP-DEV] [RFC][Concept] Data classes (a.k.a. structs)

2024-04-01 Thread Ilija Tovilo
Hi everyone! I'd like to introduce an idea I've played around with for a couple of weeks: Data classes, sometimes called structs in other languages (e.g. Swift and C#). In a nutshell, data classes are classes with value semantics. Instances of data classes are implicitly copied when assigned to

Re: [PHP-DEV] GitHub milestones

2024-03-27 Thread Ilija Tovilo
Hi Jakub On Wed, Mar 27, 2024 at 4:55 PM Jakub Zelenka wrote: > > We actually decided not to do it for 8.3 because it would be just waste of > time to set all PR's with that milestone. The thing is that PR should just > get merged when it's ready and we won't be delaying release because some

Re: [PHP-DEV] Request for RFC karma

2024-03-27 Thread Ilija Tovilo
Hi! On Wed, Mar 27, 2024 at 12:59 PM 하늘아부지 wrote: > > I request RFC karma to discuss the issue at this link. > https://github.com/php/php-src/issues/13813 > > Wiki account : daddyofsky Either somebody beat me to it, or you already had RFC privileges. Note that step 1 in the RFC process

Re: [PHP-DEV] GitHub milestones

2024-03-27 Thread Ilija Tovilo
Hi Peter On Wed, Mar 27, 2024 at 9:44 AM Peter Kokot wrote: > > I was wondering if it would be useful to add GitHub milestones for the > PHP-8.4 and PHP-9.0 (or PHP-next or something like this)? > https://github.com/php/php-src/milestones > > Because some pull requests might target versions

Re: [PHP-DEV] Proposal: AS assertions

2024-03-19 Thread Ilija Tovilo
Hi Rowan On Tue, Mar 19, 2024 at 8:39 PM Rowan Tommins [IMSoP] wrote: > > As well pattern matching, which Ilija mentioned, another adjacent feature is > a richer set of casting operators. Currently, we can assert that something is > an int; or we can force it to be an int; but we can't easily

Re: [PHP-DEV] Proposal: AS assertions

2024-03-19 Thread Ilija Tovilo
Hi Marco On Tue, Mar 19, 2024 at 7:04 PM Marco Aurélio Deleu wrote: > > > On 19 Mar 2024, at 14:51, Ilija Tovilo wrote: > > > > Hi Robert > > > >> On Tue, Mar 19, 2024 at 5:24 PM Robert Landers > >> wrote: > >> > > See https

Re: [PHP-DEV] Proposal: AS assertions

2024-03-19 Thread Ilija Tovilo
Hi Robert On Tue, Mar 19, 2024 at 5:24 PM Robert Landers wrote: > > I've been thinking about this as an RFC for awhile, but with generics > being far off (if at all), I'd like to propose a useful idea: reusing > the AS keyword in a different context. > > Example: > > $x =

Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2

2024-03-17 Thread Ilija Tovilo
Hi Rowan On Sun, Mar 17, 2024 at 3:41 PM Rowan Tommins [IMSoP] wrote: > > The remaining difference I can see in the current RFC which seems to be > unnecessary is that combining with set is only allowed on virtual > properties. Although it may be "virtual" in the strict sense, any > hook must

Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2

2024-03-16 Thread Ilija Tovilo
Hi Rowan On Sat, Mar 16, 2024 at 8:23 PM Rowan Tommins [IMSoP] wrote: > > I still think there will be a lot of users coming from other languages, or > from using __get and __set, who will look at virtual properties first. Making > things less surprising for those people seems worth some

Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2

2024-03-16 Thread Ilija Tovilo
Hi Rowan On Sat, Mar 16, 2024 at 9:32 AM Rowan Tommins [IMSoP] wrote: > > On 16 March 2024 00:19:57 GMT, Larry Garfield wrote: > > >Well, reading/writing from within a set/get hook is an obvious use case to > >support. We cannot do cached properties easily otherwise: > > > >public string

Re: [PHP-DEV] automatic formatting checks for pull requests?

2024-02-18 Thread Ilija Tovilo
On Sun, Feb 18, 2024 at 4:11 PM Gina P. Banyard wrote: > > On Saturday, 17 February 2024 at 22:18, Ilija Tovilo > wrote: > > > * The new code style should be applied only to newly added sections or > > changed code, not entire files. Otherwise, we'll have many ch

Re: [PHP-DEV] automatic formatting checks for pull requests?

2024-02-17 Thread Ilija Tovilo
Hi Hans On Sat, Feb 17, 2024 at 3:31 PM Gina P. Banyard wrote: > > On Saturday, 17 February 2024 at 11:24, Hans Henrik Bergan > wrote: > > > Can we add automatic formatting checks for pull requests? > > Made a PR: https://github.com/php/php-src/pull/13417 > > It would be nice to have some

Re: [PHP-DEV] RE: Testing new list server

2024-02-17 Thread Ilija Tovilo
Hi On Sat, Feb 17, 2024 at 12:17 AM Jorg Sowa wrote: > > Hello Derick, > there is something wrong. I don't get all of the emails from the new setup, > only part. Examples of emails I didn't receive: > - https://externals.io/message/122391 > - https://externals.io/message/122390 > -

Re: [PHP-DEV] Requesting RFC karma

2024-02-17 Thread Ilija Tovilo
Hi Hans On 16.02.24 13:05, Hans Henrik Bergan wrote: My name is "Hans Henrik Bergan", usually go by the nickname "divinity76", I've contributed to OSS (including PHP) for years, and am currently involved in 3 things that might require an RFC, and requesting RFC karma for wiki account

Re: [PHP-DEV] Registration apply for php wiki

2024-02-17 Thread Ilija Tovilo
Hi JaeHan! On Fri, Feb 16, 2024 at 10:53 AM 하늘아부지 wrote: > > Hi, My name is JaeHan Seo. (wiki username is daddyofsky) > > I hope I can make a proposal by registering on the php wiki. I can give you karma. Usually, RFC karma (which is what I'm guessing you're asking for) is granted for specific

Re: [PHP-DEV] [Discussion] Thoughts on casting to null

2024-02-14 Thread Ilija Tovilo
Hi Robert On Wed, Feb 14, 2024 at 1:29 AM Robert Landers wrote: > > I won't be the first to say this, at first glance, casting to null > sounds silly, but short arrow functions must always return something, > by design. That's when casting to null makes any sense at all (that I > can think of):

Re: [PHP-DEV] php-src docs

2024-02-12 Thread Ilija Tovilo
Hi Yuya It seems you accidentally sent your response to me instead of the list. On Sun, Feb 11, 2024 at 5:10 PM youkidearitai wrote: > > 2024年2月11日(日) 21:18 Ilija Tovilo : > > > > Hi everyone. > > > > I would like to start an initiative to centralize document

Re: [PHP-DEV] php-src docs

2024-02-12 Thread Ilija Tovilo
Hi Mönôme On Sun, Feb 11, 2024 at 2:20 PM Mönôme Epson wrote: > > > centralize documentation of the PHP internals > I'm glad to hear that you're planning to centralize the documentation for PHP > internals. > > > Let me know of any thoughts and suggestions you might have. > I have a preference

[PHP-DEV] php-src docs

2024-02-11 Thread Ilija Tovilo
Hi everyone. I would like to start an initiative to centralize documentation of the PHP internals. As mentioned in a recent e-mail, there's a lot of useful documentation scattered across the internet, like the PHP internals book, various blogs of contributors, wiki.php.net, to name a few.

Re: [PHP-DEV] Why are serialized strings wrapped in double quotes? (s::"")

2024-02-07 Thread Ilija Tovilo
Hi Sandy On Tue, Feb 6, 2024 at 9:19 PM Sanford Whiteman wrote: > > I'd like a little background on something we've long accepted: why > does the serialization format need double quotes around a string, even > though the byte length is explicit? > > Example: > > s:5:"hello"; > > All else being

[PHP-DEV] Re: [RFC][Vote] RFC1867 for non-POST HTTP verbs

2024-02-05 Thread Ilija Tovilo
Hi everyone On Mon, Jan 22, 2024 at 10:23 AM Ilija Tovilo wrote: > > I started the vote on the "RFC1867 for non-POST HTTP verbs" RFC. > https://wiki.php.net/rfc/rfc1867-non-post The RFC has been accepted with 23 yes and 1 no vote. As promised to Sara, I will b

Re: [PHP-DEV] Discussion: making continue and break into an expression

2024-01-25 Thread Ilija Tovilo
Hi Larry On Thu, Jan 25, 2024 at 6:38 PM Larry Garfield wrote: > > On Thu, Jan 25, 2024, at 11:28 AM, Ilija Tovilo wrote: > > > > This leads to very similar issues as break/continue inside blocks. See: > > https://wiki.php.net/rfc/match_blocks#technical_implicatio

Re: [PHP-DEV] Discussion: making continue and break into an expression

2024-01-25 Thread Ilija Tovilo
Hi Robert On Thu, Jan 25, 2024 at 10:16 AM Robert Landers wrote: > > Now that throwing is an expression, it allows for some very concise > programming. What are your thoughts on making a break/continue into an > expression as well? > > Instead of: > > while(true) { > ... >

Re: [PHP-DEV] Re: Wiki Access request

2024-01-24 Thread Ilija Tovilo
On Wed, Jan 24, 2024 at 1:22 PM Ilija Tovilo wrote: > > Thank you for the list. It looks more digestible, and most of it is > already congruent with CONTRIBUTING.md. > > * https://www.zend.com/resources/writing-php-extensions requires > sharing your contact infomation to obtain

Re: [PHP-DEV] Re: Wiki Access request

2024-01-24 Thread Ilija Tovilo
Hi Carlos On Wed, Jan 24, 2024 at 12:29 PM Barel wrote: > > > Feel free to share this list here, on GitHub or otherwise. I'm > > skeptical whether throwing partially outdated resources at people is > > actually helpful. > > I trimmed the list that I collected so that it only included the most >

Re: [PHP-DEV] [RFC][Vote] RFC1867 for non-POST HTTP verbs

2024-01-24 Thread Ilija Tovilo
Hi Sara Thank you for your feedback. On Tue, Jan 23, 2024 at 8:41 PM Sara Golemon wrote: > > On Mon, Jan 22, 2024 at 1:24 AM Ilija Tovilo wrote: > > > I started the vote on the "RFC1867 for non-POST HTTP verbs" RFC. > > https://wiki.php.net/rfc/rfc1867-non-post &

Re: [PHP-DEV] Re: Wiki Access request

2024-01-22 Thread Ilija Tovilo
Hi Carlos You should now have access to the /internals sub-pages. On Mon, Jan 22, 2024 at 11:38 AM Barel wrote: > > I didn't know that there was a list of tech resources listed in the > "CONTRIBUTING.md" file. I have been researching resources that have > information about PHP internals and

[PHP-DEV] [RFC][Vote] RFC1867 for non-POST HTTP verbs

2024-01-22 Thread Ilija Tovilo
Hi everyone I started the vote on the "RFC1867 for non-POST HTTP verbs" RFC. https://wiki.php.net/rfc/rfc1867-non-post Ilija -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Newly Created Wiki Account - Quick Introduction

2024-01-22 Thread Ilija Tovilo
Hi Jair! On Mon, Jan 22, 2024 at 5:14 AM Jair Humberto wrote: > > My name is Jair Humberto, I am brazilian and have been working with PHP > since 2006. I am super excited about the new things PHP has launched lately > and finally realised that I can contribute as well. I think this is a new >

Re: [PHP-DEV] Wiki Access request

2024-01-21 Thread Ilija Tovilo
Hi Carlos! On Fri, Jan 19, 2024 at 4:56 PM Barel wrote: > > This page in the Wiki https://wiki.php.net/internals/references has a lot > of links which are outdated and should be removed or changed. If you can > provide wiki edit access for me I can work on updating them and also try to > find

[PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2024-01-17 Thread Ilija Tovilo
Hi Joan Sorry for the late response. On Thu, Dec 14, 2023 at 6:08 PM Joanhey wrote: > > We can't use sapi_module.read_post() from CLI. > > https://github.com/joanhey/AdapterMan > This runtime use the CLI-SAPI, but this SAPI is very limited. We can use > parse_str() easily for

Re: [PHP-DEV] [VOTE] [RFC] Final-by-default anonymous classes

2024-01-15 Thread Ilija Tovilo
Hi Daniil On Mon, Jan 15, 2024 at 11:36 AM Daniil Gentili wrote: > > Hi all, > > I've opened voting for the final-by-default anonymous classes RFC: > https://wiki.php.net/rfc/final_by_default_anonymous_classes It seems you've edited the text of the poll. Doing so disassociates the existing

Re: [PHP-DEV] RFC karma request

2023-12-28 Thread Ilija Tovilo
Hi Valentin On Thu, Dec 28, 2023 at 1:31 PM Valentin Udaltsov wrote: > > I kindly request RFC Karma for my wiki account vudaltsov. I am planning to > publish RFC "new MyClass()->method() without parentheses". I already > created a PR, where I got generally positive feedback on this feature: >

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-12-08 Thread Ilija Tovilo
Hi Sam >> On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: >> > https://wiki.php.net/rfc/rfc1867-non-post On Thu, Dec 7, 2023 at 6:04 PM Sam I wrote: > > Hey, I'm not sure if this is bikeshedding, but the concept of parsing bodies > for non-POST requests lands re

Re: [PHP-DEV] bugs.php.net still active?

2023-12-07 Thread Ilija Tovilo
Hi Aleksander On Thu, Dec 7, 2023 at 9:22 AM Aleksander Machniak wrote: > > I was under impression that bugs.php.net was supposed to be phased out. > I.e. made read-only or something. > > https://bugs.php.net/bug.php?id=78628=1 proves that it's not the > case and I'm receiving annoying spam

[PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-12-05 Thread Ilija Tovilo
Hi everyone On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: > > I'd like to announce an RFC that proposes adding a new function called > parse_post_data() to expose the existing functionality to userland, so > that the mechanism can be used for other HTTP verbs. > > https:

Re: [PHP-DEV] Reproducible Builds

2023-11-28 Thread Ilija Tovilo
Hi Sebastian On Tue, Nov 28, 2023 at 6:28 PM Sebastian Bergmann wrote: > > I recently watched a video [1] that once again brought the topic of > reproducible builds [2] to my attention. > ... > I have not yet checked whether usage of the __DATE__ and __TIME__ macros > is the only thing that

Re: [PHP-DEV] [RFC][Discussion] Harmonise "untyped" and "typed" properties

2023-11-16 Thread Ilija Tovilo
Hi Rowan, Thanks for the RFC. On Thu, Nov 16, 2023 at 9:42 PM Rowan Tommins wrote: > > I have finally written up an RFC I have been considering for some time: > Harmonise "untyped" and "typed" properties > > RFC URL: https://wiki.php.net/rfc/mixed_vs_untyped_properties Unifying the unset

Re: [PHP-DEV] [RFC] [Discussion] Release cycle update

2023-11-10 Thread Ilija Tovilo
Hi Jakub Thank you for the proposal. On Fri, Nov 10, 2023 at 5:52 PM Jakub Zelenka wrote: > https://wiki.php.net/rfc/release_cycle_update > Currently beta is called a feature freeze but effectively it isn't. The main > issue with that is that the end of alpha just means that all RFC's

Re: [PHP-DEV] Previous discussions about generics syntax only?

2023-11-03 Thread Ilija Tovilo
Hi Daniil On Fri, Nov 3, 2023 at 12:00 AM wrote: > The much better approach, one that I intend to maybe give a shot at this > Christmas, is to add static analysis functionality to PHP itself (i.e. turn > it into a truly statically typed language). > I have a hunch it may be easy enough to do

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-31 Thread Ilija Tovilo
Hi Derick On Wed, Oct 18, 2023 at 6:10 PM Derick Rethans wrote: > On Fri, 13 Oct 2023, Ilija Tovilo wrote: > > > https://wiki.php.net/rfc/rfc1867-non-post > > The only comment I would have is that I probably would be in favour of > not leaving the "config"

Re: [PHP-DEV] Discussion - Anti-null coercion

2023-10-30 Thread Ilija Tovilo
Hi Robert On Sun, Oct 29, 2023 at 7:31 PM Robert Landers wrote: > > Hello Internals, > > We currently have a null coercion operator: ??, but we lack an > anti-null coercion operator. > ... > fn() => > ($_SERVER['HTTP_X_MY_HEADER'] ?? null) > ? md5($_SERVER['HTTP_X_MY_HEADER']) > : null; >

Re: [PHP-DEV] Request of RFC karma

2023-10-27 Thread Ilija Tovilo
Hi Alessandro Sorry for the delayed response. On Wed, Oct 25, 2023 at 4:11 PM Alessandro Rosa wrote: > I would like receiving the wiki RFC Karma for my account, in order to > submit an RFC on the built-in "empty" function. > My account is alessandro.a.rosa_gmail.com RFC karma was granted. Good

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-19 Thread Ilija Tovilo
Hi Larry On Wed, Oct 18, 2023 at 7:26 PM Larry Garfield wrote: > > On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: > >> https://wiki.php.net/rfc/rfc1867-non-post > > The functionality all seems reasonable to me. I have a few smaller concerns: > > 1. Like Derick,

Re: [PHP-DEV] RFC Karma request

2023-10-17 Thread Ilija Tovilo
Hi Daniil On Tue, Oct 17, 2023 at 8:25 PM Daniil Gentili wrote: > I'd like to create RFCs at least for final anonymous classes > (https://externals.io/message/121356) and a small tweak to JIT defaults > (https://externals.io/message/121359). > > Please give me RFC Karma :) > > Username: danog

Re: [PHP-DEV] RFC Karma Request

2023-10-17 Thread Ilija Tovilo
Hi Yuya RFC karma was granted, good luck with your RFC! Ilija On Tue, Oct 17, 2023 at 5:07 PM youkidearitai wrote: > > Hi, internals. > > I writing to trim for multibyte support function, mb_trim, mb_ltrim > and mb_rtrim. > https://github.com/php/php-src/pull/12459 > > Please give me RFC

[PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-13 Thread Ilija Tovilo
Hi everyone On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: > https://wiki.php.net/rfc/rfc1867-non-post Thank you for the feedback so far. I made a handful of changes to the RFC. * The function is renamed to request_parse_body() * The function will now throw instead of emitting warni

[PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-07 Thread Ilija Tovilo
Hi Marco Please note that you have accidentally created a new thread. I'm responding from the main thread. > >>> On Fri, Oct 6, 2023 at 2:44 PM Ilija Tovilo > >>> wrote: > >>> https://wiki.php.net/rfc/rfc1867-non-post > > Just wanted to mention that m

Re: [PHP-DEV] [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-07 Thread Ilija Tovilo
Hi Jakub >> https://wiki.php.net/rfc/rfc1867-non-post >> > > It should probably explicitly mention that it uses the same inis like > max_input_vars, max_file_uploads and max_multipart_body_parts. Indeed, I will mention that. Thank you. > It's kind of strange function as I can't decide where it

Re: [PHP-DEV] [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-07 Thread Ilija Tovilo
Hi Tim > On 10/6/23 15:44, Ilija Tovilo wrote: > > https://wiki.php.net/rfc/rfc1867-non-post > > > > Regarding the cleanup of the files, perhaps the files could be read into > a `php://temp` stream > (https://www.php.net/manual/en/wrappers.php.php#wrappers.php.memory)?

[PHP-DEV] [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-06 Thread Ilija Tovilo
Hi everyone A while ago I wrote an e-mail about RFC1867 (multipart/form-data) not being parsed by PHP for non-POST requests. https://externals.io/message/120641 I'd like to announce an RFC that proposes adding a new function called parse_post_data() to expose the existing functionality to

Re: [PHP-DEV] What should I do to create an RFC?

2023-10-01 Thread Ilija Tovilo
Hi Saki On Sat, Sep 30, 2023 at 6:04 AM Saki Takamachi wrote: > I want to create an RFC. This is my first time. > > The next two pages each have sections on how to create RFCs. However, they > differ slightly in content. Which way should I use? > > https://wiki.php.net/rfc/howto >

Re: [PHP-DEV] Wiki account for RFC

2023-09-24 Thread Ilija Tovilo
On Sat, Sep 23, 2023 at 3:36 PM Marc wrote: > > Hi, > > I like to create an RFC for integer rounding as proposed here > https://externals.io/message/120373 > > I already had an account for the wiki years ago but somehow lost my login. > > Username: mabe > > EMail: php@mabe.berlin > > Also I don't

[PHP-DEV] [RFC][Draft] Match block

2023-09-08 Thread Ilija Tovilo
Hello everyone I've been working on match blocks over the last few weeks. https://wiki.php.net/rfc/match_blocks I've already shared it in R11 and got conflicting feedback, which makes me unsure on how to proceed. We have a few options. 1. Add blocks only to match, possibly adding blocks to

Re: [PHP-DEV] Access property of object stored in a constant

2023-08-19 Thread Ilija Tovilo
Hi Juliette > > Since https://wiki.php.net/rfc/new_in_initializers we can store > > objects in global constants. However, we may not actually read or > > write to the properties of those objects without first fetching the > > constant into a local variable. > > > > const a = new stdClass; > >

[PHP-DEV] Access property of object stored in a constant

2023-08-18 Thread Ilija Tovilo
Hi everyone Since https://wiki.php.net/rfc/new_in_initializers we can store objects in global constants. However, we may not actually read or write to the properties of those objects without first fetching the constant into a local variable. const a = new stdClass; a->b = 42; // Fatal error:

Re: [PHP-DEV] Requesting RFC karma for athos

2023-08-01 Thread Ilija Tovilo
Hi Athos On Sat, Jul 29, 2023 at 3:37 AM Athos Ribeiro wrote: > I hereby request RFC karma for my recently created wiki account name > "athos". I granted you RFC karma. Please let me know if it works, it's the first time I did it so I'm not sure I did it right. :) Ilija -- PHP Internals - PHP

Re: [PHP-DEV] ??= and function calls

2023-07-05 Thread Ilija Tovilo
Hi Flávio On Wed, Jul 5, 2023 at 12:17 PM Flávio Heleno wrote: >> > I recently discovered some unfortunate behavior of the coalesce >> > assignment operator (??=) in combination with function calls. > > Great catch Ilija! > > Do you mind sharing how did you stumble upon it? Oh, it's

[PHP-DEV] ??= and function calls

2023-07-04 Thread Ilija Tovilo
Hi everyone I recently discovered some unfortunate behavior of the coalesce assignment operator (??=) in combination with function calls. Here's the TL;DR: foo()['bar'] ??= 42; Currently, this code calls foo() twice. This seems rather unexpected. The technical reason as to why this happens is

Re: [PHP-DEV] RFC1867 (multipart/form-data) PUT requests

2023-06-28 Thread Ilija Tovilo
Hi Ben On Tue, Jun 27, 2023 at 9:54 PM Ben Ramsey wrote: > > > On Jun 27, 2023, at 04:01, Ilija Tovilo wrote: > > > > Hi Ben, Hi Rowan > > > > On Mon, Jun 26, 2023 at 8:55 PM Ben Ramsey wrote: > >> > >>> On Jun 20, 2023, at 06:06, Rowan To

Re: [PHP-DEV] RFC1867 (multipart/form-data) PUT requests

2023-06-27 Thread Ilija Tovilo
Hi Ben, Hi Rowan On Mon, Jun 26, 2023 at 8:55 PM Ben Ramsey wrote: > > > On Jun 20, 2023, at 06:06, Rowan Tommins wrote: > > > > On Tue, 20 Jun 2023 at 10:25, Ilija Tovilo wrote: > > > >> Introduce a new function (currently named populate_post_data()) to >

Re: [PHP-DEV] Request to create a RFC for const args

2023-06-26 Thread Ilija Tovilo
Hi Sam! > Hello php internals team, > I would like to put forward an RFC for a new feature. I am a long time user, > but have never participated as yet to the RFC. Sorry for the late reply. Thanks for your suggestion! If you'd like RFC karma, we'll need to know your username on the wiki.

[PHP-DEV] RFC1867 (multipart/form-data) PUT requests

2023-06-20 Thread Ilija Tovilo
Hi internals A while ago I encountered a limitation of how RFC1867 requests are handled in PHP. PHP populates the $_POST and $_FILES superglobals when the Content-Type is multipart/form-data or application/x-www-form-urlencoded, but only when the method is POST. For

Re: [PHP-DEV] Expression code blocks

2023-06-17 Thread Ilija Tovilo
Hi Andreas On Fri, Jun 16, 2023 at 9:23 PM Andreas Hennings wrote: > > Hello list, > I don't know if something like this was already proposed in the past, > I did not find anything. > > Sometimes it would be nice to have a code block inside an expression, like > this: > > public function

Re: [PHP-DEV] [RFC] Interface Default Methods

2023-06-15 Thread Ilija Tovilo
Hi Levi > I am moving my RFC for interface default methods to discussion: > https://wiki.php.net/rfc/interface-default-methods. This or a similar concept makes sense to me. The proposal seems similar to Swift protocol extensions, or Rust traits, with the exception that function default

Re: [PHP-DEV] RFC [Discussion]: Marking overridden methods (#[\Override])

2023-05-22 Thread Ilija Tovilo
Hi Tim On Thu, May 11, 2023 at 6:37 PM Tim Düsterhus wrote: > I'm now opening discussion for the RFC "Marking overridden methods > (#[\Override])": > > RFC: Marking overridden methods (#[\Override]) > https://wiki.php.net/rfc/marking_overriden_methods We've already talked in private, but let me

Re: [PHP-DEV] PHP Package for PHP

2023-05-18 Thread Ilija Tovilo
Hi Marco On Thu, May 18, 2023 at 7:35 PM Rowan Tommins wrote: > > On Thu, 18 May 2023 at 16:27, Deleu wrote: > > Monolog is a great example of what PHP is missing - a single library for a > > purpose. I have never worked with any other library besides Monolog and I > > never worked on any

Re: [PHP-DEV] Final anonymous classes

2023-04-25 Thread Ilija Tovilo
Hi Claude > > Hi all, > > > > I've submitted https://github.com/php/php-src/pull/11126 to add support for > > final anonymous classes, though as noted by iluuu1994, it would probably > > make more sense to just make all anonymous classes final by default, what > > do you think? > > Extending

Re: [PHP-DEV] Expansion of PHP Symbols?

2023-04-21 Thread Ilija Tovilo
Hi Deleu > From Rob's email (https://externals.io/message/120094#120097), the argument > against a simple "use" statement seems quite natural. I certainly don't > want to redefine "use int|float as Number" in every PHP file I work with, > so naturally we would go back to type alias definition,

Re: [PHP-DEV] [Discussion] Callable types via Interfaces

2023-04-21 Thread Ilija Tovilo
Hi Larry and Nicolas! > https://wiki.php.net/rfc/allow_casting_closures_into_single-method_interface_implementations > https://wiki.php.net/rfc/allow-closures-to-declare-interfaces-they-implement > https://wiki.php.net/rfc/structural-typing-for-closures > > What we propose is to instead lean into

Re: [PHP-DEV] Future stability of PHP?

2023-04-08 Thread Ilija Tovilo
Hi Stephan > I'm sorry if this isn't the correct mailing list for that discussion but I > couldn't find a more appropriate one where people actually know how the > wind is > blowing. No worries, this seems like the appropriate place. > Is there a way to tell which APIs and language features

Re: [PHP-DEV] Array spread append

2023-04-06 Thread Ilija Tovilo
Hi Michael > I would like to open a discussion for > https://github.com/php/php-src/issues/10791 . > [https://opengraph.githubassets.com/a23cb565cc8acac6a33ecab5d9ee68a46f046a1ffe215501673156e506695430/php/php-src/issues/10791] > Array spread append ·

[PHP-DEV] Re: [RFC][Vote] Arbitrary static variable initializers

2023-04-05 Thread Ilija Tovilo
Hi everyone > I've opened the vote for the arbitrary static variable initializers RFC. > As usual, the vote is open for two weeks and will be closed on 2023-04-04. > > https://wiki.php.net/rfc/arbitrary_static_variable_initializers The arbitrary static variable initializer RFC has been accepted

Re: [PHP-DEV] Property Hooks Discussion

2023-03-31 Thread Ilija Tovilo
On Fri, Mar 31, 2023 at 3:24 PM Larry Garfield wrote: >> In other words, will it be possible for this to no longer be true (I'm >> not sure it is always true now, fwiw): >> >> $x = $y = $z = 1; >> >> $x === $y && $y === $z; > That would mean the following as a side effect: > > $f = new Foo(); >

[PHP-DEV] Re: Property Hooks Discussion

2023-03-31 Thread Ilija Tovilo
Hi Robert! On Fri, Mar 31, 2023 at 10:57 AM Robert Landers wrote: > I couldn't find the thread about Property Hooks > (https://wiki.php.net/rfc/property-hooks) -- I think it got embedded > in various places? Or maybe my search-fu in gmail is failing me. As Rowan has mentioned, you couldn't find

[PHP-DEV] Traits and redeclaring static properties

2023-03-31 Thread Ilija Tovilo
Hi everyone A few days ago we received a bug report about an inconsistency with traits and static properties. https://github.com/php/php-src/issues/10935 https://3v4l.org/Dll1m ``` class A { static $test; } class B extends A { static $test; } A::$test = 'A'; B::$test = 'B';

Re: [PHP-DEV] [IDEA] allow extending enum

2023-03-30 Thread Ilija Tovilo
Hi Davey On 29.03.23 16:31, Davey Shafik wrote: The issue of contention here is that inheritance isn't the correct mechanism for reusing enum definitions to expand on them. What about allowing "use" syntax like traits? enum HttpErrors { case HTTP_STATUS_400; case HTTP_STATUS_401;

[PHP-DEV] [RFC][Vote] Arbitrary static variable initializers

2023-03-21 Thread Ilija Tovilo
Hi everyone I've opened the vote for the arbitrary static variable initializers RFC. As usual, the vote is open for two weeks and will be closed on 2023-04-04. https://wiki.php.net/rfc/arbitrary_static_variable_initializers Ilija -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] [RFC][Vote announcement] Arbitrary static variable initializers

2023-03-17 Thread Ilija Tovilo
Hi Tim > Isn't the destructor+exception example misleading? In that case the > initial value of '$x' is constant, thus it should always be known to > reflection, no? > > Should the example look like this: > > > function foo($y) { > > $x = new Foo(); > > static $x = $y; > > } > > > > try {

Re: [PHP-DEV] [RFC][Vote announcement] Arbitrary static variable initializers

2023-03-16 Thread Ilija Tovilo
Hi Alexandru >> https://wiki.php.net/rfc/arbitrary_static_variable_initializers >> https://externals.io/message/118976 >> >> There haven't been many responses, so I'd like to put this to a vote >> early next week. >> > Only a small thing in the example for >

Re: [PHP-DEV] [RFC][Vote announcement] Arbitrary static variable initializers

2023-03-16 Thread Ilija Tovilo
Hi Tim > Using Alain's example of static variables that depend on each other. For > the following: > > function foo() { >static $a = 0; >static $b = $a + 1; > } > > The value of '$a' is known at compile time. Is the value of '$b' also > known at compile time? It might make sense to

Re: [PHP-DEV] [RFC][Vote announcement] Arbitrary static variable initializers

2023-03-15 Thread Ilija Tovilo
Hi Tim > > https://wiki.php.net/rfc/arbitrary_static_variable_initializers > > https://externals.io/message/118976 > > There is an unresolved "question": > > > Side note: It's been suggested that expressions that can be evaluated > > constantly continue to do so. This would mean that some

Re: [PHP-DEV] [RFC][Vote announcement] Arbitrary static variable initializers

2023-03-15 Thread Ilija Tovilo
Hi Alain > > https://wiki.php.net/rfc/arbitrary_static_variable_initializers > > https://externals.io/message/118976 > > Could I suggest that you make something like the following throw an error: > > function foo($i) { > static $a = $b + 1; > static $b = $i; > } > > You could try to

  1   2   3   4   >