Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-05 Thread Andreas Heigl
On 05.07.22 11:38, Jakub Zelenka wrote: On Tue, Jul 5, 2022 at 8:37 AM Andreas Heigl wrote: Hey all. On 05.07.22 02:04, Peter Cowburn wrote: On Mon, 4 Jul 2022 at 11:11, Jakub Zelenka wrote: On Mon, Jul 4, 2022 at 8:38 AM Timon de Groot wrote: Hi internals, If the rest also thinks

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-05 Thread Jakub Zelenka
On Tue, Jul 5, 2022 at 8:37 AM Andreas Heigl wrote: > Hey all. > > On 05.07.22 02:04, Peter Cowburn wrote: > > On Mon, 4 Jul 2022 at 11:11, Jakub Zelenka wrote: > > > >> On Mon, Jul 4, 2022 at 8:38 AM Timon de Groot > >> wrote: > >> > >>> Hi internals, > >>> > >>> If the rest also thinks the

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-05 Thread Marco Pivetta
Hey Timon, On Fri, 13 May 2022 at 15:33, Timon de Groot wrote: > Hi internals, > > Almost a year ago I first proposed my RFC draft to introduce a new > json_encode parameter 'indent'. I have received a lot of feedback on the > change, very insightful. The feedback can be boiled down to: > -

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-05 Thread Aleksander Machniak
On 05.07.2022 09:37, Andreas Heigl wrote: What I would have prefered is instead of a the new parameter $indent having a numerical value to have a string value. That would have allowed the following:     json_encode($data, indent: "    "); or     json_encode($data, indent: "\t"); That

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-05 Thread Andreas Heigl
Hey all. On 05.07.22 02:04, Peter Cowburn wrote: On Mon, 4 Jul 2022 at 11:11, Jakub Zelenka wrote: On Mon, Jul 4, 2022 at 8:38 AM Timon de Groot wrote: Hi internals, If the rest also thinks the RFC is good to go, I suggest we start a vote coming week. As this is my first RFC, I'm not so

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Peter Cowburn
On Mon, 4 Jul 2022 at 11:11, Jakub Zelenka wrote: > On Mon, Jul 4, 2022 at 8:38 AM Timon de Groot > wrote: > > > Hi internals, > > > > If the rest also thinks the RFC is good to go, I suggest we start a vote > > coming week. > > As this is my first RFC, I'm not so sure how this typically gets

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Jakub Zelenka
On Mon, Jul 4, 2022 at 8:38 AM Timon de Groot wrote: > Hi internals, > > If the rest also thinks the RFC is good to go, I suggest we start a vote > coming week. > As this is my first RFC, I'm not so sure how this typically gets kicked > off, so I'd like to know what I need to do! > You just

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Tim Düsterhus
Hi On 7/4/22 09:38, Timon de Groot wrote: If the rest also thinks the RFC is good to go, I suggest we start a vote coming week. With the minimum voting period being 14 days as per https://wiki.php.net/RFC/voting#voting and the feature freeze for PHP 8.2 being 2022-07-19 23:59:59 UTC as per

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Timon de Groot
As a flag can't really hurt, I'm thinking of going with option B before starting the vote. Also agree with ignoring the indent parameter, as a tab character is less dependent on how much it is repeated. Kind regards, Timon On 04-07-2022 03:22, Kevin Israel wrote: On 7/3/22 18:01, Jakub

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-04 Thread Timon de Groot
Hi internals, If the rest also thinks the RFC is good to go, I suggest we start a vote coming week. As this is my first RFC, I'm not so sure how this typically gets kicked off, so I'd like to know what I need to do! Kind regards, Timon On 04-07-2022 00:01, Jakub Zelenka wrote: Hi, On

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-03 Thread Kevin Israel
On 7/3/22 18:01, Jakub Zelenka wrote: I think we can put this RFC to the vote. If the author is to busy I would like to start voting later this week. It would be a pity not to make it to feature freeze as it is quite straight forward and the implementation seems good as well so I guess we

Re: [PHP-DEV] [RFC] Add json_encode indent parameter

2022-07-03 Thread Jakub Zelenka
Hi, On Fri, May 13, 2022 at 2:33 PM Timon de Groot wrote: > Hi internals, > > Almost a year ago I first proposed my RFC draft to introduce a new > json_encode parameter 'indent'. I have received a lot of feedback on the > change, very insightful. The feedback can be boiled down to: > -

[PHP-DEV] [RFC] Add json_encode indent parameter

2022-05-13 Thread Timon de Groot
Hi internals, Almost a year ago I first proposed my RFC draft to introduce a new json_encode parameter 'indent'. I have received a lot of feedback on the change, very insightful. The feedback can be boiled down to: - Accepting user input characters means you could create invalid JSON. Do we