[PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Christian Schneider
Derick Rethans wrote: It won't bork all scripts with a custom errorhandler if their default action is to ignore core and other errors but only handle the ones they should handle. I do agree that it should be mentioned in the changes file though. On the other hand you have to be very careful

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Andi Gutmans
At 07:20 PM 12/18/2003 +0100, Christian Schneider wrote: Derick Rethans wrote: It won't bork all scripts with a custom errorhandler if their default action is to ignore core and other errors but only handle the ones they should handle. I do agree that it should be mentioned in the changes file

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Derick Rethans
On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? So you're suggesting to add another BC break here, without a really good reason? :)

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Christian Schneider
Derick Rethans wrote: So you're suggesting to add another BC break here, without a really good reason? :) No, I'm suggesting a very minor BC break for a very good reason: To render it useful, after all (-:C - Chris -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Andi Gutmans
At 10:24 PM 12/18/2003 +0100, Derick Rethans wrote: On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? So you're suggesting to add another

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Derick Rethans
On Thu, 18 Dec 2003, Andi Gutmans wrote: At 10:24 PM 12/18/2003 +0100, Derick Rethans wrote: On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Andrey Hristov
Andi Gutmans wrote: At 10:24 PM 12/18/2003 +0100, Derick Rethans wrote: On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler if they are off? So you're

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Christian Schneider
Andrey Hristov wrote: Look like I am an weirdo :) with an web farm of servers which log every NOTICE that appear. And even I think it was possible to catch a fatal error that happens in a required file with the way the error handler works now. And what exactly keeps you from setting

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Stig S. Bakken
On Thu, 2003-12-18 at 20:35, Andi Gutmans wrote: At 07:20 PM 12/18/2003 +0100, Christian Schneider wrote: Derick Rethans wrote: It won't bork all scripts with a custom errorhandler if their default action is to ignore core and other errors but only handle the ones they should handle. I do

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Stig S. Bakken
On Thu, 2003-12-18 at 22:56, Andi Gutmans wrote: At 10:24 PM 12/18/2003 +0100, Derick Rethans wrote: On Thu, 18 Dec 2003, Andi Gutmans wrote: In any case, I do think that the custom error handler being called for any error is bogus. Why should E_STRICT or E_NOTICES be sent to the handler

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Andrey Hristov
Christian Schneider wrote: Andrey Hristov wrote: Look like I am an weirdo :) with an web farm of servers which log every NOTICE that appear. And even I think it was possible to catch a fatal error that happens in a required file with the way the error handler works now. And what exactly keeps

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Derick Rethans
On Thu, 18 Dec 2003, Christian Schneider wrote: In case someone now cries but then I need to change php.ini I'd say you have to change php.ini for PHP5 anyway. That is FUD. Come on guys, there's no better time to fix the behaviour than now. yeah, and you should be the one to decide that?

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Stig S. Bakken
On Thu, 2003-12-18 at 23:24, Derick Rethans wrote: On Thu, 18 Dec 2003, Christian Schneider wrote: In case someone now cries but then I need to change php.ini I'd say you have to change php.ini for PHP5 anyway. That is FUD. Come on guys, there's no better time to fix the behaviour

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Andrey Hristov
Stig S. Bakken wrote: Good question. Having an error handling function becomes really expensive if your code is not E_ALL-clean in a loop or something. if you set a custom error handler you know what you are doing and probably don't have such places in the code :) IMHO the error_reporting

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault, and msgs about deprecated

2003-12-18 Thread Derick Rethans
On Thu, 18 Dec 2003, Stig S. Bakken wrote: Anyway, I'm holding off with Beta 3 until we fix the --install-pear-packages problem. I'd call that a showstopper because it's something pretty basic. Has anyone managed to create a reproducing script or backtrace? It doesn't crash on my box :(

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Christian Schneider
Andrey Hristov wrote: Good question. Having an error handling function becomes really expensive if your code is not E_ALL-clean in a loop or something. if you set a custom error handler you know what you are doing and probably don't have such places in the code :) No, that's where you are wrong:

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Andrey Hristov
Christian Schneider wrote: Andrey Hristov wrote: Good question. Having an error handling function becomes really expensive if your code is not E_ALL-clean in a loop or something. if you set a custom error handler you know what you are doing and probably don't have such places in the code :)

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Christian Schneider
Andrey Hristov wrote: That's your view :) Exactly. E_NOTICEs exists for good not for bad. If one codes a simple web interface it's ok for him to use the autoinitialization but in 99.999% of the cases the user won't use And that's _your_ view ;-) [EMAIL PROTECTED]:/sample_project $ find -type f

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Johannes Schlueter
Stig S. Bakken wrote: Could someone with a crashing make install-pear-packages post the contents of their config.nice file this gives a segfault: CC='gcc' \ CXX='g++' \ './configure' \ '--prefix=/opt/php5' \ $@ this tells /home/johannes/src/php-5.0.0b3RC1/Zend/zend_hash.c(504) : ht=0x40672f58

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Andi Gutmans
Can you please update the Zend CVS and see if it still crashes? I reverted some recent engine patches. Thanks, Andi At 12:30 AM 12/19/2003 +0100, Johannes Schlueter wrote: Stig S. Bakken wrote: Could someone with a crashing make install-pear-packages post the contents of their config.nice file

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Pierre-Alain Joye
On Fri, 19 Dec 2003 00:47:06 +0100 Johannes Schlueter [EMAIL PROTECTED] wrote: With --enabled-debug it reports a memory leak but it works again. /home/johannes/src/php-cvs/php-src/Zend/zend_execute.c(405) : Freeing Does it crash again without --enabled-debug? That's what I got before. Crash

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Eduardo R. Maciel
For me it has been crashing for about 10 days ago to now: [EMAIL PROTECTED]:/usr/src/php5-200312182030# make install-pear-packages [PEAR] DB - already installed: 1.5.0RC1 [PEAR] HTTP - already installed: 1.2.1 make: *** [install-pear-packages] Falha de segmentação

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Andi Gutmans
So the revert I did 20 minutes ago didn't help? Andi At 04:06 PM 12/18/2003 -0800, Eduardo R. Maciel wrote: For me it has been crashing for about 10 days ago to now: [EMAIL PROTECTED]:/usr/src/php5-200312182030# make install-pear-packages [PEAR] DB - already installed: 1.5.0RC1

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Johannes Schlueter
Pierre-Alain Joye wrote: With --enabled-debug it reports a memory leak but it works again. /home/johannes/src/php-cvs/php-src/Zend/zend_execute.c(405) : Freeing Does it crash again without --enabled-debug? That's what I got before. Crash without, works with. Ah, I didn't run make test

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Andi Gutmans
Did this specific test work before I reverted Dmitry's patch? There were three changes in his patch, maybe one of them caused the crash and one of them fixed the problem you are mentioning. Andi At 01:24 AM 12/19/2003 +0100, Johannes Schlueter wrote: Pierre-Alain Joye wrote: With

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Johannes Schlueter
Andi Gutmans wrote: Did this specific test work before I reverted Dmitry's patch? There were three changes in his patch, maybe one of them caused the crash and one of them fixed the problem you are mentioning. Andi with yesterdays Beta3RC1 this test worked. johannes -- PHP Internals - PHP

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Pierre-Alain Joye
On Fri, 19 Dec 2003 02:22:06 +0200 Andi Gutmans [EMAIL PROTECTED] wrote: So the revert I did 20 minutes ago didn't help? Fresh check out. Same problem. It crashes in normal mode. No crash (but the ... being destroyed) message. Anything I can do to help more? As said in my previous post the

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Pierre-Alain Joye
On Fri, 19 Dec 2003 01:42:04 +0100 Pierre-Alain Joye [EMAIL PROTECTED] wrote: On Fri, 19 Dec 2003 02:22:06 +0200 Andi Gutmans [EMAIL PROTECTED] wrote: So the revert I did 20 minutes ago didn't help? Fresh check out. Same problem. It crashes in normal mode. No crash (but the ... being

Re: [PHP-DEV] Re: error_handler, was [PHP-DEV] B3, pear segfault,

2003-12-18 Thread Eduardo R. Maciel
On Fri, 19 Dec 2003 02:22:06 +0200 Andi Gutmans [EMAIL PROTECTED] wrote: So the revert I did 20 minutes ago didn't help? It was with the last snapshot, I´m going to checkout it now and test again... Anything else can I send that could help? Eduardo R. Maciel