Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-27 Thread Pierre Joye
On Wed, Feb 27, 2008 at 5:48 PM, David Zülke <[EMAIL PROTECTED]> wrote: > You mean my code should break because some ignorant noob is unaware > that PHP6, which is still months or years away, will throw out magic > quotes? How a E_DEPRECATED will break your code? Please, I doubt there is a nee

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-27 Thread David Zülke
Am 27.02.2008 um 17:25 schrieb Lokrain: Hello David, telling us what we already know. I am not quite sure, that all developers, for example the junior one, know that. You mean my code should break because some ignorant noob is unaware that PHP6, which is still months or years away,

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-27 Thread Lokrain
Hello David, > telling us what we already know. I am not quite sure, that all developers, for example the junior one, know that.

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-27 Thread Pierre Joye
Hi David, On Wed, Feb 27, 2008 at 5:19 PM, David Zülke <[EMAIL PROTECTED]> wrote: > I know, but IIRC, Andi or someone else suggested that there should be > a warning in 5.3, but that was not discussed further. Because adding a waring in 5.x is a no-no. > I mean, really, what's the point? I h

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-27 Thread David Zülke
Am 27.02.2008 um 17:03 schrieb Pierre Joye: Hi David, On Wed, Feb 27, 2008 at 4:52 PM, David Zülke <[EMAIL PROTECTED]> wrote: Guys, what's the verdict on this one? Right now, many already have if(function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc()) in their code. Now with t

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-27 Thread Pierre Joye
Hi David, On Wed, Feb 27, 2008 at 4:52 PM, David Zülke <[EMAIL PROTECTED]> wrote: > Guys, > > what's the verdict on this one? Right now, many already have > > > if(function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc()) > > in their code. > Now with the latest 5.3, that throws an E_

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-27 Thread David Zülke
Guys, what's the verdict on this one? Right now, many already have if(function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc()) in their code. Now with the latest 5.3, that throws an E_STRICT! Seriously, is that necessary? David Am 05.02.2008 um 21:23 schrieb Pierre Joye: Hi,

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-10 Thread Andrew Shearer
-1. Keep the query functions and return FALSE. No need to unnecessarily break b/c for scripts that were just trying to do the right thing by coping with both possibilities. It's just one more roadblock to PHP 6 adoption.

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Sam Barrow
On Fri, 2008-02-08 at 10:42 -0600, Brian Moon wrote: > Richard Quadling wrote: > > Aren't some things just worth the BC break? > > > > Having never used them, I can quite happily say bomb the bastards! > > Agreed. For Phorum will just change our code from: > > if ( get_magic_quotes_gpc() ) { >

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Brian Moon
Richard Quadling wrote: Aren't some things just worth the BC break? Having never used them, I can quite happily say bomb the bastards! Agreed. For Phorum will just change our code from: if ( get_magic_quotes_gpc() ) { to: if ( function_exists(get_magic_quotes_gpc) && get_magic_quotes_gpc()

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Richard Quadling
On 08/02/2008, Pierre Joye <[EMAIL PROTECTED]> wrote: > On Feb 8, 2008 1:26 PM, Tomas Kuliavas <[EMAIL PROTECTED]> wrote: > > >> So I guess I'm -1: Restore them, always return false, and throw > > >> E_DEPRECATED. > > > > > > But this was about them being in PHP 6, not PHP 5.. > > > If magic_quotes

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Pierre Joye
Hi! On Feb 8, 2008 2:31 PM, Sam Barrow <[EMAIL PROTECTED]> wrote: > I say throw them out. Magic quotes are easy to simulate 100%. I could cry by reading this sentence ;) -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubs

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Sam Barrow
On Fri, 2008-02-08 at 13:48 +0100, Pierre Joye wrote: > On Feb 8, 2008 1:26 PM, Tomas Kuliavas <[EMAIL PROTECTED]> wrote: > > >> So I guess I'm -1: Restore them, always return false, and throw > > >> E_DEPRECATED. > > > > > > But this was about them being in PHP 6, not PHP 5.. > > > If magic_quotes

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Pierre Joye
On Feb 8, 2008 1:26 PM, Tomas Kuliavas <[EMAIL PROTECTED]> wrote: > >> So I guess I'm -1: Restore them, always return false, and throw > >> E_DEPRECATED. > > > > But this was about them being in PHP 6, not PHP 5.. > > If magic_quotes_* is gone, so should anything else even remotely related > > to t

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Jani Taskinen
On Fri, 2008-02-08 at 14:26 +0200, Tomas Kuliavas wrote: > >> So I guess I'm -1: Restore them, always return false, and throw > >> E_DEPRECATED. > > > > But this was about them being in PHP 6, not PHP 5.. > > If magic_quotes_* is gone, so should anything else even remotely related > > to them be go

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Tomas Kuliavas
>> So I guess I'm -1: Restore them, always return false, and throw >> E_DEPRECATED. > > But this was about them being in PHP 6, not PHP 5.. > If magic_quotes_* is gone, so should anything else even remotely related > to them be gone. You have to fix your code anyway for it to work in PHP > 6 (or ev

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-08 Thread Jani Taskinen
On Thu, 2008-02-07 at 23:32 -0600, Larry Garfield wrote: > On Thursday 07 February 2008, Lukas Kahwe Smith wrote: > > On 07.02.2008, at 00:59, Pierre Joye wrote: > > > Hi Andi, > > > > > > On Feb 7, 2008 12:56 AM, Andi Gutmans <[EMAIL PROTECTED]> wrote: > > >> -1 > > >> > > >> Suggestion to enhance

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-07 Thread Tomas Kuliavas
> On Thursday 07 February 2008, Lukas Kahwe Smith wrote: >> On 07.02.2008, at 00:59, Pierre Joye wrote: >> > Hi Andi, >> > >> > On Feb 7, 2008 12:56 AM, Andi Gutmans <[EMAIL PROTECTED]> wrote: >> >> -1 >> >> >> >> Suggestion to enhance the suggestion: return false + emit E_STRICT >> >> message (but

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-07 Thread Larry Garfield
On Thursday 07 February 2008, Lukas Kahwe Smith wrote: > On 07.02.2008, at 00:59, Pierre Joye wrote: > > Hi Andi, > > > > On Feb 7, 2008 12:56 AM, Andi Gutmans <[EMAIL PROTECTED]> wrote: > >> -1 > >> > >> Suggestion to enhance the suggestion: return false + emit E_STRICT > >> message (but I am also

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-07 Thread Lukas Kahwe Smith
On 07.02.2008, at 00:59, Pierre Joye wrote: Hi Andi, On Feb 7, 2008 12:56 AM, Andi Gutmans <[EMAIL PROTECTED]> wrote: -1 Suggestion to enhance the suggestion: return false + emit E_STRICT message (but I am also fine with pure return false if people don't like this suggestion). Sounds re

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Steph Fox
I'm going to rock the boat again I guess... Suggestion to enhance the suggestion: return false + emit E_STRICT message (but I am also fine with pure return false if people don't like this suggestion). Sounds reasonable too. It would be nice to add a deprecate notice in 5.3.x as well. Whateve

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Pierre Joye
Hi Andi, On Feb 7, 2008 12:56 AM, Andi Gutmans <[EMAIL PROTECTED]> wrote: > -1 > > Suggestion to enhance the suggestion: return false + emit E_STRICT > message (but I am also fine with pure return false if people don't like > this suggestion). Sounds reasonable too. It would be nice to add a depr

RE: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Andi Gutmans
3 PM > To: PHP internals > Subject: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in > head, get a "final" decision > > Hi, > > It seems that there is voices in favor of keeping the GPC related > functions in HEAD/php6 but returning always FALSE. I thou

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Pierre Joye
On Feb 6, 2008 9:20 PM, Cristian Rodriguez <[EMAIL PROTECTED]> wrote: > 2008/2/6, Derick Rethans <[EMAIL PROTECTED]>: > > > I don't care that much, but I think it would matter if the functions > > just are there and return false (so -1). > > > > for set_magic_quotes_runtime(), if "true" is passed,

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Cristian Rodriguez
2008/2/6, Derick Rethans <[EMAIL PROTECTED]>: > I don't care that much, but I think it would matter if the functions > just are there and return false (so -1). > > for set_magic_quotes_runtime(), if "true" is passed, it should still > throw a fatal error, if "false" is passed it should not (or act

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Mark van der Velden
Pierre Joye wrote: Hi, +1: remove them (as it is now in HEAD) -1: Restore them and always return FALSE (not 0) 0: I don't care, do what you wish, I never use them anyway -1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Markus Fischer
Markus Fischer wrote: +1 I didn't realized it until I read Rasmus' mail. In this case, -1 to not break BC. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Geoffrey Sneddon
On 5 Feb 2008, at 20:23, Pierre Joye wrote: There is not really a need to discuss the removal again, that's why I ask for a simple vote: +1 -- Geoffrey Sneddon -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.ph

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Vesselin Kenashkov
+1 - remove the functions To make a script compatible one has to add function get_magic_quotes_gpc(){return 0;} in one of his library files. I think the current change is somewhat similar to PHP_INI_ALL in PHP -> PHP_INI_PERDIR for magic_quotes_gpc made in 4.2.3. It also could lead to breakage bu

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Lokrain
-1 On Feb 5, 2008 10:23 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: > Hi, > > It seems that there is voices in favor of keeping the GPC related > functions in HEAD/php6 but returning always FALSE. I thought the > decision was already done but I rather prefer to ask the list a second > time and be

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Jochem Maas
-1 Pierre Joye schreef: Hi, It seems that there is voices in favor of keeping the GPC related functions in HEAD/php6 but returning always FALSE. I thought the decision was already done but I rather prefer to ask the list a second time and be done with this topic (and be free to bogus any other

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Derick Rethans
On Tue, 5 Feb 2008, Mike Willbanks wrote: > > I know they've been marked "deprecated" and all, but, really, what's > > the cost/penalty to having a couple functions around for legacy apps? > > Then we will continue to be at the same old issue of they exist, people will > continue to use them and

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Derick Rethans
On Tue, 5 Feb 2008, Pierre Joye wrote: > There is not really a need to discuss the removal again, that's why I > ask for a simple vote: > > +1: remove them (as it is now in HEAD) > -1: Restore them and always return FALSE (not 0) > 0: I don't care, do what you wish, I never use them anyway I do

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-06 Thread Hannes Magnusson
On Feb 6, 2008 2:13 AM, Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > Daniel Brown wrote: > > On Feb 5, 2008 3:26 PM, Daniel Brown <[EMAIL PROTECTED]> wrote: > >> On Feb 5, 2008 3:23 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: > >>> Hi, > >>> > >>> It seems that there is voices in favor of keeping the

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Philip Olson
It seems that there is voices in favor of keeping the GPC related functions in HEAD/php6 but returning always FALSE. I thought the decision was already done but I rather prefer to ask the list a second time and be done with this topic (and be free to bogus any other bug reports about this problem,

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Pierre Joye
Hi Rasmus, On Feb 6, 2008 2:13 AM, Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > Daniel Brown wrote: > > On Feb 5, 2008 3:26 PM, Daniel Brown <[EMAIL PROTECTED]> wrote: > >> On Feb 5, 2008 3:23 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: > >>> Hi, > >>> > >>> It seems that there is voices in favor of

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Rasmus Lerdorf
Daniel Brown wrote: > On Feb 5, 2008 3:26 PM, Daniel Brown <[EMAIL PROTECTED]> wrote: >> On Feb 5, 2008 3:23 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: >>> Hi, >>> >>> It seems that there is voices in favor of keeping the GPC related >>> functions in HEAD/php6 but returning always FALSE. >> Per

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Steph Fox
But this has been discussed to death. Please say +1/-1/0 =) Pierre: Sorry, I didn't want to add to the noise, but for the sake of completeness I'll give you my 0. - Steph -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To u

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Pierre Joye
On Feb 6, 2008 1:01 AM, Daniel Brown <[EMAIL PROTECTED]> wrote: > > On Feb 5, 2008 5:46 PM, Mike Willbanks <[EMAIL PROTECTED]> wrote: > > > > > > I know they've been marked "deprecated" and all, but, really, what's > > > the cost/penalty to having a couple functions around for legacy apps? > > > >

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Daniel Brown
On Feb 5, 2008 5:46 PM, Mike Willbanks <[EMAIL PROTECTED]> wrote: > > > > I know they've been marked "deprecated" and all, but, really, what's > > the cost/penalty to having a couple functions around for legacy apps? > > > > Then we will continue to be at the same old issue of they exist, people wi

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Cristian Rodriguez
2008/2/5, Pierre Joye <[EMAIL PROTECTED]>: > Hi, > > It seems that there is voice > +1: remove them (as it is now in HEAD) Remove them , they are of no use. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Mike Willbanks
> > I know they've been marked "deprecated" and all, but, really, what's > the cost/penalty to having a couple functions around for legacy apps? > Then we will continue to be at the same old issue of they exist, people will continue to use them and never move away from them. Mike

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Richard Lynch
On Tue, February 5, 2008 2:38 pm, Jeremy Privett wrote: >> -1: Restore them and always return FALSE (not 0) I freely admit to not remembering a 2-year-old discussion, but it seems to me for BC reasons you'd want to do this... I know they've been marked "deprecated" and all, but, really, what's th

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Jeremy Privett
Pierre Joye wrote: Hi, It seems that there is voices in favor of keeping the GPC related functions in HEAD/php6 but returning always FALSE. I thought the decision was already done but I rather prefer to ask the list a second time and be done with this topic (and be free to bogus any other bug re

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Daniel Brown
On Feb 5, 2008 3:26 PM, Daniel Brown <[EMAIL PROTECTED]> wrote: > On Feb 5, 2008 3:23 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: > > Hi, > > > > It seems that there is voices in favor of keeping the GPC related > > functions in HEAD/php6 but returning always FALSE. > > Personally > > XX

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Markus Fischer
+1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread David Coallier
+1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Marco
I agree +1 Regards Marco

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Hannes Magnusson
On Feb 5, 2008 9:23 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: > +1: remove them (as it is now in HEAD) > -1: Restore them and always return FALSE (not 0) > 0: I don't care, do what you wish, I never use them anyway -1 (restore them) :) -Hannes -- PHP Internals - PHP Runtime Development Mailin

Re: [PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Daniel Brown
On Feb 5, 2008 3:23 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: > Hi, > > It seems that there is voices in favor of keeping the GPC related > functions in HEAD/php6 but returning always FALSE. Personally +1 -- Daniel P. Brown Senior Unix Geek -- PHP Internals - PHP Runtime Devel

[PHP-DEV] get_magic_quotes_gpc, get-magic-quotes-runtime in head, get a "final" decision

2008-02-05 Thread Pierre Joye
Hi, It seems that there is voices in favor of keeping the GPC related functions in HEAD/php6 but returning always FALSE. I thought the decision was already done but I rather prefer to ask the list a second time and be done with this topic (and be free to bogus any other bug reports about this prob