Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-05 Thread Andrey Hristov
Hi Stas, On 09/02/2011 10:44 PM, Stas Malyshev wrote: Hi! On 9/2/11 1:41 PM, Ferenc Kovacs wrote: I think you missed the referenced [1]: [1] Yes, we will still allow building with libmysql and we will fix bugs reported there and we will verify it works but focus on mysqlnd, as we're actually

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/streams/bug46024.phpt branches/PHP_5_4/ext/standard/tests/streams/bug46024.phpt trunk/ext/standard/tests/streams/bug4

2011-09-05 Thread Hannes Magnusson
On Sun, Sep 4, 2011 at 22:38, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! On 9/4/11 1:35 PM, Kalle Sommer Nielsen wrote: But if its possible to always be available in ZTS, what would the reasoning for it not to be available in NTS? I haven't dug into the code that deeply so I'm just

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-05 Thread Stas Malyshev
Hi! On 9/5/11 1:24 AM, Andrey Hristov wrote: the problem is that libmysql breaks, maybe more often than mysqlnd does. We rarely find bugs in mysqli, there are two codepaths in mysqli. If there is a bug in libmysql, what do you want: If we're dealing with libmysql bug, then I guess the

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-05 Thread Reindl Harald
Am 05.09.2011 11:08, schrieb Stas Malyshev: Hi! On 9/5/11 1:24 AM, Andrey Hristov wrote: the problem is that libmysql breaks, maybe more often than mysqlnd does. We rarely find bugs in mysqli, there are two codepaths in mysqli. If there is a bug in libmysql, what do you want: If we're

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/standard/tests/streams/bug46024.phpt branches/PHP_5_4/ext/standard/tests/streams/bug46024.phpt trunk/ext/standard/tests/streams/bug4

2011-09-05 Thread Johannes Schlüter
Hi, aside from the actual question: run-tests.php already makes heavy usage of realpath, so it's impossible to run the tests on a system without realpath. $ grep realpath run-tests.php | wc -l 14 johannes On Sun, 2011-09-04 at 16:41 +0200, Ferenc Kovacs wrote: Sorry, for the late reply, I

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Ulf Wendel
Am 04.09.2011 06:35, schrieb Stas Malyshev: The ones I'm most worried about are: 1. mysqli_stmt_num_rows() is expected to return number of rows after all rows were fetched while returning 0 before that. libmysql definitely Yes, here the test assumes a marginally different behavior. The test

Re: [PHP-DEV] sapi/cli/tests/020.php

2011-09-05 Thread Hannes Magnusson
On Sun, Sep 4, 2011 at 18:44, Ferenc Kovacs tyr...@gmail.com wrote: Hi. the test mentioned in the subject fails on the current trunk. it seems that Dynamic Library Support = enabled Path to sendmail =  -t -i is now missing of the output of php -n --ri standard I've checked and with the

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Stas Malyshev
Hi! On 9/5/11 2:29 AM, Ulf Wendel wrote: - BC breakage is impossible because behavior is undefined - update test, issue gone OK, since you say it's not the intended behavior to be relied upon, I'll remove this check from the test (if nobody beats me to it). -- Stanislav Malyshev,

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Pierre Joye
On Mon, Sep 5, 2011 at 11:37 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! On 9/5/11 2:29 AM, Ulf Wendel wrote:   - BC breakage is impossible because behavior is undefined   - update test, issue gone OK, since you say it's not the intended behavior to be relied upon, I'll remove

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Ulf Wendel
Am 05.09.2011 11:37, schrieb Stas Malyshev: Hi! On 9/5/11 2:29 AM, Ulf Wendel wrote: - BC breakage is impossible because behavior is undefined - update test, issue gone OK, since you say it's not the intended behavior to be relied upon, I'll remove this check from the test (if nobody beats

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Stas Malyshev
Hi! On 9/5/11 2:49 AM, Ulf Wendel wrote: Returning a relevant value for stmt_num_rows() seems a valid feature request that makes perfectly sense to me and is somewhat in line with the vague non-PS documentation of the case. It's not a good situation where mysqlnd and libmysql have different

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Ulf Wendel
Am 05.09.2011 12:00, schrieb Stas Malyshev: Hi! On 9/5/11 2:49 AM, Ulf Wendel wrote: Returning a relevant value for stmt_num_rows() seems a valid feature request that makes perfectly sense to me and is somewhat in line with the vague non-PS documentation of the case. It's not a good

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-05 Thread Hannes Magnusson
Then we need a sdk-dev so people doing their own windows builds can work in a correct environment while they are testing. Updating the sdk only on release makes it impossible for devs to test on windows prior to releases. -Hannes On Sat, Sep 3, 2011 at 00:55, Pierre Joye pierre@gmail.com

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-05 Thread Pierre Joye
as I said earlier, these files are updated on release. It will be done for the next releases. I will see if I can provide snapshots SDK but that's something I try to avoid as it bring its lot of issues with unstable/untested libs. In the meantime it is very easy to replace the existing bison with

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-05 Thread Hannes Magnusson
On Mon, Sep 5, 2011 at 14:03, Pierre Joye pierre@gmail.com wrote: as I said earlier, these files are updated on release. It will be done for the next releases. I will see if I can provide snapshots SDK but that's something I try to avoid as it bring its lot of issues with unstable/untested

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-05 Thread Pierre Joye
On Mon, Sep 5, 2011 at 2:06 PM, Hannes Magnusson hannes.magnus...@gmail.com wrote: On Mon, Sep 5, 2011 at 14:03, Pierre Joye pierre@gmail.com wrote: as I said earlier, these files are updated on release. It will be done for the next releases. I will see if I can provide snapshots SDK but

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Ulf Wendel
No mysqlnd-libmysql BC break here. Metadata and libmysql - there's hardly a better example why mysqlnd should be set as a default. With libmysql as a default, PHP 5.4 will have a randomly crashing default configuration. https://bugs.php.net/bug.php?id=55001

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Andrey Hristov
On 09/05/2011 03:19 PM, Ulf Wendel wrote: No mysqlnd-libmysql BC break here. Metadata and libmysql - there's hardly a better example why mysqlnd should be set as a default. With libmysql as a default, PHP 5.4 will have a randomly crashing default configuration.

[PHP-DEV] SKIIP of FAIL for tests depending on external bugs

2011-09-05 Thread Ulf Wendel
Am 05.09.2011 15:28, schrieb Andrey Hristov: On 09/05/2011 03:19 PM, Ulf Wendel wrote: ... always use the latest and greatest. Libmysql bug, exact version range is not known to me. Feel free to change the test to be skipped during SKIPIF, for example, like this: require(connect.inc) if

[PHP-DEV] drop TZ environment variable support in 5.4+?

2011-09-05 Thread Pierre Joye
hi, ext/date still supports the TZ environment variable in 5.3+ despite the better alternative available via either php.ini (per directory too) or http://www.php.net/date_default_timezone_set. The main problem is that putenv and getenv are not thread safe and many tests will fail either when

Re: [PHP-DEV] drop TZ environment variable support in 5.4+?

2011-09-05 Thread Derick Rethans
On Mon, 5 Sep 2011, Pierre Joye wrote: The main problem is that putenv and getenv are not thread safe and many tests will fail either when using TS SAPIs or on Windows. This method is already deprecated and it is recommended to rely on the other methods. Objections/comments? I'm against

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Ulf Wendel
Libmysql only test, skipped if using mysqlnd. No mysqlnd-libmysql BC break here. Am 02.09.2011 19:19, schrieb Stas Malyshev: new mysqli() [ext/mysqli/tests/mysqli_connect_oo_warnings.phpt] This one just times out trying to look up the invalid DNS name. This is a recent breakage, didn't happen

Re: [PHP-DEV] drop TZ environment variable support in 5.4+?

2011-09-05 Thread Pierre Joye
On Mon, Sep 5, 2011 at 4:05 PM, Derick Rethans der...@php.net wrote: On Mon, 5 Sep 2011, Pierre Joye wrote: The main problem is that putenv and getenv are not thread safe and many tests will fail either when using TS SAPIs or on Windows. This method is already deprecated and it is recommended

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Ulf Wendel
This is the one and only mysqlnd-libmysql difference of some practical relevance. I consider it at least questionable if libmysql is correct. If it was to be decided that mysqlnd is wrong, it is probably like five lines of code in mysqlnd to change, if need be. Am 02.09.2011 19:19, schrieb

Re: [PHP-DEV] INF behavior

2011-09-05 Thread Hannes Magnusson
On Tue, May 31, 2011 at 21:33, Philip Olson phi...@roshambo.org wrote: Hello everyone, There are differing opinions on this matter so I'll base a conclusion on current SVN: - Both (INF==INF and INF===INF) are true in PHP 5_4 because it's the correct behavior - PHP 5_3 will continue as is

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Andrey Hristov
Hi, On 09/05/2011 04:53 PM, Ulf Wendel wrote: This is the one and only mysqlnd-libmysql difference of some practical relevance. I consider it at least questionable if libmysql is correct. If it was to be decided that mysqlnd is wrong, it is probably like five lines of code in mysqlnd to

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Rasmus Lerdorf
On 09/05/2011 08:07 AM, Andrey Hristov wrote: and here we see a bug. The value in libmysql is not reset, as the Documentation states. Clear bug. For cases where a test exposes a libmysql bug, especially if it is something that acts differently across different versions of libmysql, the test

Re: [PHP-DEV] Why does mysqlnd get included in Linux 'core' PHP5 packages?

2011-09-05 Thread Johannes Schlüter
On Sat, 2011-09-03 at 14:42 +0200, Johannes Schlüter wrote: mysqlnd is not yet default from php.net side but SuSE has chosen to do so. Now there is one consequence: If mysqlnd is used it will be built statically in PHP, even on Unix, even if the other MySQL modules are built shared. This can

Re: [PHP-DEV] drop TZ environment variable support in 5.4+?

2011-09-05 Thread Stas Malyshev
Hi! On 9/5/11 6:57 AM, Pierre Joye wrote: The main problem is that putenv and getenv are not thread safe and many tests will fail either when using TS SAPIs or on Windows. This I'm not sure I understand how putenv() being non-thread-safe leads to tests failing - tests aren't threaded and

Re: [PHP-DEV] drop TZ environment variable support in 5.4+?

2011-09-05 Thread Pierre Joye
On Mon, Sep 5, 2011 at 9:40 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! On 9/5/11 6:57 AM, Pierre Joye wrote: The main problem is that putenv and getenv are not thread safe and many tests will fail either when using TS SAPIs or on Windows. This I'm not sure I understand how

[PHP-DEV] Anonymous functions are currently implemented using the Closure class. This is an implementation detail and should not be relied upon.

2011-09-05 Thread André Rømcke
Despite several mentions in the manual, lots of php 5.3 code uses this with instanceof or in function signature (eg: Doctrine 2). If you don't want to support this in the future, could this be cleaned-up in 5.4? ( the longer you wait, the more you break ) Possibly by creating a interface called

[PHP-DEV] REDIRECTTEST fails

2011-09-05 Thread Stas Malyshev
Hi! I have the pdo_mysql common.phpt test failing on my config, specifically the REDIRECTTEST part. It is probably due to the way I run the tests, but other tests work fine, only this one is wrong. So my environment is like this: My build directory in under php source in separate dir, so for

Re: [PHP-DEV] mysqli tests breaking

2011-09-05 Thread Ulf Wendel
Am 05.09.2011 18:49, schrieb Rasmus Lerdorf: In cases where there is no agreement whether something is a bug or just undefined behaviour it would be really nice if the library authors could work this out and agree on a common behaviour and failing that PHP should try to mask the internal

Re: [PHP-DEV] REDIRECTTEST fails

2011-09-05 Thread Ferenc Kovacs
On Mon, Sep 5, 2011 at 10:26 PM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! I have the pdo_mysql common.phpt test failing on my config, specifically the REDIRECTTEST part. It is probably due to the way I run the tests, but other tests work fine, only this one is wrong. So my environment

[PHP-DEV] netware, windows chown

2011-09-05 Thread Stas Malyshev
Hi! I've noticed a peculiar thing in our code - both Netware and Windows do not have native support for chown/chgrp. However on Netware these functions are not defined, but on Windows the are defined and always return false. So the question is - why? Is there any reason why Netware doesn't