Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Deleu
> > > I would like to suggest gitlab.com, which does provide hosting for free > for opensource projects: https://about.gitlab.com/solutions/open-source/ > Anyone with a github account can use it to log in. > It should be easy to migrate to any other gitlab instance if needed. There > are even

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Andreas Heigl
Hey Nikita. On 15.11.21 14:50, Nikita Popov wrote: [...] I hope that the new "Motivation" section clarifies things a bit, especially in regards to why "static analysis" is only a partial solution to this problem: https://wiki.php.net/rfc/deprecate_dynamic_properties#motivation Thanks for the

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Rowan Tommins
On 15/11/2021 14:49, Deleu wrote: I had already decided to spend time and effort learning about the project and then having to learn about their ticketing system and git repository is just unnecessary extra work. In any project above a handful of developers, learning the conventions and

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Rowan Tommins
On 15/11/2021 16:23, Andreas Heigl wrote: One thing, that can verify the correct working of properties, whether that is dynamic or static ones, is testing. Can it? I can't actually see how that would work, without also having a way to detect when dynamic properties were accessed, which

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Larry Garfield
On Mon, Nov 15, 2021, at 10:52 AM, Rowan Tommins wrote: > On 15/11/2021 16:23, Andreas Heigl wrote: >> One thing, that can verify the correct working of properties, whether >> that is dynamic or static ones, is testing. > > > Can it? I can't actually see how that would work, without also having a

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Andreas Heigl
Hey Rowan, hey all On 15.11.21 17:52, Rowan Tommins wrote: On 15/11/2021 16:23, Andreas Heigl wrote: One thing, that can verify the correct working of properties, whether that is dynamic or static ones, is testing. Can it? I can't actually see how that would work, without also having a way

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Côme Chilliet
Le lundi 15 novembre 2021, 15:49:04 CET Deleu a écrit : > Gitlab is not where the wide PHP Community is located. Composer, > widely-used and adopted packages, frameworks, PSRs, PHP itself and PHP Docs > are all hosted on GitHub. Choosing something else increases the barrier for > newcomers to

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Dan Ackroyd
On Mon, 15 Nov 2021 at 09:56, Hans Henrik Bergan wrote: > > if hosting it ourself is a priority, No, quite the opposite. The PHP project is pretty terrible at running infrastructure, as infrastructure needs to have people available to work on it immediately when there are issues, which is not a

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Dan Ackroyd
On Mon, 15 Nov 2021 at 09:47, Derick Rethans wrote: Derick wrote: > I think it is a mistake to decide on a whim to move over to GitHub > issues without having evaluated anything else. Maybe avoid being insulting about other people's decision making process? I'm pretty sure that Nikita doesn't

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread James Gilliland
On Mon, Nov 15, 2021 at 8:49 AM Deleu wrote: > > > > > > I would like to suggest gitlab.com, which does provide hosting for free > > for opensource projects: https://about.gitlab.com/solutions/open-source/ > > Anyone with a github account can use it to log in. > > It should be easy to migrate to

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Marco Pivetta
Chiming in, since it seems like people are suggesting Gitlab and further "exotic" tools. On Mon, Nov 15, 2021 at 6:06 PM Rowan Tommins wrote: > On 15/11/2021 14:49, Deleu wrote: > > I had already decided to spend time and effort learning about the > > project and then having to learn about

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

2021-11-15 Thread Arvids Godjuks
On Wed, Aug 25, 2021 at 1:03 PM Nikita Popov wrote: > Hi internals, > > I'd like to propose the deprecation of "dynamic properties", that is > properties that have not been declared in the class (stdClass and > __get/__set excluded, of course): > >

[PHP-DEV] Archiving of PHP-SRC Security Backport Repository on Github

2021-11-15 Thread Dale Hirt via internals
Hello PHP Internals, The PHP-SRC repository at

[PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread php-internals_nospam
L.S., As some of you may have seen, I posted a thread on Twitter a few days back referencing this RFC: https://twitter.com/jrf_nl/status/1459221549429542920 I've been asked to post the link to the Twitter discussion in this thread for visibility. The Twitter thread generated, and is still

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-15 Thread Matthew Brown
On Mon, 15 Nov 2021 at 17:32, Chase Peeler wrote: > > > On Mon, Nov 15, 2021 at 4:40 PM Matthew Brown > wrote: > > >> I encourage people to vote "yes" on this, if you want PHP to be better at >> preventing people from shooting themselves in the foot. > > > What if I want a language where

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Chase Peeler
On Mon, Nov 15, 2021 at 3:02 PM James Gilliland wrote: > On Mon, Nov 15, 2021 at 3:53 AM Derick Rethans wrote: > > > Dear Internals, > > > > On Wed, 10 Nov 2021, Nikita Popov wrote: > > > > > On Wed, Aug 25, 2021 at 12:02 PM Nikita Popov > > wrote: > > > > > > > This RFC takes the more direct

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-15 Thread Chase Peeler
On Mon, Nov 15, 2021 at 4:40 PM Matthew Brown wrote: > On Fri, 12 Nov 2021 at 08:08, Nikita Popov wrote: > > > Hi internals, > > > > I've opened the vote on > > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > > 2021-11-26. > > > > Regards, > > Nikita > > > > There are

[PHP-DEV] Re: [RFC] Migrating to GitHub issues

2021-11-15 Thread Björn Larsson via internals
Den 2021-11-02 kl. 15:19, skrev Nikita Popov: Hi internals, The migration from bugs.php.net to GitHub issues has already been discussed in https://externals.io/message/114300 and has already happened for documentation issues. I'd like to formally propose to use GitHub for PHP implementation

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Deleu
On Tue, Nov 16, 2021, 00:36 wrote: > L.S., > > As some of you may have seen, I posted a thread on Twitter a few days > back referencing this RFC: > https://twitter.com/jrf_nl/status/1459221549429542920 > > I've been asked to post the link to the Twitter discussion in this > thread for

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread James Gilliland
On Mon, Nov 15, 2021 at 3:53 AM Derick Rethans wrote: > Dear Internals, > > On Wed, 10 Nov 2021, Nikita Popov wrote: > > > On Wed, Aug 25, 2021 at 12:02 PM Nikita Popov > wrote: > > > > > This RFC takes the more direct route of deprecating this > > > functionality entirely. I expect that this

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Deleu
> > By design my REST API utilizes dynamic properties. I've always found it to > be a feature of PHP, not a bug. > > -- > Chase Peeler > chasepee...@gmail.com > I am in the unfortunate position of inheriting a system with such REST API design. I can never build new REST APIs to replace the old

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Björn Larsson via internals
Den 2021-11-15 kl. 10:52, skrev Derick Rethans: Dear Internals, On Wed, 10 Nov 2021, Nikita Popov wrote: On Wed, Aug 25, 2021 at 12:02 PM Nikita Popov wrote: This RFC takes the more direct route of deprecating this functionality entirely. I expect that this will have relatively little

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Chase Peeler
On Mon, Nov 15, 2021 at 3:11 PM Deleu wrote: > By design my REST API utilizes dynamic properties. I've always found it to >> be a feature of PHP, not a bug. >> >> -- >> Chase Peeler >> chasepee...@gmail.com >> > > I am in the unfortunate position of inheriting a system with such REST API >

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-15 Thread Matthew Brown
On Fri, 12 Nov 2021 at 08:08, Nikita Popov wrote: > Hi internals, > > I've opened the vote on > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > 2021-11-26. > > Regards, > Nikita > There are two things developers think about when releasing code: 1. does it work for me

[PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Mark Randall
On 15/11/2021 23:35, php-internals_nos...@adviesenzo.nl wrote: Either way, in my estimation, handling this deprecation will - again - require not insignificant dev-time from maintainers to determine the best course of action for each flagged instance and to implement the changes, and what with

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Levi Morrison via internals
> if hosting it ourself is a priority, i suggest looking into GitLab’s > Community Edition, which is entirely open source, > and the GNOME project moved from Bugzilla to GitLab CE in 2018, > here's how that worked out, 2 years later: > https://about.gitlab.com/blog/2020/09/08/gnome-follow-up/ >

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-15 Thread Pierre Joye
Hi, On Tue, Nov 16, 2021, 4:40 AM Matthew Brown wrote: > On Fri, 12 Nov 2021 at 08:08, Nikita Popov wrote: > > > Hi internals, > > > > I've opened the vote on > > https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close > > 2021-11-26. > > > > Regards, > > Nikita > > > > > I

[PHP-DEV] Finer control of diagnostics (deprecations, notices, and warnings)

2021-11-15 Thread Rowan Tommins
Hi all, Concerns have been raised a few times recently about adding new warnings and deprecation notices, particularly: * That code bases with many instances of a particular pattern see a lot of noise when a message is added * That library maintainers face pressure to fix deprecations from

Re: [PHP-DEV] Finer control of diagnostics (deprecations, notices, and warnings)

2021-11-15 Thread Michał Marcin Brzuchalski
Hi Rowan, pon., 15 lis 2021 o 12:34 Rowan Tommins napisał(a): > Hi all, > > Concerns have been raised a few times recently about adding new warnings > and deprecation notices, particularly: > > * That code bases with many instances of a particular pattern see a lot > of noise when a message is

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Andreas Heigl
Hea all. On 15.11.21 10:52, Derick Rethans wrote: Dear Internals, On Wed, 10 Nov 2021, Nikita Popov wrote: On Wed, Aug 25, 2021 at 12:02 PM Nikita Popov wrote: This RFC takes the more direct route of deprecating this functionality entirely. I expect that this will have relatively little

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

2021-11-15 Thread Benjamin Eberlei
On Mon, Nov 15, 2021 at 11:26 AM Nicolas Grekas < nicolas.grekas+...@gmail.com> wrote: > Hi Nikita, hi everybody, > > Le mer. 25 août 2021 à 12:03, Nikita Popov a écrit > : > > > Hi internals, > > > > I'd like to propose the deprecation of "dynamic properties", that is > > properties that have

Re: [PHP-DEV] Finer control of diagnostics (deprecations, notices, and warnings)

2021-11-15 Thread Michał Marcin Brzuchalski
pon., 15 lis 2021 o 13:03 Michał Marcin Brzuchalski < michal.brzuchal...@gmail.com> napisał(a): > Hi Rowan, > > pon., 15 lis 2021 o 12:34 Rowan Tommins > napisał(a): > >> Hi all, >> >> Concerns have been raised a few times recently about adding new warnings >> and deprecation notices,

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

2021-11-15 Thread Kamil Tekiela
I would be very sad to see this RFC not go through. I have voted Yes as I believe this "feature":is a bug that needs to be fixed. There is also an opt-in proposed for people who really do consider it a feature. I don't see why it would cause much trouble for maintainers of OSS. At the moment it

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Derick Rethans
Dear Internals, On Wed, 10 Nov 2021, Nikita Popov wrote: > On Wed, Aug 25, 2021 at 12:02 PM Nikita Popov wrote: > > > This RFC takes the more direct route of deprecating this > > functionality entirely. I expect that this will have relatively > > little impact on modern code (e.g. in Symfony

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Marco Pivetta
Hey Derick On Mon, Nov 15, 2021 at 10:47 AM Derick Rethans wrote: > Dear Internals, > > I think it is a mistake to decide on a whim to move over to GitHub > issues without having evaluated anything else. > > GitHub is a proprietary platform, where unlike with the code > repositories, the

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Derick Rethans
Dear Internals, I think it is a mistake to decide on a whim to move over to GitHub issues without having evaluated anything else. GitHub is a proprietary platform, where unlike with the code repositories, the interactions and issues are not easy to migrate out of again. It is also now owned

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Hans Henrik Bergan
if hosting it ourself is a priority, i suggest looking into GitLab’s Community Edition, which is entirely open source, and the GNOME project moved from Bugzilla to GitLab CE in 2018, here's how that worked out, 2 years later: https://about.gitlab.com/blog/2020/09/08/gnome-follow-up/ (and the TL;DR

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Andreas Leathley
On 15.11.21 10:47, Derick Rethans wrote: GitHub is a proprietary platform, where unlike with the code repositories, the interactions and issues are not easy to migrate out of again. It is also now owned by MSFT, and although they are making friendly noises towards Open Source, I remain largely

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

2021-11-15 Thread Nicolas Grekas
Hi Nikita, hi everybody, Le mer. 25 août 2021 à 12:03, Nikita Popov a écrit : > Hi internals, > > I'd like to propose the deprecation of "dynamic properties", that is > properties that have not been declared in the class (stdClass and > __get/__set excluded, of course): > >

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Deleu
On Mon, Nov 15, 2021 at 10:47 AM Derick Rethans wrote: > > and I worry that too > few people are going to be interested in gardening the issues on GH. > > cheers, > Derick > > > On Tue, 2 Nov 2021, Nikita Popov wrote: > > > Hi internals, > > > > The migration from bugs.php.net to GitHub issues

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Nikita Popov
On Mon, Nov 15, 2021 at 10:47 AM Derick Rethans wrote: > Dear Internals, > > I think it is a mistake to decide on a whim to move over to GitHub > issues without having evaluated anything else. > > GitHub is a proprietary platform, where unlike with the code > repositories, the interactions and

Re: [PHP-DEV] Finer control of diagnostics (deprecations, notices, and warnings)

2021-11-15 Thread Rowan Tommins
On 15/11/2021 12:03, Michał Marcin Brzuchalski wrote: Personally, I think that given feature users would add whole vendor directory, since the vendor/package directory is not fixed, may change - which in essence may go out of control and silently invoke a waterfall of unexpected errors. I

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Andreas Heigl
On 15.11.21 14:19, Rowan Tommins wrote: On 15/11/2021 12:51, Andreas Heigl wrote: PS: Am I the only one missing whether this is a 2/3 or a 50%+1 vote in the RFC? All votes require a 2/3 majority as of https://wiki.php.net/rfc/abolish-narrow-margins Thanks! I just stumbled over the fact

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Benjamin Eberlei
On Mon, Nov 15, 2021 at 1:52 PM Andreas Heigl wrote: > Hea all. > > On 15.11.21 10:52, Derick Rethans wrote: > > Dear Internals, > > > > On Wed, 10 Nov 2021, Nikita Popov wrote: > > > >> On Wed, Aug 25, 2021 at 12:02 PM Nikita Popov > wrote: > >> > >>> This RFC takes the more direct route of

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Nikita Popov
On Mon, Nov 15, 2021 at 1:52 PM Andreas Heigl wrote: > Hea all. > > On 15.11.21 10:52, Derick Rethans wrote: > > Dear Internals, > > > > On Wed, 10 Nov 2021, Nikita Popov wrote: > > > >> On Wed, Aug 25, 2021 at 12:02 PM Nikita Popov > wrote: > >> > >>> This RFC takes the more direct route of

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Alexandru Pătrănescu
On Mon, Nov 15, 2021 at 2:52 PM Andreas Heigl wrote: > > And as far as I can see from the PR associated with this RFC it will not > make life easier for the internals team. It is not like there will be > hundreds of lines code less to maintain. On the contrary. There is more > code and more

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-15 Thread Côme Chilliet
I strongly agree with Derick on this matter. Le lundi 15 novembre 2021, 12:06:54 CET Nikita Popov a écrit : > For better or worse, GitHub is where nearly all open-source projects are > hosted, which means that pretty much anyone involved in open-source has an > account there and is familiar with

Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-15 Thread Rowan Tommins
On 15/11/2021 12:51, Andreas Heigl wrote: PS: Am I the only one missing whether this is a 2/3 or a 50%+1 vote in the RFC? All votes require a 2/3 majority as of https://wiki.php.net/rfc/abolish-narrow-margins -- Rowan Tommins [IMSoP] -- PHP Internals - PHP Runtime Development Mailing