paleolimbot commented on PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1204376962
Ok, made the definitions inline, although perhaps there is a prettier way to
do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
lidavidm commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r937046260
##
src/nanoarrow/typedefs_inline.h:
##
@@ -0,0 +1,172 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
paleolimbot commented on PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1204391097
I'm not sure which buffer you mean! The `struct ArrowBuffer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lidavidm commented on PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1204391711
> I'm not sure which buffer you mean! The `struct ArrowBuffer`?
Sorry, I mean the buffer of values inside the bitmap builder
--
This is an automated message from the Apache G
lidavidm merged PR #51:
URL: https://github.com/apache/arrow-adbc/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arrow.apach
codecov-commenter commented on PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1205513028
#
[Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/10?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
paleolimbot commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r938858642
##
src/nanoarrow/bitmap_inline.h:
##
@@ -0,0 +1,131 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
paleolimbot commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r938864854
##
src/nanoarrow/bitmap_inline.h:
##
@@ -0,0 +1,131 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
paleolimbot commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r938856922
##
src/nanoarrow/nanoarrow.h:
##
@@ -483,82 +372,117 @@ ArrowErrorCode ArrowSchemaViewInit(struct
ArrowSchemaView* schema_view,
/// }@
-/// \defgroup nanoa
paleolimbot commented on PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1206514130
I see...I'd been using it to simplify the append process, but the right
thing to do is to properly bitpack-as-you-append (which is now implemented) so
that the `ArrowBufferXXX()`
paleolimbot commented on PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#issuecomment-1206553114
Ok, I think I have this with syntax and feature parity with the `struct
ArrowBuffer` (in preparation for defining an owning `struct ArrowArray` that is
a `struct ArrowBitmap` + a
paleolimbot commented on issue #8:
URL: https://github.com/apache/arrow-nanoarrow/issues/8#issuecomment-1206564623
That's an excellent point, and David's "bag of buffers" comment makes a lot
of sense. Type-specific appenders are definitely the way to go and I think
after #5 we'll have what
paleolimbot merged PR #13:
URL: https://github.com/apache/arrow-nanoarrow/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arr
lidavidm commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r939027329
##
src/nanoarrow/bitmap_inline.h:
##
@@ -0,0 +1,323 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. S
pitrou commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r939041016
##
src/nanoarrow/buffer_inline.h:
##
@@ -15,14 +15,20 @@
// specific language governing permissions and limitations
// under the License.
+#ifndef NANOARROW_BUFFE
paleolimbot commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r939043459
##
src/nanoarrow/buffer_inline.h:
##
@@ -15,14 +15,20 @@
// specific language governing permissions and limitations
// under the License.
+#ifndef NANOARROW_
paleolimbot commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r939045503
##
src/nanoarrow/buffer_inline.h:
##
@@ -15,14 +15,20 @@
// specific language governing permissions and limitations
// under the License.
+#ifndef NANOARROW_
lidavidm commented on code in PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10#discussion_r939046140
##
src/nanoarrow/buffer_inline.h:
##
@@ -15,14 +15,20 @@
// specific language governing permissions and limitations
// under the License.
+#ifndef NANOARROW_BUF
paleolimbot merged PR #10:
URL: https://github.com/apache/arrow-nanoarrow/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arr
paleolimbot closed issue #4: Implement bitmap helpers
URL: https://github.com/apache/arrow-nanoarrow/issues/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
paleolimbot closed issue #11: Inline performance-sensitive functions and their
dependencies
URL: https://github.com/apache/arrow-nanoarrow/issues/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
paleolimbot commented on issue #11:
URL: https://github.com/apache/arrow-nanoarrow/issues/11#issuecomment-1206753929
Fixed in #10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
codecov-commenter commented on PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#issuecomment-1206757501
#
[Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/12?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
paleolimbot opened a new pull request, #14:
URL: https://github.com/apache/arrow-nanoarrow/pull/14
Fixes #5 by implementing an Array whose buffer lifecycle is handled by
`struct ArrowBuffer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lidavidm commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r939160612
##
src/nanoarrow/nanoarrow.h:
##
@@ -261,6 +261,24 @@ ArrowErrorCode ArrowMetadataGetValue(const char* metadata,
const char* key,
lidavidm commented on code in PR #14:
URL: https://github.com/apache/arrow-nanoarrow/pull/14#discussion_r939166568
##
src/nanoarrow/typedefs_inline.h:
##
@@ -165,6 +212,20 @@ struct ArrowBitmap {
int64_t size_bits;
};
+/// \brief A structure used as the private data member
dependabot[bot] opened a new pull request, #54:
URL: https://github.com/apache/arrow-adbc/pull/54
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.4.0 to 42.4.1.
Changelog
Sourced from https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md";>postgresql's
changelog.
lidavidm merged PR #54:
URL: https://github.com/apache/arrow-adbc/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arrow.apach
paleolimbot commented on code in PR #14:
URL: https://github.com/apache/arrow-nanoarrow/pull/14#discussion_r940170048
##
src/nanoarrow/typedefs_inline.h:
##
@@ -165,6 +212,20 @@ struct ArrowBitmap {
int64_t size_bits;
};
+/// \brief A structure used as the private data mem
lidavidm commented on code in PR #14:
URL: https://github.com/apache/arrow-nanoarrow/pull/14#discussion_r940193353
##
src/nanoarrow/array.c:
##
@@ -0,0 +1,220 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the N
paleolimbot commented on code in PR #14:
URL: https://github.com/apache/arrow-nanoarrow/pull/14#discussion_r940252598
##
src/nanoarrow/nanoarrow.h:
##
@@ -503,6 +456,35 @@ static inline void ArrowBitmapReset(struct ArrowBitmap*
bitmap);
/// }@
+/// \defgroup nanoarrow-arra
codecov-commenter commented on PR #14:
URL: https://github.com/apache/arrow-nanoarrow/pull/14#issuecomment-1208146419
#
[Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/14?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
paleolimbot commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r940384176
##
src/nanoarrow/nanoarrow.h:
##
@@ -261,6 +261,24 @@ ArrowErrorCode ArrowMetadataGetValue(const char* metadata,
const char* key,
lidavidm opened a new issue, #55:
URL: https://github.com/apache/arrow-adbc/issues/55
- A way to get the row count of a result set, when known (== DBAPI
`Cursor.rowcount`)
- A way to get the name of the 'current' catalog (== Ibis
`Backend.current_database`)
--
This is an automated mes
paleolimbot commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r940454918
##
src/nanoarrow/metadata.c:
##
@@ -114,8 +114,156 @@ ArrowErrorCode ArrowMetadataGetValue(const char*
metadata, const char* key,
return NANOARROW_OK;
}
+
paleolimbot commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r940456577
##
src/nanoarrow/metadata.c:
##
@@ -114,8 +114,156 @@ ArrowErrorCode ArrowMetadataGetValue(const char*
metadata, const char* key,
return NANOARROW_OK;
}
+
lidavidm commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r940548127
##
src/nanoarrow/metadata.c:
##
@@ -114,8 +114,156 @@ ArrowErrorCode ArrowMetadataGetValue(const char*
metadata, const char* key,
return NANOARROW_OK;
}
+Arr
paleolimbot commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r940552993
##
src/nanoarrow/metadata.c:
##
@@ -114,8 +114,156 @@ ArrowErrorCode ArrowMetadataGetValue(const char*
metadata, const char* key,
return NANOARROW_OK;
}
+
lidavidm commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r940553688
##
src/nanoarrow/metadata.c:
##
@@ -114,8 +114,156 @@ ArrowErrorCode ArrowMetadataGetValue(const char*
metadata, const char* key,
return NANOARROW_OK;
}
+Arr
paleolimbot closed issue #5: Implement `ArrowArray*` helpers
URL: https://github.com/apache/arrow-nanoarrow/issues/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
paleolimbot merged PR #14:
URL: https://github.com/apache/arrow-nanoarrow/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arr
paleolimbot commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r940564227
##
src/nanoarrow/metadata.c:
##
@@ -114,8 +114,156 @@ ArrowErrorCode ArrowMetadataGetValue(const char*
metadata, const char* key,
return NANOARROW_OK;
}
+
lidavidm opened a new pull request, #57:
URL: https://github.com/apache/arrow-adbc/pull/57
This demonstrates distributing ADBC drivers as Python packages. A Python
package for a driver just has a function that exposes the address of the
AdbcDriverInitFunc. This is passed to the driver manag
paleolimbot commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r941390810
##
src/nanoarrow/metadata.c:
##
@@ -114,8 +114,156 @@ ArrowErrorCode ArrowMetadataGetValue(const char*
metadata, const char* key,
return NANOARROW_OK;
}
+
lidavidm commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r941444065
##
src/nanoarrow/typedefs_inline.h:
##
@@ -166,6 +166,34 @@ enum ArrowType {
NANOARROW_TYPE_INTERVAL_MONTH_DAY_NANO
};
+/// \brief An non-owning view of a str
paleolimbot commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r941544035
##
src/nanoarrow/typedefs_inline.h:
##
@@ -166,6 +166,34 @@ enum ArrowType {
NANOARROW_TYPE_INTERVAL_MONTH_DAY_NANO
};
+/// \brief An non-owning view of a
lidavidm commented on code in PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12#discussion_r941545043
##
src/nanoarrow/typedefs_inline.h:
##
@@ -166,6 +166,34 @@ enum ArrowType {
NANOARROW_TYPE_INTERVAL_MONTH_DAY_NANO
};
+/// \brief An non-owning view of a str
paleolimbot merged PR #12:
URL: https://github.com/apache/arrow-nanoarrow/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arr
paleolimbot closed issue #6: Implement metadata building utility
URL: https://github.com/apache/arrow-nanoarrow/issues/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
paleolimbot opened a new pull request, #15:
URL: https://github.com/apache/arrow-nanoarrow/pull/15
When pulling nanoarrow to a new computer I realized that the example user
presets were well out of date...typical development will require setting
`Arrow_DIR`, `ArrowTesting_DIR`, and `GTest_D
codecov-commenter commented on PR #15:
URL: https://github.com/apache/arrow-nanoarrow/pull/15#issuecomment-1209616315
#
[Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/15?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
lidavidm merged PR #56:
URL: https://github.com/apache/arrow-adbc/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arrow.apach
lidavidm closed issue #52: [Python] Implement DBAPI
URL: https://github.com/apache/arrow-adbc/issues/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
paleolimbot merged PR #15:
URL: https://github.com/apache/arrow-nanoarrow/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arr
paleolimbot opened a new pull request, #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16
Fixes #8.
After #14, users can already append to `struct ArrowBuffer`s, possibly
element-wise, and use those buffers to make a valid `struct ArrowArray` (given
some knowledge of the spe
codecov-commenter commented on PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#issuecomment-1209865114
#
[Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/16?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
lidavidm commented on PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#issuecomment-1209880928
I think typed appenders would make sense, yeah. Also, having single-element
appenders so you can easily build up arrays from row-oriented data.
I don't think we need to handle
lidavidm commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942417008
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArraySe
paleolimbot commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942431188
##
src/nanoarrow/typedefs_inline.h:
##
@@ -166,6 +166,24 @@ enum ArrowType {
NANOARROW_TYPE_INTERVAL_MONTH_DAY_NANO
};
+/// \brief Functional types of buff
paleolimbot commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942434862
##
src/nanoarrow/utils_inline.h:
##
@@ -26,6 +26,114 @@
extern "C" {
#endif
+static inline void ArrowLayoutInit(struct ArrowLayout* layout,
+
paleolimbot commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942437669
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArra
lidavidm commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942439274
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArraySe
paleolimbot commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942441450
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArra
paleolimbot commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942442675
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArra
paleolimbot commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942446356
##
src/nanoarrow/array_inline.h:
##
@@ -0,0 +1,146 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
lidavidm commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942446454
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArraySe
lidavidm commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942447804
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArraySe
paleolimbot commented on PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#issuecomment-1210685336
Just a note that I'm reworking this interface based on some thoughts after
working with this for a day or so:
- Instead of copying all the buffer/bitmap methods for the arra
paleolimbot commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942470780
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArra
lidavidm commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942472594
##
src/nanoarrow/nanoarrow.h:
##
@@ -508,9 +512,31 @@ void ArrowArraySetValidityBitmap(struct ArrowArray* array,
struct ArrowBitmap* b
ArrowErrorCode ArrowArraySe
zeroshade commented on issue #55:
URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1210860838
Two more gaps to add:
* Retrieve the last inserted id for inserts into an auto-increment table
* Retrieve the number of rows affected by the last query (number inserted /
n
zeroshade opened a new issue, #59:
URL: https://github.com/apache/arrow-adbc/issues/59
For the common case of executing a single SQL string, let's have a method on
the connection object for executing the query directly without the need for an
intermediate Statement object
--
This is an a
zeroshade opened a new issue, #60:
URL: https://github.com/apache/arrow-adbc/issues/60
If available, it would be great to be able to retrieve any information about
parameter binding that is available. Some potential information that *might* be
available:
* Number of expected paramete
zeroshade commented on issue #59:
URL: https://github.com/apache/arrow-adbc/issues/59#issuecomment-1210917005
With this, it might make sense for the `AdbcStatement` object to *only*
represent a prepared statement and place the `Prepare` method on the Connection
rather than on the statement.
zeroshade opened a new issue, #61:
URL: https://github.com/apache/arrow-adbc/issues/61
Rather than the separate `Execute` / `GetStream` functions, it might be
better to follow something similar to FlightSQL's interface or Go's
`database/sql` API.
Have two functions:
* Execute
lidavidm commented on issue #59:
URL: https://github.com/apache/arrow-adbc/issues/59#issuecomment-1210982209
I think this makes sense to provide as a convenience, but maybe not as the
only method. The separate Statement object still lets us configure any options
in an ABI-compatible way (si
lidavidm commented on issue #60:
URL: https://github.com/apache/arrow-adbc/issues/60#issuecomment-1210983818
Flight SQL provides this. I think this makes sense, but yeah, something like
`SELECT ?, ?` is going to be dubious. I don't know if there's a great way of
indicating that, though. Or,
lidavidm commented on issue #61:
URL: https://github.com/apache/arrow-adbc/issues/61#issuecomment-1210987487
I think it may still have sense to have a generic Execute to ease
compatibility with APIs that do not differentiate between the types of queries
(and note JDBC has all three!), but h
lidavidm commented on issue #61:
URL: https://github.com/apache/arrow-adbc/issues/61#issuecomment-1210989539
Also, possibly the driver manager could define execute-with-result-set and
execute-with-rows-affected in terms of the generic execute + generic getters to
retrieve the affected rows/
lidavidm commented on issue #61:
URL: https://github.com/apache/arrow-adbc/issues/61#issuecomment-1210994922
CC @pitrou, @hannes, @krlmlr if you have opinions here?
@lwhite1 had the same feedback about executeQuery/execute in Java last
month. So for consistency a query method returni
zeroshade commented on issue #60:
URL: https://github.com/apache/arrow-adbc/issues/60#issuecomment-1211012442
at a minimum it would be good to be able to at least know the *number* of
expected inputs even if the schema isn't knowable.
Maybe having two values? an integer indicating the
lidavidm commented on code in PR #16:
URL: https://github.com/apache/arrow-nanoarrow/pull/16#discussion_r942753583
##
src/nanoarrow/array_inline.h:
##
@@ -0,0 +1,246 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. Se
lidavidm commented on issue #60:
URL: https://github.com/apache/arrow-adbc/issues/60#issuecomment-1211081338
That makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
lidavidm commented on issue #60:
URL: https://github.com/apache/arrow-adbc/issues/60#issuecomment-1211134073
How about this? The parameters are always encoded as a schema, but unknown
types are represented as just NullType. Avoids having lots of optional
things/multiple calls.
```dif
paleolimbot opened a new pull request, #17:
URL: https://github.com/apache/arrow-nanoarrow/pull/17
It turns out this is really annoying to do otherwise! Declaring a variable
of an appropriate type gets verbose when switching on type, and it sounds like
these functions might be useful for da
codecov-commenter commented on PR #17:
URL: https://github.com/apache/arrow-nanoarrow/pull/17#issuecomment-1211146044
#
[Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/17?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
lidavidm commented on code in PR #17:
URL: https://github.com/apache/arrow-nanoarrow/pull/17#discussion_r942812080
##
src/nanoarrow/buffer_test.cc:
##
@@ -160,3 +160,31 @@ TEST(BufferTest, BufferTestError) {
ArrowBufferReset(&buffer);
}
+
+TEST(BufferTest, BufferTestAppend
lidavidm merged PR #58:
URL: https://github.com/apache/arrow-adbc/pull/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arrow.apach
lidavidm commented on issue #55:
URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1211184131
So looking into it
- rowcount is easy to bind, but hard to support (lots of things don't
support it or only support it for inserts) - that's OK. Flight SQL only exposes
it for upd
zeroshade commented on issue #60:
URL: https://github.com/apache/arrow-adbc/issues/60#issuecomment-1211193521
Seems good to me! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
lidavidm commented on issue #55:
URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1211235028
Punting on paramstyle and last inserted ID, but adding row count and current
catalog:
```diff
commit 50b2e40d727c0a51029d7f5506c0696b3a19a3b9
Author: David Li
Date:
lidavidm commented on issue #55:
URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1211236715
Returning strings from a C API is a bit annoying and I'm not sure whether
this is preferable, or if we want to go with an ODBC-style API (pass a
caller-allocated buffer and length an
paleolimbot commented on code in PR #17:
URL: https://github.com/apache/arrow-nanoarrow/pull/17#discussion_r943029428
##
src/nanoarrow/buffer_test.cc:
##
@@ -160,3 +160,31 @@ TEST(BufferTest, BufferTestError) {
ArrowBufferReset(&buffer);
}
+
+TEST(BufferTest, BufferTestApp
paleolimbot commented on PR #17:
URL: https://github.com/apache/arrow-nanoarrow/pull/17#issuecomment-1211464135
Ok - this is a first pass at #8 that implements the functions needed to make
"build by buffer" a thing. The `ArrowBufferAppendInt8()` family of functions
helps make code that does
paleolimbot merged PR #17:
URL: https://github.com/apache/arrow-nanoarrow/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@arr
zeroshade commented on issue #55:
URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1212115628
Is the idea that `RowCount` would do double duty as the number of rows in a
result set OR the number of rows affected by an update/insert?
Given the lack of reliable support,
lidavidm commented on issue #55:
URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1212119635
> Is the idea that `RowCount` would do double duty as the number of rows in
a result set OR the number of rows affected by an update/insert?
Yeah, I don't see a reason to have
zeroshade commented on issue #55:
URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1212124555
Sounds good to me
> Also, I would argue these sorts of use cases are mostly out of scope,
though that's mostly my assumption.
I agree, seems fine for that to be out of
lidavidm opened a new pull request, #62:
URL: https://github.com/apache/arrow-adbc/pull/62
Fixes #60.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
bdklahn opened a new issue, #330:
URL: https://github.com/apache/arrow-julia/issues/330
I'm so glad someone implemented Arrow for Julia. Thanks!
And I think the intro to the User Manual is the clearest I've come across to
help understand the what and why of Arrow.
It looks like
401 - 500 of 1554 matches
Mail list logo
