[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-13 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396834367 @sijie Ok thanks very much for the explanation, I already merged to my branch. This is an

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396810024 @sijie I still have questions, 1. Although the fix will solve the object recycle problem, but the response with valid data is ignored. Will this case

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396810024 @sijie I still have questions, 1. Although the fix will solve the object recycle problem, but the response with valid data is ignored. Will this case

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie it's possible that compleRequest() come before request.complte(), such as

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie it's possible that compleRequest() come before request.complte(), such as

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie it's possible that compleRequest() come before request.complte(), such as

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie sometimes compleRequest() come before request.complte(), such as the path on

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times compleRequest() come before request.complte(), such as the path on

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times compleRequest() come before request.complte(), such as the path on

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times compleRequest() come before request.complte, such as the path on

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times compleRequest() come before request.complte(), such as the path on

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times requestComplete come before request.complte, such as the path on

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times requestComplete come before request.complte, such as the path on

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times requestComplete come before request.complte, such as the path on

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396500590 @sijie but in

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396500590 @sijie but in

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-12 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396500590 @sijie but in

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-11 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396449927 @sijie I think the fix of infodog/bookkeeper#1 may have problem. because `request.complete(rCtx.getBookieIndex(), bookie, buffer, entryId) `will be

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-11 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396449927 @sijie I think the fix of infodog/bookkeeper#1 may have problem. because `request.complete(rCtx.getBookieIndex(), bookie, buffer, entryId) `will be

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-11 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396449927 @sijie I think the fix of infodog/bookkeeper#1 may have problem. because `request.complete(rCtx.getBookieIndex(), bookie, buffer, entryId) `will be

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-11 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396167544 @eolivelli I setup a bookkeeper cluster with 3 bookie server, and then setup two clients read the logs , the client code is as following: ``` void

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-11 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396167544 @eolivelli I setup a bookkeeper cluster with 3 bookie server, and then setup a client read the logs , the client code is as following: ``` void

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-11 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396167544 I setup a bookkeeper cluster with 3 bookie server, and then setup a client read the logs , the client code is as following: ``` void downloadLog() throws

[GitHub] infodog commented on issue #1509: solve #1476 issue.

2018-06-11 Thread GitBox
infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396167544 I setup a bookkeeper cluster with 3 bookie server, and then setup a client read the logs , the client code is as following: ``` void downloadLog() throws