Build failed in Jenkins: distributedlog-nightly-build #500

See -- [...truncated 253.78 KB...] [INFO] Downloaded:

[GitHub] sijie opened a new pull request #788: Issue 787: Client should be able to get ledger metadata from Handles.

sijie opened a new pull request #788: Issue 787: Client should be able to get ledger metadata from Handles. URL: https://github.com/apache/bookkeeper/pull/788 Descriptions of the changes in this PR: - create a `LedgerMetadata` interface for exposing public information - add

[GitHub] sijie commented on issue #240: Make distributedlog compiled with latest bookkeeper version

sijie commented on issue #240: Make distributedlog compiled with latest bookkeeper version URL: https://github.com/apache/distributedlog/pull/240#issuecomment-347742803 @jiazhai I think CI failed due to one flaky test. one of the travis ci passed -

[GitHub] sijie opened a new pull request #786: Issue 765: Add `isSealed()` to ReadHandle

sijie opened a new pull request #786: Issue 765: Add `isSealed()` to ReadHandle URL: https://github.com/apache/bookkeeper/pull/786 Descriptions of the changes in this PR: add `isSealed` to ReadHandle, so distributedlog can use this for implementing readers.

[GitHub] sijie opened a new pull request #785: Issue 784: LedgerEntries#close should not throw checked exception

sijie opened a new pull request #785: Issue 784: LedgerEntries#close should not throw checked exception URL: https://github.com/apache/bookkeeper/pull/785 Descriptions of the changes in this PR: override `close()` in LedgerEntries to make it not throw checked exception.

[GitHub] sijie opened a new pull request #241: Include `nc` command in distributedlog docker image

sijie opened a new pull request #241: Include `nc` command in distributedlog docker image URL: https://github.com/apache/distributedlog/pull/241 Descriptions of the changes in this PR: `nc` is usually used for checking if zookeeper is up and also verifying connectivity. It is good

[GitHub] sijie opened a new pull request #240: Make distributedlog compiled with latest bookkeeper version

sijie opened a new pull request #240: Make distributedlog compiled with latest bookkeeper version URL: https://github.com/apache/distributedlog/pull/240 Descriptions of the changes in this PR: There are code changes on PendingReadOp for new bookkeeper api in current master.

[GitHub] jiazhai commented on a change in pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file

jiazhai commented on a change in pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file URL: https://github.com/apache/bookkeeper/pull/781#discussion_r153665035 ## File path: docker/scripts/entrypoint.sh ## @@ -37,10 +37,13 @@

[GitHub] jiazhai commented on a change in pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file

jiazhai commented on a change in pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file URL: https://github.com/apache/bookkeeper/pull/781#discussion_r153665035 ## File path: docker/scripts/entrypoint.sh ## @@ -37,10 +37,13 @@

[GitHub] sijie opened a new issue #784: LedgerEntries#close should not throw checked exception

sijie opened a new issue #784: LedgerEntries#close should not throw checked exception URL: https://github.com/apache/bookkeeper/issues/784 **FEATURE REQUEST** 1. Please describe the feature you are requesting. LedgerEntries inherits from `AutoCloseable`. but it doesn't

[GitHub] ivankelly commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle

ivankelly commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle URL: https://github.com/apache/bookkeeper/issues/765#issuecomment-347672188 I'm ok with keeping just #close/asyncClose, but in that case, close should only be part of WriteHandle. The reason I suggested

[GitHub] sijie commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle

sijie commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle URL: https://github.com/apache/bookkeeper/issues/765#issuecomment-347669752 I am not sure is there a strong reason to make this change. because separating this to a method means user can close a ledger without

[GitHub] sijie commented on issue #783: Provide a #forceRecovery method in BookKeeperAdmin

sijie commented on issue #783: Provide a #forceRecovery method in BookKeeperAdmin URL: https://github.com/apache/bookkeeper/issues/783#issuecomment-347667738 @ivankelly this was an admin tool to handle production issues when there was bug in bookkeeper recovery.

[GitHub] ivankelly commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle

ivankelly commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle URL: https://github.com/apache/bookkeeper/issues/765#issuecomment-347661934 Also, WriteHandle#close is inherited from Handle, so its definition isn't that clear. All handles are closable, so why do some of

[GitHub] jvrao commented on a change in pull request #775: Tests wait for client to see started bookie

jvrao commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153620882 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java ## @@

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347659567 > what does #forceClose mean to a readhandle open for a ledger that is already closed. it's a noop. > I think the fence/recovery

[GitHub] sijie opened a new issue #783: Provide a #forceRecovery method in BookKeeperAdmin

sijie opened a new issue #783: Provide a #forceRecovery method in BookKeeperAdmin URL: https://github.com/apache/bookkeeper/issues/783 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Currently distributedlog tool provides a command for force-recovering

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153617571 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153615458 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153615548 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java ## @@

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153615166 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153615102 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153615134 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153614967 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie

ivankelly commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153614842 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] sijie commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

sijie commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153613287 ## File path:

[GitHub] philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153612490 ## File path:

[GitHub] sijie commented on issue #774: Open should run recovery by default

sijie commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347651531 @ivankelly : I think @jiazhai also put down his opinion as well (just to make sure everyone that express the opinion in this thread is not missed)

[GitHub] sijie commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle

sijie commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle URL: https://github.com/apache/bookkeeper/issues/765#issuecomment-347646937 1. `WriteHandle` probably doesn't need this. 2. +1 for renaming it to `isSealed()`. I am not sure renaming `WriteHandle#close()`

[GitHub] sijie commented on issue #769: defect of merge script: some times not able to get reviewers list

sijie commented on issue #769: defect of merge script: some times not able to get reviewers list URL: https://github.com/apache/bookkeeper/issues/769#issuecomment-347645665 @jiazhai thank you for reporting this. we might consider improving the merge script by looking for reviews with

[GitHub] philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153606120 ## File path:

[GitHub] sijie commented on issue #778: Make build pass using JDK9

sijie commented on issue #778: Make build pass using JDK9 URL: https://github.com/apache/bookkeeper/issues/778#issuecomment-347644706 @eolivelli I think there is already an issue for this - #569 you can decide which one to use and mark the other one as duplicated.

[GitHub] philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153605472 ## File path:

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153603117 ## File path: site/docs/latest/api/ledger-api.md ## @@ -471,3 +471,304 @@ mvn exec:java

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153604520 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/WriteFlagTest.java ## @@ -0,0

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153601282 ## File path: site/docs/latest/api/ledger-api.md ## @@ -471,3 +471,304 @@ mvn exec:java

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153600707 ## File path: site/docs/latest/api/ledger-api.md ## @@ -36,12 +36,12 @@ If you're using

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153600627 ## File path: site/.ruby-version ## @@ -0,0 +1 @@ +2.4.1 Review comment: I don't think we need this.

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153600416 ## File path: site/docs/latest/api/ledger-api.md ## @@ -20,7 +20,7 @@ If you're using

[GitHub] philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153604345 ## File path:

[GitHub] sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

sijie commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153600223 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/CreateBuilder.java ## @@ -91,6

[GitHub] philipsu522 commented on issue #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

philipsu522 commented on issue #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#issuecomment-347638395 > I am not sure about. I think slow should be before read-only. @philipsu522 @yzang can you guys

[GitHub] sijie commented on issue #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

sijie commented on issue #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#issuecomment-347635719 > What is the rationale for trying read-only before slow? Surely a write to the read-only is likely to

[GitHub] philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

philipsu522 commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153596276 ## File path:

[GitHub] sijie commented on a change in pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file

sijie commented on a change in pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file URL: https://github.com/apache/bookkeeper/pull/781#discussion_r153593969 ## File path: docker/scripts/entrypoint.sh ## @@ -37,10 +37,13 @@

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153584368 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153584188 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153588504 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153589728 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java ##

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153584509 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153583368 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java ## @@

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153584936 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153589913 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java ##

[GitHub] sijie commented on a change in pull request #775: Tests wait for client to see started bookie

sijie commented on a change in pull request #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#discussion_r153585139 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java ##

[GitHub] sijie commented on issue #775: Tests wait for client to see started bookie

sijie commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347620519 @ivankelly `CompletableFuture methodAsync()` is better if you are going to provide a sync version of same method `void method()`.

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153578019 ## File path:

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552849 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552867 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552837 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] ivankelly commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

ivankelly commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153546644 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/CreateBuilder.java ## @@

[GitHub] ivankelly commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

ivankelly commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153546571 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] ivankelly commented on a change in pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file

ivankelly commented on a change in pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file URL: https://github.com/apache/bookkeeper/pull/781#discussion_r153539090 ## File path: docker/scripts/entrypoint.sh ## @@ -37,10 +37,13

[GitHub] ivankelly closed pull request #782: Don't print out redundant JMX notice

ivankelly closed pull request #782: Don't print out redundant JMX notice URL: https://github.com/apache/bookkeeper/pull/782 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] ivankelly commented on issue #782: Don't print out redundant JMX notice

ivankelly commented on issue #782: Don't print out redundant JMX notice URL: https://github.com/apache/bookkeeper/pull/782#issuecomment-347571350 Ignore previous two comments. JMX flags are still valid. Will merge this. This

[GitHub] ivankelly commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle

ivankelly commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle URL: https://github.com/apache/bookkeeper/issues/765#issuecomment-347570600 Updating the tutorial is blocked on this. This is an automated

[GitHub] ivankelly commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle

ivankelly commented on issue #765: Add `isClosed()` to WriteHandle and ReadHandle URL: https://github.com/apache/bookkeeper/issues/765#issuecomment-347568436 @sijie 1. does the WriteHandle need this? 2. Perhaps we should rename this operation? To something like isSealed(), and also

[GitHub] ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153501013 ## File path:

[GitHub] ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153498756 ## File path:

[GitHub] ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153498595 ## File path:

[GitHub] ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153499178 ## File path:

[GitHub] ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

ivankelly commented on a change in pull request #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#discussion_r153502756 ## File path:

Build failed in Jenkins: bookkeeper-master #1957

See Changes: [zhaijia] ISSUE #230: Enable Checkstyle on the tls package [ivank] Explicitly search for bookkeeper-server jar -- [...truncated 47.04 KB...] Tests run: 2,

[GitHub] ivankelly commented on issue #782: Don't print out redundant JMX notice

ivankelly commented on issue #782: Don't print out redundant JMX notice URL: https://github.com/apache/bookkeeper/pull/782#issuecomment-347470415 *removed On Tue 28 Nov 2017, 09:50 Ivan Kelly wrote: > Oh, I didn't know that. Ok that case, this while if else

[GitHub] eolivelli commented on issue #774: Open should run recovery by default

eolivelli commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347462497 @ivankelly the new proposal of forceClose() sounds interesting to me. It is more explicit

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347459450 @sijie @eolivelli @jvrao @merlimat Another thing just occurred to me. Why don't we remove recovery open completely and replace it with a

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347458079 Looks like I'm fighting a losing battle here. In summary, the opinions are default | recovery true | recovery false |

[GitHub] ivankelly opened a new pull request #782: Don't print out redundant JMX notice

ivankelly opened a new pull request #782: Don't print out redundant JMX notice URL: https://github.com/apache/bookkeeper/pull/782 Users don't really care that JMX is enabled by default, so don't print it out. This is an

[GitHub] ivankelly closed pull request #772: Explicitly search for bookkeeper-server jar

ivankelly closed pull request #772: Explicitly search for bookkeeper-server jar URL: https://github.com/apache/bookkeeper/pull/772 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ivankelly commented on issue #772: Explicitly search for bookkeeper-server jar

ivankelly commented on issue #772: Explicitly search for bookkeeper-server jar URL: https://github.com/apache/bookkeeper/pull/772#issuecomment-347452655 @merlimat I'll create another PR This is an automated message from the

[GitHub] ivankelly commented on issue #775: Tests wait for client to see started bookie

ivankelly commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347450084 Updated return types to ```CompletableFuture```, though i think `` was better as we don't actually care about what's returned, just