[GitHub] sijie closed pull request #1290: Added executeOrdered to complement submitOrdered

sijie closed pull request #1290: Added executeOrdered to complement submitOrdered URL: https://github.com/apache/bookkeeper/pull/1290 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] sijie commented on issue #1290: Added executeOrdered to complement submitOrdered

sijie commented on issue #1290: Added executeOrdered to complement submitOrdered URL: https://github.com/apache/bookkeeper/pull/1290#issuecomment-376777075 (the CI failure is unrelated) This is an automated message from the Ap

[GitHub] sijie commented on issue #1290: Added executeOrdered to complement submitOrdered

sijie commented on issue #1290: Added executeOrdered to complement submitOrdered URL: https://github.com/apache/bookkeeper/pull/1290#issuecomment-376777028 IGNORE CI This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #1294: BK configuration file updates

sijie commented on issue #1294: BK configuration file updates URL: https://github.com/apache/bookkeeper/pull/1294#issuecomment-376776487 rebased to latest master This is an automated message from the Apache Git Service. To res

[GitHub] sijie commented on issue #1296: Create 4.6.2 documentation stub

sijie commented on issue #1296: Create 4.6.2 documentation stub URL: https://github.com/apache/bookkeeper/pull/1296#issuecomment-376776154 (TRAVIS PASSED since travis the only CI validate building site. so it is okay to ignore CI) ---

[GitHub] sijie commented on issue #1296: Create 4.6.2 documentation stub

sijie commented on issue #1296: Create 4.6.2 documentation stub URL: https://github.com/apache/bookkeeper/pull/1296#issuecomment-376776002 IGNORE CI This is an automated message from the Apache Git Service. To respond to the m

[GitHub] sijie closed pull request #1288: Add sync variants of all methods in handles

sijie closed pull request #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] sijie commented on issue #1299: [dlog] use Atomic***FieldUpdater and LongAdder if possible

sijie commented on issue #1299: [dlog] use Atomic***FieldUpdater and LongAdder if possible URL: https://github.com/apache/bookkeeper/pull/1299#issuecomment-376775102 /cc @philipsu522 for reviews This is an automated message

[GitHub] sijie opened a new pull request #1300: [dlog] Fix TestZKLogStreamMetadataStore

sijie opened a new pull request #1300: [dlog] Fix TestZKLogStreamMetadataStore URL: https://github.com/apache/bookkeeper/pull/1300 Descriptions of the changes in this PR: *Problem* All test cases in `TestZKLogStreamMetadataStore` share same zookeeper cluster. so if the

[GitHub] sijie commented on issue #1300: [dlog] Fix TestZKLogStreamMetadataStore

sijie commented on issue #1300: [dlog] Fix TestZKLogStreamMetadataStore URL: https://github.com/apache/bookkeeper/pull/1300#issuecomment-376775064 /cc @philipsu522 for reviews This is an automated message from the Apache Git S

[GitHub] sijie opened a new pull request #1299: [dlog] use Atomic***FieldUpdater and LongAdder if possible

sijie opened a new pull request #1299: [dlog] use Atomic***FieldUpdater and LongAdder if possible URL: https://github.com/apache/bookkeeper/pull/1299 Descriptions of the changes in this PR: Atomic**FieldUpdater + volatile provides similar guarantees as Atomic*** but use much

[GitHub] reddycharan commented on issue #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on issue #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-376723194 Thanks @ivankelly for taking the effort to consider ways to refactor the code. But this class is in deep down in the stack and I'm hesita

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177611374 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ## @@

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177590256 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java #

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177532672 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ## @@

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177535531 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ## @@

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177532166 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ## @@

[GitHub] sijie commented on issue #1281: Issue #570: Introducing EntryLogManager.

sijie commented on issue #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-376631793 @ivankelly : appreciate you are working on this change. Here are my thought below: > If there are circular dependencies, then the

[GitHub] sijie commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog

sijie commented on issue #1283: Issue #1282: call to appendLedgersMap in flushCompactionLog URL: https://github.com/apache/bookkeeper/pull/1283#issuecomment-376622093 @reddycharan > I'm not sure what you meant by "What if we flush the log channel successfully but not the ledger ma

[GitHub] sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177515383 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockReadHandle.ja

[GitHub] sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177515542 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockReadHandle.ja

[GitHub] sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177514356 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockReadHandle.ja

[GitHub] sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177509903 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeper.ja

[GitHub] sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177510570 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeper.ja

[GitHub] sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177513577 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockLedgerHandle.

[GitHub] sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177516314 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockReadHandle.ja

[GitHub] sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177513995 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockReadHandle.ja

[GitHub] ivankelly closed issue #1287: NPE at DNS.reverse

ivankelly closed issue #1287: NPE at DNS.reverse URL: https://github.com/apache/bookkeeper/issues/1287 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] ivankelly closed pull request #1295: Issue #1287: NPE at DNS.reverse

ivankelly closed pull request #1295: Issue #1287: NPE at DNS.reverse URL: https://github.com/apache/bookkeeper/pull/1295 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull re

[GitHub] ivankelly commented on issue #1295: Issue #1287: NPE at DNS.reverse

ivankelly commented on issue #1295: Issue #1287: NPE at DNS.reverse URL: https://github.com/apache/bookkeeper/pull/1295#issuecomment-376608384 Just hit this in a CI run. Merging. This is an automated message from the Apache Gi

[GitHub] ivankelly commented on issue #1288: Add sync variants of all methods in handles

ivankelly commented on issue #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288#issuecomment-376594014 @eolivelli there was a integration test failure, so kicking again. I think it's unrelated, but want to be sure. Also, too late in the da

[GitHub] ivankelly commented on issue #1288: Add sync variants of all methods in handles

ivankelly commented on issue #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288#issuecomment-376592561 retest this please This is an automated message from the Apache Git Ser

[GitHub] ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177471484 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeepe

[GitHub] eolivelli commented on issue #1288: Add sync variants of all methods in handles

eolivelli commented on issue #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288#issuecomment-376570571 I did not want to close this one This is an automated message from the

[GitHub] ivankelly opened a new pull request #1288: Add sync variants of all methods in handles

ivankelly opened a new pull request #1288: Add sync variants of all methods in handles URL: https://github.com/apache/bookkeeper/pull/1288 As discussed on the mailing list [1], this patch removes the inconsistency around the naming of the close call on the new handle APIs, by creating

[GitHub] eolivelli commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

eolivelli commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r177470458 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeepe

Jenkins build is back to stable : bookkeeper_postcommit_master_java9 #83

See

Jenkins build is still unstable: bookkeeper_release_branch #101

See

[GitHub] ivankelly opened a new pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

ivankelly opened a new pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298 There are two implementations of the ReadHandle interface. One pure, which isn't backed by any production code, and another on

Build failed in Jenkins: bookkeeper_postcommit_master_java8 #83

See -- [...truncated 74.94 KB...] 2018-03-27T12:12:34.945 [INFO] Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven/2.0.6/maven-2.0.6.pom 2018-03-2

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177391042 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ##

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177383683 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -292

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177382401 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -264

[GitHub] ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

ivankelly commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177388920 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ##

[GitHub] eolivelli opened a new pull request #1297: Release notes for 4.6.2 version

eolivelli opened a new pull request #1297: Release notes for 4.6.2 version URL: https://github.com/apache/bookkeeper/pull/1297 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] eolivelli opened a new pull request #1296: Create 4.6.2 documentation stub

eolivelli opened a new pull request #1296: Create 4.6.2 documentation stub URL: https://github.com/apache/bookkeeper/pull/1296 This change prepares the directory structure for docs of 4.6.2. New pages are not linked from menu. ---

[GitHub] eolivelli commented on issue #1268: (WIP) Enable bytebuf leak detection in tests

eolivelli commented on issue #1268: (WIP) Enable bytebuf leak detection in tests URL: https://github.com/apache/bookkeeper/pull/1268#issuecomment-376421725 @sijie how is going this work? This is an automated message from the A

[GitHub] sijie opened a new pull request #1295: Issue #1287: NPE at DNS.reverse

sijie opened a new pull request #1295: Issue #1287: NPE at DNS.reverse URL: https://github.com/apache/bookkeeper/pull/1295 Descriptions of the changes in this PR: *Problem* Null value can be returned on retrieving attributes. *Solution* If null value is re