sijie commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177611374
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java
##########
@@ -209,16 +211,39 @@ public void onSizeLimitReached(final Checkpoint cp)
throws IOException {
public void run() {
try {
LOG.info("Started flushing mem table.");
- long logIdBeforeFlush = entryLogger.getCurrentLogId();
+ long prevAllocLogIdBeforeFlush =
entryLogger.getPreviousAllocatedEntryLogId();
Review comment:
@reddycharan
> why would you say that behavior would be different between preallocation
enabled and disabled? Is it because of async nature of preallocation?
yeah because preallocation is in background, preallocation can advance entry
log id. if it does, the logic is not correct.
> I can add "getCurrentLogId" to the EntryLogManager Interface. For
EntryLogManagerForSingleEntryLog implementation it would give the logId of the
current activelog (which is current behavior).
That could work for now. Although I would still like to see if there is
possibility to produce a cleaner interface without exposing those log ids. Let
me think a bit more and come back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
