sijie commented on a change in pull request #1281: Issue #570: Introducing
EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177532166
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java
##########
@@ -78,6 +79,7 @@ public void initialize(ServerConfiguration conf,
.setNameFormat("SortedLedgerStorage-%d")
.setPriority((Thread.NORM_PRIORITY + Thread.MAX_PRIORITY) /
2).build());
this.stateManager = stateManager;
+ this.isTransactionalCompactionEnabled =
conf.getUseTransactionalCompaction();
Review comment:
@ivankelly
> The external behaviour of SortedLedgerStorage should not change with this
patch
it is not an external behavior of SortedLedgerStorage. It is the logic of
SortedLedgerStorage. SortedLedgerStorage needs to realize the compaction
mechanism to do checkpointing. That's related to the discussion below around
checkpointing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
