[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152645332 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152549714 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152548916 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152545958 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152544979 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152515790 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152515198 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152509013 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-22 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152509013 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152481205 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152481777 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152480729 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152481149 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152481584 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152481043 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152480808 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152481849 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-21 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152481543 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-15 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151218740 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-15 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151225622 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/SyncCallbackUtils.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-15 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151225239 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

2017-11-15 Thread GitBox
sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r151218118 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java